Reading a file byte by byte

[Seabass]

Hello everyone,

I'm trying to do a Hex Viewer in C#. I'm reading the user selected
file byte by byte but it seems to take forever ( one minute to read a
larger file ). Is there any way to make this function work faster ?

Here is my code:

/// <summary>
/// Opens a file chooser.
/// </summary>
///
private void openToolStripMe nuItem_Click(ob ject sender,
EventArgs e)
{
openFileDialog. ShowDialog();

string fileName = openFileDialog. FileName;

FileStream fileReader = new FileStream(file Name,
FileMode.Open, FileAccess.Read );
StringBuilder buffer = new StringBuilder() ;

long length = fileReader.Leng th;
long position = 0;

while (position < length) // is this correct ?? or should
it be length - 1 instead of length ?
{
position++;
buffer.Append(f ileReader.ReadB yte());
}
textBox.Text = buffer.ToString ();

}
}

[Jon Skeet [C# MVP]]

Seabass <sh****@upei.ca wrote:

I'm trying to do a Hex Viewer in C#. I'm reading the user selected
file byte by byte but it seems to take forever ( one minute to read a
larger file ). Is there any way to make this function work faster ?

Yes - read it in blocks instead of reading a byte at a time.

Note that it's also a bad idea to save the results in a StringBuilder.
That's for *strings*, not binary data. MemoryStream is, in some ways,
the binary equivalent of StringBuilder.

I have a class in my miscutil library that helps to read the whole of a
stream in one go. See
http://pobox.com/~skeet/csharp/miscutil

Note also that you should use a "using" statement so that your stream
is always closed. (In fact, you're *never* closing it in your code.)

--
Jon Skeet - <sk***@pobox.co m>
http://www.pobox.com/~skeet Blog: http://www.msmvps.com/jon.skeet
If replying to the group, please do not mail me too

[Ignacio Machin \( .NET/ C# MVP \)]

Hi,

"Seabass" <sh****@upei.ca wrote in message
news:11******** **************@ h2g2000hsg.goog legroups.com...

Hello everyone,

I'm trying to do a Hex Viewer in C#. I'm reading the user selected
file byte by byte but it seems to take forever ( one minute to read a
larger file ). Is there any way to make this function work faster ?

Well, what do you expect? of course it will takes forever.

A better approach is to read a chunk of the file and then process it from
memory.

Also beware with big files, using StringBuilder may not be the best way for
this.

I would just read what the screen can show, in this way you do not read
content that will not be visible in the screen

[=?ISO-8859-1?Q?Arne_Vajh=F8j?=]

Seabass wrote:

I'm trying to do a Hex Viewer in C#. I'm reading the user selected
file byte by byte but it seems to take forever ( one minute to read a
larger file ). Is there any way to make this function work faster ?

Others have already suggested reading many bytes instead
of one byte at a time.

If you really like ReadByte you can just wrap your Stream
in a BufferedStream, that should get rid of the worst ineffciencies
of using ReadByte.

Arne

[Moty Michaely]

On May 13, 1:33 am, Arne Vajhøj <a...@vajhoej.d kwrote:

Seabass wrote:

I'm trying to do a Hex Viewer in C#. I'm reading the user selected
file byte by byte but it seems to take forever ( one minute to read a
larger file ). Is there any way to make this function work faster ?

Others have already suggested reading many bytes instead
of one byte at a time.

If you really like ReadByte you can just wrap your Stream
in a BufferedStream, that should get rid of the worst ineffciencies
of using ReadByte.

Arne

Hi there,

Check the BufferedStream class that adds a buffering layer to read and
write operations of other streams.

http://msdn2.microsoft.com/en-us/lib...redstream.aspx

Hope this helps.

Moty

[=?ISO-8859-1?Q?Arne_Vajh=F8j?=]

Moty Michaely wrote:

On May 13, 1:33 am, Arne Vajhøj <a...@vajhoej.d kwrote:

>Seabass wrote:

>>I'm trying to do a Hex Viewer in C#. I'm reading the user selected
file byte by byte but it seems to take forever ( one minute to read a
larger file ). Is there any way to make this function work faster ?

Others have already suggested reading many bytes instead
of one byte at a time.

If you really like ReadByte you can just wrap your Stream
in a BufferedStream, that should get rid of the worst ineffciencies
of using ReadByte.

Check the BufferedStream class that adds a buffering layer to read and
write operations of other streams.

That was already in what you quoted ...

Arne

[Moty Michaely]

On May 20, 2:05 am, Arne Vajhøj <a...@vajhoej.d kwrote:

Moty Michaely wrote:

On May 13, 1:33 am, Arne Vajhøj <a...@vajhoej.d kwrote:

Seabass wrote:
I'm trying to do a Hex Viewer in C#. I'm reading the user selected
file byte by byte but it seems to take forever ( one minute to read a
larger file ). Is there any way to make this function work faster ?
Others have already suggested reading many bytes instead
of one byte at a time.

If you really like ReadByte you can just wrap your Stream
in a BufferedStream, that should get rid of the worst ineffciencies
of using ReadByte.

Check the BufferedStream class that adds a buffering layer to read and
write operations of other streams.

That was already in what you quoted ...

Arne

Yep, Sorry for that, I missed that :)

Moty