Marshalling a Callback with BOOL parameter

[markb]

Hi

My C# app is being called from a callback from an unmanaged DLL. One of
the parameters of the callback is of type BOOL. I am using PInvoke to
marshal this to a (managed) bool. The problem is that no matter if we
pass TRUE or FALSE, the bool is always marshalled as true.

// unmanaged code in dll

typedef bool (__stdcall *BoolCallBack)( short b);

extern "C" BOOL __declspec(dlle xport) __stdcall
BoolCallback(Bo olCallBack lpBoolCallBack, BOOL b)
{
return lpBoolCallBack( b);
}

// c#
private delegate bool BoolCallbackDel egate(bool b);

[DllImport("Unma nagedDll")]
private static extern bool BoolCallback(Bo olCallbackDeleg ate
lpBoolCallBack, bool b);

private static bool BoolCallbackDel gate(bool b)
{
return b;
}

static void Main(string[] args)
{
bool b = BoolCallback(Bo olCallbackDelga te, true);
Debug.Assert(b == true);

b = BoolCallback(Bo olCallbackDelga te, false);
Debug.Assert(b == false);
}

The second Assert alwasys asserts because the callback is returning
true when it should be false.

I think that this is a bug somewhere in c#/clr/PInkove because this
doesnt happen in c++ clr. I think it was fixed for c++ clr under this
kb article http://support.microsoft.com/default.aspx?kbid=823071 but
not fixed for c#.

Any thoughts?

Mark

[Willy Denoyette [MVP]]

"markb" <ma************ *@gmail.comwrot e in message
news:11******** **************@ m73g2000cwd.goo glegroups.com.. .
| Hi
|
| My C# app is being called from a callback from an unmanaged DLL. One of
| the parameters of the callback is of type BOOL. I am using PInvoke to
| marshal this to a (managed) bool. The problem is that no matter if we
| pass TRUE or FALSE, the bool is always marshalled as true.
|
| // unmanaged code in dll
|
| typedef bool (__stdcall *BoolCallBack)( short b);
|
| extern "C" BOOL __declspec(dlle xport) __stdcall
| BoolCallback(Bo olCallBack lpBoolCallBack, BOOL b)
| {
| return lpBoolCallBack( b);
| }
|
| // c#
| private delegate bool BoolCallbackDel egate(bool b);
|
| [DllImport("Unma nagedDll")]
| private static extern bool BoolCallback(Bo olCallbackDeleg ate
| lpBoolCallBack, bool b);
|
| private static bool BoolCallbackDel gate(bool b)
| {
| return b;
| }
|
| static void Main(string[] args)
| {
| bool b = BoolCallback(Bo olCallbackDelga te, true);
| Debug.Assert(b == true);
|
| b = BoolCallback(Bo olCallbackDelga te, false);
| Debug.Assert(b == false);
| }
|
| The second Assert alwasys asserts because the callback is returning
| true when it should be false.
|
| I think that this is a bug somewhere in c#/clr/PInkove because this
| doesnt happen in c++ clr. I think it was fixed for c++ clr under this
| kb article http://support.microsoft.com/default.aspx?kbid=823071 but
| not fixed for c#.
|
| Any thoughts?
|
| Mark
|
A BOOL is a typedef'd DWORD in C or an int, while a 'bool' is a single byte
in C# (and C++)
So you need to declare the return as int or you need to tag the return like
this:

[DllImport("Unma nagedDll")]
[return: MarshalAs(Unman agedType.Bool)]
private static extern bool BoolCallback(Bo olCallbackDeleg ate

Willy.

[markb]

Willy Denoyette [MVP] wrote:

"markb" <ma************ *@gmail.comwrot e in message
news:11******** **************@ m73g2000cwd.goo glegroups.com.. .
| Hi
|
| My C# app is being called from a callback from an unmanaged DLL. One of
| the parameters of the callback is of type BOOL. I am using PInvoke to
| marshal this to a (managed) bool. The problem is that no matter if we
| pass TRUE or FALSE, the bool is always marshalled as true.
|
| // unmanaged code in dll
|
| typedef bool (__stdcall *BoolCallBack)( short b);
|
| extern "C" BOOL __declspec(dlle xport) __stdcall
| BoolCallback(Bo olCallBack lpBoolCallBack, BOOL b)
| {
| return lpBoolCallBack( b);
| }
|
| // c#
| private delegate bool BoolCallbackDel egate(bool b);
|
| [DllImport("Unma nagedDll")]
| private static extern bool BoolCallback(Bo olCallbackDeleg ate
| lpBoolCallBack, bool b);
|
| private static bool BoolCallbackDel gate(bool b)
| {
| return b;
| }
|
| static void Main(string[] args)
| {
| bool b = BoolCallback(Bo olCallbackDelga te, true);
| Debug.Assert(b == true);
|
| b = BoolCallback(Bo olCallbackDelga te, false);
| Debug.Assert(b == false);
| }
|
| The second Assert alwasys asserts because the callback is returning
| true when it should be false.
|
| I think that this is a bug somewhere in c#/clr/PInkove because this
| doesnt happen in c++ clr. I think it was fixed for c++ clr under this
| kb article http://support.microsoft.com/default.aspx?kbid=823071 but
| not fixed for c#.
|
| Any thoughts?
|
| Mark
|
A BOOL is a typedef'd DWORD in C or an int, while a 'bool' is a single byte
in C# (and C++)
So you need to declare the return as int or you need to tag the return like
this:

[DllImport("Unma nagedDll")]
[return: MarshalAs(Unman agedType.Bool)]
private static extern bool BoolCallback(Bo olCallbackDeleg ate

Willy.

Thanks for your reply Willy

Perhaps my example was unclear. The problem does not lie with passing
the bool to the unmanaged dll nor does it lie with with the return from
the unmanaged dll, it lies with the unmanaged dll calling a managed
callback with a BOOL as a parameter. (FYI it doesn't matter if you use
a c++ bool, a char, DWORD or whatever - the problem is still the same)

If you step through the code, the unmanaged dll, cleary calls the
callback with TRUE but it appears as false in the csharp code. Even
changing the delegate prototype to the following does not solve the
problem:

private static extern bool BoolCallback(Bo olCallbackDeleg ate
lpBoolCallBack,[MarshalAs(Unman agedType.Bool)]bool b);

The c++ clr version (below) of my csharp example works so it looks like
a problem with csharp?!?

ref class Program
{
private:
delegate bool BoolCallbackDel gate(bool b);

static bool GetBool(bool b)
{
return b;
}

public:
static void Main()
{
BoolCallbackDel gate^ fp = gcnew BoolCallbackDel gate(GetBool);
GCHandle gch = GCHandle::Alloc (fp);
IntPtr ip = Marshal::GetFun ctionPointerFor Delegate(fp);
BoolCallBack cb = static_cast<Boo lCallBack>(ip.T oPointer());
bool b = BoolCallback(cb , true);
Debug::Assert(b == true);

b = BoolCallback(cb , false);
Debug::Assert(b == false);
}
};

Mark

[Willy Denoyette [MVP]]

"markb" <ma************ *@gmail.comwrot e in message
news:11******** *************@j 44g2000cwa.goog legroups.com...

Willy Denoyette [MVP] wrote:

>"markb" <ma************ *@gmail.comwrot e in message
news:11******* *************** @m73g2000cwd.go oglegroups.com. ..
| Hi
|
| My C# app is being called from a callback from an unmanaged DLL. One of
| the parameters of the callback is of type BOOL. I am using PInvoke to
| marshal this to a (managed) bool. The problem is that no matter if we
| pass TRUE or FALSE, the bool is always marshalled as true.
|
| // unmanaged code in dll
|
| typedef bool (__stdcall *BoolCallBack)( short b);
|
| extern "C" BOOL __declspec(dlle xport) __stdcall
| BoolCallback(Bo olCallBack lpBoolCallBack, BOOL b)
| {
| return lpBoolCallBack( b);
| }
|
| // c#
| private delegate bool BoolCallbackDel egate(bool b);
|
| [DllImport("Unma nagedDll")]
| private static extern bool BoolCallback(Bo olCallbackDeleg ate
| lpBoolCallBack, bool b);
|
| private static bool BoolCallbackDel gate(bool b)
| {
| return b;
| }
|
| static void Main(string[] args)
| {
| bool b = BoolCallback(Bo olCallbackDelga te, true);
| Debug.Assert(b == true);
|
| b = BoolCallback(Bo olCallbackDelga te, false);
| Debug.Assert(b == false);
| }
|
| The second Assert alwasys asserts because the callback is returning
| true when it should be false.
|
| I think that this is a bug somewhere in c#/clr/PInkove because this
| doesnt happen in c++ clr. I think it was fixed for c++ clr under this
| kb article http://support.microsoft.com/default.aspx?kbid=823071 but
| not fixed for c#.
|
| Any thoughts?
|
| Mark
|
A BOOL is a typedef'd DWORD in C or an int, while a 'bool' is a single byte
in C# (and C++)
So you need to declare the return as int or you need to tag the return like
this:

[DllImport("Unma nagedDll")]
[return: MarshalAs(Unman agedType.Bool)]
private static extern bool BoolCallback(Bo olCallbackDeleg ate

Willy.

Thanks for your reply Willy

Perhaps my example was unclear. The problem does not lie with passing
the bool to the unmanaged dll nor does it lie with with the return from
the unmanaged dll, it lies with the unmanaged dll calling a managed
callback with a BOOL as a parameter. (FYI it doesn't matter if you use
a c++ bool, a char, DWORD or whatever - the problem is still the same)

If you step through the code, the unmanaged dll, cleary calls the
callback with TRUE but it appears as false in the csharp code. Even
changing the delegate prototype to the following does not solve the
problem:

private static extern bool BoolCallback(Bo olCallbackDeleg ate
lpBoolCallBack,[MarshalAs(Unman agedType.Bool)]bool b);

The c++ clr version (below) of my csharp example works so it looks like
a problem with csharp?!?

ref class Program
{
private:
delegate bool BoolCallbackDel gate(bool b);

static bool GetBool(bool b)
{
return b;
}

public:
static void Main()
{
BoolCallbackDel gate^ fp = gcnew BoolCallbackDel gate(GetBool);
GCHandle gch = GCHandle::Alloc (fp);
IntPtr ip = Marshal::GetFun ctionPointerFor Delegate(fp);
BoolCallBack cb = static_cast<Boo lCallBack>(ip.T oPointer());
bool b = BoolCallback(cb , true);
Debug::Assert(b == true);

b = BoolCallback(cb , false);
Debug::Assert(b == false);
}
};

Mark

typedef bool (__stdcall *BoolCallBack)( short b);
should be:
typedef bool (__stdcall *BoolCallBack)( BOOL b);

Willy.