Performance issue (bug?) with .NET 2 ListView

[mrshrinkray]

Are there any know bugs with the ListView in .NET 2? I'm having
problems with an application that takes 15 seconds in 1.1, and now
takes over a minute. The code in question uses:

listViewItem = this.listView1. Items.Add(...)

followed by 7 calls to

listViewItem.Su bItems.Add(...)

When I comment out this code, the application runs in the same time as
the 1.1 version.

Any suggestions? I can provide the source code if required.

[Marc Gravell]

I would suggest a: using the ListViewItem ctor that allows you to specify
the sub-items in one go, and b: using the {Begin|End}Upda te syntax (around a
block of such) - i.e.

listview.BeginU pdate();
try {
ListViewItem newItem = new ListViewItem(ne w string[] {
"text1","text2" ,"text3","text4 "});
listview.Items. Add(newItem);
// and again...
// and again...
// and again...
// (or use AddRange)
} finally {
listview.EndUpd ate();
}

See if that works any quicker... you could also try {Suspend|Resume }Layout.

Marc

[Willy Denoyette [MVP]]

What's happening in .Add(...)?
Please post a complete sample that illustraties the issue, without seeing
any code it's hard to tell what's happening.

Willy.

<mr*********@go oglemail.com> wrote in message
news:11******** **************@ c74g2000cwc.goo glegroups.com.. .
| Are there any know bugs with the ListView in .NET 2? I'm having
| problems with an application that takes 15 seconds in 1.1, and now
| takes over a minute. The code in question uses:
|
| listViewItem = this.listView1. Items.Add(...)
|
| followed by 7 calls to
|
| listViewItem.Su bItems.Add(...)
|
| When I comment out this code, the application runs in the same time as
| the 1.1 version.
|
| Any suggestions? I can provide the source code if required.
|

[cody]

try to add the subitems *before* you add the item to the istview

--
<mr*********@go oglemail.com> schrieb im Newsbeitrag
news:11******** **************@ c74g2000cwc.goo glegroups.com.. .

Are there any know bugs with the ListView in .NET 2? I'm having
problems with an application that takes 15 seconds in 1.1, and now
takes over a minute. The code in question uses:

listViewItem = this.listView1. Items.Add(...)

followed by 7 calls to

listViewItem.Su bItems.Add(...)

When I comment out this code, the application runs in the same time as
the 1.1 version.

Any suggestions? I can provide the source code if required.

[mrshrinkray]

It's over 6000 items I'm adding, here's a snippet:

ListViewItem listViewItem =
this.listView1. Items.Add(e.Req uestInfo.IP);
listViewItem.Su bItems.Add(e.Re questInfo.DateA ndTime.ToString ("U"));
listViewItem.Su bItems.Add(e.Re questInfo.TimeD ifference+ "");
listViewItem.Su bItems.Add(e.Re questInfo.Reque st);
listViewItem.Su bItems.Add(e.Re questInfo.Statu s+" ");
listViewItem.Su bItems.Add(e.Re questInfo.Bytes + "");
listViewItem.Su bItems.Add(e.Re questInfo.Refer er);
listViewItem.Su bItems.Add(e.Re questInfo.Brows er);

which is taken from a small project I'm writing, full source is at:

http://www.gotdotnet.com/Workspaces/...1-dbe878a161b7

[mrshrinkray]

I also tried changing

// ListViewItem listViewItem =
this.listView1. Items.Add(e.Req uestInfo.IP);
ListViewItem listViewItem = new ListViewItem(e. RequestInfo.IP) ;
this.listView1. Items.Add(listV iewItem);

and also used BeginUpdate,End Update but with no improvement

[cody]

Items.AddRange( ) will be your friend.

If you use .NET2.0 the VirtualMode of the listview class could also be a
great idea.

--
<mr*********@go oglemail.com> schrieb im Newsbeitrag
news:11******** *************@j 55g2000cwa.goog legroups.com...

It's over 6000 items I'm adding, here's a snippet:

ListViewItem listViewItem =
this.listView1. Items.Add(e.Req uestInfo.IP);
listViewItem.Su bItems.Add(e.Re questInfo.DateA ndTime.ToString ("U"));
listViewItem.Su bItems.Add(e.Re questInfo.TimeD ifference+ "");
listViewItem.Su bItems.Add(e.Re questInfo.Reque st);
listViewItem.Su bItems.Add(e.Re questInfo.Statu s+" ");
listViewItem.Su bItems.Add(e.Re questInfo.Bytes + "");
listViewItem.Su bItems.Add(e.Re questInfo.Refer er);
listViewItem.Su bItems.Add(e.Re questInfo.Brows er);

which is taken from a small project I'm writing, full source is at:

http://www.gotdotnet.com/Workspaces/...1-dbe878a161b7

[mrshrinkray]

I should've posted the whole method, here it is:

private void OnLineMatched(o bject sender,LogReade rLineEventArgs e)
{
if ( this.InvokeRequ ired )
{
OnLineMatchedDe legate d1 = new
OnLineMatchedDe legate(OnLineMa tched);
this.Invoke(d1, new object[] { sender, e });
}
else
{
// ListViewItem listViewItem =
this.listView1. Items.Add(e.Req uestInfo.IP);
ListViewItem listViewItem = new ListViewItem(e. RequestInfo.IP) ;
listViewItem.Su bItems.Add(e.Re questInfo.DateA ndTime.ToString ("U"));
listViewItem.Su bItems.Add(e.Re questInfo.TimeD ifference + "");
listViewItem.Su bItems.Add(e.Re questInfo.Reque st);
listViewItem.Su bItems.Add(e.Re questInfo.Statu s + " ");
listViewItem.Su bItems.Add(e.Re questInfo.Bytes + "");
listViewItem.Su bItems.Add(e.Re questInfo.Refer er);
listViewItem.Su bItems.Add(e.Re questInfo.Brows er);
this.listView1. Items.Add(listV iewItem);
this.listView1. EndUpdate();

this.statusBar1 .Panels[1].Text = e.CurrentLine + "/" +
e.TotalLines;
this.progressBa r1.PerformStep( );
}
}

public class LogReaderLineEv entArgs : EventArgs
{
...
public ServerRequestIn fo RequestInfo
{
get
{
return this.serverRequ estDetails;
}
}
}

public struct ServerRequestIn fo
{
public DateTime DateAndTime;
public string IP;
public string Request;
public int Status;
public string Browser;
public string Referer;
public string Method;
public int TimeDifference;
public int Bytes;
}

[mrshrinkray]

The fact it's working in 15 seconds in 1.1 and 1 minute in .NET 2 seems
to point to something else I feel

cody wrote:

Items.AddRange( ) will be your friend.

If you use .NET2.0 the VirtualMode of the listview class could also be a
great idea.

--
<mr*********@go oglemail.com> schrieb im Newsbeitrag
news:11******** *************@j 55g2000cwa.goog legroups.com...

It's over 6000 items I'm adding, here's a snippet:

ListViewItem listViewItem =
this.listView1. Items.Add(e.Req uestInfo.IP);
listViewItem.Su bItems.Add(e.Re questInfo.DateA ndTime.ToString ("U"));
listViewItem.Su bItems.Add(e.Re questInfo.TimeD ifference+ "");
listViewItem.Su bItems.Add(e.Re questInfo.Reque st);
listViewItem.Su bItems.Add(e.Re questInfo.Statu s+" ");
listViewItem.Su bItems.Add(e.Re questInfo.Bytes + "");
listViewItem.Su bItems.Add(e.Re questInfo.Refer er);
listViewItem.Su bItems.Add(e.Re questInfo.Brows er);

which is taken from a small project I'm writing, full source is at:

http://www.gotdotnet.com/Workspaces/...1-dbe878a161b7

[Chris Dunaway]

Just a thought:

Do you have any try catches that might be swallowing an exception?
Perhaps an exception is being generated and swallowed.