Why does the instance change?

[Daniel]

Hey guys

I have an instance of an object say:

List<Object> myList = new List<Object>();

Object myObject = new Object();
myObject.Positi onVector = new Vector3(10,10,1 0);

myList.Add(myOb ject);
With the above code as an accurate example i do that in a loop. And on each
iteration i change the position vector, however when i do this and check my
list it has correctly added each new instance as a separate entry but they
all have the position of the last one to be added. When i steped through it
in debug this was verified, the correct positon details are in on one
iteration and on the next iteration immediately after the new instance has
its position changed so too does the one already in my List.

I presume that a new memory allocation isn't being made and so on setting
position it overwrites the same memory my list is looking at but why? I
thought the 'new' operator explicitly tells it to create a new memory
allocation? Am i missing something? Anyone know how i can prevent this
situation.

Thanks

[Jon Skeet [C# MVP]]

Daniel <Da*****@vestry online.com> wrote:

This goes through one huge class, which calls another class which is
inherited down from two more. Its impossbile to show a complete example.
No it's not. It just requires a little work. No-one's asking you to
post everything in your real classes - just enough for us to compile
and run a program which demonstrates the problem.
Hence my original shortened version that showed only the parts needed to
recreate my problem. Ok i will sort this one out for myself, thanks
anyway.

It's great to show a shortened version that only shows the parts needed
- but it *didn't* allow anyone to recreate the problem. You need to
post:

1) Enough that people can compile and run the program
2) Not too much: nothing that isn't required to show the problem
3) What you expect to happen and what actually happened

--
Jon Skeet - <sk***@pobox.co m>
http://www.pobox.com/~skeet Blog: http://www.msmvps.com/jon.skeet
If replying to the group, please do not mail me too

[Daniel]

Thanks Jon

unfortunately i really dont know how to on this one, usually when i post an
issue i provide all the information needed. I know its difficult to help
when someone gives not everything but the reason i am having a problem may
be due to how complex this piece of code that uses it is.

I would have to rewrite my code anyway to give a shortened version to pull
out the non-needed parts then post that. As someone earlier stated using my
short eample they found no problems so i guess the issue is elsewhere.
Either way its very strange and for such a simple requirement i was
surprised to have a problem. It's ok i will sort it, nothing worse than
someone asking for help and unable to give help to those trying to help.
Hopefully i will get it.

"Jon Skeet [C# MVP]" <sk***@pobox.co m> wrote in message
news:MP******** *************** @msnews.microso ft.com...

Daniel <Da*****@vestry online.com> wrote:

This goes through one huge class, which calls another class which is
inherited down from two more. Its impossbile to show a complete example.

No it's not. It just requires a little work. No-one's asking you to
post everything in your real classes - just enough for us to compile
and run a program which demonstrates the problem.

Hence my original shortened version that showed only the parts needed to
recreate my problem. Ok i will sort this one out for myself, thanks
anyway.

It's great to show a shortened version that only shows the parts needed
- but it *didn't* allow anyone to recreate the problem. You need to
post:

1) Enough that people can compile and run the program
2) Not too much: nothing that isn't required to show the problem
3) What you expect to happen and what actually happened

--
Jon Skeet - <sk***@pobox.co m>
http://www.pobox.com/~skeet Blog: http://www.msmvps.com/jon.skeet
If replying to the group, please do not mail me too

[Göran Andersson]

What does ObjectID.Cards contain? Will it be a different number for each
iteration in the loop? If it won't, then you will get the same instance
from the GetObject method.

The GetObject method never creates new objects, it only returns objects
from the list in the _objMan object. That is the main difference from
the example code you showed first.

Daniel wrote:

Ok my apologies here is the exact code,

On my external class that calls the code withina loop.

PlayingCard theCardSceneObj = new PlayingCard();

theCardSceneObj = (PlayingCard)_o bjMan.GetObject ((int)ObjectID. Cards);

theCardSceneObj .SetCardFrame(p layer.Hand[j]);

theCardSceneObj .FaceUp = player.Hand[j].ShowState;

theCardSceneObj .IsVisible = true;

theCardSceneObj .Position = new Vector3(seatPos .X + (j * 15), seatPos.Y + (j
* 10), 0);

_objMan.AddToRe nderList(theCar dSceneObj);

Inside the_objMan instance:

class ObjectManager

{

List<SceneObjec t> _sceneObjList;

List<SceneObjec t> __renderList;

public ObjectManager()

{

_sceneObjList = new List<SceneObjec t>();

}

public void AddToRenderList (SceneObject so)
{
_renderList.Add (so);
}

public object GetObject(int ObjectId)

{

int count = 0;

foreach (SceneObject so in _sceneObjList)

{

if (so.ObjectID == ObjectId)

return _sceneObjList[count];

count++;

}

return null;

}
That any clearer?

"Göran Andersson" <gu***@guffa.co m> wrote in message
news:u1******** ******@TK2MSFTN GP03.phx.gbl...

No, sorry, the code you show is *not* an accurate example. If you can't
show the actual code you are using, you have to at least show a complete
example that will actually show the problem you are talking about.

It's near to impossible to locate an error in a code by looking at some
other code that doesn't even have the error in it.

Think of it as going to your local mecanic, show him a picture of your
bike, and ask him why you car is not starting... ;)

Daniel wrote:

Hey guys

I have an instance of an object say:

List<Object> myList = new List<Object>();

Object myObject = new Object();
myObject.Positi onVector = new Vector3(10,10,1 0);

myList.Add(myOb ject);
With the above code as an accurate example i do that in a loop. And on
each iteration i change the position vector, however when i do this and
check my list it has correctly added each new instance as a separate
entry but they all have the position of the last one to be added. When i
steped through it in debug this was verified, the correct positon details
are in on one iteration and on the next iteration immediately after the
new instance has its position changed so too does the one already in my
List.

I presume that a new memory allocation isn't being made and so on setting
position it overwrites the same memory my list is looking at but why? I
thought the 'new' operator explicitly tells it to create a new memory
allocation? Am i missing something? Anyone know how i can prevent this
situation.

Thanks

[Joanna Carter [TeamB]]

"Daniel" <Da*****@vestry online.com> a écrit dans le message de news:
eL************* *@TK2MSFTNGP05. phx.gbl...

| unfortunately i really dont know how to on this one, usually when i post
an
| issue i provide all the information needed. I know its difficult to help
| when someone gives not everything but the reason i am having a problem may
| be due to how complex this piece of code that uses it is.
|
| I would have to rewrite my code anyway to give a shortened version to pull
| out the non-needed parts then post that. As someone earlier stated using
my
| short eample they found no problems so i guess the issue is elsewhere.
| Either way its very strange and for such a simple requirement i was
| surprised to have a problem. It's ok i will sort it, nothing worse than
| someone asking for help and unable to give help to those trying to help.
| Hopefully i will get it.

All you have to post to make this understandable is the part of the
PlayingCard class that includes the Position property, as that is the
property that you state is always the same for all instances of the
PlayingCard class.

e.g.

public class PlayingCard
{
private Vector3 position;

public Vector3 Position
{
get { return position; }
set { position = value; }
}
}

Does this look anything like the property declared in your class ?

Joanna

--
Joanna Carter [TeamB]
Consultant Software Engineer

[Daniel]

Hi Goran

Yes it does because i get the object but i did this

PlayingCard pc = new PlayingCard();

pc = GetObject(objec tId); etc etc

And i still had the same problem.

In response to the other question, yes thats how my position method looks.

"Göran Andersson" <gu***@guffa.co m> wrote in message
news:%2******** ********@TK2MSF TNGP03.phx.gbl. ..

What does ObjectID.Cards contain? Will it be a different number for each
iteration in the loop? If it won't, then you will get the same instance
from the GetObject method.

The GetObject method never creates new objects, it only returns objects
from the list in the _objMan object. That is the main difference from the
example code you showed first.

Daniel wrote:

Ok my apologies here is the exact code,

On my external class that calls the code withina loop.

PlayingCard theCardSceneObj = new PlayingCard();

theCardSceneObj = (PlayingCard)_o bjMan.GetObject ((int)ObjectID. Cards);

theCardSceneObj .SetCardFrame(p layer.Hand[j]);

theCardSceneObj .FaceUp = player.Hand[j].ShowState;

theCardSceneObj .IsVisible = true;

theCardSceneObj .Position = new Vector3(seatPos .X + (j * 15), seatPos.Y +
(j * 10), 0);

_objMan.AddToRe nderList(theCar dSceneObj);

Inside the_objMan instance:

class ObjectManager

{

List<SceneObjec t> _sceneObjList;

List<SceneObjec t> __renderList;

public ObjectManager()

{

_sceneObjList = new List<SceneObjec t>();

}

public void AddToRenderList (SceneObject so)
{
_renderList.Add (so);
}

public object GetObject(int ObjectId)

{

int count = 0;

foreach (SceneObject so in _sceneObjList)

{

if (so.ObjectID == ObjectId)

return _sceneObjList[count];

count++;

}

return null;

}
That any clearer?

"Göran Andersson" <gu***@guffa.co m> wrote in message
news:u1******** ******@TK2MSFTN GP03.phx.gbl...

No, sorry, the code you show is *not* an accurate example. If you can't
show the actual code you are using, you have to at least show a complete
example that will actually show the problem you are talking about.

It's near to impossible to locate an error in a code by looking at some
other code that doesn't even have the error in it.

Think of it as going to your local mecanic, show him a picture of your
bike, and ask him why you car is not starting... ;)

Daniel wrote:
Hey guys

I have an instance of an object say:

List<Object> myList = new List<Object>();

Object myObject = new Object();
myObject.Positi onVector = new Vector3(10,10,1 0);

myList.Add(myOb ject);
With the above code as an accurate example i do that in a loop. And on
each iteration i change the position vector, however when i do this and
check my list it has correctly added each new instance as a separate
entry but they all have the position of the last one to be added. When
i steped through it in debug this was verified, the correct positon
details are in on one iteration and on the next iteration immediately
after the new instance has its position changed so too does the one
already in my List.

I presume that a new memory allocation isn't being made and so on
setting position it overwrites the same memory my list is looking at
but why? I thought the 'new' operator explicitly tells it to create a
new memory allocation? Am i missing something? Anyone know how i can
prevent this situation.

Thanks

[Daniel]

SceneChair chair = (SceneChair)_ob jMan.GetObject( (int)ObjectID.S eats);

chair.Position = GetSeatPosition (1);

chair.FrameNum = 1;

_objMan.AddToRe nderStack(chair );

SceneChair chair2 = new SceneChair();

chair2 = chair;

chair2.Position = GetSeatPosition (3);

chair2.FrameNum = 2;

_objMan.AddToRe nderStack(chair 2);

Ok in the above code when i debug, at the line chair2.Position both
instances are equal in data as you would expect.

Now when i go to the final _objMan.AddToRe nderStack line both the chair
instance and the chair2 instance framenumbers become 2. But i only changed
chair2's one so chair being a differenct instance shouldnt be effected
right?

The SceneChair chair2 = new SceneChair(); should have created a new memory
space and then when i changed chair2's framenum the memory allocated for
chair2 shoudl change while chair's remains the same. Am i right? So why do
they both change later on??? This is why when i add it to my stack they are
equal, as it is changing them as i said before while on the stack as if it
were the same instance.


"Göran Andersson" <gu***@guffa.co m> wrote in message
news:%2******** ********@TK2MSF TNGP03.phx.gbl. ..

What does ObjectID.Cards contain? Will it be a different number for each
iteration in the loop? If it won't, then you will get the same instance
from the GetObject method.

The GetObject method never creates new objects, it only returns objects
from the list in the _objMan object. That is the main difference from the
example code you showed first.

Daniel wrote:

Ok my apologies here is the exact code,

On my external class that calls the code withina loop.

PlayingCard theCardSceneObj = new PlayingCard();

theCardSceneObj = (PlayingCard)_o bjMan.GetObject ((int)ObjectID. Cards);

theCardSceneObj .SetCardFrame(p layer.Hand[j]);

theCardSceneObj .FaceUp = player.Hand[j].ShowState;

theCardSceneObj .IsVisible = true;

theCardSceneObj .Position = new Vector3(seatPos .X + (j * 15), seatPos.Y +
(j * 10), 0);

_objMan.AddToRe nderList(theCar dSceneObj);

Inside the_objMan instance:

class ObjectManager

{

List<SceneObjec t> _sceneObjList;

List<SceneObjec t> __renderList;

public ObjectManager()

{

_sceneObjList = new List<SceneObjec t>();

}

public void AddToRenderList (SceneObject so)
{
_renderList.Add (so);
}

public object GetObject(int ObjectId)

{

int count = 0;

foreach (SceneObject so in _sceneObjList)

{

if (so.ObjectID == ObjectId)

return _sceneObjList[count];

count++;

}

return null;

}
That any clearer?

"Göran Andersson" <gu***@guffa.co m> wrote in message
news:u1******** ******@TK2MSFTN GP03.phx.gbl...

No, sorry, the code you show is *not* an accurate example. If you can't
show the actual code you are using, you have to at least show a complete
example that will actually show the problem you are talking about.

It's near to impossible to locate an error in a code by looking at some
other code that doesn't even have the error in it.

Think of it as going to your local mecanic, show him a picture of your
bike, and ask him why you car is not starting... ;)

Daniel wrote:
Hey guys

I have an instance of an object say:

List<Object> myList = new List<Object>();

Object myObject = new Object();
myObject.Positi onVector = new Vector3(10,10,1 0);

myList.Add(myOb ject);
With the above code as an accurate example i do that in a loop. And on
each iteration i change the position vector, however when i do this and
check my list it has correctly added each new instance as a separate
entry but they all have the position of the last one to be added. When
i steped through it in debug this was verified, the correct positon
details are in on one iteration and on the next iteration immediately
after the new instance has its position changed so too does the one
already in my List.

I presume that a new memory allocation isn't being made and so on
setting position it overwrites the same memory my list is looking at
but why? I thought the 'new' operator explicitly tells it to create a
new memory allocation? Am i missing something? Anyone know how i can
prevent this situation.

Thanks

[Lebesgue]

First - this does not compile.
Second - we don't know the definition of GetSeatPosition , SceneChair, type
of _objMan, definition of its GetObject and AddToRenderStac k method,
SceneChair class definition,...

How can we help you if WE can not recreate the problem? Jon Skeet has
already provided you advice how to structure your question, but I think he
did not send you the link:
http://www.yoda.arachsys.com/csharp/complete.html
Can you post a complete program (OK, the thing you have posted is short
enough, just make it complete) that demonstrates the problem?

"Daniel" <Da*****@vestry online.com> wrote in message
news:%2******** ********@TK2MSF TNGP05.phx.gbl. ..

SceneChair chair = (SceneChair)_ob jMan.GetObject( (int)ObjectID.S eats);

chair.Position = GetSeatPosition (1);

chair.FrameNum = 1;

_objMan.AddToRe nderStack(chair );

SceneChair chair2 = new SceneChair();

chair2 = chair;

chair2.Position = GetSeatPosition (3);

chair2.FrameNum = 2;

_objMan.AddToRe nderStack(chair 2);

Ok in the above code when i debug, at the line chair2.Position both
instances are equal in data as you would expect.

Now when i go to the final _objMan.AddToRe nderStack line both the chair
instance and the chair2 instance framenumbers become 2. But i only changed
chair2's one so chair being a differenct instance shouldnt be effected
right?

The SceneChair chair2 = new SceneChair(); should have created a new memory
space and then when i changed chair2's framenum the memory allocated for
chair2 shoudl change while chair's remains the same. Am i right? So why do
they both change later on??? This is why when i add it to my stack they
are equal, as it is changing them as i said before while on the stack as
if it were the same instance.


"Göran Andersson" <gu***@guffa.co m> wrote in message
news:%2******** ********@TK2MSF TNGP03.phx.gbl. ..

What does ObjectID.Cards contain? Will it be a different number for each
iteration in the loop? If it won't, then you will get the same instance
from the GetObject method.

The GetObject method never creates new objects, it only returns objects
from the list in the _objMan object. That is the main difference from the
example code you showed first.

Daniel wrote:

Ok my apologies here is the exact code,

On my external class that calls the code withina loop.

PlayingCard theCardSceneObj = new PlayingCard();

theCardSceneObj = (PlayingCard)_o bjMan.GetObject ((int)ObjectID. Cards);

theCardSceneObj .SetCardFrame(p layer.Hand[j]);

theCardSceneObj .FaceUp = player.Hand[j].ShowState;

theCardSceneObj .IsVisible = true;

theCardSceneObj .Position = new Vector3(seatPos .X + (j * 15), seatPos.Y +
(j * 10), 0);

_objMan.AddToRe nderList(theCar dSceneObj);

Inside the_objMan instance:

class ObjectManager

{

List<SceneObjec t> _sceneObjList;

List<SceneObjec t> __renderList;

public ObjectManager()

{

_sceneObjList = new List<SceneObjec t>();

}

public void AddToRenderList (SceneObject so)
{
_renderList.Add (so);
}

public object GetObject(int ObjectId)

{

int count = 0;

foreach (SceneObject so in _sceneObjList)

{

if (so.ObjectID == ObjectId)

return _sceneObjList[count];

count++;

}

return null;

}
That any clearer?

"Göran Andersson" <gu***@guffa.co m> wrote in message
news:u1******** ******@TK2MSFTN GP03.phx.gbl...
No, sorry, the code you show is *not* an accurate example. If you can't
show the actual code you are using, you have to at least show a
complete example that will actually show the problem you are talking
about.

It's near to impossible to locate an error in a code by looking at some
other code that doesn't even have the error in it.

Think of it as going to your local mecanic, show him a picture of your
bike, and ask him why you car is not starting... ;)

Daniel wrote:
> Hey guys
>
> I have an instance of an object say:
>
> List<Object> myList = new List<Object>();
>
> Object myObject = new Object();
> myObject.Positi onVector = new Vector3(10,10,1 0);
>
> myList.Add(myOb ject);
>
>
> With the above code as an accurate example i do that in a loop. And on
> each iteration i change the position vector, however when i do this
> and check my list it has correctly added each new instance as a
> separate entry but they all have the position of the last one to be
> added. When i steped through it in debug this was verified, the
> correct positon details are in on one iteration and on the next
> iteration immediately after the new instance has its position changed
> so too does the one already in my List.
>
> I presume that a new memory allocation isn't being made and so on
> setting position it overwrites the same memory my list is looking at
> but why? I thought the 'new' operator explicitly tells it to create a
> new memory allocation? Am i missing something? Anyone know how i can
> prevent this situation.
>
> Thanks

[Daniel]

As i said before i cannot do that.

First there is too much to send and second this code is protected and
copyrighted so i will not be pasting large segements on a newsgroup.

I thought maybe i had overlooked something simple and someone was going to
say 'ah your not understaing how the new operator works' or something like
that. So don't worry clearly this is not a simple thing to fix and requires
going through a lot of code to see why these instances are not acting as
they should.

Thanks for your help but unfortunately i cannot provide more code,
definitely not a compilable version.

"Lebesgue" <le******@gmail .com> wrote in message
news:%2******** ********@TK2MSF TNGP04.phx.gbl. ..

First - this does not compile.
Second - we don't know the definition of GetSeatPosition , SceneChair, type
of _objMan, definition of its GetObject and AddToRenderStac k method,
SceneChair class definition,...

How can we help you if WE can not recreate the problem? Jon Skeet has
already provided you advice how to structure your question, but I think he
did not send you the link:
http://www.yoda.arachsys.com/csharp/complete.html
Can you post a complete program (OK, the thing you have posted is short
enough, just make it complete) that demonstrates the problem?

"Daniel" <Da*****@vestry online.com> wrote in message
news:%2******** ********@TK2MSF TNGP05.phx.gbl. ..

SceneChair chair = (SceneChair)_ob jMan.GetObject( (int)ObjectID.S eats);

chair.Position = GetSeatPosition (1);

chair.FrameNum = 1;

_objMan.AddToRe nderStack(chair );

SceneChair chair2 = new SceneChair();

chair2 = chair;

chair2.Position = GetSeatPosition (3);

chair2.FrameNum = 2;

_objMan.AddToRe nderStack(chair 2);

Ok in the above code when i debug, at the line chair2.Position both
instances are equal in data as you would expect.

Now when i go to the final _objMan.AddToRe nderStack line both the chair
instance and the chair2 instance framenumbers become 2. But i only
changed chair2's one so chair being a differenct instance shouldnt be
effected right?

The SceneChair chair2 = new SceneChair(); should have created a new
memory space and then when i changed chair2's framenum the memory
allocated for chair2 shoudl change while chair's remains the same. Am i
right? So why do they both change later on??? This is why when i add it
to my stack they are equal, as it is changing them as i said before while
on the stack as if it were the same instance.


"Göran Andersson" <gu***@guffa.co m> wrote in message
news:%2******** ********@TK2MSF TNGP03.phx.gbl. ..

What does ObjectID.Cards contain? Will it be a different number for each
iteration in the loop? If it won't, then you will get the same instance
from the GetObject method.

The GetObject method never creates new objects, it only returns objects
from the list in the _objMan object. That is the main difference from
the example code you showed first.

Daniel wrote:
Ok my apologies here is the exact code,

On my external class that calls the code withina loop.

PlayingCard theCardSceneObj = new PlayingCard();

theCardSceneObj = (PlayingCard)_o bjMan.GetObject ((int)ObjectID. Cards);

theCardSceneObj .SetCardFrame(p layer.Hand[j]);

theCardSceneObj .FaceUp = player.Hand[j].ShowState;

theCardSceneObj .IsVisible = true;

theCardSceneObj .Position = new Vector3(seatPos .X + (j * 15), seatPos.Y
+ (j * 10), 0);

_objMan.AddToRe nderList(theCar dSceneObj);

Inside the_objMan instance:

class ObjectManager

{

List<SceneObjec t> _sceneObjList;

List<SceneObjec t> __renderList;

public ObjectManager()

{

_sceneObjList = new List<SceneObjec t>();

}

public void AddToRenderList (SceneObject so)
{
_renderList.Add (so);
}

public object GetObject(int ObjectId)

{

int count = 0;

foreach (SceneObject so in _sceneObjList)

{

if (so.ObjectID == ObjectId)

return _sceneObjList[count];

count++;

}

return null;

}
That any clearer?

"Göran Andersson" <gu***@guffa.co m> wrote in message
news:u1******** ******@TK2MSFTN GP03.phx.gbl...
> No, sorry, the code you show is *not* an accurate example. If you
> can't show the actual code you are using, you have to at least show a
> complete example that will actually show the problem you are talking
> about.
>
> It's near to impossible to locate an error in a code by looking at
> some other code that doesn't even have the error in it.
>
> Think of it as going to your local mecanic, show him a picture of your
> bike, and ask him why you car is not starting... ;)
>
> Daniel wrote:
>> Hey guys
>>
>> I have an instance of an object say:
>>
>> List<Object> myList = new List<Object>();
>>
>> Object myObject = new Object();
>> myObject.Positi onVector = new Vector3(10,10,1 0);
>>
>> myList.Add(myOb ject);
>>
>>
>> With the above code as an accurate example i do that in a loop. And
>> on each iteration i change the position vector, however when i do
>> this and check my list it has correctly added each new instance as a
>> separate entry but they all have the position of the last one to be
>> added. When i steped through it in debug this was verified, the
>> correct positon details are in on one iteration and on the next
>> iteration immediately after the new instance has its position changed
>> so too does the one already in my List.
>>
>> I presume that a new memory allocation isn't being made and so on
>> setting position it overwrites the same memory my list is looking at
>> but why? I thought the 'new' operator explicitly tells it to create a
>> new memory allocation? Am i missing something? Anyone know how i can
>> prevent this situation.
>>
>> Thanks

[Jon Skeet [C# MVP]]

Daniel <Da*****@vestry online.com> wrote:

SceneChair chair = (SceneChair)_ob jMan.GetObject( (int)ObjectID.S eats);

chair.Position = GetSeatPosition (1);

chair.FrameNum = 1;

_objMan.AddToRe nderStack(chair );

SceneChair chair2 = new SceneChair();

chair2 = chair;

chair2.Position = GetSeatPosition (3);

chair2.FrameNum = 2;

_objMan.AddToRe nderStack(chair 2);
Ok in the above code when i debug, at the line chair2.Position both
instances are equal in data as you would expect.

Now when i go to the final _objMan.AddToRe nderStack line both the chair
instance and the chair2 instance framenumbers become 2. But i only changed
chair2's one so chair being a differenct instance shouldnt be effected
right?

No. You're creating a new object in the line

SceneChair chair2 = new SceneChair();

but then you're immediately making that object useless by doing:

chair2 = chair;

At that point, chair2 and chair both reference the same object, so when
you make changes to that object, you'll see the changes through either
of the variables.

--
Jon Skeet - <sk***@pobox.co m>
http://www.pobox.com/~skeet Blog: http://www.msmvps.com/jon.skeet
If replying to the group, please do not mail me too