threading

[Mike P]

I have two loops that I am running, one of which is calling a method
which contains the second one. What I want to happen is for when the
second loop exits (the inner loop), then the code will return to the
first loop (the outer loop) and continue executing, but this doesn't
seem to be happening. Here is my code if anybody can help me out :

Loop 1 :

for (int i = 0; i < oItems.Count; i++)
{
oItems = oInbox.Items;

ProgressWindow progress = new ProgressWindow( );
progress.Text = "Work";
System.Threadin g.ThreadPool.Qu eueUserWorkItem (new
System.Threadin g.WaitCallback( MoveMail), new object[] { progress,
oItems, destfolder, objConn });

if (oItems.Count == 1)
{
i = -1;
}
else
{
i = 0;
}

progress.ShowDi alog();
}

Loop 2 in MoveMail method :

private void MoveMail(object status)
{
object[] parms = (object[])status;
IProgressCallba ck callback = (IProgressCallb ack)parms[0];
Outlook.Items col = (Outlook.Items) parms[1];
Outlook.MAPIFol der destfolder =
(Outlook.MAPIFo lder)parms[2];
SqlConnection objConn = (SqlConnection) parms[3];

string strInsertQuery = "";

callback.Begin( 0, col.Count);

for (int i = 1; i < col.Count + 1; i++)
{
callback.SetTex t(String.Format ("Performing op: {0}",
i));
callback.StepTo (i);

if (callback.IsAbo rting)
{
return;
}

if (col.Item(i) is Outlook.MailIte m)
{
Outlook.MailIte m oMsg =
(Outlook.MailIt em)col.Item(i);

//subject
if ((oMsg.Subject == null) || (oMsg.Subject == ""))
{
oMsg.Subject = "blank";
}
else
{
//escape quotes in subject
oMsg.Subject = oMsg.Subject.Re place("'", "''");
}

if (oMsg.ReceivedB yName == null)
{
if (oMsg.SenderNam e.IndexOf("'") != -1)
{
string strSenderName =
oMsg.SenderName .Replace("'", "''");

strInsertQuery = "INSERT INTO SeedingResults
(SenderName, ReceivedTime, Subject) VALUES ('" + strSenderName + "','" +
oMsg.ReceivedTi me.ToString() + "','" + oMsg.Subject.To String() + "')";
}
else
{
strInsertQuery = "INSERT INTO SeedingResults
(SenderName, ReceivedTime, Subject) VALUES ('" +
oMsg.SenderName .ToString() + "','" + oMsg.ReceivedTi me.ToString() +
"','" + oMsg.Subject.To String() + "')";
}
}
else
{
if (oMsg.SenderNam e.IndexOf("'") != -1)
{
string strSenderName2 =
oMsg.SenderName .Replace("'", "''");

strInsertQuery = "INSERT INTO SeedingResults
(ReceivedByName , SenderName, ReceivedTime, Subject) VALUES ('" +
oMsg.ReceivedBy Name.ToString() + "','" + strSenderName2 + "','" +
oMsg.ReceivedTi me.ToString() + "','" + oMsg.Subject.To String() + "')";
}
else
{
strInsertQuery = "INSERT INTO SeedingResults
(ReceivedByName , SenderName, ReceivedTime, Subject) VALUES ('" +
oMsg.ReceivedBy Name.ToString() + "','" + oMsg.SenderName .ToString() +
"','" + oMsg.ReceivedTi me.ToString() + "','" + oMsg.Subject.To String() +
"')";
}
}

//write to database
SqlCommand objInsertComman d = new
SqlCommand(strI nsertQuery, objConn);

try
{
objInsertComman d.ExecuteNonQue ry();
}
catch
{
throw new DatabaseExcepti on();
}

oMsg.Move(destf older);

if (callback.IsAbo rting)
{
return;
}
}
}
}

*** Sent via Developersdex http://www.developersdex.com ***

[Jon Skeet [C# MVP]]

On Mar 20, 12:40 pm, Mike P <mike.p...@gmai l.comwrote:

I have two loops that I am running, one of which is calling a method
which contains the second one. What I want to happen is for when the
second loop exits (the inner loop), then the code will return to the
first loop (the outer loop) and continue executing, but this doesn't
seem to be happening. Here is my code if anybody can help me out :

There's a lot of code there, most of it not relevant to the problem.

Could you post a short but complete program that demonstrates the
problem?
See http://pobox.com/~skeet/csharp/complete/html for more on what I
mean by this.

Jon

[Mike P]

Here's the code cut down :

Loop 1 :

for (int i = 0; i < oItems.Count; i++)
{
oItems = oInbox.Items;

ProgressWindow progress = new ProgressWindow( );
progress.Text = "Work";
System.Threadin g.ThreadPool.Qu eueUserWorkItem (new
System.Threadin g.WaitCallback( MoveMail), new object[] { progress,
oItems, destfolder, objConn });

if (oItems.Count == 1)
{
i = -1;
}
else
{
i = 0;
}

progress.ShowDi alog();
}

Loop 2 :

private void MoveMail(object status)
{
object[] parms = (object[])status;
IProgressCallba ck callback = (IProgressCallb ack)parms[0];
Outlook.Items col = (Outlook.Items) parms[1];
Outlook.MAPIFol der destfolder =
(Outlook.MAPIFo lder)parms[2];
SqlConnection objConn = (SqlConnection) parms[3];

string strInsertQuery = "";

callback.Begin( 0, col.Count);

for (int i = 1; i < col.Count + 1; i++)
{
callback.SetTex t(String.Format ("Performing op: {0}",
i));
callback.StepTo (i);

if (callback.IsAbo rting)
{
return;
}

if (col.Item(i) is Outlook.MailIte m)
{
Outlook.MailIte m oMsg =
(Outlook.MailIt em)col.Item(i);

//db stuff goes here

oMsg.Move(destf older);

if (callback.IsAbo rting)
{
return;
}
}
}
}
*** Sent via Developersdex http://www.developersdex.com ***

[Jon Skeet [C# MVP]]

On Mar 20, 2:00 pm, Mike P <mike.p...@gmai l.comwrote:

Here's the code cut down :

<snip>

Please read http://www.yoda.arachsys.com/csharp/incomplete.html

Jon

[Mike P]

Here's another attempt :

Main form :

Outlook.Applica tion oApp = new Outlook.Applica tionClass();

Outlook.NameSpa ce oNS = oApp.GetNamespa ce("mapi");

string strUserName =
System.Environm ent.UserName.To String();

oNS.Logon(strUs erName, System.Reflecti on.Missing.Valu e, false, true);

Outlook.MAPIFol der oInbox =
oNS.GetDefaultF older(Outlook.O lDefaultFolders .olFolderInbox) ;

Outlook.MAPIFol der destfolder =
oInbox.Folders. Item("Archive") ;

Outlook.Items oItems = oInbox.Items;

int intTotalNumberO fItemsInInbox = oItems.Count;

for (int i = 0; i < oItems.Count; i++)
{
oItems = oInbox.Items;

ProgressWindow progress = new ProgressWindow( );
progress.Text = "Work";
System.Threadin g.ThreadPool.Qu eueUserWorkItem (new
System.Threadin g.WaitCallback( MoveMail), new object[] { progress,
oItems, destfolder, objConn });

if (oItems.Count == 1)
{
i = -1;
}
else
{
i = 0;
}

progress.ShowDi alog();
}

private void MoveMail(object status)
{
object[] parms = (object[])status;
IProgressCallba ck callback = (IProgressCallb ack)parms[0];
Outlook.Items col = (Outlook.Items) parms[1];
Outlook.MAPIFol der destfolder =
(Outlook.MAPIFo lder)parms[2];
SqlConnection objConn = (SqlConnection) parms[3];

callback.Begin( 0, col.Count);

for (int i = 1; i < col.Count + 1; i++)
{
callback.SetTex t(String.Format ("Performing op: {0}",
i));
callback.StepTo (i);

if (callback.IsAbo rting)
{
return;
}

if (col.Item(i) is Outlook.MailIte m)
{
Outlook.MailIte m oMsg =
(Outlook.MailIt em)col.Item(i);

oMsg.Move(destf older);

if (callback.IsAbo rting)
{
return;
}
}
}
}

Added to this I am using ProgressWindow. cs and IProgressCallba ck.cs from
the following example :

http://www.codeproject.com/cs/miscct...ressdialog.asp

HTH,

Mike


*** Sent via Developersdex http://www.developersdex.com ***

[Mike P]

The problem I have with this code is that without the threading code,
after it has completed executing inside the second loop it returns to
the first loop, whereas when the threading code is added, it doesn't.
Here's the code in it's original form :

for (int i = 0; i < oItems.Count; i++)
{
oItems = oInbox.Items;

MoveMail(oItems , destfolder, objConn);

if (oItems.Count == 1)
{
i = -1;
}
else
{
i = 0;
}

private void MoveMail(Outloo k.Items col, Outlook.MAPIFol der destfolder,
SqlConnection objConn)
{

for (int i = 1; i < col.Count + 1; i++)
{
if (col.Item(i) is Outlook.MailIte m)
{
Outlook.MailIte m oMsg =
(Outlook.MailIt em)col.Item(i);

oMsg.Move(destf older);
}
}
}

*** Sent via Developersdex http://www.developersdex.com ***

[Jon Skeet [C# MVP]]

On Mar 20, 2:23 pm, Mike P <mike.p...@gmai l.comwrote:

Here's another attempt :

*Please* read the link I gave.

Try to cut and paste the code you've posted directly into an empty
file and compile it. It won't work, because it's incomplete.

Also, anything which requires Outlook isn't going to be easy for
everyone to reproduce. Put in some dummy work (eg writing a counter to
the console). This isn't meant to be real code, it's meant to be code
which *just* demonstrates the problem.

Jon

[Willy Denoyette [MVP]]

"Mike P" <mi*******@gmai l.comwrote in message
news:ue******** ******@TK2MSFTN GP05.phx.gbl...

Here's another attempt :

Main form :

Outlook.Applica tion oApp = new Outlook.Applica tionClass();

Outlook.NameSpa ce oNS = oApp.GetNamespa ce("mapi");

string strUserName =
System.Environm ent.UserName.To String();

oNS.Logon(strUs erName, System.Reflecti on.Missing.Valu e, false, true);

Outlook.MAPIFol der oInbox =
oNS.GetDefaultF older(Outlook.O lDefaultFolders .olFolderInbox) ;

Outlook.MAPIFol der destfolder =
oInbox.Folders. Item("Archive") ;

Outlook.Items oItems = oInbox.Items;

int intTotalNumberO fItemsInInbox = oItems.Count;

for (int i = 0; i < oItems.Count; i++)
{
oItems = oInbox.Items;

ProgressWindow progress = new ProgressWindow( );
progress.Text = "Work";
System.Threadin g.ThreadPool.Qu eueUserWorkItem (new
System.Threadin g.WaitCallback( MoveMail), new object[] { progress,
oItems, destfolder, objConn });

if (oItems.Count == 1)
{
i = -1;
}
else
{
i = 0;
}

progress.ShowDi alog();
}

private void MoveMail(object status)
{
object[] parms = (object[])status;
IProgressCallba ck callback = (IProgressCallb ack)parms[0];
Outlook.Items col = (Outlook.Items) parms[1];
Outlook.MAPIFol der destfolder =
(Outlook.MAPIFo lder)parms[2];
SqlConnection objConn = (SqlConnection) parms[3];

callback.Begin( 0, col.Count);

for (int i = 1; i < col.Count + 1; i++)
{
callback.SetTex t(String.Format ("Performing op: {0}",
i));
callback.StepTo (i);

if (callback.IsAbo rting)
{
return;
}

if (col.Item(i) is Outlook.MailIte m)
{
Outlook.MailIte m oMsg =
(Outlook.MailIt em)col.Item(i);

oMsg.Move(destf older);

if (callback.IsAbo rting)
{
return;
}
}
}
}

Added to this I am using ProgressWindow. cs and IProgressCallba ck.cs from
the following example :

http://www.codeproject.com/cs/miscct...ressdialog.asp

HTH,

Mike


*** Sent via Developersdex http://www.developersdex.com ***

It's really hard to see what's going on, but I would suggest you to forget about a
threadpool thread, use a 'normal auxiliary' thread and initialize this one to enter the STA.
This way you are creating the COM reference on the main UI thread (STA) and you pass COM
references to a worker thread taken from the pool, however these pool threads are running in
the MTA, that means that you probably have to deal with marshaling issues between the MTA
and the STA thread.
Another option is to create the "Outlook" instance from the auxiliary thread, don't
initialize it to enter an STA, should work from MTA.

Willy.

[Mike P]

Willy,

Apologies, I'm new to threading, but what do you mean by MTA?
Thanks,

Mike
*** Sent via Developersdex http://www.developersdex.com ***

[Mike P]

Willy,

Apologies, I'm new to threading, but what do you mean by MTA?
Thanks,

Mike
*** Sent via Developersdex http://www.developersdex.com ***