HttpWebrequest Upload Of (image) Binary file.

[Gert Conradie]

The following code can uplaod text files. When i upload a binary file
it fail.

I might be:
1) using the wrong Encoding
2) will have to System.Convert. ToBase64String the content of the
binary file

Any help / suggestions would be much appreciated. Already spend a lot
of time on this.

Regards, Gert

Here is the console application code:

static void Main(string[] args)
{
UploadImageFile (@"C:\imagetest .JPG"); //fail
UploadImageFile (@"C:\test.txt" ); //work
Console.ReadLin e();
}
private static string GetMultipartBou ndary()
{
return String.Format(" *************** ********{0}",
DateTime.Now.Ti cks);
}
private static void UploadImageFile (string fileNameToUpLoa d)
{
Console.WriteLi ne("");

Console.WriteLi ne("=========== =============== ==============" );
Console.WriteLi ne("UploadImage File");

Console.WriteLi ne("=========== =============== ==============" );

string url;
string uploadFileFormC ontrolName;
string boundry;
string databoundary;
string filetype;
StringBuilder reqString;
Encoding enc;
MemoryStream oPostStream;
BinaryWriter oPostData;
HttpWebRequest request;
System.IO.FileI nfo fileToUpLoad;
byte[] byteArrayBefore ;
byte[] byteArray;
byte[] byteArrayAfter;

reqString = new StringBuilder() ;
oPostStream = new MemoryStream();
oPostData = new BinaryWriter(oP ostStream);

url = "http://server/myreceivepage.a sp";
request =
(HttpWebRequest )System.Net.Web Request.Create( url);

boundry = GetMultipartBou ndary();
databoundary = "--" + boundry;
uploadFileFormC ontrolName = "fileinput1 ";
//I think here is my problem:
enc = Encoding.GetEnc oding(1252);
//enc = Encoding.ASCII;
//enc = Encoding.UTF8;
//enc = Encoding.Unicod e;
//enc = Encoding.BigEnd ianUnicode;
enc = Encoding.Defaul t;
//enc = Encoding.UTF32;
//enc = Encoding.UTF7;

fileToUpLoad = new FileInfo(fileNa meToUpLoad);
//this can be enhanced, ok for testing
switch (fileToUpLoad.E xtension)
{
case ".txt":
filetype = "text/plain";
break;

case ".jpg":
filetype = "image/pjpeg";
break;

case ".gif":
filetype = "image/gif";
break;

default:
filetype = "text/plain";
break;
}

//read the file content and store in byteArray[]
long numBytes = fileToUpLoad.Le ngth;
FileStream fStream = new FileStream(file NameToUpLoad,
FileMode.Open, FileAccess.Read );
BinaryReader br = new BinaryReader(fS tream, enc);
byteArray = br.ReadBytes((i nt)numBytes);
br.Close();
fStream.Close() ;

//request.Credent ials = new NetworkCredenti al("user",
"password") ;

request.Method = "POST";
request.Content Type = "multipart/form-data;boundary=" +
boundry;
//Start to build request string:
//=============== =============== ====
//Should you have extra form inputs other than uploadfile
control:
//reqString.Appen d("--" + boundry + "\r\n");
//reqString.Appen d(databoundary + "\r\n");
//reqString.Appen d("Content-Disposition: form-data; name=
\"txtAddPerson\ ";");
//reqString.Appen d("\r\n");
//reqString.Appen d("\r\n");
//reqString.Appen d("myValue");
//reqString.Appen d("\r\n");

reqString.Appen d(databoundary + "\r\n");
reqString.Appen d(string.Format ("Content-Disposition: form-
data; name=\"{0}\"; ", uploadFileFormC ontrolName));
reqString.Appen d(string.Format ("filename=\"{0 }\"\r\n",
fileToUpLoad.Na me));
reqString.Appen d(string.Format ("Content-Type: {0}\r\n",
filetype));
byteArrayBefore = enc.GetBytes(re qString.ToStrin g());

//normally file content goes here - currently in
byteArray[]
//Start to build request string END:
//=============== =============== ====
reqString = new StringBuilder() ;
reqString.Appen d("\r\n");
reqString.Appen dFormat("--{0}--\r\n", boundry);
byteArrayAfter = enc.GetBytes(re qString.ToStrin g());

oPostData.Write (byteArrayBefor e);
oPostData.Write (byteArray);
//maybe like this: ?
//
oPostData.Write (System.Convert .ToBase64String (byteArray));
oPostData.Write (byteArrayAfter );

request.Content Length = (int)oPostData. BaseStream.Leng th;
request.Content Length = byteArrayBefore .Length +
byteArray.Lengt h + byteArrayAfter. Length;

try
{
Stream stream = request.GetRequ estStream();
oPostStream.Wri teTo(stream);
StreamReader reader = new
StreamReader(re quest.GetRespon se().GetRespons eStream());
string myOrginalRawHtm l = reader.ReadToEn d();
myOrginalRawHtm l = myOrginalRawHtm l.Replace("<br> ", "\r
\n");
Console.WriteLi ne(myOrginalRaw Html);
}
catch (System.Excepti on ex)
{
Console.WriteLi ne(ex.Message);
}

Console.WriteLi ne("=========== =============== ==============" );
Console.WriteLi ne("");
}

Thanks, gert

[Gert]

Found my mistake. (It even failed for txt files where it lost the frst
two characters.)

Change this:
reqString.Appen d(string.Format ("Content-Type: {0}\r\n", filetype));
To (Add extra line break):
reqString.Appen d(string.Format ("Content-Type: {0}\r\n\r\n",
filetype));

Regards, gert

On Jun 15, 3:39 pm, Gert Conradie <gert.conra...@ gmail.comwrote:

The following code can uplaod text files. When i upload abinaryfile
it fail.

I might be:
1) using the wrong Encoding
2) will have to System.Convert. ToBase64String the content of thebinaryfile

Any help / suggestions would be much appreciated. Already spend a lot
of time on this.

Regards,Gert

Here is the console application code:

static void Main(string[] args)
{
UploadImageFile (@"C:\imagetest .JPG"); //fail
UploadImageFile (@"C:\test.txt" ); //work
Console.ReadLin e();
}

private static string GetMultipartBou ndary()
{
return String.Format(" *************** ********{0}",
DateTime.Now.Ti cks);
}
private static void UploadImageFile (string fileNameToUpLoa d)
{
Console.WriteLi ne("");

Console.WriteLi ne("=========== =============== ==============" );
Console.WriteLi ne("UploadImage File");

Console.WriteLi ne("=========== =============== ==============" );

string url;
string uploadFileFormC ontrolName;
string boundry;
string databoundary;
string filetype;
StringBuilder reqString;
Encoding enc;
MemoryStream oPostStream;
BinaryWriter oPostData;
HttpWebRequestr equest;
System.IO.FileI nfo fileToUpLoad;
byte[] byteArrayBefore ;
byte[] byteArray;
byte[] byteArrayAfter;

reqString = new StringBuilder() ;
oPostStream = new MemoryStream();
oPostData = new BinaryWriter(oP ostStream);

url = "http://server/myreceivepage.a sp";
request =
(HttpWebRequest )System.Net.Web Request.Create( url);

boundry = GetMultipartBou ndary();
databoundary = "--" + boundry;
uploadFileFormC ontrolName = "fileinput1 ";
//I think here is my problem:
enc = Encoding.GetEnc oding(1252);
//enc = Encoding.ASCII;
//enc = Encoding.UTF8;
//enc = Encoding.Unicod e;
//enc = Encoding.BigEnd ianUnicode;
enc = Encoding.Defaul t;
//enc = Encoding.UTF32;
//enc = Encoding.UTF7;

fileToUpLoad = new FileInfo(fileNa meToUpLoad);
//this can be enhanced, ok for testing
switch (fileToUpLoad.E xtension)
{
case ".txt":
filetype = "text/plain";
break;

case ".jpg":
filetype = "image/pjpeg";
break;

case ".gif":
filetype = "image/gif";
break;

default:
filetype = "text/plain";
break;
}

//read the file content and store in byteArray[]
long numBytes = fileToUpLoad.Le ngth;
FileStream fStream = new FileStream(file NameToUpLoad,
FileMode.Open, FileAccess.Read );
BinaryReader br = new BinaryReader(fS tream, enc);
byteArray = br.ReadBytes((i nt)numBytes);
br.Close();
fStream.Close() ;

//request.Credent ials = new NetworkCredenti al("user",
"password") ;

request.Method = "POST";
request.Content Type = "multipart/form-data;boundary=" +
boundry;

//Start to build request string:
//=============== =============== ====
//Should you have extra form inputs other than uploadfile
control:
//reqString.Appen d("--" + boundry + "\r\n");
//reqString.Appen d(databoundary + "\r\n");
//reqString.Appen d("Content-Disposition: form-data; name=
\"txtAddPerson\ ";");
//reqString.Appen d("\r\n");
//reqString.Appen d("\r\n");
//reqString.Appen d("myValue");
//reqString.Appen d("\r\n");

reqString.Appen d(databoundary + "\r\n");
reqString.Appen d(string.Format ("Content-Disposition: form-
data; name=\"{0}\"; ", uploadFileFormC ontrolName));
reqString.Appen d(string.Format ("filename=\"{0 }\"\r\n",
fileToUpLoad.Na me));
reqString.Appen d(string.Format ("Content-Type: {0}\r\n",
filetype));
byteArrayBefore = enc.GetBytes(re qString.ToStrin g());

//normally file content goes here - currently in
byteArray[]

//Start to build request string END:
//=============== =============== ====
reqString = new StringBuilder() ;
reqString.Appen d("\r\n");
reqString.Appen dFormat("--{0}--\r\n", boundry);
byteArrayAfter = enc.GetBytes(re qString.ToStrin g());

oPostData.Write (byteArrayBefor e);
oPostData.Write (byteArray);
//maybe like this: ?
//
oPostData.Write (System.Convert .ToBase64String (byteArray));
oPostData.Write (byteArrayAfter );

request.Content Length = (int)oPostData. BaseStream.Leng th;
request.Content Length = byteArrayBefore .Length +
byteArray.Lengt h + byteArrayAfter. Length;

try
{
Stream stream = request.GetRequ estStream();
oPostStream.Wri teTo(stream);
StreamReader reader = new
StreamReader(re quest.GetRespon se().GetRespons eStream());
string myOrginalRawHtm l = reader.ReadToEn d();
myOrginalRawHtm l = myOrginalRawHtm l.Replace("<br> ", "\r
\n");
Console.WriteLi ne(myOrginalRaw Html);
}
catch (System.Excepti on ex)
{
Console.WriteLi ne(ex.Message);
}

Console.WriteLi ne("=========== =============== ==============" );
Console.WriteLi ne("");
}

Thanks,gert