calling a sub from another sub and assigning value

[kkshansid]

on calling a sub from another sub and assigning value
it gives error
compile error:
expected function or variable
Please help as I tried many methods but failed

Sub MRKGRD(ByVal XX)
If XX = "TR" Then
MRKGRD = 444.4
ElseIf XX = "IM" Then
MRKGRD = 555.5
ElseIf XX = "AB" Then
MRKGRD = 666.6
ElseIf XX = "TC" Then
MRKGRD = 777.7
ElseIf XX = "DA" Then
MRKGRD = 888.8
ElseIf XX = "BC" Then
MRKGRD = 999.9
Else
MRKGRD = XX
End If
End Sub
Sub updMRK()
Dim AAA As DAO.Database
Dim RSTREV As DAO.Recordset
 
   Set AAA = CurrentDb
   Set RSTREV = AAA.OpenRecordset("SELECT * FROM REV")
   RSTREV.MoveFirst
   Do Until RSTREV.EOF
    Set RSTAG = AAA.OpenRecordset("SELECT * FROM AAAAG WHERE SEQ='" & RSTREV("SEQ") & "'")
         RSTAG.MoveFirst
         RSTREV.Edit
         For I = 1 To 10
         RSTREV("SUB" & I) = RSTAG("SUB" & I)
 
 
         RSTREV("MRK" & I & "_AA1") = MRKGRD(RSTAG("SUB" & I & "_AA1"))
 
    MsgBox "MARKS UPDATED"
Next
 
         RSTREV.Update
         RSTREV.MoveNext
   Loop
    MsgBox "MARKS UPDATED"
End Sub

[PhilOfWalton]

It doesn't help not giving the line where the compile error is shown.

It doesn't help not giving a table structure.

In Sub updMRK(), you have not defined RSTAG as a recordset.

I don't like the look of

 Set RSTAG = AAA.OpenRecordset("SELECT * FROM AAAAG 
WHERE SEQ='" & RSTREV("SEQ") & "'")
 

Phil

[MikeTheBike]

Hi

As the error message suggests this statement

RSTREV("MRK" & I & "_AA1") = MRKGRD(RSTAG("SUB" & I & "_AA1"))

is expecting a variable OR Funtion on the right hand side, NOT a Sub() as you have.

You 'Sub' should be

Funtion MRKGRD(ByVal XX as String) as String
 
End Function

It is a long time since I used DAO, but from memeory don't you also need RSTREV.Update to save the data (but not in ADO)?

I also have doubts about it being a String function as you are retuning numeric values except for the 'Else' case.
What type of field are you saving the returned value to??

HTH


MTB