deletecontrol issues

[wraithzshadow]

hello, so here is my problem... i wrote a function that opens a form,
and goes through all of the controls in the form, i check the first
letter of the name to see if it is an 'X', and if it is, then it
deletes the control. the problem is that it only deletes some of the
controls with names that start with an 'X'... now i wrote the program
so it looks for the 'X' because i couldnt figure out how to only look
at the controls in the details. if i could get it to, then all i would
need to do is tell it to delete ALL controls in the detail section...

the code...

Public Function clearForm()

Dim ctl As Control, ctls As Controls
Dim frm As Form
Dim x As String

DoCmd.openForm "JSA Form V2", acDesign

Set frm = Forms![JSA Form V2]
Set ctls = frm.Controls

For Each ctl In frm.Controls
x = Mid(ctl.Properties("Name"), 1, 1)
If x = "X" Then
DeleteControl frm.Name, ctl.Properties("Name")
End If
Next

DoCmd.Close acForm, "JSA Form V2", acSaveYes

End Function

after i run this function and open the form some of the controls are
gone, some are not... all of the controls in question were created in a
different function, all going through the same process... when i run
the function i notice that it doesnt even look at some of the
controls... it goes through all of the ones that i want to be left on
the form, and goes through and deletes a bunch of the ones its supposed
to... but it completely skips some, i dont understand why... they
appear in the form properties under the control section, they have the
correct name format (exactly the same as the ones that DO get
deleted)... but the for each loop doesnt look at them at all...

i would appreciate help in 1. figuring out how to run a deletecontrol
on only the controls in the details section or 2. figuring out why the
for each control in form.controls loop skips a bunch of the controls...

[salad]

wr***********@gmail.com wrote:

hello, so here is my problem... i wrote a function that opens a form,
and goes through all of the controls in the form, i check the first
letter of the name to see if it is an 'X', and if it is, then it
deletes the control. the problem is that it only deletes some of the
controls with names that start with an 'X'... now i wrote the program
so it looks for the 'X' because i couldnt figure out how to only look
at the controls in the details. if i could get it to, then all i would
need to do is tell it to delete ALL controls in the detail section...

the code...

Public Function clearForm()

Dim ctl As Control, ctls As Controls
Dim frm As Form
Dim x As String

DoCmd.openForm "JSA Form V2", acDesign

Set frm = Forms![JSA Form V2]
Set ctls = frm.Controls

For Each ctl In frm.Controls
x = Mid(ctl.Properties("Name"), 1, 1)
If x = "X" Then
DeleteControl frm.Name, ctl.Properties("Name")
End If
Next

DoCmd.Close acForm, "JSA Form V2", acSaveYes

End Function

after i run this function and open the form some of the controls are
gone, some are not... all of the controls in question were created in a
different function, all going through the same process... when i run
the function i notice that it doesnt even look at some of the
controls... it goes through all of the ones that i want to be left on
the form, and goes through and deletes a bunch of the ones its supposed
to... but it completely skips some, i dont understand why... they
appear in the form properties under the control section, they have the
correct name format (exactly the same as the ones that DO get
deleted)... but the for each loop doesnt look at them at all...

i would appreciate help in 1. figuring out how to run a deletecontrol
on only the controls in the details section or 2. figuring out why the
for each control in form.controls loop skips a bunch of the controls...

On the face of things it appears your code should work.

I might change it to

Set ctls = frm.Controls 'this line is unused, not needed

For Each ctl In frm.Controls
If Left(ctl.Name,1) = "X" then
DeleteControl frm.Name, ctl.name
endif
Next

From help topic Specifications it states:
"Number of controls and sections you can add over the lifetime of the
form or report 754"

Have you been deleting and adding lots of controls to the form? If so,
maybe 754 controls has been met and that throws off some things. As I
said, your code looks ok

You might want to do something like
For Each ctl In frm.Controls
If Left(ctl.Name,1) = "X" then
DeleteControl frm.Name, ctl.name
msgbox "Deleted " & ctl.Name
Else
msgbox "Kept " & ctl.Name
endif
Next

[wraithzshadow]

lol... made the changes you suggested... kept getting an error, the
thing was doing less than it had before. took a lil while, but i
figured it out... the program would delete the control, then try to
reference it when printing the message... so i reversed it so that it
printed the message than deleted it... i also made the change from
ctltext.properties("Name") to ctltext.Name throughout the rest of my
code... when i run the function it posts messages saying "kept" to all
the ones it should, and "deleted" to the ones that get deleted, but it
doesnt post even a message about the ones its supposed to delete but
doesnt... there arent many controls on this form, under 100...

i dont suppose you know if there is a way to tell it to simply delete
everything in the detail section... that is ultimately what im trying
to get it to do

[wraithzshadow]

found a way around it... i changed the way i named my textboxes so it
would just be = "TextBox" & num where num is a number from 1 to however
many i create... then when i go to delete them i dont use a for each...

i use for i = 1 to frm.count - 23 '23 = # of items other than the above
deletecontrol frm.name, "TextBox" & i
next i

[Kevin Rollo]

Rather than repeatedly Creating then Deleting these controls, it may be
beneficial to leave a set hidden and ready on your form then unhide/rehide
as required using the Visible property.

You can manipulate the textbox on the fly, for example

with me.textbox01
.controlsource = "surname"
.left = 200
.top = 200
.visible = True
end with

then disengage it later with

me.textbox01.visible = false
me.textbox01.controlsource = ""
BTW, I suspect your initial problem was a refresh issue in that the
deletecontrol was affecting the frm.controls counter, hence apparently
skipping controls. You could try assembling the list of controls to delete
first perhaps in an array, then second pass through that array and delete
the controls. Although your last work-around looks good too!

Regards,
Kevin Rollo
Western Australia
--
Regards,
Kevin

<wr***********@gmail.comwrote in message
news:11*********************@h48g2000cwc.googlegro ups.com...
found a way around it... i changed the way i named my textboxes so it
would just be = "TextBox" & num where num is a number from 1 to however
many i create... then when i go to delete them i dont use a for each...

i use for i = 1 to frm.count - 23 '23 = # of items other than the above
deletecontrol frm.name, "TextBox" & i
next i

[Bibi]

Hi,

The same problem occured to me...

To solve it you can test this:

j = Forms!IndicsARestituer.Count - 1

For i = j To 1 Step -1
If Left(Forms!IndicsARestituer(i).Name, 4) = "Niv_" Then
DeleteControl "IndicsARestituer",
Forms!IndicsARestituer(i).Name
End If
Next

I think the problem come from the change of the index of the control
when you use DeleteControl. So you have to begin from the end...

Regards,
Julien
Kevin Rollo a écrit :

Rather than repeatedly Creating then Deleting these controls, it may be
beneficial to leave a set hidden and ready on your form then unhide/rehide
as required using the Visible property.

You can manipulate the textbox on the fly, for example

with me.textbox01
.controlsource = "surname"
.left = 200
.top = 200
.visible = True
end with

then disengage it later with

me.textbox01.visible = false
me.textbox01.controlsource = ""
BTW, I suspect your initial problem was a refresh issue in that the
deletecontrol was affecting the frm.controls counter, hence apparently
skipping controls. You could try assembling the list of controls to delete
first perhaps in an array, then second pass through that array and delete
the controls. Although your last work-around looks good too!

Regards,
Kevin Rollo
Western Australia
--
Regards,
Kevin

<wr***********@gmail.comwrote in message
news:11*********************@h48g2000cwc.googlegro ups.com...
found a way around it... i changed the way i named my textboxes so it
would just be = "TextBox" & num where num is a number from 1 to however
many i create... then when i go to delete them i dont use a for each...

i use for i = 1 to frm.count - 23 '23 = # of items other than the above
deletecontrol frm.name, "TextBox" & i
next i