cancel and undo commands aren't working right

[jmarcrum]

Hey everybody!

I've created 2 buttons that I've placed on all my forms: a Save button & a Cancel button.

The cancel button I have a question about.

I used the wizard to create the button and I selected the Record Operations/Undo Record option. I edited the vba code to have the button also close the form after it undoes any changes. Here is the actual code for the OnClick event for the cancel button:

Private Sub cmdCancel_Click()
On Error GoTo errHandle
 
Dim intProcced As Integer
 
'Warn the user that any information entered will be lost, then if the user responds that it is
'ok, erase the record and close the form
 
intProcced = MsgBox("Warning: Any changes made or any information entered will not be saved.", vbOKCancel, "Warning")
    If intProcced = 2 Then
        Exit Sub
    End If
 
DoCmd.DoMenuItem acFormBar, acEditMenu, acUndo, , acMenuVer1X
 
DoCmd.Close
 
Exit Sub
 
errHandle:
If Err.Number = 2046 Then
    DoCmd.Close
    Exit Sub
Else
    'Print the error message and send an email to Administrator
    SendErrorMsg "cmdCancel_Click on frmEnterNewFeeder", Err.Number, Err.Description
    MsgBox Err.Description
End If
 
Exit Sub
 
End Sub

The problem I am having is when someone gets into the form and makes NO changes (doesn't type anything at all). If they click the Cancel button at that point, this message pops up:
"The command or action Undo isn't available now."

Which is true, nothing was done to "undo". What I want the button to do, is undo only if a change has been made. How can I (in the vba code) check first that a change has been made on the form and only execute the undo if a change has been made, otherwise I just want to close the form.

The Error checking and check for the error condition and ignore it code that I have there doesn't work!

Thank so much for your help!

[Rabbit]

The error trapping should work if that's the right error number. You could also try checking to see if it's dirty first.

[jmarcrum]

for some reason, the error trapping isn't working correctly, is there something else I could try with the errhandle? That onDirty command you mentioned...how would I do that?

[Minion]

Try altering the top half of your code to read the following:

Private Sub cmdCancel_Click()
On Error GoTo errHandle
 
Dim intProcced As Integer
 
'Warn the user that any information entered will be lost, then if the user responds that it is
'ok, erase the record and close the form
 
'------------------------------------
' Add this piece here   
' -----------------------------------
If Me.Dirty = True Then
DoCmd.Close acForm
Exit Sub
End IF
' ==================
 
 
 
intProcced = MsgBox("Warning: Any changes made or any information entered will not be saved.", vbOKCancel, "Warning")
    If intProcced = 2 Then
        Exit Sub
    End If
 

See if that does the trick for you.

- Minion -

for some reason, the error trapping isn't working correctly, is there something else I could try with the errhandle? That onDirty command you mentioned...how would I do that?

[jmarcrum]

Hey thanks Minion,

Your tip worked beautifully. I ended up modifying my code to look like this...

Private Sub cmdCancel_Click()
On Error GoTo errHandle
 
Dim intProcced As Integer
 
'Warn the user that any information entered will be lost, then if the user responds that it is
'ok, erase the record and close the form
 
intProcced = MsgBox("Warning: Any changes made or any information entered will not be saved.", vbOKCancel, "Warning")
    If intProcced = 2 Then
        Exit Sub
    End If
 
If Me.Dirty = True Then
    DoCmd.SetWarnings False
    DoCmd.OpenQuery "qryMoveFeedersFalse"
    DoCmd.SetWarnings True
    DoCmd.Close
    Exit Sub
Else
    DoCmd.SetWarnings False
    DoCmd.OpenQuery "qryMoveFeedersFalse"
    DoCmd.SetWarnings True
    DoCmd.Close
    Exit Sub
End If
 
errHandle:
If Err.Number = 2046 Then
    DoCmd.Close
    Exit Sub
Else
    'Print the error message and send an email to Administrator
    SendErrorMsg "cmdCancel_Click on frmEnterNewFeeder", Err.Number, Err.Description
    MsgBox Err.Description
End If
 
Exit Sub
 
End Sub

[Minion]

I'm glad to hear that it got you moving in the right direction. Sometimes all we need to find the answer is a nudge.

- Minion -