can anyone help me out with the error operation not allowed wen object is open

[haunter]

If i close the recordset then it automatically gets focussed to the login..can any1 help me out in rectifyin the code given below-

Dim rs As New ADODB.Recordset
Dim cn As New ADODB.Connection
Private Sub Command1_Click()
If Text1 = "" Then
MsgBox "enter the username", vbInformation + vbOKOnly, "login"
Text1.SetFocus
Exit Sub
End If
If Text2 = "" Then
MsgBox "enter the password", vbInformation + vbOKOnly, "login"
Text2.SetFocus
Exit Sub
End If
If Text1 <> "" And Text2 <> "" Then
If rs.State = 1 Then
rs.Close
Else
rs.Open "select * from login where username='" & Text1 & "' and password='" & Text2 & "'", cn, adOpenDynamic, adLockOptimistic, adCmdText
If rs.EOF = True Then
MsgBox "invalid username and pass", vbCritical + vbOKOnly, "login"
Text1 = ""
Text2 = ""
Text1.SetFocus
Else
MsgBox "username and pass corect", vbInformation + vbOKOnly, "login"
If vbOK Then
Unload Me
MDIForm1.Show
End If
End If
End If
End If
End Sub
 
Private Sub Command2_Click()
Unload Me
End Sub
 
Private Sub Form_Load()
Text1 = ""
Text2 = ""
cn.Open "Provider=MSDAORA.1;Password=tiger;User ID=system;Persist Security Info=True"
End Sub

[MikeTheBike]

Hi

I suggest this mod

Private Sub Command1_Click()
    If Text1 = "" Then
        MsgBox "enter the username", vbInformation + vbOKOnly, "login"
        Text1.SetFocus
        Exit Sub
    End If
    If Text2 = "" Then
        MsgBox "enter the password", vbInformation + vbOKOnly, "login"
        Text2.SetFocus
        Exit Sub
    End If
    If Text1 <> "" And Text2 <> "" Then
        If rs.State = 1 Then
        rs.Close
    Else
        rs.Open "select * from login where username='" & Text1 & "' and password='" & Text2 & "'", cn, adOpenDynamic, adLockOptimistic, adCmdText
        If rs.EOF = True Then
            MsgBox "invalid username and pass", vbCritical + vbOKOnly, "login"
            Text1 = ""
            Text2 = ""
            Text1.SetFocus
        Else
            MsgBox "username and pass corect", vbInformation + vbOKOnly, "login"
            If vbOK Then
                Unload Me
                MDIForm1.Show
            End If
        End If
        rs.Close  '########## CLOSE RECORDSET HERE !!
    End If
End Sub

ie add rs.close where indicated on line 29.

Also 'If vbOK Then' is redundant as vbOK is always true !! (ie = 1)

HTH


MTB

[haunter]

well its still the same.I am getting the error pointed at cn.open in the form load...thank u in advance :)

[MikeTheBike]

I must confess I am puzzled why a connection should be open in the on load event but you could try this

If cn.State = adStateClosed Then cn.Open "Provider=MSDAORA.1;Password=tiger;User ID=system;Persist Security Info=True"

However I would change the module level declaration to

Dim rs As ADODB.Recordset
Dim cn As ADODB.Connection

And the load even to this

Private Sub Form_Load()
    Text1 = ""
    Text2 = ""
 
    Set cn = New ADODB.Connection
    Set rs = New ADODB.Recordset
 
    cn.Open "Provider=MSDAORA.1;Password=tiger;User ID=system;Persist Security Info=True"
End Sub

and, although not strictly necessary in this instance, but just for completeness and good housekeeping(?), add this

Private Sub Form_Unload(Cancel As Integer)
    If rs.State = adStateOpen Then rs.Close
    Set rs = Nothing
 
    cn.Close
    Set cn = Nothing
End Sub

??

HTH


MTB

[haunter]

thank you anyways i figured the error :D it was actually my timer control enabled for progress bar which was causing all of the mess :)