already an open DataReader associated with this Command which must be closed first

[Bart]

Hi,

i get the error:
"There is already an open DataReader associated with this Command which must
be closed first"

Thanks
Bart
-----------------------------------------
Imports System.Data.sql client
Imports System.Data
....
....
sql = "SELECT count(*) FROM pc where lokl='" & w & "';"
comd = New SqlCommand(sql, oConnection)
recpc = comd.ExecuteSca lar

sql = "SELECT pcnr FROM pc where lokl='" & w & "';"
comd = New SqlCommand(sql, oConnection)
dtreader = comd.ExecuteRea der

for j = 1 To recpc
dtreader.Read()
ww = dtreader.GetVal ue(0)
sql = "INSERT INTO mytable (field1 values(" & ww & ")"
comd.ExecuteNon Query()
Next

dtreader.Close( )
---------------------------------------------------------------

[Eliyahu Goldin]

Create another command object for running the insert:

sql = "INSERT INTO mytable (field1 values(" & ww & ")"
comd1 = New SqlCommand(sql, oConnection)
comd1.ExecuteNo nQuery()
--
Eliyahu Goldin,
Software Developer & Consultant
Microsoft MVP [ASP.NET]
http://msmvps.com/blogs/egoldin
"Bart" <[e-mail] e in message
news:uk******** ******@TK2MSFTN GP02.phx.gbl...

Hi,

i get the error:
"There is already an open DataReader associated with this Command which

must

be closed first"

Thanks
Bart
-----------------------------------------
Imports System.Data.sql client
Imports System.Data
...
...
sql = "SELECT count(*) FROM pc where lokl='" & w & "';"
comd = New SqlCommand(sql, oConnection)
recpc = comd.ExecuteSca lar

sql = "SELECT pcnr FROM pc where lokl='" & w & "';"
comd = New SqlCommand(sql, oConnection)
dtreader = comd.ExecuteRea der

for j = 1 To recpc
dtreader.Read()
ww = dtreader.GetVal ue(0)
sql = "INSERT INTO mytable (field1 values(" & ww & ")"
comd.ExecuteNon Query()
Next

dtreader.Close( )
---------------------------------------------------------------

[Bart]

Hi, thansk for replying

I did this:

sql = "SELECT count(*) FROM pc where lokl='" & w & "';"
comd = New SqlCommand(sql, oConnection)
recpc = comd.ExecuteSca lar

sql = "SELECT pcnr FROM pc where lokl='" & w & "';"
comd = New SqlCommand(sql, oConnection)
dtreader = comd.ExecuteRea der

For j = 1 To recpc
dtreader.Read()
ww = dtreader.GetVal ue(0)
sql = "INSERT INTO mytable (field1 values(" & ww & ")"
comd1 = New SqlCommand(sql, oConnection)
comd1.ExecuteNo nQuery()
Next
dtreader.Close( )

but still same error at line: comd1.ExecuteNo nQuery()
"Eliyahu Goldin" <RE************ **************@ mMvVpPsS.orgsch reef in
bericht news:OB******** *****@TK2MSFTNG P02.phx.gbl...

Create another command object for running the insert:

sql = "INSERT INTO mytable (field1 values(" & ww & ")"
comd1 = New SqlCommand(sql, oConnection)
comd1.ExecuteNo nQuery()
--
Eliyahu Goldin,
Software Developer & Consultant
Microsoft MVP [ASP.NET]
http://msmvps.com/blogs/egoldin

[Eliyahu Goldin]

You need to re-structure the code to close the first datareader before
starting using another one on the same connection. Only one request can be
served at the time and untill the first reader closes it won't let anyone
else to run.

--
Eliyahu Goldin,
Software Developer & Consultant
Microsoft MVP [ASP.NET]
http://msmvps.com/blogs/egoldin
"Bart" <[e-mail] e in message
news:Og******** ******@TK2MSFTN GP02.phx.gbl...

Hi, thansk for replying

I did this:

sql = "SELECT count(*) FROM pc where lokl='" & w & "';"
comd = New SqlCommand(sql, oConnection)
recpc = comd.ExecuteSca lar

sql = "SELECT pcnr FROM pc where lokl='" & w & "';"
comd = New SqlCommand(sql, oConnection)
dtreader = comd.ExecuteRea der

For j = 1 To recpc
dtreader.Read()
ww = dtreader.GetVal ue(0)
sql = "INSERT INTO mytable (field1 values(" & ww & ")"
comd1 = New SqlCommand(sql, oConnection)
comd1.ExecuteNo nQuery()
Next
dtreader.Close( )

but still same error at line: comd1.ExecuteNo nQuery()
"Eliyahu Goldin" <RE************ **************@ mMvVpPsS.orgsch reef in
bericht news:OB******** *****@TK2MSFTNG P02.phx.gbl...

Create another command object for running the insert:

sql = "INSERT INTO mytable (field1 values(" & ww & ")"
comd1 = New SqlCommand(sql, oConnection)
comd1.ExecuteNo nQuery()
--
Eliyahu Goldin,
Software Developer & Consultant
Microsoft MVP [ASP.NET]
http://msmvps.com/blogs/egoldin

[=?ISO-8859-1?Q?G=F6ran_Andersson?=]

Bart wrote:

Hi,

i get the error:
"There is already an open DataReader associated with this Command which must
be closed first"

Thanks
Bart
-----------------------------------------
Imports System.Data.sql client
Imports System.Data
...
...
sql = "SELECT count(*) FROM pc where lokl='" & w & "';"
comd = New SqlCommand(sql, oConnection)
recpc = comd.ExecuteSca lar

sql = "SELECT pcnr FROM pc where lokl='" & w & "';"
comd = New SqlCommand(sql, oConnection)
dtreader = comd.ExecuteRea der

for j = 1 To recpc
dtreader.Read()
ww = dtreader.GetVal ue(0)
sql = "INSERT INTO mytable (field1 values(" & ww & ")"
comd.ExecuteNon Query()
Next

dtreader.Close( )
---------------------------------------------------------------

You can't use the connection for running queries while it's used by the
data reader.

Why don't you do this in a single query?

"insert into mytable (field1) select pcnt from pc where lokl='" & w & "';"

--
Göran Andersson
_____
http://www.guffa.com

[Cowboy \(Gregory A. Beamer\)]

Not sure why you want to loop to do this, as this can all be done on the SQL
side, with a temp table, unless you are persisting the answers for a long
time. Even with a permanent table, you can clear the table before rerunning
this operation. If you need to know which number the record is, you can use
an IDENTITY field, in SQL Server (have to work from DUAL in Oracle) or
autonumber in Access.

This is the proc in SQL Server:

CREATE PROCEDURE TestProc
(
@w int -- Not sure of type here
)
AS

INSERT INTO MyTable (pcnr)
SELECT pcnr FROM pc
WHERE lokl = @w

SELECT @@COUNT

You now can use the return value for count and run the insert on all records
at the same time. The syntax is much easier.

1. Set up connection
2. Set up command
3. Set command as CommandType.Sto redProcedure
4. Run ExecuteScalar on Command and retrieve count of records changed

Very effficient and much easier to manage.

--
Gregory A. Beamer
MVP; MCP: +I, SE, SD, DBA

*************** *************** ***************
Think outside the box!
*************** *************** ***************
"Bart" <[e-mail] e in message
news:uk******** ******@TK2MSFTN GP02.phx.gbl...

Hi,

i get the error:
"There is already an open DataReader associated with this Command which
must be closed first"

Thanks
Bart
-----------------------------------------
Imports System.Data.sql client
Imports System.Data
...
...
sql = "SELECT count(*) FROM pc where lokl='" & w & "';"
comd = New SqlCommand(sql, oConnection)
recpc = comd.ExecuteSca lar

sql = "SELECT pcnr FROM pc where lokl='" & w & "';"
comd = New SqlCommand(sql, oConnection)
dtreader = comd.ExecuteRea der

for j = 1 To recpc
dtreader.Read()
ww = dtreader.GetVal ue(0)
sql = "INSERT INTO mytable (field1 values(" & ww & ")"
comd.ExecuteNon Query()
Next

dtreader.Close( )
---------------------------------------------------------------

[=?Utf-8?B?TWlsb3N6IFNrYWxlY2tpIFtNQ0FEXQ==?=]

Good morning Bart,

You used the same connection for more than one data readers and I guess
you're not using MARS - Multiple Active Result Sets (which is supported by
SQL Server 2005 only), therefore, once reader is executed, connection is
assigned to it exclusively - to release the connection, you have to close
connection or reader. In addition to that, there is not point to make things
complex and inefficient (shooting database many times in the loop as you’ve
presented in the posted code snipped). It’s very easy to build the query that
does exactly the same thing, but in one roundtrip:

sql = "INSERT INTO mytable (field1) SELECT pcnr FROM pc WHERE lokl = @lokl"

comd = new SqlCommand(sql, oConnection)
comd.Parameters .Add("@lokl", SqlDbType.NVarC har).Value = w

try
oConnection.Ope n()
comd.ExecuteNon Query();
catch ex as Exception
throw ex
finally
oConnection.Clo se()
end try

Done. Hope this helps
--
Milosz
"Bart" wrote:

Hi, thansk for replying

I did this:

sql = "SELECT count(*) FROM pc where lokl='" & w & "';"
comd = New SqlCommand(sql, oConnection)
recpc = comd.ExecuteSca lar

sql = "SELECT pcnr FROM pc where lokl='" & w & "';"
comd = New SqlCommand(sql, oConnection)
dtreader = comd.ExecuteRea der

For j = 1 To recpc
dtreader.Read()
ww = dtreader.GetVal ue(0)
sql = "INSERT INTO mytable (field1 values(" & ww & ")"
comd1 = New SqlCommand(sql, oConnection)
comd1.ExecuteNo nQuery()
Next
dtreader.Close( )

but still same error at line: comd1.ExecuteNo nQuery()
"Eliyahu Goldin" <RE************ **************@ mMvVpPsS.orgsch reef in
bericht news:OB******** *****@TK2MSFTNG P02.phx.gbl...

Create another command object for running the insert:

sql = "INSERT INTO mytable (field1 values(" & ww & ")"
comd1 = New SqlCommand(sql, oConnection)
comd1.ExecuteNo nQuery()
--
Eliyahu Goldin,
Software Developer & Consultant
Microsoft MVP [ASP.NET]
http://msmvps.com/blogs/egoldin

[Bart]

Thanks to all ...

But in fact, it's not so simple, because there are other parameters needed.
What i try to do is:

sql = "INSERT INTO studres (logon, dag, uur, type, pcnr) SELECT [lol] ,
[dag], [uur],'l', pcnr FROM pc where lokl='" & w & "';"
comd = New SqlCommand(sql, oConnection)
comd.Parameters .AddWithValue("[lol]", lol)
comd.Parameters .AddWithValue("[dag]", tda)
comd.Parameters .AddWithValue("[uur]", vv)
comd.ExecuteNon Query()

but this gives the error:"Incorrec t syntax near 'nvarchar'.

In sql server, field login is nvarchar(25), field dag is Datetime and field
uur is int

....
"Cowboy (Gregory A. Beamer)" <No************ @comcast.netNoS pamMschreef in
bericht news:FB******** *************** ***********@mic rosoft.com...

Not sure why you want to loop to do this, as this can all be done on the
SQL side, with a temp table, unless you are persisting the answers for a
long time. Even with a permanent table, you can clear the table before
rerunning this operation. If you need to know which number the record is,
you can use an IDENTITY field, in SQL Server (have to work from DUAL in
Oracle) or autonumber in Access.

This is the proc in SQL Server:

CREATE PROCEDURE TestProc
(
@w int -- Not sure of type here
)
AS

INSERT INTO MyTable (pcnr)
SELECT pcnr FROM pc
WHERE lokl = @w

SELECT @@COUNT

You now can use the return value for count and run the insert on all
records at the same time. The syntax is much easier.

1. Set up connection
2. Set up command
3. Set command as CommandType.Sto redProcedure
4. Run ExecuteScalar on Command and retrieve count of records changed

Very effficient and much easier to manage.

--
Gregory A. Beamer
MVP; MCP: +I, SE, SD, DBA

*************** *************** ***************
Think outside the box!
*************** *************** ***************
"Bart" <[e-mail] e in message
news:uk******** ******@TK2MSFTN GP02.phx.gbl...

>Hi,

i get the error:
"There is already an open DataReader associated with this Command which
must be closed first"

Thanks
Bart
-----------------------------------------
Imports System.Data.sql client
Imports System.Data
...
...
sql = "SELECT count(*) FROM pc where lokl='" & w & "';"
comd = New SqlCommand(sql, oConnection)
recpc = comd.ExecuteSca lar

sql = "SELECT pcnr FROM pc where lokl='" & w & "';"
comd = New SqlCommand(sql, oConnection)
dtreader = comd.ExecuteRea der

for j = 1 To recpc
dtreader.Read( )
ww = dtreader.GetVal ue(0)
sql = "INSERT INTO mytable (field1 values(" & ww & ")"
comd.ExecuteNo nQuery()
Next

dtreader.Close ()
---------------------------------------------------------------

[=?ISO-8859-1?Q?G=F6ran_Andersson?=]

Specify the data type for the parameters.
Example:

comd.Parameters .Add("@lol", SqlDbType.NVarC har. 25).Value = lol

Parameters are named using @. Square brackets are used to specify that a
string is a name. It's used for names with non-alphanumeric characters,
like [current-price], or names that are keywords, like [from].

Bart wrote:

Thanks to all ...

But in fact, it's not so simple, because there are other parameters needed.
What i try to do is:

sql = "INSERT INTO studres (logon, dag, uur, type, pcnr) SELECT [lol] ,
[dag], [uur],'l', pcnr FROM pc where lokl='" & w & "';"
comd = New SqlCommand(sql, oConnection)
comd.Parameters .AddWithValue("[lol]", lol)
comd.Parameters .AddWithValue("[dag]", tda)
comd.Parameters .AddWithValue("[uur]", vv)
comd.ExecuteNon Query()

but this gives the error:"Incorrec t syntax near 'nvarchar'.

In sql server, field login is nvarchar(25), field dag is Datetime and field
uur is int

...
"Cowboy (Gregory A. Beamer)" <No************ @comcast.netNoS pamMschreef in
bericht news:FB******** *************** ***********@mic rosoft.com...

>Not sure why you want to loop to do this, as this can all be done on the
SQL side, with a temp table, unless you are persisting the answers for a
long time. Even with a permanent table, you can clear the table before
rerunning this operation. If you need to know which number the record is,
you can use an IDENTITY field, in SQL Server (have to work from DUAL in
Oracle) or autonumber in Access.

This is the proc in SQL Server:

CREATE PROCEDURE TestProc
(
@w int -- Not sure of type here
)
AS

INSERT INTO MyTable (pcnr)
SELECT pcnr FROM pc
WHERE lokl = @w

SELECT @@COUNT

You now can use the return value for count and run the insert on all
records at the same time. The syntax is much easier.

1. Set up connection
2. Set up command
3. Set command as CommandType.Sto redProcedure
4. Run ExecuteScalar on Command and retrieve count of records changed

Very effficient and much easier to manage.

--
Gregory A. Beamer
MVP; MCP: +I, SE, SD, DBA

************** *************** *************** *
Think outside the box!
************** *************** *************** *
"Bart" <[e-mail] e in message
news:uk******* *******@TK2MSFT NGP02.phx.gbl.. .

>>Hi,

i get the error:
"There is already an open DataReader associated with this Command which
must be closed first"

Thanks
Bart
-----------------------------------------
Imports System.Data.sql client
Imports System.Data
...
...
sql = "SELECT count(*) FROM pc where lokl='" & w & "';"
comd = New SqlCommand(sql, oConnection)
recpc = comd.ExecuteSca lar

sql = "SELECT pcnr FROM pc where lokl='" & w & "';"
comd = New SqlCommand(sql, oConnection)
dtreader = comd.ExecuteRea der

for j = 1 To recpc
dtreader.Read ()
ww = dtreader.GetVal ue(0)
sql = "INSERT INTO mytable (field1 values(" & ww & ")"
comd.ExecuteN onQuery()
Next

dtreader.Clos e()
---------------------------------------------------------------

--
Göran Andersson
_____
http://www.guffa.com

[Bart]

Yes, that's it
thanks

"Göran Andersson" <gu***@guffa.co mschreef in bericht
news:eZ******** ******@TK2MSFTN GP02.phx.gbl...

Specify the data type for the parameters.
Example:

comd.Parameters .Add("@lol", SqlDbType.NVarC har. 25).Value = lol

Parameters are named using @. Square brackets are used to specify that a
string is a name. It's used for names with non-alphanumeric characters,
like [current-price], or names that are keywords, like [from].

Bart wrote:

>Thanks to all ...

But in fact, it's not so simple, because there are other parameters
needed. What i try to do is:

sql = "INSERT INTO studres (logon, dag, uur, type, pcnr) SELECT [lol] ,
[dag], [uur],'l', pcnr FROM pc where lokl='" & w & "';"
comd = New SqlCommand(sql, oConnection)
comd.Parameters .AddWithValue("[lol]", lol)
comd.Parameters .AddWithValue("[dag]", tda)
comd.Parameters .AddWithValue("[uur]", vv)
comd.ExecuteNon Query()

but this gives the error:"Incorrec t syntax near 'nvarchar'.

In sql server, field login is nvarchar(25), field dag is Datetime and
field uur is int

...
"Cowboy (Gregory A. Beamer)" <No************ @comcast.netNoS pamMschreef
in bericht news:FB******** *************** ***********@mic rosoft.com...

>>Not sure why you want to loop to do this, as this can all be done on the
SQL side, with a temp table, unless you are persisting the answers for a
long time. Even with a permanent table, you can clear the table before
rerunning this operation. If you need to know which number the record
is, you can use an IDENTITY field, in SQL Server (have to work from DUAL
in Oracle) or autonumber in Access.

This is the proc in SQL Server:

CREATE PROCEDURE TestProc
(
@w int -- Not sure of type here
)
AS

INSERT INTO MyTable (pcnr)
SELECT pcnr FROM pc
WHERE lokl = @w

SELECT @@COUNT

You now can use the return value for count and run the insert on all
records at the same time. The syntax is much easier.

1. Set up connection
2. Set up command
3. Set command as CommandType.Sto redProcedure
4. Run ExecuteScalar on Command and retrieve count of records changed

Very effficient and much easier to manage.

--
Gregory A. Beamer
MVP; MCP: +I, SE, SD, DBA

************* *************** *************** **
Think outside the box!
************* *************** *************** **
"Bart" <[e-mail] e in message
news:uk****** ********@TK2MSF TNGP02.phx.gbl. ..
Hi,

i get the error:
"There is already an open DataReader associated with this Command which
must be closed first"

Thanks
Bart
-----------------------------------------
Imports System.Data.sql client
Imports System.Data
...
...
sql = "SELECT count(*) FROM pc where lokl='" & w & "';"
comd = New SqlCommand(sql, oConnection)
recpc = comd.ExecuteSca lar

sql = "SELECT pcnr FROM pc where lokl='" & w & "';"
comd = New SqlCommand(sql, oConnection)
dtreader = comd.ExecuteRea der

for j = 1 To recpc
dtreader.Rea d()
ww = dtreader.GetVal ue(0)
sql = "INSERT INTO mytable (field1 values(" & ww & ")"
comd.Execute NonQuery()
Next

dtreader.Clo se()
---------------------------------------------------------------

--
Göran Andersson
_____
http://www.guffa.com