urllib and saving pictures? [solved]

[public2]

Hi.

This is my first post, and is about an assignment I've at my college.

An overall description:
We have to make a function, with one argument, the URL. then we have to search the HTML code for any pictures, and to do that I will search for <img and src tags.

All that I can, but then we have to save the pictures local on my harddrive, and make a collage with all the pictures in it. My hindrance right now is the saving part.

For testing the script, I'm using this code:
Code:

def getImageUrl(urlstring):
    import urllib
    connection=urllib.urlopen(urlstring)
    picture = connection.read()
    connection.close()
    curloc = picture.find("img")
    if curloc <> -1:
        picloc = picture.find("<src", curloc)
        picstart = picture.rfind(">",0,picloc)
        #writefile.open(picture,"wt")
        pic = open(picture, 'wb').read
        picture = urllib.urlopen(urlstring)
        pic.write(picture)
        pic.close()
    else:
        print "There is no pictures in this URL"

I know my code isn't optimized, but I just can't seem to find the function, so it will save my pictures...

In advanced thanks.
Greetings
Public2

[bartonc]

I'm in a rush at the moment and must be brief. For starters, this line is wrong:

pic = open(picture, 'wb').read
 

probably should be

pic = open(picture, 'wb')
 

Also, Your post didn't come through quite right. I reformatted. please check it.

More this afternoon

[bartonc]

I don't see you getting the index of the last tag.
Once you have both the start and end indeces, get a slice of the block like this:

subBlock = block[start:end]
 

Then go ahead and and write it

[fuffens]

The easiest way to retreive the image file is probably to use urlretrieve in the urllib module.

For example if you want to store the thescripts logo from this homepage on your local drive you can do the following:

import urllib
urllib.urlretrieve(r'http://www.thescripts.com/images/logo.jpg', r'c:\temp\logo.jpg')

Good luck!
/Fredrik

[public2]

Hey again.

I finally got finished with my assignment, and thought I would write the code down here. It turned out that we had to make most of the code in Jython, so some of the modules couldn't be used, but I managed anyway. Here is the complete code:

import urllib
from urlparse import urljoin
import random
 
def makeCollageFromUrl(urlString):    
    listOfImages = getImagesUrl(urlString)
    imageNames = []
    for imageUrl in listOfImages:
        filename = saveImage(imageUrl)
        imageNames.append(filename)
    width = 640
    height = 480
    picture = makeEmptyPicture(width,height)
    for imageName in imageNames:
        p = makePicture(imageName)
        if p.getWidth()<width and p.getHeight()<height:
            copyPictureToPicture(p,picture,random.randint(0,width-p.getWidth()),random.randint(0,height-p.getHeight()),0.5)
 
    picture.show()
    writePictureTo(picture,r"C:\HTMLCollage.jpg")
 
def getImagesUrl(urlString):
  connection=urllib.urlopen(urlString)
  getPictures = connection.read()
  connection.close()
  executeIndex = 0
  PicHTMLlist = []
  while getPictures.find("<img",executeIndex) <> -1:
    currentPicIndex = getPictures.find("<img",executeIndex)
    currentSrcIndex = getPictures.find("src=",currentPicIndex)
    nxtIndex = getPictures.find(">",currentSrcIndex)
    executeIndex = nxtIndex
    if getPictures.find("http",currentSrcIndex,nxtIndex)!=-1:
        end = getPictures.find(" ",currentSrcIndex,nxtIndex)
        currentPic = getPictures[currentSrcIndex+4:end]
        currentPic = currentPic.replace('"'," ")
        currentPic = currentPic.replace("'"," ")
        repCurrPic = currentPic.lstrip()
        repCurrPic = repCurrPic.rstrip()
        if repCurrPic.rfind(".jpg") != -1 or repCurrPic.rfind(".gif") != -1:
            PicHTMLlist.append(repCurrPic)
  return PicHTMLlist
 
def saveImage(urlString):
    connection = urllib.urlopen(urlString)
    getPictures = connection.read()
    connection.close()
    sepIndex = urlString.rfind("/")
    filnavn = urlString[(sepIndex+1):]
    file = open(filnavn,"wb")
    file.write(getPictures)
    file.close()
    return filnavn
 
def copyPictureToPicture(sourcePic,targetPic,offsetX,offsetY, blend):
  for x in range(1,sourcePic.getWidth()+1):
    for y in range(1,sourcePic.getHeight()+1):
      color = sourcePic.getPixel(x,y).getColor()
      targetPixel = targetPic.getPixel(x+offsetX,y+offsetY)
      targetColor = targetPixel.getColor()
      targetPixel.setRed(int(color.getRed()*blend+targetColor.getRed()*blend))
      targetPixel.setGreen(int(color.getGreen()*blend+targetColor.getGreen()*blend))
      targetPixel.setBlue(int(color.getBlue()*blend+targetColor.getBlue()*blend))
 

There might be some word in Danish, but most of it is in English. Thanks for your help.

Have a great evening.

Greetings Public2