Issue With Simple Php Login Script - Mysql Error

[cmbcorp]

Hi,

I have been playing around with a simple php login script and im getting an error message when i attempt to log in with the username and password i set in the sql table. The error message is as follows:

Warning: mysql_num_rows(): supplied argument is not a valid MySQL result resource in /home/greenpos/public_html/test4/checklogin.php on line 28
Wrong Username or Password

The code:

<?php
$host="localhost"; // Host name 
$username="greenpos_admin1"; // Mysql username 
$password="carlo"; // Mysql password 
$db_name="greenpos_test"; // Database name 
$tbl_name="greenpos_test.members"; // Table name 
 
// Connect to server and select databse.
mysql_connect("$host", "$username", "$password")or die("cannot connect"); 
mysql_select_db("$db_name")or die("cannot select DB");
 
// username and password sent from signup form 
$myusername=$_POST['myusername']; 
$mypassword=$_POST['mypassword']; 
 
$sql="SELECT * FROM $tbl_name WHERE username='$myusername' and password='$mypassword'";
$result=mysql_query($sql);
 
// Mysql_num_row is counting table row
$count=mysql_num_rows($result);
// If result matched $myusername and $mypassword, table row must be 1 row
 
if($count==1){
// Register $myusername, $mypassword and redirect to file "login_success.php"
session_register("myusername");
session_register("mypassword"); 
header("location:login_success.php");
}
else {
echo "Wrong Username or Password";
}
?>

--

I had created a database in sql called greenpos_test and created a table called members.

CREATE TABLE `members` (
`id` INT( 4 ) NOT NULL ,
`myusername` VARCHAR( 65 ) NOT NULL ,
`mypassword` VARCHAR( 65 ) NOT NULL 
) ENGINE = MYISAM ;

in the table i created 2 fields, myusername and mypassword and each field i put username as jason and password as jason. EG:

i put in these details in the table:

myusername - type (varchar(65) - no function - no null - and value = jason
mypassword - type (varchar(65) - no function - no null - and value = jason

If that makes any sense.

Please can someone tell me why it wont allow me to login in with the my username and password.

Regards,
Jason
[REMOVED]

[dafodil]

Are you using PHP 4.1.0 or higher?

The use of session_register() is depreciated

This is the preferred way....

$_SESSION['zim'] = "An invader from another planet.";

Write this:

session_register("myusername")

like this:

$_SESSION['myusername']=$myusername;

same on the password


And make sure you put

session_start();

before you try to access or store Session varables.

It's preferred to put session_start() at the beginning of your php code




Please also put a exit; after you redirect a page to ensure that it will redirect to the page.

Like this:

header("location:login_success.php");
exit;

[cmbcorp]

Hi thanks soooo much for the reply.

i have done what you asked.

below is the code:

<?php
 
$host="localhost"; // Host name 
$username="greenpos_admin1"; // Mysql username 
$password="carlo"; // Mysql password 
$db_name="greenpos_test"; // Database name 
$tbl_name="members"; // Table name 
 
// Connect to server and select databse.
mysql_connect("$host", "$username", "$password")or die("cannot connect"); 
mysql_select_db("$db_name")or die("cannot select DB");
 
// username and password sent from signup form 
session_start();
$myusername=$_POST['myusername']; 
$mypassword=$_POST['mypassword']; 
 
$sql="SELECT * FROM $tbl_name WHERE username='$myusername' and password='$mypassword'";
$result=mysql_query($sql);
 
// Mysql_num_row is counting table row
$count=mysql_num_rows($result);
// If result matched $myusername and $mypassword, table row must be 1 row
 
if($count==1){
// Register $myusername, $mypassword and redirect to file "login_success.php"
$_SESSION['myusername']=$myusername;
$_SESSION['mypassword']=$mypassword;
header("location:login_success.php");
exit;
}
else {
echo "Wrong Username or Password";
}
?>

--

THE ERROR MESSAGE APPEARING NOW IS:

Warning: session_start() [function.session-start]: Cannot send session cookie - headers already sent by (output started at /home/greenpos/public_html/test4/checklogin.php:9) in /home/greenpos/public_html/test4/checklogin.php on line 22

Warning: session_start() [function.session-start]: Cannot send session cache limiter - headers already sent (output started at /home/greenpos/public_html/test4/checklogin.php:9) in /home/greenpos/public_html/test4/checklogin.php on line 22

Warning: mysql_num_rows(): supplied argument is not a valid MySQL result resource in /home/greenpos/public_html/test4/checklogin.php on line 30
Wrong Username or Password

please if you can please reply!!.

thanks so much.
jason

[dafodil]

Can you try this code:

<?php
 
$host="localhost"; // Host name 
$username="greenpos_admin1"; // Mysql username 
$password="carlo"; // Mysql password 
$db_name="greenpos_test"; // Database name 
$tbl_name="members"; // Table name 
 
// Connect to server and select databse.
mysql_connect("$host", "$username", "$password")or die("cannot connect"); 
mysql_select_db("$db_name")or die("cannot select DB");
 
// username and password sent from signup form 
 
$myusername=$_POST['myusername']; 
$mypassword=$_POST['mypassword']; 
 
$sql="SELECT * FROM $tbl_name WHERE username='$myusername' and password='$mypassword'";
$result=mysql_query($sql);
 
// Mysql_num_row is counting table row
$count=mysql_num_rows($result);
// If result matched $myusername and $mypassword, table row must be 1 row
 
if($count==1){
// Register $myusername, $mypassword and redirect to file "login_success.php"
session_start();
$_SESSION['myusername']=$myusername;
$_SESSION['mypassword']=$mypassword;
header("location:login_success.php");
exit;
}
else {
header("location: invalid.php");
exit;
}
?>
 

Please create an invalid.php page...

[cmbcorp]

Hi Thanks once again!!!,
you have been great.

i modified the code to your code.

i still get the error message:

Warning: mysql_num_rows(): supplied argument is not a valid MySQL result resource in /home/greenpos/public_html/test4/checklogin.php on line 30
Wrong Username or Password

although i didnt add the invalid.php but i didnt think that mattered.

i think my problem lies in my table members..

this is what i added via a sql command to the members table in the greenpos_test database:

CREATE TABLE `test_mysql` (
`myusername` varchar(65) NOT NULL default '',
`mypassword` varchar(65) NOT NULL default '',
PRIMARY KEY (`myusername`)
) TYPE=MyISAM AUTO_INCREMENT=0 ;

Do you think that has anything to do with it?

cheers,
jason.

[cmbcorp]

this is what i put in the username and password fields in the members table:

INSERT INTO `members` VALUES (jason', 'jason');

?

[dafodil]

Replace this code:

// Connect to server and select databse.
mysql_connect("$host", "$username", "$password")or die("cannot connect"); 
mysql_select_db("$db_name")or die("cannot select DB");
 

with this:

// Connect to server and select databse.
$link=mysql_connect("$host", "$username", "$password")or die("cannot connect"); 
mysql_select_db($db_name, $link)or die("cannot select DB");
 

It should work now...


Please always put :

mysql_close( $link );

after you use the database. It's a good practice

[cmbcorp]

Hi,

nope that didnt work either..

error message:


Warning: mysql_num_rows(): supplied argument is not a valid MySQL result resource in /home/greenpos/public_html/test4/checklogin.php on line 30
Wrong Username or Password

[dafodil]

Did you already set this connections on your db?

$host="localhost"; // Host name
$username="greenpos_admin1"; // Mysql username
$password="carlo"; // Mysql password

on the config.inc

[cmbcorp]

just to let you know i am using cpanel on my own server
in the mysql section in cpanel this info comes up:

Users in greenpos_test
greenpos_admin1 (Privileges: ALL PRIVILEGES)
Connection Strings
Perl $dbh = DBI->connect("DBI:mysql:greenpos_test:localhost","gree npos_admin1","<PASSWORD HERE>");
PHP $dbh=mysql_connect ("localhost", "greenpos_admin1", "<PASSWORD HERE>") or die ('I cannot connect to the database because: ' . mysql_error());
mysql_select_db ("greenpos_test");

so i guess i have added the correct username/password for that database etc?

i dont know, im new to this, i think i have done something wrong somewhere in the setup..

cheers,
thanks for getting back to me so quick.

[dafodil]

just to let you know i am using cpanel on my own server
in the mysql section in cpanel this info comes up:

Users in greenpos_test
greenpos_admin1 (Privileges: ALL PRIVILEGES)
Connection Strings
Perl $dbh = DBI->connect("DBI:mysql:greenpos_test:localhost","gree npos_admin1","<PASSWORD HERE>");
PHP $dbh=mysql_connect ("localhost", "greenpos_admin1", "<PASSWORD HERE>") or die ('I cannot connect to the database because: ' . mysql_error());
mysql_select_db ("greenpos_test");

so i guess i have added the correct username/password for that database etc?

i dont know, im new to this, i think i have done something wrong somewhere in the setup..

cheers,
thanks for getting back to me so quick.

Set the password to carlo according to your code.

[cmbcorp]

i have.. i just cut and copied that from cpanel to show that i have setup the database and made the user and set the password and gave the user all rights.

ill reset the password and see if this helps.

any other ideas?

cheers mate.

[cmbcorp]

ok so i reset the user and re-added greenpos_admin1 with password carlo and i get this error now:

Parse error: syntax error, unexpected T_OBJECT_OPERATOR in /home/greenpos/public_html/test4/checklogin.php on line 18


Any ideas?

Thanks for your help.
----

CODE BELOW:

<?php
 
$host="localhost"; // Host name 
$username="greenpos_admin1"; // Mysql username 
$password="carlo"; // Mysql password 
$db_name="greenpos_test"; // Database name 
$tbl_name="members"; // Table name 
 
// Connect to server and select databse.
$dbh = DBI->connect("DBI:mysql:greenpos_test:localhost","greenpos_admin1","<carlo>"); 
PHP $dbh=mysql_connect ("localhost", "greenpos_admin1", "<carlo>") or die ('I cannot connect to the database because: ' . mysql_error());
mysql_select_db ("greenpos_test");  
 
 
// username and password sent from signup form 
 
$myusername=$_POST['myusername']; 
$mypassword=$_POST['mypassword']; 
 
$sql="SELECT * FROM $tbl_name WHERE username='$myusername' and password='$mypassword'";
$result=mysql_query($sql);
 
// Mysql_num_row is counting table row
$count=mysql_num_rows($result);
// If result matched $myusername and $mypassword, table row must be 1 row
 
if($count==1){
// Register $myusername, $mypassword and redirect to file "login_success.php"
session_start();
$_SESSION['myusername']=$myusername;
$_SESSION['mypassword']=$mypassword;
header("location:login_success.php");
exit;
}
else {
echo "Wrong Username or Password";
exit;
}
?>

[code green]

Parse error: syntax error, unexpected T_OBJECT_OPERATOR in /home/greenpos/public_html/test4/checklogin.php on line 18

This is exactly what it says it is. A syntax error on line 18. Can't work out where that is but the chevrons round the password look dodgy.

[cmbcorp]

This is exactly what it says it is. A syntax error on line 18. Can't work out where that is but the chevrons round the password look dodgy.

i just removed the <> from around the passwords and still the same thing....


any ideas?

[cmbcorp]

i just removed the <> from around the passwords and still the same thing....


any ideas?

no sorry: this is the new error message:

Warning: mysql_num_rows(): supplied argument is not a valid MySQL result resource in /home/greenpos/public_html/test4/checklogin.php on line 30
Welcome

[code green]

This query has failed.

$sql="SELECT * FROM $tbl_name WHERE username='$myusername' and password='$mypassword'";
$result=mysql_query($sql);

Check you have the expected values in $_POST
[PHP]$myusername=$_POST['myusername'];
$mypassword=$_POST['mypassword']; [/PHP]
It is advisable to use LIKE when comparing strings in MYSql instead of '='

[pbmods]

Jason, please use CODE tags when posting source code. See the REPLY GUIDELINES on the right side of the page next time you post.

[cmbcorp]

This query has failed.

$sql="SELECT * FROM $tbl_name WHERE username='$myusername' and password='$mypassword'";
$result=mysql_query($sql);

Check you have the expected values in $_POST
[PHP]$myusername=$_POST['myusername'];
$mypassword=$_POST['mypassword']; [/PHP]
It is advisable to use LIKE when comparing strings in MYSql instead of '='

Hi Codegreen,

THanks for your help also!.

you guys rock!

anyways, im very new to this all..

what exactly do you mean with your post?

i just dont understand whats going on, im positive i have followed everything right.

please get back to me, i would really appreciate it.

Cheers,
Jason.

[cmbcorp]

Hi gyus,

I think i have confused everyone and myself.

Below is the code im using:

<?php
$host="localhost"; // Host name 
$username="greenpos_admin1"; // Mysql username 
$password="carlo"; // Mysql password 
$db_name="greenpos_test"; // Database name 
$tbl_name="members"; // Table name 
 
// Connect to server and select databse.
// Connect to server and select databse.
$link=mysql_connect("$host", "$username", "$password")or die("cannot connect"); 
mysql_select_db($db_name, $link)or die("cannot select DB"); 
 
 
// username and password sent from signup form 
 
$myusername=$_POST['myusername']; 
$mypassword=$_POST['mypassword']; 
 
$sql="SELECT * FROM $tbl_name WHERE username='$myusername' and password='$mypassword'";
$result=mysql_query($sql);
 
// Mysql_num_row is counting table row
$count=mysql_num_rows($result);
// If result matched $myusername and $mypassword, table row must be 1 row
 
if($count==1){
// Register $myusername, $mypassword and redirect to file "login_success.php"
session_start();
$_SESSION['myusername']=$myusername;
$_SESSION['mypassword']=$mypassword;
header("location:login_success.php");
exit;
}
else {
echo "Wrong Username or Password";
exit;
}
?> 

This is what i did to create the table in mysql:

CREATE TABLE `members` (
`id` int(4) NOT NULL auto_increment,
`username` varchar(65) NOT NULL default '',
`password` varchar(65) NOT NULL default '',
PRIMARY KEY (`id`)
) TYPE=MyISAM AUTO_INCREMENT=2 ;

I then:
Dumped the data for table `members`

INSERT INTO `members` VALUES (1, 'jason', 'jason'');

Now when i use my login screen and type in my username and password

i get this error message:

Warning: session_start() [function.session-start]: Cannot send session cache limiter - headers already sent (output started at /home/greenpos/public_html/test4/checklogin.php:9) in /home/greenpos/public_html/test4/checklogin.php on line 37

Warning: Cannot modify header information - headers already sent by (output started at /home/greenpos/public_html/test4/checklogin.php:9) in /home/greenpos/public_html/test4/checklogin.php on line 40

line 37:
session_start();

Line 40:
header("location:login_success.php");

Im not sure if im diong everything right...

The code for my main_login.php:

<table width="300" border="0" align="center" cellpadding="0" cellspacing="1" bgcolor="#CCCCCC">
<tr>
<form name="form1" method="post" action="checklogin.php">
<td>
<table width="100%" border="0" cellpadding="3" cellspacing="1" bgcolor="#FFFFFF">
<tr>
<td colspan="3"><strong>Member Login </strong></td>
</tr>
<tr>
<td width="78">Username</td>
<td width="6">:</td>
<td width="294"><input name="myusername" type="text" id="myusername"></td>
</tr>
<tr>
<td>Password</td>
<td>:</td>
<td><input name="mypassword" type="text" id="mypassword"></td>
</tr>
<tr>
<td>&nbsp;</td>
<td>&nbsp;</td>
<td><input type="submit" name="Submit" value="Login"></td>
</tr>
</table>
</td>
</form>
</tr>
</table>

All i can think of is that when i added the table members to my database, i added username and password as the fields and not myusername and mypassword?

Please i would really appreciate your help.

Thanks.
Jason.

[dafodil]

else {
echo "Wrong Username or Password";
exit;
}
 

I told you to replace that part already. You cannot echo when you use session that's why you keep seeing the error about header already sent....
The alternative solution is to redirect to a page...

Are you sure you can connect to your mysql?