By using this site, you agree to our updated Privacy Policy and our Terms of Use. Manage your Cookies Settings.
432,490 Members | 1,417 Online
Bytes IT Community
+ Ask a Question
Need help? Post your question and get tips & solutions from a community of 432,490 IT Pros & Developers. It's quick & easy.

Regex needed for splitting on commas (not inside quotes)

P: 7
I'm having quite a time with this particular problem:

I have users that enter tag words as form input, let's say for a photo or a topic of discussion. They are allowed to delimit tags with spaces and commas, and can use quotes to encapsulate multiple words.

An example:

tag1, tag2 tag3, "tag4 tag4, tag4" tag5, "tag6 tag6"

So, as we can see here anything is allowed, but the problem is that splitting on commas obviously destroys tag4 (the tag inside quotes but with a comma).

I've tried tons of regex, using preg_split, preg_match, and more but cannot figure out a solution. If this cannot be done, then it's also completely okay to tell the user they are not allowed to use commas inside of quoted strings via error message - which I tried doing using preg_match but my regex fails.

My regex for preg_match to alert the user of the problem:

/".*,.*"/

This works fine, but if you put any other quotes after the first quoted string (referring to "tag6 tag6") then it fails when it should not, since there are no commas inside tag6.
May 28 '07 #1
Share this Question
Share on Google+
9 Replies


bergy
P: 89
I'm no regex guru by any means, but here is something to try in case you haven't thought of thise already. Change your example to this:

tag1, tag2 tag3, \"tag4 tag4, tag4\" tag5, \"tag6 tag6\"

And see if that works in your expression. If so just do a addslashes() function on the tag string before you pass it to your regex.

I'm having quite a time with this particular problem:

I have users that enter tag words as form input, let's say for a photo or a topic of discussion. They are allowed to delimit tags with spaces and commas, and can use quotes to encapsulate multiple words.

An example:

tag1, tag2 tag3, "tag4 tag4, tag4" tag5, "tag6 tag6"

So, as we can see here anything is allowed, but the problem is that splitting on commas obviously destroys tag4 (the tag inside quotes but with a comma).

I've tried tons of regex, using preg_split, preg_match, and more but cannot figure out a solution. If this cannot be done, then it's also completely okay to tell the user they are not allowed to use commas inside of quoted strings via error message - which I tried doing using preg_match but my regex fails.

My regex for preg_match to alert the user of the problem:

/".*,.*"/

This works fine, but if you put any other quotes after the first quoted string (referring to "tag6 tag6") then it fails when it should not, since there are no commas inside tag6.
May 28 '07 #2

P: 7
That doesn't seem to make a difference in my particular case. Thanks for the reply, though! Any other thoughts?

I'm no regex guru by any means, but here is something to try in case you haven't thought of thise already. Change your example to this:

tag1, tag2 tag3, \"tag4 tag4, tag4\" tag5, \"tag6 tag6\"

And see if that works in your expression. If so just do a addslashes() function on the tag string before you pass it to your regex.
May 28 '07 #3

bergy
P: 89
That doesn't seem to make a difference in my particular case. Thanks for the reply, though! Any other thoughts?
Well this is really dirty, but... what if you do a simple str_replace on quotes in the string (before regex) something like replacing the " with ~ or even ___QUOTE___, do your regex and then re-replace the ~ or ___QUOTE___ with " when you're done. Definitely not the best or fastest solution, but it should work.
May 28 '07 #4

pbmods
Expert 5K+
P: 5,821
Here's what I came up with:

Expand|Select|Wrap|Line Numbers
  1. $str = 'tag1, tag2 tag3, "tag4 tag4, tag4" tag5, "tag6 tag6"';
  2. print("$str<br /><br />\n\n");
  3.  
  4. $matches = preg_split('/(?<!\\\\)"/', $str);
  5.  
  6. $tags = array();
  7.  
  8. foreach($matches as $match) {
  9.     $innerTags = preg_split('/(?<!\\\\),/', $match);
  10.     foreach($innerTags as $tag)
  11.         if(preg_match('/\w/', $tag))
  12.             $tags[] = trim($tag);
  13. }
  14.  
  15. var_dump($tags);
  16.  
First, we split the string by '"', unless it's escaped (preceded by '\'). Now we know where the '"'s are.

Next, we run through each set of tags in between '"'s and split those by unescaped ',' (similarly to '\"', '\,' won't get split). Now we know where the individual tags are; all we have to do now is clean up.

We run through each potential tag and check to see if it has at least one alphanumeric character. If it does, we add it to $tags, sans leading/trailing whitespace.

This might not be the best way to do it; I whipped it up in about 10 minutes. But it works.

[EDIT: If you have magic_quotes turned on, you'll need to run stripslashes on your input first.]
May 28 '07 #5

P: 7
I have finally found a way to do what is needed, based on what everyone has said so far. It is complicated, that much is true, but it works. The last solution posted did not work still, so I am forgetting Regex for now and simply using PHP's string functions.

Test data: (string)$tag_list = tag1, tag2, "tag3 tag3, tag3" tag4, "tag5, tag5", tag6 tag7

[PHP]
// ensure there is at least one beginning and one ending quote
if(strpos($tag_list, '"') !== false && strrpos($tag_list, '"', 1) !== false) {
$quotes_found = true; // initialize the while loop
// find the position of the last quote
$last_quote_pos = strrpos($tag_list, '"', 1);
// initialize so that the first time we try and find the beginning quote we start from position 0
$end_quote_pos = 0;
// we go through the whole string until we reach the last quote
while($quotes_found) {
// find the position of the beginning quote for this tag string
$begin_quote_pos = strpos($tag_list, '"', ($end_quote_pos + 1));
// find the position of the end quote for this tag string
$end_quote_pos = strpos($tag_list, '"', ($begin_quote_pos + 1));
// have we reached the last quote?
if($begin_quote_pos == $last_quote_pos ||
$end_quote_pos == $last_quote_pos) {
$quotes_found = false; // set the while loop to stop after this
}
// split out the quoted tag string
$original_tag = substr($tag_list, $begin_quote_pos, ($end_quote_pos - $begin_quote_pos + 1));
// remove commas from the inside of the quoted string (this is the whole point of this entire if/while combo)
$fixed_tag = strtr($original_tag, ',', ' ');
// replace the quoted string tags with the fixed ones (sans commas)
$tag_list = strtr($tag_list, array($original_tag=>$fixed_tag));
} // end while going through the string with quotes
} // end making sure there is at least one beginning and end quote
[/PHP]

End result: (string)$tag_list = tag1, tag2, "tag3 tag3 tag3" tag4, "tag5 tag5", tag6 tag7

I can now do what was originally sought out, which is to use explode() on $tag_list commas and/or spaces, giving me what I originally needed - which is a list of the tags in an array!
May 28 '07 #6

pbmods
Expert 5K+
P: 5,821
Heh. Oops. My code doesn't check to see if the comma is inside of quotes (which was the whole point).

Well at any rate, I'm glad you found a solution for your problem.
May 28 '07 #7

pbmods
Expert 5K+
P: 5,821
I couldn't deal with the fact that I couldn't figure this out, so I gave it one more go, and I think I've got it this time:

Expand|Select|Wrap|Line Numbers
  1. <?php
  2.     $str = 'tag1, tag2 tag3, "tag4 tag4, tag4" tag5, "tag6 tag6"';
  3.     print("$str<br /><br />\n\n");
  4.  
  5.     $matches = preg_split('/(?<!\\\\)"/', $str);
  6.  
  7.     $tags = array();
  8.  
  9.     foreach($matches as $idx => $match) {
  10.         if($idx % 2)
  11.             $tags[] = stripslashes(trim($match));
  12.         else {
  13.             $innerTags = preg_split('/(?<!\\\\),/', $match);
  14.             foreach($innerTags as $tag)
  15.                 if(preg_match('/\w/', $tag))
  16.                     $tags[] = stripslashes(trim($tag));
  17.         }
  18.     }
  19.  
  20.     var_dump($tags);
  21. ?>
  22.  
The only difference is that we directly copy odd-index matches instead of parsing them for commas.

Think about it. When you split by quote, matches 0, 2, 4, etc. are outside of the quotes, but matches 1, 3, 5 are inside. So matches 1, 3 and 5 should not be parsed, but matches 0, 2 and 4 should. If you don't believe me, var_dump $matches.

Also, I added stripslashes so that if you escape a quote or comma, it doesn't print the slash.

Here's what I get for output:
Expand|Select|Wrap|Line Numbers
  1. tag1, tag2 tag3, "tag4 tag4, tag4" tag5, "tag6 tag6"
  2.  
  3. array(5) {
  4.   [0]=>
  5.   string(4) "tag1"
  6.   [1]=>
  7.   string(9) "tag2 tag3"
  8.   [2]=>
  9.   string(15) "tag4 tag4, tag4"
  10.   [3]=>
  11.   string(4) "tag5"
  12.   [4]=>
  13.   string(9) "tag6 tag6"
  14. }
  15.  
[EDIT: If you want to split tags by space in addition to comma, use this regex instead:

Expand|Select|Wrap|Line Numbers
  1. $innerTags = preg_split('/(?<!\\\\)((,\s*)|((?<!,)\s+))/', $match);
This splits by either comma (with optional following whitespace character[s]) or else just a whitespace character[s] (with a negative lookbehind so that we don't end up catching '\,' properly only to then split at the following whitespace character).

This will result in the following output:

Expand|Select|Wrap|Line Numbers
  1. tag1, tag2 tag3, "tag4 tag4, tag4" tag5, "tag6 tag6"
  2.  
  3. array(6) {
  4.   [0]=>
  5.   string(4) "tag1"
  6.   [1]=>
  7.   string(4) "tag2"
  8.   [2]=>
  9.   string(4) "tag3"
  10.   [3]=>
  11.   string(15) "tag4 tag4, tag4"
  12.   [4]=>
  13.   string(4) "tag5"
  14.   [5]=>
  15.   string(9) "tag6 tag6"
  16. }
  17.  
Or try this on for size:

Expand|Select|Wrap|Line Numbers
  1. tag1, tag2\ tag3, "tag4 tag4, tag4" tag5\, \"tag6 tag6\"
  2.  
  3. array(5) {
  4.   [0]=>
  5.   string(4) "tag1"
  6.   [1]=>
  7.   string(9) "tag2 tag3"
  8.   [2]=>
  9.   string(15) "tag4 tag4, tag4"
  10.   [3]=>
  11.   string(11) "tag5, "tag6"
  12.   [4]=>
  13.   string(5) "tag6""
  14. }
  15.  
]

[EDIT EDIT: The one big flaw in these regexes is that they don't check for escaped slashes (e.g., \\"). But you know what? My brain hurts. You go figure it out. o_O]

[EDIT EDIT EDIT: Nevermind. I got that working, too:

Expand|Select|Wrap|Line Numbers
  1. <?php
  2.     $str = 'tag1, tag2\ tag3, "tag4 tag4, tag4" tag5\\\\, "tag6 tag6\"';
  3.     print("$str<br /><br />\n\n");
  4.  
  5.     $matches = preg_split('/((?<!\\\\)|(?<=\\\\\\\\))"/', $str);
  6.  
  7.     $tags = array();
  8.  
  9.     foreach($matches as $idx => $match) {
  10.         if($idx % 2)
  11.             $tags[] = stripslashes(trim($match));
  12.         else {
  13.             $innerTags = preg_split('/((?<!\\\\)|(?<=\\\\\\\\))((,\s*)|((?<!,)\s))/', $match);
  14.             foreach($innerTags as $tag)
  15.                 if(preg_match('/\w/', $tag))
  16.                     $tags[] = stripslashes(trim($tag));
  17.         }
  18.     }
  19.  
  20.     var_dump($tags);
  21. ?>
  22.  
The major difference is that we will split if the quote or comma and/or/xor space is either not preceded by a slash or is preceded by two slashes.

Sample output (note that the comma after tag5 gets parsed properly):
Expand|Select|Wrap|Line Numbers
  1. tag1, tag2\ tag3, "tag4 tag4, tag4" tag5\\, "tag6 tag6\"
  2.  
  3. array(5) {
  4.   [0]=>
  5.   string(4) "tag1"
  6.   [1]=>
  7.   string(9) "tag2 tag3"
  8.   [2]=>
  9.   string(15) "tag4 tag4, tag4"
  10.   [3]=>
  11.   string(5) "tag5\"
  12.   [4]=>
  13.   string(10) "tag6 tag6""
  14. }
  15.  
This is why pbmods should not be stuck in his apartment on a national holiday.]
May 28 '07 #8

P: 7
This is why pbmods should not be stuck in his apartment on a national holiday.
Wow, that's a lot of work you did! That code is probably better than what I have and accounts for things that I hope users won't do but I'm sure they will.

Thanks!
May 28 '07 #9

pbmods
Expert 5K+
P: 5,821
Thanks!
You are welcome.

And don't worry about me; my templating engine needed an overhaul anyway ~_^
May 28 '07 #10

Post your reply

Sign in to post your reply or Sign up for a free account.