Here is my code with the added suggestions Ronald gave. It does produce the error msgs when fields are empty, however, I can not post a comment now even when all fields are filled. Here is the updated code.
[PHP]<?php
// open connection to database
include("db_connect.php");
// get post_id from query string
$post_id = (isset($_REQUEST["post_id"]))?$_REQUEST["post_id"]:"";
// if post_id is a number get post from database
if (preg_match("/^[0-9]+$/", $post_id)) {
$sql = "SELECT post_id, title, post, DATE_FORMAT(postdate, '%M %e, %Y at %l:%i %p') AS dateattime FROM blg_posts
WHERE post_id=$post_id LIMIT 1";
$result = mysql_query($sql);
$myposts = mysql_fetch_array($result);
}
include ("functions.php");
$errors = array('xname', 'xmail', 'xcomment');
// Process values after submit
if (isset($_POST['postcomment'])) {
// Verify name
if (isset($_POST['name']) AND trim(strip_tags($_POST['name'])) > ' ')
$name = trim(strip_tags($_POST['name']));
else
$errors['xname'] = 'Please enter your name';
//Verify email
if (isset($_POST['email']) AND trim(strip_tags($_POST['email'])) > ' ')
$name = trim(strip_tags($_POST['email']));
else
$errors['xmail'] = 'Please enter your email';
//Verify comment
if (isset($_POST['comment']) AND trim(strip_tags($_POST['comment'])) > ' ')
$name = trim(strip_tags($_POST['comment']));
else
$errors['xcomment'] = 'Please enter a comment';
// If no errors, process the code
if (!$errors) { $posttitle = addslashes(trim(strip_tags($_POST["posttitle"])));
$name = addslashes(trim(strip_tags($_POST["name"])));
$email = addslashes(trim(strip_tags($_POST["email"])));
$website = addslashes(trim(strip_tags($_POST["website"])));
$comment = addslashes(trim(strip_tags($_POST["comment"])));
$sql = "INSERT INTO comments
(post_id,name,email,website,comment)
VALUES ('$post_id', '$name', '$email', '$website', '$comment')";
$result2 = mysql_query($sql);
if (!$result2) {
$message = "Failed to insert comment.";
} else {
$message = "Comment added.";
$comment_id = mysql_insert_id();
// Send yourself an email when a comment is successfully added
$emailsubject = "Comment added to: ".$posttitle;
$emailbody = "Comment on '".$posttitle."'"."\r\n"
."http://www.newnycrossroads.com/post.php?post_id=".$post_id
."#c".$comment_id."\r\n\r\n"
.$comment."\r\n\r\n"
.$name." (".$website.")\r\n\r\n";
$emailbody = stripslashes($emailbody);
$emailheader = "From: ".$name." <".$email.">\r\n"."Reply-To: ".$email;
@mail("info@newnycrossroads.com", $emailsubject, $emailbody, $emailheader);
// direct to post page to eliminate repeat comment posts
header("Location: post.php?post_id=$post_id&message=$message");
exit;
}
}
// There were errors found
else {
print '<span class="warning">Please correct the following errors:<br />';
print '<ul><li><b>';
print implode('</b></li><li><b>',$errors);
print '</b></li></ul></span>'; }
}
if ($myposts) {
$sql = "SELECT comment_id, name, website, comment, DATE_FORMAT(tstamp, '%M %e, %Y at %l:%i %p') AS commentdate FROM comments WHERE post_id = $post_id ORDER by tstamp DESC";
$result3 = mysql_query($sql);
$mycomments = mysql_fetch_array($result3);
}
?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<title>New NY Crossroads Blog</title>
<link rel="stylesheet" type="text/css" href="blog.css" />
</head>
<body>
<!-- BEGIN Header -->
<?php include("header.php"); ?>
<!-- END Header -->
<!-- This is main part of page -->
<div id="maincontent" >
<!-- POSTS -->
<!-- five most recent posts will go here -->
<div id="posts">
<?php
if($myposts) {
do {
$post_id = $myposts["post_id"];
$title = $myposts["title"];
$post = format($myposts["post"]);
$dateattime = $myposts["dateattime"];
echo "<h2>$title</h2>\n";
echo "<h4>$dateattime</h4>\n";
echo "<div class='post'>\n $post \n</div>";
} while ($myposts = mysql_fetch_array($result));
} else {
echo "<p>There is no post matching a post_id of $post_id.</p>";
}
?>
<!-- BEGIN Comments -->
<div id="comments">
<h2>Comments</h2>
<?php
if($mycomments) {
echo "<dl>";
do {
$comment_id = $mycomments["comment_id"];
$name = $mycomments["name"];
$website = $mycomments["website"];
$comment = format($mycomments["comment"]);
$commentdate = ($mycomments["commentdate"]);
if ($website != "") {
echo "<dt><a href='$website'>$name</a> wrote on $commentdate</dt>\n";
} else {
echo "<dt>$name wrote on $commentdate</dt>\n";
}
echo "<dd>$comment</dd>\n";
} while ($mycomments = mysql_fetch_array($result3));
echo "</dl>";
} else {
echo "<p>There are no comments yet.</p>";
}
?>
</div>
<!-- END Comments -->
</div>
<!-- END Posts -->
<!-- SIDEBAR -->
<div id="sidebar">
<br />
<p><a href="../index.php">New NY Crossroads - HOME</a></p>
<!-- Search -->
<?php include("searchform.php"); ?>
<!-- Comment Submission form -->
<form action="<?=$_SERVER["PHP_SELF"]?>" method="post" id="addcomment">
<input type="hidden" name="post_id" value="<?=$post_id ?>" />
<input type="hidden" name="posttitle" value="<?=$title ?>" />
<h3>Add a comment</h3>
<?php
if (isset($message)) {
echo "<p class='message'>".$_POST["message"]."</p>";
}
?>
<p>Name: (Required) <!-- I want an Error msg inserted if NAME empty -->
<br /><input name="name" type="text" value="<?php echo $name ?>"/></p>
<p>Email: <input name="email" type="text" value="<?php echo $email ?>" /></p>
<p>Website:
<br />http://<input name="website" type="text" class="web" /></p>
<p>Comment: (Required) <!-- I want an Error msg inserted if COMMENTempty -->
<br /><textarea name="comment" cols="25" rows="15"><?php echo $comment ?> </textarea></p>
<p><input type="submit" name="postcomment" value="Post comment" /></p>
</form>
<!--END comment form -->
</div>
<!-- END Sidebar -->
</div>
<!-- END Maincontent
<!-- FOOTER -->
<?php include("footer.php"); ?>
</body>
</html>[/PHP]
8
