Returning a null reference in PHP 4.4.2

[jamiesonhale]

Consider a class that encapsulates an associative array. It has two
"setter" methods:

class A
{
....
function setAttribute( $name, $value )
{
$this->attributes[ $name ] = $value;
}
....
function setAttributeByRef( $name, &$value )
{
$this->attributes[ $name ] =& $value;
}
....

The following "getter" method *used* to work just fine prior to version
4.4.2:

....
function & getAttribute( $name )
{
if ( isset( $this->attributes[ $name ] ) )
return $this->attributes[ $name ];
return NULL;
}
....

However, as of version 4.4.2, this throws a "FATAL: Only variable
references should be returned by reference." error. Unfortunately, my
host (and several of my client hosts) are stuck on this version.

Is there an elegant way to solve this problem? I want to return a value
indicating that no such attribute exists.

(I've googled the problem and can't find anything useful other than a
suggestion in a PHP bug report that I learn how to write "proper"
code.)

Thanks!

J

[Colin McKinnon]

ja**********@gmail.com wrote:

function & getAttribute( $name )
{
if ( isset( $this->attributes[ $name ] ) )
return $this->attributes[ $name ];
return NULL;
}
...

However, as of version 4.4.2, this throws a "FATAL: Only variable
references should be returned by reference." error. Unfortunately, my
host (and several of my client hosts) are stuck on this version.

Is there an elegant way to solve this problem? I want to return a value
indicating that no such attribute exists.

I think that a better solution would be to work with the array keys.

But doesn't this work:

function & getAttribute($name)
{
return $this->attributes[$name];
}

For an inelegant hack:
function &getAttribute($name)
{
static $dummy;
$dummy=NULL;
return (isset($this->attributes[$name]) ?
$this->attributes[$name]
: $dummy);
}

C.

[jamiesonhale]

Colin McKinnon wrote:

But doesn't this work:

function & getAttribute($name)
{
return $this->attributes[$name];
}

Hmmm. I could have swore that threw an error too if the key wasn't
set... Am I thinking an older version? (Another language?)

That seems to work. I'll have to re-work a large chunk of code, but
that seems to do it. Thanks. :)

J

[Henk Verhoeven]

Hi,

To be honest, i think the "solution" of php4 to reference anomalies
sucks. I suggest you use php5, or php 4.3. In php4.4 you have to resort
to this kind of ugly code:

function &getAttribute( $name )
{
if ( isset( $this->attributes[ $name ] ) )
return $this->attributes[ $name ];
$null = NULL;
return $null;
}

BTW, you may not need $this->attributes, you can do:

function setAttribute( $name, $value )
{
$this->$name = $value;
}
function &getAttribute( $name )
{
if ( isset( $this->$name ) )
return $this->$name;
$null = NULL;
return $null;
}

Greetings,

Henk Verhoeven.
More info about reference anomalies:
http://www.phppeanuts.org/site/index...e+anomaly.html
ja**********@gmail.com wrote:

Consider a class that encapsulates an associative array. It has two
"setter" methods:

class A
{
...
function setAttribute( $name, $value )
{
$this->attributes[ $name ] = $value;
}
...
function setAttributeByRef( $name, &$value )
{
$this->attributes[ $name ] =& $value;
}
...

The following "getter" method *used* to work just fine prior to version
4.4.2:

...
function & getAttribute( $name )
{
if ( isset( $this->attributes[ $name ] ) )
return $this->attributes[ $name ];
return NULL;
}
...

However, as of version 4.4.2, this throws a "FATAL: Only variable
references should be returned by reference." error. Unfortunately, my
host (and several of my client hosts) are stuck on this version.

Is there an elegant way to solve this problem? I want to return a value
indicating that no such attribute exists.

(I've googled the problem and can't find anything useful other than a
suggestion in a PHP bug report that I learn how to write "proper"
code.)

Thanks!

J

[Chung Leong]

ja**********@gmail.com wrote:

function & getAttribute( $name )
{
if ( isset( $this->attributes[ $name ] ) )
return $this->attributes[ $name ];
return NULL;
}

Why not just

function &getAttribute( $name )
{
return $this->attributes[ $name ];
}