Loops

[Fire Juggler]

Hi I have this this code
{while ($row = mysql_fetch_array($numresultsgal)) {
$table=$row{'table_gal'};
$numresultphotos=mysql_query("SELECT * FROM" .$table. "order by date desc");
$numphotos=mysql_num_rows($numresultphotos);

echo"<b>Gallery:</b> " .$row{'gallery'}. "<br>";
echo "<b>No. Of Photos:</b> " .$numphotos. "<br>" ;}

But it keeps failing to produce the number of photos in the gallery. But it
will display the table name if i want it to. So it's got the correct name,
so any ideas why it's failing and not telling me how many rows are in the
database.

Thanks

--
Kathryn (Fire Juggler)
http://www.firejugglers.34sp.com
http://www.cornwalljugglers.co.uk

[Ewoud Dronkert]

On Sat, 9 Jul 2005 16:42:17 +0100, Fire Juggler wrote:

{while ($row = mysql_fetch_array($numresultsgal)) {
What's that first { doing there?
$table=$row{'table_gal'};
Replace { and } with [ and ].
$numresultphotos=mysql_query("SELECT * FROM" .$table. "order by date desc");
The table name gets plastered against 'FROM' and 'order', the query will
not be valid. Also, if you only need the number of rows, don't get the
complete result set, but use an aggregate function (COUNT) to let de
database do the counting for you.
echo"<b>Gallery:</b> " .$row{'gallery'}. "<br>";

Replace { and } with [ and ].

--
Firefox Browser - Rediscover the web - http://getffox.com/
Thunderbird E-mail and Newsgroups - http://gettbird.com/

[Tony]

Fire Juggler wrote:

Hi I have this this code
{while ($row = mysql_fetch_array($numresultsgal)) {
$table=$row{'table_gal'};
$numresultphotos=mysql_query("SELECT * FROM" .$table. "order by date
desc"); $numphotos=mysql_num_rows($numresultphotos);

echo"<b>Gallery:</b> " .$row{'gallery'}. "<br>";
echo "<b>No. Of Photos:</b> " .$numphotos. "<br>" ;}

But it keeps failing to produce the number of photos in the gallery.
But it will display the table name if i want it to. So it's got the
correct name, so any ideas why it's failing and not telling me how
many rows are in the database.

Is that the EXACT code? If so, you have an error in your SQL syntax. That
error is resulting in a false value for $numresultphotos, which, in turn,
gives a false value for $numphotos.

The error that I see is in the lack of spaces: "SELECT * FROM" . $table .
"order by date desc" - if $table = 'MyTable', your query would be "SELECT *
FROMMyTableorder by date desc" - add spaces: ".. FROM " . $table . " order
by..."

If you also add some error reporting, you'll probably find errors faster -
and, BTW, you don't have to concatenate variables when using double-quotes:

$numresultphotos = mysql_query("SELECT * FROM $table order by date desc");
if (!$numresultphotos) { die (mysql_error()); }
$numphotos = mysql_num_rows($numresultphotos);
--
Tony Garcia
Web Right! Development
Riverside, CA
www.WebRightDevelopment.com