DataTable.AcceptChanges

[Allan Bredahl]

Hi All

I have a problem with getting a DataTable to submit changes back to the
database when calling AcceptChanges.
What I do is simplyfied this :
1) I set up a SqlDataAdapter with SelectCommand, InsertCommand,
UpdateCommand and DeleteCommand pointing to each a stored procedure.

Dim ad as new SqlDataAdapter
Dim ds as new DataSet
........ I setup the adapter 1) ........

ad.Fill(ds)

Dim dt as DataTable = ds.tables("MyTable")
Dim row as DataRow = dt.NewRow

row("field1") = "New String"
row("field2") = 234{int}
row("field3") = 212.34{single}

dt.Rows.Add(row)
dt.AcceptChanges()

This adds the new row to the DataTable just fine, but nothing happens in the
database when calling AcceptChanges.
Am I missing somethig completely here, or shouldn't I be able to insert the
new row into the database using AcceptChanges ??

Do I have to call ad.Update(ds) ??

This is not so easy since in my real code the DataAdapter and the actual
DataTable is placed/used in different places.
Does anyone have a solution to this ??

Thanks in advance

Allan

[Miha Markic]

Hi Allan,

AcceptChanges merely consolidates the changes once they are sucesfully
stored to database.
The right order would be:

Update(..)
AcceptChanges(..)

--
Miha Markic - RightHand .NET consulting & software development
miha at rthand com
www.rthand.com

"Allan Bredahl" <[e-mail]> wrote in message
news:%2***************@TK2MSFTNGP11.phx.gbl...

Hi All

I have a problem with getting a DataTable to submit changes back to the
database when calling AcceptChanges.
What I do is simplyfied this :
1) I set up a SqlDataAdapter with SelectCommand, InsertCommand,
UpdateCommand and DeleteCommand pointing to each a stored procedure.

Dim ad as new SqlDataAdapter
Dim ds as new DataSet
....... I setup the adapter 1) ........

ad.Fill(ds)

Dim dt as DataTable = ds.tables("MyTable")
Dim row as DataRow = dt.NewRow

row("field1") = "New String"
row("field2") = 234{int}
row("field3") = 212.34{single}

dt.Rows.Add(row)
dt.AcceptChanges()

This adds the new row to the DataTable just fine, but nothing happens in the database when calling AcceptChanges.
Am I missing somethig completely here, or shouldn't I be able to insert the new row into the database using AcceptChanges ??

Do I have to call ad.Update(ds) ??

This is not so easy since in my real code the DataAdapter and the actual
DataTable is placed/used in different places.
Does anyone have a solution to this ??

Thanks in advance

Allan

[Allan Bredahl]

That Means that I must have access to the DataAdapter if I want to be able
to commit the changes to the database ??
The problem is that I have a function that uses a DataAdapter to Fill my
DataSet, but I do not have access to this from where I need to commit the
changes to the DataSet/DataTable
thanks

Allan
"Miha Markic" <miha at rthand com> skrev i en meddelelse
news:Ov**************@tk2msftngp13.phx.gbl...

Hi Allan,

AcceptChanges merely consolidates the changes once they are sucesfully
stored to database.
The right order would be:

Update(..)
AcceptChanges(..)

[Cor]

Hi Allan,

If the dataadapter is not there, you can make a newone, it does not have to
be the same one.

And then exact as Miha wrote

xxxDataadpter.update(ds,"mytablename")

I hope this helps,

Cor

Update(..)

AcceptChanges(..)

[Jon Skeet [C# MVP]]

Allan Bredahl <[e-mail]> wrote:

That Means that I must have access to the DataAdapter if I want to be able
to commit the changes to the database ??
Yes. The DataAdapter is the only thing that links the database and the
dataset.
The problem is that I have a function that uses a DataAdapter to Fill my
DataSet, but I do not have access to this from where I need to commit the
changes to the DataSet/DataTable

Then you need to change your design, I'm afraid.

--
Jon Skeet - <sk***@pobox.com>
http://www.pobox.com/~skeet
If replying to the group, please do not mail me too

[Allan Bredahl]

Hi Cor

I know that is a posibility, but I must try to find the best and most clean
way to do it.
Maby the best solution is to go the MS way and follow there Application
Architecture guidelines, and work with a DataAccessLayer
Allan
"Cor" <no*@non.com> skrev i en meddelelse
news:Ov**************@TK2MSFTNGP11.phx.gbl...

Hi Allan,

If the dataadapter is not there, you can make a newone, it does not have to be the same one.

[Miha Markic]

Hi Allan,

As other pointed out, the dataadapter is correct way.
The DAL itself uses them behind the scenes.

--
Miha Markic - RightHand .NET consulting & software development
miha at rthand com
www.rthand.com

"Allan Bredahl" <[e-mail]> wrote in message
news:%2******************@TK2MSFTNGP12.phx.gbl...

Hi Cor

I know that is a posibility, but I must try to find the best and most clean way to do it.
Maby the best solution is to go the MS way and follow there Application
Architecture guidelines, and work with a DataAccessLayer
Allan
"Cor" <no*@non.com> skrev i en meddelelse
news:Ov**************@TK2MSFTNGP11.phx.gbl...

Hi Allan,

If the dataadapter is not there, you can make a newone, it does not have

to

be the same one.

[Allan Bredahl]

Yep, thats what I am thinking of.

Allan
"Miha Markic" <miha at rthand com> skrev i en meddelelse
news:OU**************@TK2MSFTNGP11.phx.gbl...

Hi Allan,

As other pointed out, the dataadapter is correct way.
The DAL itself uses them behind the scenes.

[Jay B. Harlow [MVP - Outlook]]

Allan,
In addition to all the other comments

Am I missing somethig completely here, or shouldn't I be able to insert the new row into the database using AcceptChanges ?? AcceptChanges changes the DataRow.RowState to Unchanged, it also updates the
DataRow Current & Original values.

http://msdn.microsoft.com/library/de...ClassTopic.asp

The DataAdpater.Update method does not bother looking at Unchanged rows. The
DataAdapter.Update method is what actually updates the database. Note
DataAdapter.Update will call DataRow.AcceptChanges...

You may want to read David Sceppa's book "Microsoft ADO.NET - Core
Reference" from MS Press. It is a good tutorial on ADO.NET to learn the
nuances of when & where to call AcceptChanges as well as when & where to
create DataAdapters. It is also an excellent desk reference once you know
ADO.NET.

Hope this helps
Jay

"Allan Bredahl" <[e-mail]> wrote in message
news:%2***************@TK2MSFTNGP11.phx.gbl... Hi All

I have a problem with getting a DataTable to submit changes back to the
database when calling AcceptChanges.
What I do is simplyfied this :
1) I set up a SqlDataAdapter with SelectCommand, InsertCommand,
UpdateCommand and DeleteCommand pointing to each a stored procedure.

Dim ad as new SqlDataAdapter
Dim ds as new DataSet
....... I setup the adapter 1) ........

ad.Fill(ds)

Dim dt as DataTable = ds.tables("MyTable")
Dim row as DataRow = dt.NewRow

row("field1") = "New String"
row("field2") = 234{int}
row("field3") = 212.34{single}

dt.Rows.Add(row)
dt.AcceptChanges()

This adds the new row to the DataTable just fine, but nothing happens in the database when calling AcceptChanges.
Am I missing somethig completely here, or shouldn't I be able to insert the new row into the database using AcceptChanges ??

Do I have to call ad.Update(ds) ??

This is not so easy since in my real code the DataAdapter and the actual
DataTable is placed/used in different places.
Does anyone have a solution to this ??

Thanks in advance

Allan