I hit this bug last night in some test code I had written. It took a few
minutes to figure out what the root cause was, and it left me thinking,
"Wow. That was an interesting one that doesn't come up very often!".
So, for fun, who sees the bug and can explain why it's happening?
List<Threadthre ads = new List<Thread>();
for (int i = 0; i < 2; i++)
{
Thread t = new Thread(delegate ()
{
Debug.Assert(i != 2);
});
t.Start();
threads.Add(t);
}
foreach (Thread thread in threads)
thread.Join();
--
Chris Mullins 19 1313
Chris Mullins [MVP - C#] wrote:
I hit this bug last night in some test code I had written. It took a few
minutes to figure out what the root cause was, and it left me thinking,
"Wow. That was an interesting one that doesn't come up very often!".
So, for fun, who sees the bug and can explain why it's happening?
Define "bug".
Assuming your main thread doesn't get preempted while creating the
threads, both threads are going to fail the assertion. And since the
main thread is doing so little, it is in fact likely to get all the way
to the first call to Join() before another thread gets to run.
But is that a bug? The Debug class is thread-safe, so having two
threads concurrent fail an assertion shouldn't cause a problem in and of
itself.
Pete
Even though it does deal with concurrency, I wouldn't file this under a
concurrency issue, per se. The error comes from using an anonymous method
in the loop and capturing the variable "i".
Because it is used in the anonymous method (and there is only one
instance of it created), when the loop exits, i is equal to 2. Not all the
threads have started up by this point, and then by the time that they do,
the assertion fails.
--
- Nicholas Paldino [.NET/C# MVP]
- mv*@spam.guard. caspershouse.co m
"Chris Mullins [MVP - C#]" <cm******@yahoo .comwrote in message
news:e6******** ******@TK2MSFTN GP02.phx.gbl...
>I hit this bug last night in some test code I had written. It took a few minutes to figure out what the root cause was, and it left me thinking, "Wow. That was an interesting one that doesn't come up very often!".
So, for fun, who sees the bug and can explain why it's happening?
List<Threadthre ads = new List<Thread>();
for (int i = 0; i < 2; i++)
{
Thread t = new Thread(delegate ()
{
Debug.Assert(i != 2);
});
t.Start();
threads.Add(t);
}
foreach (Thread thread in threads)
thread.Join();
--
Chris Mullins
On Oct 24, 2:19 pm, "Chris Mullins [MVP - C#]" <cmull...@yahoo .com>
wrote:
I hit this bug last night in some test code I had written. It took a few
minutes to figure out what the root cause was, and it left me thinking,
"Wow. That was an interesting one that doesn't come up very often!".
So, for fun, who sees the bug and can explain why it's happening?
List<Threadthre ads = new List<Thread>();
for (int i = 0; i < 2; i++)
{
Thread t = new Thread(delegate ()
{
Debug.Assert(i != 2);
});
t.Start();
threads.Add(t);
}
foreach (Thread thread in threads)
thread.Join();
--
Chris Mullins
Hi Chris,
It looks like you're incrementing i to 2 before the threads start.
You can see the same thing with one thread and no anonymous delegate:
private static int _global;
public static void Main()
{
_global = 1;
Thread t = new Thread(MyThread Proc);
t.Start();
_global = 2;
t.Join();
}
public static void MyThreadProc()
{
Debug.Assert(_g lobal != 2);
}
It's not a .Net bug or anything like that, but it's certainly a bug in the
sense that "my code doesn't do what I wrote it to do" sense.
The convergence of technology that caused this to happen made for a weird
debugging process. When you run it in the debugger, it works just fine (as
do most race conditions). Inspecting all the variables always shows the
correct results, etc.
I've seen many people do thing like this with Closures, and the fact that
the passed variable changes makes the code very strange to follow...
It was also confusing, as I *expected* the variable passed into the closure
to be passed by value (it's an int, afterall). I expected to get the same
behavior as if I had passed in a constant. The fact that C# boxed the
variable, passed in a reference to it, and then later checked it after the
for-loop had completed (and the original variable was out of scope) and got
the "illegal" variable, really was amusing...
--
Chris
"Nicholas Paldino [.NET/C# MVP]" <mv*@spam.guard .caspershouse.c omwrote in
message news:et******** ******@TK2MSFTN GP04.phx.gbl...
Even though it does deal with concurrency, I wouldn't file this under a
concurrency issue, per se. The error comes from using an anonymous method
in the loop and capturing the variable "i".
Because it is used in the anonymous method (and there is only one
instance of it created), when the loop exits, i is equal to 2. Not all
the threads have started up by this point, and then by the time that they
do, the assertion fails.
--
- Nicholas Paldino [.NET/C# MVP]
- mv*@spam.guard. caspershouse.co m
"Chris Mullins [MVP - C#]" <cm******@yahoo .comwrote in message
news:e6******** ******@TK2MSFTN GP02.phx.gbl...
>>I hit this bug last night in some test code I had written. It took a few minutes to figure out what the root cause was, and it left me thinking, "Wow. That was an interesting one that doesn't come up very often!".
So, for fun, who sees the bug and can explain why it's happening?
List<Threadthr eads = new List<Thread>(); for (int i = 0; i < 2; i++) { Thread t = new Thread(delegate () { Debug.Assert(i != 2); });
t.Start(); threads.Add(t); }
foreach (Thread thread in threads) thread.Join();
-- Chris Mullins
Well, it's a bug in that the code doesn't do what was originally intended.
Instead an "impossible " assertion fires, and the developer(s) get a very
confused look on their faces for a few minutes...
Your explination is dead on, but the boxing / byref behavior of the variable
passed into the Closure is what made this code behavie in a way other than
was expected. I was expecting the int (a value type) to be passed in by
value, and therefore not change...
--
Chris Mullins
"Peter Duniho" <Np*********@Nn OwSlPiAnMk.comw rote in message
news:13******** *****@corp.supe rnews.com...
Chris Mullins [MVP - C#] wrote:
>I hit this bug last night in some test code I had written. It took a few minutes to figure out what the root cause was, and it left me thinking, "Wow. That was an interesting one that doesn't come up very often!".
So, for fun, who sees the bug and can explain why it's happening?
Define "bug".
Assuming your main thread doesn't get preempted while creating the
threads, both threads are going to fail the assertion. And since the main
thread is doing so little, it is in fact likely to get all the way to the
first call to Join() before another thread gets to run.
But is that a bug? The Debug class is thread-safe, so having two threads
concurrent fail an assertion shouldn't cause a problem in and of itself.
Pete
Chris Mullins [MVP - C#] wrote:
[...]
It was also confusing, as I *expected* the variable passed into the closure
to be passed by value (it's an int, afterall). I expected to get the same
behavior as if I had passed in a constant. The fact that C# boxed the
variable, passed in a reference to it, and then later checked it after the
for-loop had completed (and the original variable was out of scope) and got
the "illegal" variable, really was amusing...
Maybe someone who has more intimate knowledge can comment, but AFAIK
this isn't a case of the value type being boxed. If it were, you
wouldn't have had the problem, since the boxing still preserves the
value as it was at the moment of boxing, not referencing the variable
itself.
Rather, by capturing the variable in the anonymous method, what is being
used in the method is the variable itself. That's why any change to the
variable that happens before the code that uses it is executed is seen
when that code is executed.
The key here is the "capturing" behavior, and I believe that has nothing
to do with boxing.
I think the variable capturing that happens with anonymous methods is
pretty cool, actually. But I agree it can lead to some non-obvious
results when one is not aware that the capturing is going on, and what
the capturing does.
Pete
Chris Mullins [MVP - C#] wrote:
Well, it's a bug in that the code doesn't do what was originally intended.
Instead an "impossible " assertion fires, and the developer(s) get a very
confused look on their faces for a few minutes...
I'm glad you put "impossible " in quotes. :)
Your explination is dead on, but the boxing / byref behavior of the variable
passed into the Closure is what made this code behavie in a way other than
was expected. I was expecting the int (a value type) to be passed in by
value, and therefore not change...
I think my other post elaborates on this already, but I think it's
important to note that not only is there no boxing, I don't think it's
actually that the variable is being "passed" either. So it's not really
correct to talk about the variable be passed by reference or by value.
It's captured, not passed.
If you did want the value passed by value, you could have achieved that
by using the ParameterizedTh readStart constructor for the Thread
instances, and a delegate that actually does have a parameter. Then you
could literally pass the loop variable in by value and have things work
as you expected.
None of this is meant to downplay the potential for confusion here. I
agree that it can be confusing, if you're not familiar with the variable
capturing behavior. I have the benefit of having already been surprised
by this months ago and having Jon Skeet explain it here in this
newsgroup. :)
Pete
Peter and Chris,
There is no boxing here. What is going on here is that the compiler is
generating a class which has a public field "i" which also contains the
method which is passed to the thread for the delegate.
The field is of the same type as the variable, in this case, an int,
which means no boxing occurs.
The reason that it asserts is mentioned in my first post. Because the
scope of i actually contains the loop, there is one instance of the
anonymous class created for the delegate, for all iterations of the loop.
To have a separate instance created every time, you can replace the code
with the following:
List<Threadthre ads = new List<Thread>();
for (int i = 0; i < 2; i++)
{
// Reassign i to prevent a shared anonymous method implementation.
int x = i;
Thread t = new Thread(delegate ()
{
Debug.Assert(x != 2);
});
t.Start();
threads.Add(t);
}
In the code above, a new instance of the anonymous class will be created
on each iteration through the loop and then assigned to the delegate.
--
- Nicholas Paldino [.NET/C# MVP]
- mv*@spam.guard. caspershouse.co m
"Peter Duniho" <Np*********@Nn OwSlPiAnMk.comw rote in message
news:13******** *****@corp.supe rnews.com...
Chris Mullins [MVP - C#] wrote:
>[...] It was also confusing, as I *expected* the variable passed into the closure to be passed by value (it's an int, afterall). I expected to get the same behavior as if I had passed in a constant. The fact that C# boxed the variable, passed in a reference to it, and then later checked it after the for-loop had completed (and the original variable was out of scope) and got the "illegal" variable, really was amusing...
Maybe someone who has more intimate knowledge can comment, but AFAIK this
isn't a case of the value type being boxed. If it were, you wouldn't have
had the problem, since the boxing still preserves the value as it was at
the moment of boxing, not referencing the variable itself.
Rather, by capturing the variable in the anonymous method, what is being
used in the method is the variable itself. That's why any change to the
variable that happens before the code that uses it is executed is seen
when that code is executed.
The key here is the "capturing" behavior, and I believe that has nothing
to do with boxing.
I think the variable capturing that happens with anonymous methods is
pretty cool, actually. But I agree it can lead to some non-obvious
results when one is not aware that the capturing is going on, and what the
capturing does.
Pete
Chris Mullins [MVP - C#] <cm******@yahoo .comwrote:
I hit this bug last night in some test code I had written. It took a few
minutes to figure out what the root cause was, and it left me thinking,
"Wow. That was an interesting one that doesn't come up very often!".
So, for fun, who sees the bug and can explain why it's happening?
List<Threadthre ads = new List<Thread>();
for (int i = 0; i < 2; i++)
{
Thread t = new Thread(delegate ()
{
Debug.Assert(i != 2);
});
t.Start();
threads.Add(t);
}
foreach (Thread thread in threads)
thread.Join();
Posting without reading any responses... "i" is captured and only has a
single "instance", so the assertion will fail if the thread executes
after the loop has "finished".
The solution:
List<Threadthre ads = new List<Thread>();
for (int i = 0; i < 2; i++)
{
int j=i; // THIS IS THE CHANGE
Thread t = new Thread(delegate ()
{
Debug.Assert(j != 2); // AND THIS
});
t.Start();
threads.Add(t);
}
foreach (Thread thread in threads)
thread.Join();
There's a new instance of "j" each time we go round the loop.
--
Jon Skeet - <sk***@pobox.co m> http://www.pobox.com/~skeet Blog: http://www.msmvps.com/jon.skeet
If replying to the group, please do not mail me too This thread has been closed and replies have been disabled. Please start a new discussion. Similar topics |
by: aurora |
last post by:
Hello!
Just gone though an article via Slashdot titled "The Free Lunch Is Over: A
Fundamental Turn Toward Concurrency in Software"
http://www.gotw.ca/publications/concurrency-ddj.htm]. It argues that the
continous CPU performance gain we've seen is finally over. And that future
gain would primary be in the area of software concurrency taking advantage
hyperthreading and multicore architectures.
Perhaps something the Python interpreter...
|
by: Suzanne |
last post by:
Hi All
I'm having problems getting my data adapter to throw a concurrency
exception with an INSERT command. I want to throw a concurrency
exception if an attempt is made to enter a row into tb_table when a
row with the same int_UID already exists in there.
Here is my stored procedure:
if not exists (select int_UID from tb_table where int_UID = @aint_UID)
|
by: Bob |
last post by:
While testing my my program I came up with a consistency exception. My
program consists of three datagridviews, One called dgvPostes which is the
parent grid and its two children,one called dgvPlans and the other dgvTanks.
What happens is as follows. I will either create or edit a record in the
datagridview dgvPlans and call the Updatedb procedure (code below). The
first save works OK. Then when that is done, on the same record I will try...
|
by: William E Voorhees |
last post by:
I'm updating an Access database in a windows multi-user environment.
I'm using disconnected data
I read data from an Access Data table to a data object
I update the data object from a windows form
I save the data from the data object to the Access Data table using a data
adapter as follows:
|
by: John |
last post by:
Hi
I have a vs 2003 winform data app. All the data access code has been
generated using the data adapter wizard and then pasted into the app. The
problem I have is that I am getting a data concurrency error on
mydataadapter.update() method. I know that there is no data concurrency
problem as I am the only user testing the app. Obviously the error is
misleading. What can I do from here to fix this problem?
Thanks
| |
by: Chris Mullins [MVP - C#] |
last post by:
I hit this bug last night in some test code I had written. It took a few
minutes to figure out what the root cause was, and it left me thinking,
"Wow. That was an interesting one that doesn't come up very often!".
So, for fun, who sees the bug and can explain why it's happening?
List<Threadthreads = new List<Thread>();
for (int i = 0; i < 2; i++)
{
Thread t = new Thread(delegate()
|
by: John |
last post by:
Hi
I have developed the following logic to handle db concurrency violations. I
just wonder if someone can tell me if it is correct or if I need a
different approach.Would love to know how pros handle it.
Thanks
Regards
|
by: marktang |
last post by:
ONU (Optical Network Unit) is one of the key components for providing high-speed Internet services. Its primary function is to act as an endpoint device located at the user's premises. However, people are often confused as to whether an ONU can Work As a Router. In this blog post, we’ll explore What is ONU, What Is Router, ONU & Router’s main usage, and What is the difference between ONU and Router. Let’s take a closer look !
Part I. Meaning of...
|
by: Hystou |
last post by:
Most computers default to English, but sometimes we require a different language, especially when relocating. Forgot to request a specific language before your computer shipped? No problem! You can effortlessly switch the default language on Windows 10 without reinstalling. I'll walk you through it.
First, let's disable language synchronization. With a Microsoft account, language settings sync across devices. To prevent any complications,...
|
by: Oralloy |
last post by:
Hello folks,
I am unable to find appropriate documentation on the type promotion of bit-fields when using the generalised comparison operator "<=>".
The problem is that using the GNU compilers, it seems that the internal comparison operator "<=>" tries to promote arguments from unsigned to signed.
This is as boiled down as I can make it.
Here is my compilation command:
g++-12 -std=c++20 -Wnarrowing bit_field.cpp
Here is the code in...
|
by: jinu1996 |
last post by:
In today's digital age, having a compelling online presence is paramount for businesses aiming to thrive in a competitive landscape. At the heart of this digital strategy lies an intricately woven tapestry of website design and digital marketing. It's not merely about having a website; it's about crafting an immersive digital experience that captivates audiences and drives business growth.
The Art of Business Website Design
Your website is...
| |
by: tracyyun |
last post by:
Dear forum friends,
With the development of smart home technology, a variety of wireless communication protocols have appeared on the market, such as Zigbee, Z-Wave, Wi-Fi, Bluetooth, etc. Each protocol has its own unique characteristics and advantages, but as a user who is planning to build a smart home system, I am a bit confused by the choice of these technologies. I'm particularly interested in Zigbee because I've heard it does some...
|
by: agi2029 |
last post by:
Let's talk about the concept of autonomous AI software engineers and no-code agents. These AIs are designed to manage the entire lifecycle of a software development project—planning, coding, testing, and deployment—without human intervention. Imagine an AI that can take a project description, break it down, write the code, debug it, and then launch it, all on its own....
Now, this would greatly impact the work of software developers. The idea...
|
by: TSSRALBI |
last post by:
Hello
I'm a network technician in training and I need your help.
I am currently learning how to create and manage the different types of VPNs and I have a question about LAN-to-LAN VPNs.
The last exercise I practiced was to create a LAN-to-LAN VPN between two Pfsense firewalls, by using IPSEC protocols.
I succeeded, with both firewalls in the same network. But I'm wondering if it's possible to do the same thing, with 2 Pfsense firewalls...
|
by: adsilva |
last post by:
A Windows Forms form does not have the event Unload, like VB6. What one acts like?
|
by: bsmnconsultancy |
last post by:
In today's digital era, a well-designed website is crucial for businesses looking to succeed. Whether you're a small business owner or a large corporation in Toronto, having a strong online presence can significantly impact your brand's success. BSMN Consultancy, a leader in Website Development in Toronto offers valuable insights into creating effective websites that not only look great but also perform exceptionally well. In this comprehensive...
| |