ArrayList: Getting "System.Str ing[]" Instead of Actual Values

[R2d2Rabeau]

Hi,

I'm new to C#, please be patient :-) I am trying to pass an Arraylist (myAL) to a jagged array (myAL2) . The problem I have is that when I write the values to a file i do not get the values instead I get "System.Str ing[]" ? How can I fix the problem? I wanted to use ArralyList because its length is flexible and I can add values to it.

...All help will be greatly appreciated.

Here's my code:

//create jagged array
 
string[][] myAL2;
 
// set dimension 1's length
 
myAL2 = new string[myAL.Count][];
 
// set dimensions 2 oj jagged array
 
for (int m = 0; m < myAL.Count; m++)
 
{
 
//here i just set D2 to 19 as a temporary solution as I don't know yet how to get the length of the ArrayList Counts....
 
myAL2[m] = new string[19];
 
//read through myAL ArrayList and passing arrays to 2D jagged array list
 
for (int ix = 0; ix < myAL.Count; ++ix)
 
{
 
// This is causing a problem by not giving me the value
 
myAL2[ix][n] = Convert.ToString(myAL[ix]);
 
}
 
}

[kenobewan]

Are you using .net 2.0? This can be a reversion to a default schema.

[R2d2Rabeau]

I am indeed using .Net 2.0

This can be a reversion to a default schema.

How can I fix the problem?

[rock7799]

myAL2[m][ix] = Convert.ToStrin g(myAL[ix]);

actually you are misplacing the variables in the for loop. I just changed the places of variables. If the arraylist contains only strings then you can directly use myAL[ix].ToString(); function to get that.

Instead of jagged array you can use ArrayList of ArrayList.

Hope this solves ur problem.

[R2d2Rabeau]

myAL2[m][ix] = Convert.ToStrin g(myAL[ix]);

actually you are misplacing the variables in the for loop. I just changed the places of variables. If the arraylist contains only strings then you can directly use myAL[ix].ToString(); function to get that.

Instead of jagged array you can use ArrayList of ArrayList.

Hope this solves ur problem.

Hi,

variable m=19 represents the number of columns
ix represents the number of rows.
So they should be as I put them.


Maybe my problem comes down to this:

 myAL2[ix][n] = myAL[ix].ToString();

as it stores in myAL2 "System.Str ing[ ]" instead of the actual values..

(NB myAl ArrayList has both integers and strings. )

Any other idea?

[rock7799]

can you post entire code since the declaration and the assignments are imp so i need to know. WHen i tried taking simple string it worked with the change i mentioned. so post the entire code then may be all others also can help you.

[R2d2Rabeau]

can you post entire code since the declaration and the assignments are imp so i need to know. WHen i tried taking simple string it worked with the change i mentioned. so post the entire code then may be all others also can help you.

Ok, here is all of the code, it is not pretty though...


(reference Microsoft Excel 11.0 Object Library in COM has been added)

using System;
using System.Collections.Generic;
using System.Text;
using Microsoft.Office.Interop.Excel;
using System.IO;
using System.Collections;
using System.ComponentModel;
using System.Data;
 
namespace ConsApp_ArrayList_eXCEL_10MAY
{
    class Program
    {
 
 
        static public string[] ConvertToStringArray(System.Array values)
        {
            // create a new string array
            //string[] theArray = new string[values.Length];
            ArrayList theArray = new ArrayList();
 
            //loop through the 2-D System.Array and populate the 1-D String Array
            for (int i = 1; i <= values.Length; i++)
            {
                if (values.GetValue(1, i) == null)
                    theArray.Add("");
                else
                    theArray.Add((string)values.GetValue(1, i).ToString());
            }
            // add 2 additional holders as I will add 2 values per row later
            theArray.Add("");
            theArray.Add("");
 
            return (string[])theArray.ToArray(typeof(string));
 
        }
 
 
 
        static void Main(string[] args)
        {
            //Write result to a file
            FileStream fs = new FileStream("RMReportx_UPDATED.txt", FileMode.OpenOrCreate, FileAccess.Write);
            StreamWriter sWriter = new StreamWriter(fs);
            Microsoft.Office.Interop.Excel.Application ExcelObj = null;
            //InitializeComponent();
            ExcelObj = new Microsoft.Office.Interop.Excel.Application();
 
            // create Jagged array
            string[][] jaggedA = new string[238][];
 
 
            // read excel file where the data is comming from
            Microsoft.Office.Interop.Excel.Workbook theWorkbook = ExcelObj.Workbooks.Open("C:/Documents and Settings/zzeghoud/My Documents/RMReportx.xls", 0, true, 5,
                  "", "", true, Microsoft.Office.Interop.Excel.XlPlatform.xlWindows, "\t", false, false, 0, true, false, false);
            // get the collection of sheets in the workbook
            Microsoft.Office.Interop.Excel.Sheets sheets = theWorkbook.Worksheets;
            // get the first and only worksheet from the collection of worksheets
            Microsoft.Office.Interop.Excel.Worksheet worksheet = (Microsoft.Office.Interop.Excel.Worksheet)sheets.get_Item(1);
 
 
            // create ArrayList to hold the sheet's data
            ArrayList myAL = new ArrayList();
 
            // read file from line 8 to line 247
            for (int i = 8; i < 247; i++) // i should increase until it reaches a row with null
            // 3384, 247 is an arbitrary number of rows (should cover max number of rows in Excel sheet
            //odeally the number of row should be counted beforehand and then passed
            {
                Microsoft.Office.Interop.Excel.Range range = worksheet.get_Range("A" + i.ToString(), "q" + i.ToString());
                System.Array myvalues = (System.Array)range.Cells.Value2;
                string[] strArray = ConvertToStringArray(myvalues);
                //add data to the myAL arrayList
                myAL.Add(ConvertToStringArray(myvalues));
 
 
 
 
            }
 
            //create jagged array
            string[][] myAL2;
            // set dimension 1's length
            myAL2 = new string[myAL.Count][];
            //create (temp) string array for the columns
            string[] myALChild = new string[19];
 
            //string str;
 
            // set dimensions 2 oj jagged array
            for (int m = 0; m < myAL.Count; m++)
            {
                myAL2[m] = new string[19];
 
            }
 
 
 
            //read through myAL ArrayList and assing arrays to 2D jagged array list
            for (int ix = 0; ix < myAL.Count; ix++)
            {
                for (int n = 0; n < 19; n++)
                {
                   myAL2[n][ix] = Convert.ToString(myAL[ix]);
                 }
            }
 
 
            // write results to file
            for (int ix = 0; ix < myAL.Count; ix++)
            {
                for (int n = 0; n < 19; n++)
                {
                    sWriter.WriteLine(myAL2[ix][n].ToString());
 
                }
            }
 
            Console.WriteLine(" The Text file named RMReportx_UPDATED.txt is created ");
            if (sWriter != null) { sWriter.Close(); }
            Console.ReadLine();
 
 
        }
 
    }
}

Thanks again,

[rock7799]

Hi,

The problem here i see is while assigning the values to jagged array you are using

for (int ix = 0; ix < myAL.Count; ix++)
{
for (int n = 0; n < 19; n++)
{
myAL2[n][ix] = Convert.ToStrin g(myAL[ix]);
}
}

while getting back values your have made change in variables.. there is the problem since jagged array do not have same number of rows and columns when you write into file it gives u object.

Try to make the same adjusment in other for loop and then see the difference.

The change of variables i told u will solve the problem.
Here is simple code i wrote just to see whats happening....
may this will help you..


//create jagged array
string sMSG = "If you smell what the Rock is Cooking !";
ArrayList myAL = new ArrayList();
string[] arr = sMSG.Split(' ');

for (int i = 0; i < arr.Length; i++)
{
myAL.Add(arr[i]);
}
string[][] myAL2;

// set dimension 1's length

myAL2 = new string[myAL.Count][];

// set dimensions 2 oj jagged array

for (int m = 0; m < myAL.Count; m++)
{
//here i just set D2 to 19 as a temporary solution as I don't know yet how to get the length of the ArrayList Counts....

myAL2[m] = new string[9];

//read through myAL ArrayList and passing arrays to 2D jagged array list

for (int ix = 0; ix < myAL.Count; ++ix)
{
// This is causing a problem by not giving me the value
myAL2[m][ix] = Convert.ToStrin g(myAL[ix]);
Console.WriteLi ne(Convert.ToSt ring(myAL[ix]));
}
}

[R2d2Rabeau]

The change of variables i told u will solve the problem.
Here is simple code i wrote just to see whats happening....
may this will help you..

Hi,

Thank you for the code you wrote, I tried to adapt it to my problem (see below) however I still get "System.Str ing[ ]" and not the actual value???
What am I missing?...

 
      {     ...
           System.Array myvalues = (System.Array)range.Cells.Value2;
           myAL.Add(ConvertToStringArray(myvalues));
       }
 
           string[][] myAL2;
 
            // set dimension 1's length
 
            myAL2 = new string[myAL.Count][];
 
            // set dimensions 2 oj jagged array
 
            for (int m = 0; m < myAL.Count; m++)
            {
                //here i just set D2 to 19 as a temporary solution as I don't know yet how to get the length of the ArrayList Counts....
 
                myAL2[m] = new string[19];
 
                //read through myAL ArrayList and passing arrays to 2D jagged array list
 
                for (int ix = 0; ix < myAL.Count; ++ix)
                {
                    // This is causing a problem by not giving me the value
                    myAL2[m][ix] = Convert.ToString(myAL[ix]);
                    Console.WriteLine(Convert.ToString(myAL[ix]));
                }
 
            }

Again, thank you for your help.

[R2d2Rabeau]

Thanks a Million, I have sorted it out thanks to you!

for (int i = 8; i < 247; i++)            
// 247 is an arbitrary number of rows (should cover max number of rows in //Excel sheet
    {
      string[] strArray = ConvertToStringArray(myvalues);
 
      for (int v = 0; v < strArray.Length; v++)
                {
                    myAL.Add(strArray[v]);
                }
 
    }

I only have to work on this code now, as I need to get the values per row.


Thanks again you have been extremely helpful and patient!