How to validate length and match required character?

[KingIcode]

This how i validate my required characters and the length

JavaScript

function submitChangej(){
 
  var inputlastName = document.getElementById("lastname"); 
  var inputfirstName = document.getElementById("firstname"); 
  var inputmobileNumber = document.getElementById("mobilenumber");
  var inputidNumber = document.getElementById("idnumber");
  var firstname =  /^[a-zA-Z-\s]{2,128}$/; 
  var lastname = /^[a-zA-Z-\s]{2,128}$/; 
  var mobilenumber = /^[0-9]{10,20}$/;
  var idnumber = /^([0-9]){2}([0-1][0-9])([0-3][0-9])([0-9]){4}([0-1])([0-9]){2}?$/;
 
 
  var inputSubmit = document.getElementById("applyforreseller");
 
  var Container = document.getElementById('Agreement');
 
  if((inputfirstName.value.length < 2 || inputfirstName.value.length > 128 ) || ( inputlastName.value.length < 2 || inputlastName > 128 ) || (inputmobileNumber.value.length < 10 || inputmobileNumber > 20) || (inputidNumber.value.length < 13)){
 
 
        Container.style.display = 'none';
  }
  else{
 
        Container.style.display = 'block';
  }
  var Container = document.getElementById('Agreement');
 if((firstname.value.match(firstname) != null) || (lastname.match(lastname) != null) || (mobilenumber.value.match(mobilenumber) != null) || (idnumber.value.value.match(idnumber) != null)){
 
        Container.style.display = 'none';
  }
  else{
 
        Container.style.display = 'block';
 
  } 
}
 

I want to hide the button if value does not match the required type, I m able to hide it on the length, but my match does not work.

I than call my method

submitChangej()

on the fields that i validate.


The button should be hidden when match and length are invalid, if everything is correct than the button should appear.

Your will be appreciated

[Dormilich]

some comments first.

• unless you target a very specific group of people you shouldn’t make any constraints on names (currently you exclude any people that have non-ASCII characters in their name, such as O’Brian, François, Jürgen, etc.)
• there is an unescaped hypen in the character class definition. might yield unexpected results.
• [0-9] equals \d
• you can omit all parentheses in the ID number check and could compact it to /^\d{2}[01]\d[0-3]\d{5}[0-1]\d{2}?$/

[KingIcode]

I target very specific group of people.

[Dormilich]

so can exclude even apostrophes?

[KingIcode]

Yes, I work according to what is required.

[KingIcode]

Fixed my issue by doing the following

if(!firstname.test(inputfirstName.value) || !lastname.test(inputlastName.value) || !mobilenumber.test(inputmobileNumber.value) || !idnumber.test(inputidNumber.value)){
 
        if (Container){Container.style.display = 'none';}
 }
  else{
        if (Container) {Container.style.display = 'block';}
      }