change src of embed using JS

[helraizer1]

I have this code in JS

    function show_player() {
        document.mediaplayer1.style.visibility = "visible";
    }
    function content(p, clip) {
        var mus = document.getElementById('music');
 
        mus.style.visibility = "visible";
        mus.innerHTML = p;
 
            var sound = [];
 
        sound['ocean'] = "./Ocean_Breeze.mp3";
        sound['always'] = "http://www.youtube.com/v/K9MFBuzr6p4&rel=1";
        sound['day'] = "http://www.youtube.com/v/Wxx_rO2oLPE&rel=1";
        sound['mid'] = "http://www.youtube.com/v/4qQ4fpTBHwI&rel=1";
        sound['erupt'] = "http://www.youtube.com/v/tqhz-i1WIQo&rel=1";
 
        document.mediaplayer1.src = sound[clip];
 
    }
 

with the following HTML to go with it.

<table align="center">
<tr>
<td colspan="1"><p style="visibility:hidden;" id="music">Ocean Breeze</p></td>
</tr>
<tr>
<td colspan="1"><embed type="application/x-mplayer2" pluginspage="http://www.microsoft.com/Windows/MediaPlayer/" name="mediaplayer1" showstatusbar="1" id="mp" EnableContextMenu="false" autostart="false"  width="630" height="70"  transparentstart="1" loop="0" controller="true" src="" style="visibility:hidden;"></embed></td>
</tr>
</table>
</td></tr></table>
<br><br><br>
<table align="center">
<tr>
<td align="center" colspan="1"><p>Which song would you like to hear?</p></td></tr>
<tr>
<td>
<a href="#" onclick="javascript:show_player();content('Ocean Breeze','ocean');"> Ocean Breeze</a>
</td>
<td>|</td>
</tr>
<tr>
<td>
<a href="#" onclick="javascript:show_player();content('Always with me, always with you','always');">Always With Me, Always With You</a>
</td>
<td>|</td>
</tr>
<tr>
<td>
<a href="#" onclick="javascript:show_player();content('Day at the Beach','day');">Day Of The Beach</a>
</td>
<td>|</td>
</tr>
<tr>
<td>
<a href="#"  onclick="javascript:show_player();content('Midnight','mid');">Midnight</a>
</td>
<td>|</td>
</tr>
<tr>
<td>
<a href="#" onclick="javascript:show_player();content('Eruption', 'erupt');">Eruption</a>
</td>
<td>|</td>
</tr>
</table>
 

When I click the links the player appears, so the visibility part works, also the innerHTML of the <p> element works on each, but the content doesn't change, is there something I'm doing wrong?

Sam

[acoder]

Do you get any errors?

[helraizer1]

Do you get any errors?

No errors, it simply wouldn't play the media but now I've fixed it, I changed it to:

function play(desc) {
 
 
        var sound = [];
 
        sound['ocean'] = '<embed type="application/x-mplayer2" pluginspage="http://www.microsoft.com/Windows/MediaPlayer/" name="mediaplayer1" showstatusbar="1" EnableContextMenu="false"  autostart="true"  width="400" height="400"  transparentstart="1" loop="0" controller="true" src="./Ocean_Breeze.mp3"  style=" border:1 #fff;"></embed>';
 
        sound['always'] = '<embed type="application/x-mplayer2" pluginspage="http://www.microsoft.com/Windows/MediaPlayer/" name="mediaplayer1" showstatusbar="1" EnableContextMenu="false"  autostart="true"  width="400" height="400"  transparentstart="1" loop="0" controller="true" src="always.mp3"  style=" border:1 #fff;"></embed>';
 
        sound['day'] = '<embed type="application/x-mplayer2" pluginspage="http://www.microsoft.com/Windows/MediaPlayer/" name="mediaplayer1" showstatusbar="1" EnableContextMenu="false"  autostart="true"  width="400" height="400"  transparentstart="1" loop="0" controller="true" src="day at the beach.mp3"  style=" border:1 #fff;"></embed>';
 
        sound['mid'] = '<embed type="application/x-mplayer2" pluginspage="http://www.microsoft.com/Windows/MediaPlayer/" name="mediaplayer1" showstatusbar="1" EnableContextMenu="false"  autostart="true"  width="400" height="400"  transparentstart="1" loop="0" controller="true" src="Midnight.mp3"  style=" border:1 #fff;"></embed>';
 
        sound['erupt'] = '<embed type="application/x-mplayer2" pluginspage="http://www.microsoft.com/Windows/MediaPlayer/" name="mediaplayer1" showstatusbar="1" EnableContextMenu="false"  autostart="true"  width="400" height="400"  transparentstart="1" loop="0" controller="true" src="eruption.mp3"  style=" border:1 #fff;"></embed>';
 
        document.getElementById('player').innerHTML = sound[desc];
        }

with player being -

<td colspan="1" ><div id="player"></div></td>
 

It works now.

Sam

[acoder]

Well, that would work, but it seems a bit overkill to replace the whole object each time just to change the source. Anyway, since there's only 5 options, it's not too bad.