adding column numbers

[decren]

Hello,
I have a table with an add-row setup. The table has several columns but I only need to calculate COLUMN FOUR. The results go to a textbox via a button. My code is.....

function sumup() {
 document.getElementById("Table1")
  column = document.getElementsByTagName("colFour");
  document.myForm.tbTotal.value = column;
}

.....

<TABLE NAME="Table1" id="Table1">
<COL WIDTH=10*>
    <COL WIDTH=139*>
    <COL WIDTH=27*>
    <COL WIDTH=29*>
    <COL WIDTH=27* NAME="colFour" id="colFour">
    <COL WIDTH=10*>

.....

<INPUT TYPE=TEXT NAME="tbTotal">
<INPUT TYPE=BUTTON NAME="pbTest" VALUE="TEST" onclick="sumup();"./>

.....But when I click pbTest, the result in tbTotal is, with the brackets.....
[object]
.....What am I doing wrong?

[acoder]

You need to use getElementById instead.

[DutchKingCobra]

hi pal,
im working on your problem whenever i have some time,

in firefox the price wont be written to the new cell created
this is easily fixed
use

// cell 4 - ***PRICE*** of record
var itemCost = document.forms['R2CDorder1'].tbPrice.value;
var cell4 = row.insertCell(4); 
cell4.appendChild(document.createTextNode(itemCost)); 
 

well peace m8

[decren]

You need to use getElementById instead

I assume you mean...

column = document.getElementBy("colFour");

...I did not realize you could use getElementById consecutively... Thanks, I'll try to work that out.

im working on your problem whenever i have some time,

I appreciate any help on this. I think its turning out to be a decent piece of work in progress but I hope not to paint myself into a corner... and thank you for the heads up in firefox.

...To anyone else, The project I'm working on is at:

[HTML]http://www.aaronzjukebox.com/R2CDorder1[/HTML]

but the problem is associated with Table4 instead of Table1. Any and all pointers are appreciated.

[mrhoo]

This is a general function to total the cells in a table column.
It assumes that all of the rows are in a single tbody,
though it is easy enough to call it on multiple tbodies and total the result.
Empty cells in the column and cells without numbers are treated as 0.

You can call the function with no arguments, columnSum();
and it will return the total of the last column of the first tbody on the page,
or you can specify the parent table or tbody and the column number.

function columnSum(pa,col){
    pa= pa || document.getElementsByTagName('tbody')[0];
    /* if no parent is passed, get the first tbody on the page */
 
    var G= pa.getElementsByTagName('tr');
    col= col || G[0].getElementsByTagName('td').length;
    --col;
    /* if no col is passed, get the index of the last column
    note- not 0 based, the argument for the first column is passed as 1 */
 
    var L= G.length,sum= 0,temA= [];
    for(var i= 0; i< L; i++){
        tem= G[i].getElementsByTagName('td')[col];
        var c=0;
        while(tem && !tem.data ) tem= tem.childNodes[c++];
         /* digs into the cell's innards, in case the data is in a child of the cell */
        tem= tem? tem.data : 0;
        sum+= parseFloat(tem) || 0;
    }
    return sum;
}

[decren]

=DutchKingCobra
in firefox the price wont be written to the new cell created
this is easily fixed
use

// cell 4 - ***PRICE*** of record
var itemCost = document.forms['R2CDorder1'].tbPrice.value;
var cell4 = row.insertCell(4); 
cell4.appendChild(document.createTextNode(itemCost)); 
 

well peace m8

I downloaded FireFox to see what was going wrong. My problem was that I had NAMEd all my elements in the table but had not assigned IDs. This worked fine in IE but halted the function in FireFox. Thanx for the heads-up.

[decren]

I want to thank everyone at TheScripts for their input to this problem. With your help and with a table located at:
http://4umi.com/web/javascript/
I was able to work out a solution. If anyone is interested in (what I believe to be unique) addRow/shoppingCart type form, you are welcome to take what you need from:
http://www.aaronzjukebox.com/R2CDorder1
Understand though that it is a work in progress so you will have to sift through a lot of garbage to get the scripts to your particular need.
And thanx again

[pbmods]

Wouldn't it make more sense just to add an onchange handler to each of the inputs you want to total? Something like...

[HTML]
<td><input id="row1Price" onchange="sumRows(this);" /></td>
[/HTML]

var $rowValues = {};
function sumRows($element) {
    $element.value = $element.value.replace(/[^\d.]/, '');
    $rowValues[$element.id] = $element.value;
 
    document.getElementById('theSum').value = sum($rowValues);
}
 
function sum($obj) {
    var $retVal = 0;
 
    for($r in $obj)
        $retVal += $obj[$r];
 
    return $retVal;
}