plz help me with this code (a FileFilter for JFileChooser)

[FinPingvin]

Hi!

This code wont work properly, it returns true for showing all maps, but not any files. It is supposed to filter the JFileChooser to only show *.mp3 files.
I have looked at it too long now, so i think its best to let someone else to look at it now :p

Here it is:

import javax.swing.filechooser.*;
import java.io.File;

public class Mp3Filter extends FileFilter {

public boolean accept(File file) {
String ext = getExtension(file);

if (file.isDirectory())
return true;

else if (ext != null && ext == "mp3")
return true;

else return false;
}

public String getExtension(File file) {
String ext = null;
String fileName = file.getName();
int i = fileName.lastIndexOf(".");

if (i > 0 && i < fileName.length() - 1)
ext = fileName.substring(i+1).toLowerCase();

return ext;
}

public String getDescription() {
return ".mp3 Files";
}
}

[r035198x]

Hi!

This code wont work properly, it returns true for showing all maps, but not any files. It is supposed to filter the JFileChooser to only show *.mp3 files.
I have looked at it too long now, so i think its best to let someone else to look at it now :p

Here it is:

import javax.swing.filechooser.*;
import java.io.File;

public class Mp3Filter extends FileFilter {

public boolean accept(File file) {
String ext = getExtension(file);

if (file.isDirectory())
return true;

else if (ext != null && ext == "mp3")
return true;

else return false;
}

public String getExtension(File file) {
String ext = null;
String fileName = file.getName();
int i = fileName.lastIndexOf(".");

if (i > 0 && i < fileName.length() - 1)
ext = fileName.substring(i+1).toLowerCase();

return ext;
}

public String getDescription() {
return ".mp3 Files";
}
}

1.) Remember to wrap code in code tags next time you post code.
2.) When comparing Strings in java, do not use ==. Use the .equals method. e.g

ext.equals("mp3")

[JosAH]

The String class has a very convenient method for this: endsWith().

kind regards,

Jos

[FinPingvin]

Sorry r035198x, my first post on the forums.
Ah and you are so right, guess i was kind of tired last night hehe.

and thanks josAH, endsWith() was a handy method!