Trying to change the color of a graphics object

[mjrtom19]

I have a Jframe using a menubar to determine the color and shape of a graphics2d object, at the moment the color stays red no matter what. I think the problem is in the itemListener in the inner class myShape, but I dont know what it is.

Heres the code:

import java.awt.*;
import javax.swing.*;
import java.awt.event.*;
import java.awt.Graphics2D.*;
import java.awt.geom.*;
 
 
/** A menu class that gives the option to display a circle or a rectangle
 * that is either Green, Yellow, or Blue, it makes a text field to display
 * which is shape/color is present
 * @author Thomas Capranica
 *
 */
public class menu implements ActionListener, ItemListener {
    JMenuBar menuBar;
    JMenu menu, submenu;
    JMenuItem menuItem;
    JCheckBoxMenuItem Yellow, Blue;
    JRadioButtonMenuItem Rect, Circ;
    JMenu firstMenu, secondMenu;
    JTextField field = new JTextField(30);
    JTextField field2 = new JTextField(30);
    String color = "Red";
    String shape = "Square";
    boolean yellow = false;
    boolean blue = false;
 
    public static void main(String[] args){
        menu j = new menu();
    }
    public menu(){
        JFrame frame = new JFrame("JMenus");
        frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
 
        field.setEditable(false);
        field2.setEditable(false);
 
        field.setText("The Color is " + color);
        field2.setText("The Shape is a " + shape);
 
        menuBar = new JMenuBar();
        JPanel north = new JPanel();
        north.setLayout(new GridLayout(1,2));
        north.add(field);
        north.add(field2);
        frame.add(north,BorderLayout.NORTH);
 
        ButtonGroup Sgroup = new ButtonGroup();
 
        Yellow = new JCheckBoxMenuItem("Yellow");
        Blue = new JCheckBoxMenuItem("Blue");
        Yellow.addItemListener(this);
        Blue.addItemListener(this);
        Yellow.addItemListener(new myShape());
 
        Rect = new JRadioButtonMenuItem("Rectangle");
        Circ = new JRadioButtonMenuItem("Circle");
 
        Sgroup.add(Circ);
        Sgroup.add(Rect);
 
        firstMenu = new JMenu("Colors");
        firstMenu.getAccessibleContext().setAccessibleDescription("" +
                "Sets the Colrors of the Object");
        firstMenu.add(Yellow);
        firstMenu.add(Blue);
        firstMenu.addSeparator();
 
        secondMenu = new JMenu("Shapes");
        secondMenu.add(Rect);
        secondMenu.add(Circ);
        firstMenu.add(secondMenu);
        menuBar.add(firstMenu);
 
        frame.add(new myShape());
        frame.setJMenuBar(menuBar);
        frame.setSize(300,200);
        frame.setVisible(true);
    }
//Checks to see which radioButton is selected, sets the shape accordingly (not done)    
    public void actionPerformed(ActionEvent e){
        field2.setText("Its A " + shape); 
    }
 
// Checks to see which checkBoxes are checked, changes the color accordingly
    public void itemStateChanged(ItemEvent e){
 
        JMenuItem source = (JMenuItem)(e.getSource());
        String select = ((e.getStateChange() == ItemEvent.SELECTED) ?
                "selected":"unselected");
        String which = source.getText();
        if(which.equals("Yellow") && select.equals("selected"))
            yellow = true;
        else if(which.equals("Yellow") && select.equals("unselected"))
            yellow = false;
        else if(which.equals("Blue") && select.equals("selected"))
            blue = true;
        else if(which.equals("Blue") && select.equals("unselected"))
            blue = false;
 
         if(blue == true  && yellow == false)
             color = "Blue";
         else if(yellow == true  && blue == false)
             color = "Yellow";
         else if(yellow == true && blue == true)
             color = "Green";
         else if(yellow == false && blue == false)
             color = "Red";
 
         field.setText("The Color is " + color); 
    }
    class myShape extends JPanel implements ItemListener {
        Graphics2D g2;
        Color c;
        public void paintComponent(Graphics g){
            super.paintComponent(g);
            g2 = (Graphics2D) g;
            g2.setColor(c);            
            g2.fill(new Rectangle(125,50,50,50));            
        }        
        public void itemStateChanged(ItemEvent e){
            JMenuItem source = (JMenuItem)(e.getSource());
            String select = ((e.getStateChange() == ItemEvent.SELECTED) ?
                    "selected":"unselected");
            String which = source.getText();
            if(which.equals("Yellow") && select.equals("selected"))
                yellow = true;
            else if(which.equals("Yellow") && select.equals("unselected"))
                yellow = false;
            else if(which.equals("Blue") && select.equals("selected"))
                blue = true;
            else if(which.equals("Blue") && select.equals("unselected"))
                blue = false;
 
             if(blue == true  && yellow == false)
                 c = Color.BLUE;
             else if(yellow == true  && blue == false)
                 c = Color.YELLOW;
             else if(yellow == true && blue == true)
                 c = Color.GREEN;
             else if(yellow == false && blue == false)
                 c = Color.RED;
             repaint();   
        }
    }
}

[BigDaddyLH]

Please enclose your posted code in [code] tags (See How to Ask a Question).

This makes it easier for our Experts to read and understand it. Failing to do so creates extra work for the moderators, thus wasting resources, otherwise available to answer the members' questions.

Please use [code] tags in future.

MODERATOR

[BigDaddyLH]

Very close! You wrote:

frame.add(new myShape());

which meant you never had a change to teach your component to listen to the menu items. Replace that with:

myShape component = new myShape();
Yellow.addItemListener(component);
Blue.addItemListener(component);
frame.add(component);
 

My the way, there is a strong convention in Java to give classes (and interfaces) names that start with capital letters: Menu and MyShape, and all other names start with lower case letters.