malloc inside loop

[star bright]

Hi
I have code which looks like this
ABC_STRUCT abc[50];
unsigned int j=0;

for (i=0;i< x;i++) {
char* sub = (char *) malloc (somesize);
strcpy(sub,some source);
abc[j].data= (unsigned char*) sub;
abc[j].len= strlen(sub);
...........
j++
}

for(i=0;i<=j-1;i++)
{
free((POINTER)abc[i].data
}

I just wanted to make sure that the above code is freeing up the memory properly and there are no memory leaks

Thanks in advance

[weaknessforcats]

The code should be

abc[i].data = (char *) malloc (somesize);
 strcpy(abc[i].data,some source);
 

The loop should be:

for (i=0;i< 50;i++) {
 etc...

since there are 50 elements in your array.

You should not keep the strlen as a struct member. The length of
abc[i].data can gotten as needed. Plus if you keep the strlen then yu have to make sure you maintain it whenever abc[i].data changes.

The free would be:

free(abc[i].data);
 

The loop should be:

(i=0;i< 50;i++)
 {
etc...

because you have 50 array elements.

[star bright]

Hi
Thanks for your reply. I understand the code doesn't look perfect because this is not complete code . I pulled out lines which were related to what i am trying to understand which is if the code is similar to what i posted will free function free up memory correctly .

Thanks

[donbock]

You also need to deal properly with the case when malloc fails. Skip the code that reads or writes via sub when malloc returns NULL; and skip the code that calls free when .data is NULL.