Delete the dynamic allocated using new char[]

[mohidsheik]

Please help me whether the following method to delete the memory which is created dynamically in another function is correct or not

 
long newValues ( char** pszValue)
{
    *pszValue = new char[ 128 ];
    strcpy( *pszValue, "newvalue");
    return 0;
}
 
 
 
int APIENTRY WinMain(HINSTANCE hInstance, HINSTANCE hPrevInstance,  LPSTR     lpCmdLine,  int  nCmdShow)
{
    char*  curValue;
    newValues ( &curValue);
    delete curValue;
 
    return 0;
}
 
 

Thanks

[ilikepython]

Please help me whether the following method to delete the memory which is created dynamically in another function is correct or not

 
long newValues ( char** pszValue)
{
    *pszValue = new char[ 128 ];
    strcpy( *pszValue, "newvalue");
    return 0;
}
 
 
 
int APIENTRY WinMain(HINSTANCE hInstance, HINSTANCE hPrevInstance,  LPSTR     lpCmdLine,  int  nCmdShow)
{
    char*  curValue;
    newValues ( &curValue);
    delete curValue;
 
    return 0;
}
 
 

Thanks

I believe you need to delete with the brackets since you allocated an array.

[weaknessforcats]

You have hidden your new inside a function named newValues. This is a good idea. It's also a good idea to hide your delete. I suggest you write a deleteValues that deletes what newValues has allocated.

It's never good to have new/delete scattered all over the code.

[mohidsheik]

You have hidden your new inside a function named newValues. This is a good idea. It's also a good idea to hide your delete. I suggest you write a deleteValues that deletes what newValues has allocated.

It's never good to have new/delete scattered all over the code.

Thanks for the advice.The doubt what i have is, If I delete the newvalue inside the function, how the value will get returned to the calling method.