my code has failed to print out the last number i enter in the reverse order

[blazo]

its here why isit like that

#include <stdio.h>
int z[10];
    int y;
    void reverse_order(int x[],int y)
    {
    for (y = 9; y >=0; --y)
      {
             printf("%d \t",x[y]);
        }
        }
 int main(void)  {
 
 printf("Enter any numbers of your choice \n");
        for (y = 0; y <10; ++y)
        {
scanf("%d\t", &z[y]);
 
            }
 printf("the reverse of the entered numbers is\n");
 reverse_order(z,y);
 return 0;
 }

[jimwawar]

its here why isit like that

#include <stdio.h>
int z[10];
    int y;
    void reverse_order(int x[],int y)
    {
    for (y = 9; y >=0; --y)
      {
             printf("%d \t",x[y]);
        }
        }
 int main(void)  {
 
 printf("Enter any numbers of your choice \n");
        for (y = 0; y <10; ++y)
        {
scanf("%d\t", &z[y]);
 
            }
 printf("the reverse of the entered numbers is\n");
 reverse_order(z,y);
 return 0;
 }

You are using two different size loops. In you enter you are using 10 for a loop which goes 0,1,2,3,4,5,6,7,8,9 or 10 entries in your reverse loop you are 9 which goes 0,1,2,3,4,5,6,7,8 or 9 entries. Change you reverse loop to 10 and it will work as you expect.

Jim

[JosAH]

I'd say get rid of that '\t' in the scanf format specifier.

kind regards,

Jos

[Banfa]

You are using two different size loops. In you enter you are using 10 for a loop which goes 0,1,2,3,4,5,6,7,8,9 or 10 entries in your reverse loop you are 9 which goes 0,1,2,3,4,5,6,7,8 or 9 entries. Change you reverse loop to 10 and it will work as you expect.

You statement about the reverse for loop is not true.

it starts at 9 and iterates while y >= 0 for values 9, 8, 7, 6, 5, 4, 3, 2, 1, 0 inside the loop.

[jimwawar]

You statement about the reverse for loop is not true.

it starts at 9 and iterates while y >= 0 for values 9, 8, 7, 6, 5, 4, 3, 2, 1, 0 inside the loop.

You are correct, I should have said 11 for the input and 10 for the output. The result is the same, the arrays are not of equal length.

Jim

[JosAH]

You are correct, I should have said 11 for the input and 10 for the output. The result is the same, the arrays are not of equal length.

Jim

That isn't true either; for (int y= 0; y < 10; ++y) loops ten times, not eleven times.

kind regards,

Jos

[RRick]

From the original code,

• Why are you passing y to the subroutine, when you overwrite its value in the for loop?
• If y is the size of the array (i.e y=10) then the - -y decrement will work
• If y is the index to the last entry (i.e. y=9), then change - -y to y- -

[Ganon11]

• If y is the size of the array (i.e y=10) then the - -y decrement will work
• If y is the index to the last entry (i.e. y=9), then change - -y to y- -

Shouldn't both work, since the last statement in the for loop header is only executed at the end of the loop?

[RRick]

You're right. The decrement order doesn't matter. It's the middle conditional that gets checked after the intialization and each loop.

Sooo, we are back to the loops. Both loops are using a different countint base, but end up with the same number of entries.

When you remove the '\t' from the printf, does your program work correctly??