Functions In Fraction Calculator

[Nkhosinathie]

hello everyone,i'm writing this csalculator proogram that is using functions to perform functions in a fraction calculator.this is what i did and my problem now the readInFraction does not take the values to the function execute to perform the calculations that i want.my problem is that the values i'm reading in readInFraction are not transferred to execute.

//program that that allows the user to perform arithmetic operations on fractions
#include<iostream>
using namespace std;


void execute(char&,int&,int&,int&,int&,int&,int&);
void readInFraction(int,int,int,int);
void menuAndGetOP(char);//function prototype that receives and takes nothing
void division (int,int,int,int,int,int);//function prototype for dividing
void addition (int,int,int,int,int,int);//function prototype for adding
void subtraction (int,int,int,int,int,int);//function prototype for subtraction
void multiplication (int,int,int,int,int,int);//function prototype for multipling


int main()
{
int N1;//declaration of N1
int N2;//declaration of N2
int D1;//declaration of D1
int D2;//declaration of D2
char OP;//declaration of OP
int Dr=0;
int Nr=0;


menuAndGetOP(OP);
readInFraction(N1,D1,N2,D2);
execute(OP,N1,D1,N2,D2,Dr,Nr);
return 0;
}
void menuAndGetOP(char OP)//function defination
{

//prints massage
cout<<" "<<"********************************************** ************\n";
cout<<" "<<"* To perform arithmetic operations on fractions: *\n";
cout<<" "<<"* Multiplication: press '*' *\n";
cout<<" "<<"* Subtraction: press '-' *\n";
cout<<" "<<"* Addition: press '+' *\n";
cout<<" "<<"* Division: press `/` *\n";
cout<<" "<<"* Enter operation (+ , -, *, / ):";
cin>>OP;
cout<<" "<<"********************************************** ************\n";



}//end of function menuAndGetOP '

void readInFraction(int n1,int d1,int n2,int d2)

{
char jack;

cout<<"enter the first fraction\n";
cin>>n1>>jack>>d1;
cout<<"enter second fraction\n";
cin>>n2>>jack>>d2;

}

void addition(int n1,int d1,int n2,int d2,int dr,int nr)//function prototype for adding
{

nr=(n1*d2)+(n2*d1);//performs adding calculations
dr=d1*d2;//performs adding calculations

cout<<nr<<"/"<<dr;
}
void division(int n1,int d1,int n2,int d2,int dr,int nr)

{

nr=n1*d2;//performs divide calculations
dr=n2*d1;//performs divide calculations

cout<<nr<<"/"<<dr;

}
void multiplication(int n1,int d1,int n2,int d2,int dr,int nr)
{

nr=n1*n2;//performs multiplication calculations
dr=d1*d2;//performs multiplication calculations

cout<<nr<<"/"<<dr;

}
void subtraction(int n1,int d1,int n2,int d2,int dr,int nr)

{
nr=(n1*d2)-(n2*d1);//performs subtraction calculations
dr=d1*d2;//performs subtraction calculations

cout<<nr<<"/"<<dr;
}
void execute(char&OP,int& n1,int& d1,int& n2,int& d2,int& dr,int&nr)


{



switch (OP)//switch statement that allows user to enter a choice
{
case '-' :subtraction(n1,d1,n2,d2,dr,nr);//if user entered '-' operator
break;

case '*':multiplication(n1,d1,n2,d2,dr,nr);
break;

case '+':addition(n1,d1,n2,d2,dr,nr);
break;

case '/' :division(n1,d1,n2,d2,dr,nr);
break;

default:
cout<<"wrong operation\n";
break;
}
}

[ilikepython]

hello everyone,i'm writing this csalculator proogram that is using functions to perform functions in a fraction calculator.this is what i did and my problem now the readInFraction does not take the values to the function execute to perform the calculations that i want.my problem is that the values i'm reading in readInFraction are not transferred to execute.

//program that that allows the user to perform arithmetic operations on fractions
#include<iostream>
using namespace std;


void execute(char&,int&,int&,int&,int&,int&,int&);
void readInFraction(int,int,int,int);
void menuAndGetOP(char);//function prototype that receives and takes nothing
void division (int,int,int,int,int,int);//function prototype for dividing
void addition (int,int,int,int,int,int);//function prototype for adding
void subtraction (int,int,int,int,int,int);//function prototype for subtraction
void multiplication (int,int,int,int,int,int);//function prototype for multipling


int main()
{
int N1;//declaration of N1
int N2;//declaration of N2
int D1;//declaration of D1
int D2;//declaration of D2
char OP;//declaration of OP
int Dr=0;
int Nr=0;


menuAndGetOP(OP);
readInFraction(N1,D1,N2,D2);
execute(OP,N1,D1,N2,D2,Dr,Nr);
return 0;
}
void menuAndGetOP(char OP)//function defination
{

//prints massage
cout<<" "<<"********************************************** ************\n";
cout<<" "<<"* To perform arithmetic operations on fractions: *\n";
cout<<" "<<"* Multiplication: press '*' *\n";
cout<<" "<<"* Subtraction: press '-' *\n";
cout<<" "<<"* Addition: press '+' *\n";
cout<<" "<<"* Division: press `/` *\n";
cout<<" "<<"* Enter operation (+ , -, *, / ):";
cin>>OP;
cout<<" "<<"********************************************** ************\n";



}//end of function menuAndGetOP '

void readInFraction(int n1,int d1,int n2,int d2)

{
char jack;

cout<<"enter the first fraction\n";
cin>>n1>>jack>>d1;
cout<<"enter second fraction\n";
cin>>n2>>jack>>d2;

}

void addition(int n1,int d1,int n2,int d2,int dr,int nr)//function prototype for adding
{

nr=(n1*d2)+(n2*d1);//performs adding calculations
dr=d1*d2;//performs adding calculations

cout<<nr<<"/"<<dr;
}
void division(int n1,int d1,int n2,int d2,int dr,int nr)

{

nr=n1*d2;//performs divide calculations
dr=n2*d1;//performs divide calculations

cout<<nr<<"/"<<dr;

}
void multiplication(int n1,int d1,int n2,int d2,int dr,int nr)
{

nr=n1*n2;//performs multiplication calculations
dr=d1*d2;//performs multiplication calculations

cout<<nr<<"/"<<dr;

}
void subtraction(int n1,int d1,int n2,int d2,int dr,int nr)

{
nr=(n1*d2)-(n2*d1);//performs subtraction calculations
dr=d1*d2;//performs subtraction calculations

cout<<nr<<"/"<<dr;
}
void execute(char&OP,int& n1,int& d1,int& n2,int& d2,int& dr,int&nr)


{



switch (OP)//switch statement that allows user to enter a choice
{
case '-' :subtraction(n1,d1,n2,d2,dr,nr);//if user entered '-' operator
break;

case '*':multiplication(n1,d1,n2,d2,dr,nr);
break;

case '+':addition(n1,d1,n2,d2,dr,nr);
break;

case '/' :division(n1,d1,n2,d2,dr,nr);
break;

default:
cout<<"wrong operation\n";
break;
}
}

First of all, you have all these integer values, why not just use a class.

Your functions are useless because they don't bring back anything to do the program. I don't know why you declared execute with pass by reference. Only the functions that return more than one value should use pass by reference. And they should only do it on the variables that you want to return:

void add(int N1, int D1, int N2, int D2, int &dr, int &nr);