Help on simple left brace error

[medetali]

C:\VC\Src\5060309482_6\6.cpp(131) : fatal error C1075: end of file found before the left brace '{' at 'C:\VC\Src\5060309482_6\6.cpp(76)' was matched
Error executing cl.exe.







//seqlist.h



#include <math.h>
#include <iostream.h>

class SeqList
{
private:
char *elem;
int length;
int MaxSize;
public:



void Clear( )const;
bool IsEmpty ( ) const {return (length==0);};
bool IsFull ( ) const { return (length==MaxSize);
int Length ( ) const;
char Get ( int i ) const;
int Find (char e ) const;
int Insert (int i, char e );
char Delete (int i );
};

SeqList::SeqList(int size):
{

elem = new char[size];
if (!elem) cout<<"there is no space in memory"<<endl;
else {length=0; MaxSize = 100-1;}

}

SeqList::SeqList():
{
elem = new char[10];
if (!elem) cout<<"there is no space in memory"<<endl;
else {length=0; MaxSize = 100-1; }

}

SeqList::~SeqList ( )
{
delete [ ]elem;
}


void SeqList::Clear()
{
length=0;
}


int SeqList::Length ( ) const
{
return length+MAXB;
}

char SeqList::Get ( int i ) const
{
if ((i>0) && (i<=length)) return elem[i];
else { cout <<"i is not correct ! "<<endl;return '#';
}
}

int SeqList::Find ( char e ) const
{
elem[0]= e; int i = length;
while (elem[i] != e ) i--;
return i;
}

int SeqList::Insert (int i, char e)
{
if ((i<1) || (i>length+1))
{
cout<<"i is not correct"<<endl;
return 0;
if (MaxSize == length)

{
cout<<"no space for new item"<<endl;
return 0;
}
for (int j=length; j>=i; j--)
elem[j+1]=elem[j];
elem[i]=e;
length++;
return 1;
}

char SeqList::Delete (int i )
{
if ((i<1) || (i>length))
cout<<"i is not correct"<<endl;

char e=elem[i];

for (int j=i; j<length; j++) elem[j]=elem[j+1];
length--;
return e;
}
void main()
{
SeqList chlist(10);
char ctemp;
int i, n;
int result;
cout<<"number of the elements:";
cin>>n;
cout<<"input the elements:";
for (i=1; i<=n; i++)
{ cin>>ctemp; chlist.Insert(i, ctemp); }
cout<<endl;
ctemp=chlist.Delete(1);
result = chlist.Insert(chlist.Length()/2+1, ctemp);
if (result==0) cout<<"fail to insert the element"<<endl;
else
cout<<"output the elements:"<<output the elements()<<endl;
for (i=1; i<=chlist.Length(); i++)
cout<<chlist.Get(i);
cout<<endl;





}

[Soneji]

The original problem you noted was from two missing braces.
One in the class, and another in a function definition.

I fixed those, and a ton of other problems came up.

I couldn't fix the whole thing, because I wasn't sure about some things.

I did go through it and comment the crap out of it for you.

Maybe you can look through the comments, and fix it based on my notes.

 
#include <math.h>
#include <iostream.h>
 
class SeqList
{
    private:
               char *elem;   
               int length;   
            int MaxSize;  
    public:
 
// You don't have the constructors or destructor declared in the class.
//   You can't define them below without declaring them here first.
 
// Const means you won't alter any values with the function... 
            void Clear( ) const;
// But in the definition for this function, you alter 'length'.
// ( Remove 'const' from the 'Clear' function. )
 
            bool IsEmpty ( ) const {return (length==0);};
// added closing brace to the end of the line below.
            bool IsFull ( )     const { return (length==MaxSize); } 
            int  Length ( ) const;
            char Get ( int i ) const;     
            int  Find (char e ) const;  
            int  Insert (int i, char e );    
               char Delete (int i );           
  };
 
// Constructor not declared. ( See above )
SeqList::SeqList(int size): // What's the colon for?
//  You don't have a list of intializers here.     
  {                                
 
            elem = new char[size];            
          if (!elem) cout<<"there is no space in memory"<<endl;    
          else {length=0;     MaxSize = 100-1;}
 
  }
// Constructor not declared. ( See above )
SeqList::SeqList():  // Again with the colon.  What are you trying to do?
  {
          elem = new char[10];            
          if (!elem) cout<<"there is no space in memory"<<endl;    
          else {length=0;     MaxSize = 100-1; }
 
}
// Destructor not declared. ( See above )
SeqList::~SeqList ( ) 
{
delete [ ]elem; 
}
 
 
void SeqList::Clear()  // ( See start of this comment in the class above )
{
    length=0; // See? You assign 0 to 'length'.
 }    // You're "altering" the length variable.  This is a no-no with const.
 
 
int SeqList::Length ( ) const
 {
      return length+MAXB;  // MAXB is undeclared.  
 }                       // Can't use it till you declare it. 
 
 
char SeqList::Get ( int i ) const
 {
       if ((i>0) && (i<=length)) return elem[i];
    else { cout <<"i is not correct ! "<<endl;return '#';
    } 
  }
 
int SeqList::Find ( char e ) const
{ 
     elem[0]= e;  int i = length;   
     while (elem[i] != e ) i--;      
     return i;                      
}
 
int SeqList::Insert (int i, char e) 
{
if ((i<1) || (i>length+1)) 
{
        cout<<"i is not correct"<<endl;
        return 0;    
    if (MaxSize == length) 
 
    { 
        cout<<"no space for new item"<<endl;
        return 0; 
    }
        for (int j=length; j>=i; j--) 
       elem[j+1]=elem[j];
    elem[i]=e;    
    length++;        
    return 1;        
 }  // *************************
}   // Added another brace here.
    // *************************
char SeqList::Delete (int i ) 
{
    if ((i<1) || (i>length)) 
        cout<<"i is not correct"<<endl;
 
         char e=elem[i];
 
      for (int j=i; j<length; j++)  elem[j]=elem[j+1];
    length--;        
    return e;        
}
void main()  // This should be 'int', not void.
{
    SeqList chlist(10);
        char ctemp;
        int i, n;
        int result;
        cout<<"number of the elements:";
        cin>>n;
        cout<<"input the elements:";  
        for (i=1; i<=n; i++)
            { cin>>ctemp;    chlist.Insert(i, ctemp); }    
        cout<<endl;
        ctemp=chlist.Delete(1);    
        result = chlist.Insert(chlist.Length()/2+1, ctemp);
        if (result==0) cout<<"fail to insert the element"<<endl;
        else 
            cout<<"output the elements:"<<output the elements()<<endl;
// What are you trying to do with: "output the elements()"  ???
// You don't have a function named that, and if you did, it wouldn't work
//    without underscores between the names.
            for (i=1; i<=chlist.Length(); i++)
                cout<<chlist.Get(i);                                   
            cout<<endl;                                
}
 

Not sure if this will be any help, but I hope it is.

Good luck! :)
-Soneji

[JosAH]

@OP: please don't double post. Your other (identical) thread didn't contain replies
yet and I removed it; please keep one problem in one thread only.

kind regards,

Jos

ps. use [ code ] ... [ /code ] tags when you post code. It makes it much more
readable; see the other reply for an example.

[weaknessforcats]

You have problem here:

char SeqList::Get ( int i ) const
{
if ((i>0) && (i<=length)) return elem[i];
else { cout <<"i is not correct ! "<<endl;return '#';
}
}

The semi-colon after your "if" should not be there.

[Soneji]

You have problem here:

Originally Posted by medetali
char SeqList::Get ( int i ) const
{                                          // -Soneji
if ((i>0) && (i<=length)) return elem[i];  // return elem[i];  :)
else { cout <<"i is not correct ! "<<endl;return '#';
}
}
 

The semi-colon after your "if" should not be there.

Uh... weakness, that semicolon SHOULD be there. There's a return statement after that 'if' statement.

Without the semicolon, it won't compile.

:)

If I'm wrong on this, call me on it. ;)

-Soneji

[r035198x]

I think you need a brace here

             bool IsFull ( )     const { return (length==MaxSize);

P.S It is a good idea sometimes to have one statement per line.

[weaknessforcats]

Uh... weakness, that semicolon SHOULD be there. There's a return statement after that 'if' statement.

Without the semicolon, it won't compile.

You're right. I hate code like this. It doesn't take much effort to

if ((i>0) && (i<=length))
{  
   return elem[i];  // return elem[i];  :)
}
else
{ 
   cout <<"i is not correct ! "<<endl;return '#';
 
}
 

[Soneji]

LOL!

I know what you mean.

I've still got eye-strain from going through it the first time. :)

Lates!
-Soneji