warning about character const

[nickyeng]

Hi all,
I have this warning in my code, i dont know which part of it need to change ...
It keeps give me this warning message :

here is my code:

/* hero.h */
#ifndef _HERO_H_
#define _HERO_H_
#include <iostream>
#include <string>
#include "screen.h"
#include "terrain.h"
 
namespace Game {
    using namespace std;
    class Hero{
        public:
        Hero(){
            posX = 2;
            posY = 2;
            health = 100;
            scr.setStatus("Health : 100%");
        }
 
        int getHealth(){
            return health;
        }
 
        bool testAlive(){
            if(health==0){
                return false;
            }else{
                return true;
            }
        }
 
        void moving(){
            char c;
 
            system("stty raw -echo");
            cin.get(c);
            system("stty raw -echo");
 
            if(c=='u' || c=='U'){
                    if(terr.Move(posX,posY-1)==true){
                        posY = posY - 1;
                        health = health - 1;
                    }else{
                        health = health - 5;
                        scr.setStatus("You ran into a Wall!");
                        scr.Beep();
 
                    }
            }else if(c=='d' || c=='D'){
 
                    if(terr.Move(posX,posY-1)==true){
                        posY = posY + 1;
                        health = health - 1;
 
                    }else{
                        scr.setStatus("You ran into a Wall!");
                        scr.Beep();
                        health = health - 5;
                    }
            }else if(c=='r' || c=='R'){
                    if(terr.Move(posX,posY-1)==true){
                        posX = posX + 1;
                        health = health - 1;
 
                    }else{
                        scr.setStatus("You ran into a Wall!");
                        scr.Beep();
                        health = health - 5;
                    }
            }else if(c=='l' || c=='L'){
                    if(terr.Move(posX,posY-1)==true){
                        posX = posX - 1;
                        health = health - 1;
 
                    }else{
                        scr.setStatus("You ran into a Wall!");
                        scr.Beep();
                        health = health - 5;
                    }
 
            }
        }
 
        void DrawHero(){
            scr.Insert(posX,posY,'H');
        }
 
        private:
 
            int posX;
            unsigned posY;
            unsigned health;
            Screen scr;
            Terrain terr;
    };
}
#endif
 

[DeMan]

The problem is in screen.h and given the line number given is 91, I assume is now more complex than in your previous post, Though i suspect it may be to do with how you use your variables xSize & ySize.


The Error Messages literally mean:
in the file fou include at line 7 of hero.h the following problem occurs:
at (or near) line 91 char 12 of screen.h .......

[nickyeng]

i have this :

    void Beep(){
            cout << '0x07';
        }
 

the warning is about cout << '0x07';.

i wanna make the screen somehow beep.
the code above correct to so?

[DeMan]

I've always been a fan of printf, so I don't know too much about cout. your statement

i wanna make the screen somehow beep.

Doesn't make much sense to me....my screen displays things, my speakers make noise.....

[Ganon11]

There is a simple escape sequence you can use with cout to make a beep, according to http://msdn2.microsoft.com/en-us/library/6aw8xdf2.aspx

Just cout << "\a"; and a beep should sound.

[Banfa]

i have this :

    void Beep(){
            cout << '0x07';
        }
 

the warning is about cout << '0x07';.

i wanna make the screen somehow beep.
the code above correct to so?

The problem is the '0x07', this is a character constant because it uses single quotes '...' . Now I assume you are trying to output character value 7 which is BEL and normally plays a beep through the PC speaker, however '0x07' is not a single character, you need an escape sequence, that is / followed by various options to produce a single character.

For istance

/r - carridge return
/n - new line
/t - tab

to name the well know ones but you can also have the following

/ooo - character with the octal value ooo
/xhh - character with the hexidecimal value hh

so
instead of '0x07' you should have used '/x07' or '/7'