Help with the procedure..

[evantri]

(6)
Write a small procedure that will prompt the user for an integer, then get that value and assign it to a local variable. This local variable is then used to change the value of a passed in parameter. The routine should be called getValue and look like:

void getValue(int *value_to_be_returned)
AND it will be called from the mainline as
getValue(&my_value);
WHERE myvalue is declared inside the mainline.

I've tried to do this but that's sumtin wrong in the code:

#include <stdio.h>
 
void getValue ( int * value_to_be_returned )
 
{
 
static int returned_value;
 
returned_value = 5;
 
* value_to_be_returned = returned_value;
 
}
 
int main ( int argc, char ** argv )
 
{
 
// Mainline Variable Declarations
FILE * output = stdout;
FILE * input = stdin;
 
int * my_value;
int number;
 
fprintf ( output, "Enter the integer number : " ); fflush ( stdout );
fscanf ( input, "%d", &number );
 
* my_value = number;
 
fprintf ( output, "\nValue that is entered is %d\n\n", &my_value );
 
getValue ( &my_value );
 
fprintf ( output, "Value that is changed is %d\n\n", &my_value );
 
}
 
 

[horace1]

my_value is a int * (pointer to int) not an int so your function call (which passes the address of my_value)
getValue (& my_value );

should be (which passes the address of number)
getValue ( my_value );

you have similar mistakes elsewhere, the following now works

#include <stdio.h>
 
void getValue ( int * value_to_be_returned )
{
static int returned_value;
 
returned_value = 5;
 
* value_to_be_returned = returned_value;
 
}
 
int main ( int argc, char ** argv )
{
// Mainline Variable Declarations
FILE * output = stdout;
FILE * input = stdin;
 
int * my_value;
int number;
 
fprintf ( output, "Enter the integer number : " ); fflush ( stdout );
fscanf ( input, "%d", &number );
 
* my_value = number;
 
fprintf ( output, "\nValue that is entered is %d\n\n", *my_value );
 
getValue ( my_value );
 
fprintf ( output, "Value that is changed is %d\n\n", *my_value );
 
}
 

you don't need my_value, you could use number directly

#include <stdio.h>
 
void getValue ( int * value_to_be_returned )
{
static int returned_value;
 
returned_value = 5;
 
* value_to_be_returned = returned_value;
 
}
 
int main ( int argc, char ** argv )
 
{
 
// Mainline Variable Declarations
FILE * output = stdout;
FILE * input = stdin;
int number;
 
fprintf ( output, "Enter the integer number : " ); fflush ( stdout );
fscanf ( input, "%d", &number );
 
fprintf ( output, "\nValue that is entered is %d\n\n", number );
 
getValue ( &number );
 
fprintf ( output, "Value that is changed is %d\n\n", number );
}
 

[evantri]

Your code worked but there is a segmentation fault appeared, what happened?

[horace1]

Your code worked but there is a segmentation fault appeared, what happened?

both programs run OK on my system (using DEV-C++ with gcc compiler) - do both give segmentation faults when you run them?

you get a segmentation fault if you use an invalid address, e.g. if you miss the & when calling getValue

getValue ( number );
 

getValue() would use the value of number as the address rather than the address of number

did you copy and paste my code or edit your own, if the latter you probably missed something

[evantri]

I copied your code. I'm using cc compiler. Still gave me seg fault

[horace1]

I copied your code. I'm using cc compiler. Still gave me seg fault

managed to replicate the problem on a Linux box using cc
In the first program I missed assigning the address of number to my_value. The code is now

#include <stdio.h>
 
void getValue ( int * value_to_be_returned )
{
static int returned_value;
 
returned_value = 5;
 
* value_to_be_returned = returned_value;
 
}
 
int main ( int argc, char ** argv )
{
// Mainline Variable Declarations
FILE * output = stdout;
FILE * input = stdin;
 
int * my_value;
int number;
 
fprintf ( output, "Enter the integer number : " ); fflush ( stdout );
fscanf ( input, "%d", &number );
 
my_value=&number;               // ** missing statement
* my_value = number;
 
fprintf ( output, "\nValue that is entered is %d\n\n", *my_value );
 
getValue ( my_value );
 
fprintf ( output, "Value that is changed is %d\n\n", *my_value );
 
}
 

[evantri]

The code worked now, thanx