Problrm in invesing a char array

[Alenik1989]

i have this code which suppose to get a n input from the file and store it in a char array then i have to inverse it.....
rhis code isnt complete but im getting a wiered error
i see the error when the c++ starts linking not in the compilation procces.
my code is

#include<iostream>
#include<cstring>
#include<fstream>
int reverse(char* str);
using namespace std;
 
int main()
{
ifstream infile;
ofstream outfile;
infile.open("input.txt");
outfile.open("output.txt");
char name[60];
char invname[60];
 
    if(infile.fail())
    cout<<"FAILED";
    else
    {
    while(!infile.eof())
    {
               infile.getline(name,'\n');
                 reverse(name);
}
}
return 0;
}    
 
 
int Reverse(char* str)
{
if (NULL==str)return -1; //no string
int l=strlen(str)-1; //get the string length
if (1==l)return 1;
 
for(int x=0;x < l;x++,l--)
{
str[x]^=str[l];  //triple XOR Trick
str[l]^=str[x];  //for not using a temp
str[x]^=str[l];
}
return 0;
}
 
 

the error is

Linking...
asdqwe.obj : error LNK2001: unresolved external symbol "int __cdecl reverse(char *)" (?reverse@@YAHPAD@Z)
Debug/asdqwe.exe : fatal error LNK1120: 1 unresolved externals
Error executing link.exe.
 
asdqwe.exe - 2 error(s), 0 warning(s)
 

can enyone explain the error for me please and tell what to do......ASAP please!!!!!!

[mschenkelberg]

i have this code which suppose to get a n input from the file and store it in a char array then i have to inverse it.....
rhis code isnt complete but im getting a wiered error
i see the error when the c++ starts linking not in the compilation procces.
my code is

#include<iostream>
#include<cstring>
#include<fstream>
int reverse(char* str);
using namespace std;
 
int main()
{
ifstream infile;
ofstream outfile;
infile.open("input.txt");
outfile.open("output.txt");
char name[60];
char invname[60];
 
    if(infile.fail())
    cout<<"FAILED";
    else
    {
    while(!infile.eof())
    {
               infile.getline(name,'\n');
                 reverse(name);
}
}
return 0;
}    
 
 
int Reverse(char* str)
{
if (NULL==str)return -1; //no string
int l=strlen(str)-1; //get the string length
if (1==l)return 1;
 
for(int x=0;x < l;x++,l--)
{
str[x]^=str[l];  //triple XOR Trick
str[l]^=str[x];  //for not using a temp
str[x]^=str[l];
}
return 0;
}
 
 

the error is

Linking...
asdqwe.obj : error LNK2001: unresolved external symbol "int __cdecl reverse(char *)" (?reverse@@YAHPAD@Z)
Debug/asdqwe.exe : fatal error LNK1120: 1 unresolved externals
Error executing link.exe.
 
asdqwe.exe - 2 error(s), 0 warning(s)
 

can enyone explain the error for me please and tell what to do......ASAP please!!!!!!

declare function after using namespace std;

[Alenik1989]

declare function after using namespace std;

Done that
made no differance
enything else?

[Alenik1989]

ok i got it i revised the code to

#include<iostream>
#include<cstring>
#include<fstream>
void reverseit(char array[]);
using namespace std;
int main()
{
    ifstream infile;
 
    infile.open("input.txt");
        outfile.open("output.txt");
        char name[60];
 
 
        if(infile.fail())
            cout<<"FAILED";
        else
        {
            while(!infile.eof())
            {
infile.getline(name,60);
reverseit(name);
 
            }
            }
        return 0;
}    
 
 
 
 
void reverseit(char array[])
{ 
    char c; int len, mid=0;
 
    len = strlen(array); 
    mid = (len-1)/2;
 
    for(int i=0,j=len-1; i <=mid; i++,j--)
    { c = array[i];
      array[i] = array[j];
      array[j] = c;
    }
    cout <<array<<endl;
}
 

this is working perfect but i have another problem
this code suppose to determine if the input is palindrome (original and reversed have to be the same)!!!!
programs works perfectly for words like MADAM but not for phrases like
madam, i'm adam
which it reversed is mada m'i ,madam if you ignore the spaces and punctuation while comparing it will read like madamimmadam and the original would be madamimadam...

my question is how can i ignore the punctuation and spaces when copmaring the original and reversed arrays? (can i use strcmp)!!!
TANX

[Laharl]

You can simply ignore the character if it fails a isalpha() test. isalpha can be found in <cctype>.

[Alenik1989]

ok i will try that
anyone knows whats wrong with this func

void copy(char array[],char copyarray[])
{
    strcpy(copyarray,array);
    int i=0;
  char c;
 
  while (copyarray[i])
  {
    c=copyarray[i];
    putchar (toupper(c));
    i++;
  }
}
 

it suppose to get the array and make all of its contents to upper charachters!!!!
but it repeats the original one after the upper one like when array=like
copyarray is shown as LIKElike

any ideas????

[weaknessforcats]

I can see the putchar so that explains LIKE. Now what are you doing after this functon returns?? Maybe displaying the original array??

[happyjack27]

ok i will try that
anyone knows whats wrong with this func

void copy(char array[],char copyarray[])
{
    strcpy(copyarray,array);
    int i=0;
  char c;
 
  while (copyarray[i])
  {
    c=copyarray[i];
    putchar (toupper(c));
    i++;
  }
}
 

it suppose to get the array and make all of its contents to upper charachters!!!!
but it repeats the original one after the upper one like when array=like
copyarray is shown as LIKElike

any ideas????

you're making the problem overly complicated. you don't need to use strcpy or putchar. just write one character at a time to the destination array: the upper case version of the corresponding character in the source array. you want to set each character in the destination array to be the upper case version of the corresponding character in the source array, right? so write that.