a little help for string used in classes

[djm]

hello everyone, im doing a c++ coursework which consists linked lists
and use of classes. but im getting some compilation errors. can some
please help me out.

//this is the header file Definition.h
#ifndef DEFINTION_H
#define DEFINITON_H

#include <string>
using namespace std;
class Definition
{
public:
Definition(); //constructor(int ialisation)
~Definition(); //destructor

//setter methods
void setDefinition(s tring);
void setNext(Definit ion*);

//getter Methods
string getDefinition() ;
Definition* getNext();

private:
string definition;
Definition* next;
};
#endif

*************** *************** *************** *************** *************** *************** *************** ***
//and the cpp file (Definition.cpp )
#include <iostream>
#include <string>
#include "Definition .h"
using namespace std;

Definition::Def inition()
{
definition.clea r();
next = NULL;
}

Definition::~De finition()
{
}

void Definition::set Definition(stri ng d)
{
definition = d;
}
void Definition::set Next(Definition * n)
{
next = n;
}

string Definition::get Definition()
{
return definition; //*****line 29******
}

Definition* Definition::get Definition()
{
return next; //*****line 34****
}

*************** *************** *************** *************** *************** *************** *************** ***
see the problem comes when i try to compile the Definition.cpp file. i
get the following erros

Definition.cpp: 34: error: prototype for `Definition*
Definition::get Definition()
' does not match any in class `Definition'
Definition.cpp: 29: error: candidate is: std::string
Definition::get Definition()
Definition.cpp: 34: error: `Definition* Definition::get Definition()'
and `std::st
ring Definition::get Definition()' cannot be overloaded
*************** *************** *************** *************** *************** *************** *************** ****

ive only done the linked list using integer data types, so i tried the
same coding for string. please forgive me if ive done any stupid
things in the coding.
please help me out
thanks!

[Jim Langston]

"djm" <dj*******@gmai l.comwrote in message
news:11******** **************@ i13g2000prf.goo glegroups.com.. .

hello everyone, im doing a c++ coursework which consists linked lists
and use of classes. but im getting some compilation errors. can some
please help me out.

//this is the header file Definition.h
#ifndef DEFINTION_H
#define DEFINITON_H

#include <string>
using namespace std;
class Definition
{
public:
Definition(); //constructor(int ialisation)
~Definition(); //destructor

//setter methods
void setDefinition(s tring);
void setNext(Definit ion*);

//getter Methods
string getDefinition() ;
Definition* getNext();

private:
string definition;
Definition* next;
};
#endif

*************** *************** *************** *************** *************** *************** *************** ***
//and the cpp file (Definition.cpp )

[SNIP]

string Definition::get Definition()
{
return definition; //*****line 29******
}

Definition* Definition::get Definition()
{
return next; //*****line 34****
}

You have 2 functions getDefinition both accepting no paramater. VC++
describes the problem a little differnent.

'Definition *Definition::ge tDefinition(voi d)' : overloaded function differs
only by return type from 'std::string Definition::get Definition(void )'

You can't overload a functioion only be return type. The parameters have to
be different. So maybe rename the 2nd one to:
Definition* Definition::get NextDefinition( )

then it would compile since you wouldn't be trying to overload the same
function name.

[Barry]

djm wrote:

hello everyone, im doing a c++ coursework which consists linked lists
and use of classes. but im getting some compilation errors. can some
please help me out.

//this is the header file Definition.h
#ifndef DEFINTION_H
#define DEFINITON_H

#include <string>
using namespace std;
class Definition
{
public:
Definition(); //constructor(int ialisation)
~Definition(); //destructor

//setter methods
void setDefinition(s tring);
void setNext(Definit ion*);

//getter Methods
string getDefinition() ;
Definition* getNext();

private:
string definition;
Definition* next;
};
#endif

*************** *************** *************** *************** *************** *************** *************** ***
//and the cpp file (Definition.cpp )
#include <iostream>
#include <string>
#include "Definition .h"
using namespace std;

Definition::Def inition()
{
definition.clea r();
next = NULL;
}

Definition::~De finition()
{
}

void Definition::set Definition(stri ng d)
{
definition = d;
}
void Definition::set Next(Definition * n)
{
next = n;
}

string Definition::get Definition()
{
return definition; //*****line 29******
}

Definition* Definition::get Definition()

Definition* Definition::get Next()

{
return next; //*****line 34****
}

[djm]

On Oct 13, 12:55 pm, "Jim Langston" <tazmas...@rock etmail.comwrote :

"djm" <djmlog...@gmai l.comwrote in message

news:11******** **************@ i13g2000prf.goo glegroups.com.. .

hello everyone, im doing a c++ coursework which consists linked lists
and use of classes. but im getting some compilation errors. can some
please help me out.

//this is the header file Definition.h
#ifndef DEFINTION_H
#define DEFINITON_H

#include <string>
using namespace std;
class Definition
{
public:
Definition(); //constructor(int ialisation)
~Definition(); //destructor

//setter methods
void setDefinition(s tring);
void setNext(Definit ion*);

//getter Methods
string getDefinition() ;
Definition* getNext();

private:
string definition;
Definition* next;
};
#endif

*************** *************** *************** *************** *************** *************** *************** ***
//and the cpp file (Definition.cpp )

[SNIP]

string Definition::get Definition()
{
return definition; //*****line 29******
}
Definition* Definition::get Definition()
{
return next; //*****line 34****
}

You have 2 functions getDefinition both accepting no paramater. VC++
describes the problem a little differnent.

'Definition *Definition::ge tDefinition(voi d)' : overloaded function differs
only by return type from 'std::string Definition::get Definition(void )'

You can't overload a functioion only be return type. The parameters have to
be different. So maybe rename the 2nd one to:
Definition* Definition::get NextDefinition( )

then it would compile since you wouldn't be trying to overload the same
function name.

thanks Jim. i see the careless mistake ive done. now the program works
perfect..
thanks for your help. i really appreciate it.

[djm]

On Oct 13, 1:16 pm, Barry <dhb2...@gmail. comwrote:

djm wrote:

hello everyone, im doing a c++ coursework which consists linked lists
and use of classes. but im getting some compilation errors. can some
please help me out.

//this is the header file Definition.h
#ifndef DEFINTION_H
#define DEFINITON_H

#include <string>
using namespace std;
class Definition
{
public:
Definition(); //constructor(int ialisation)
~Definition(); //destructor

//setter methods
void setDefinition(s tring);
void setNext(Definit ion*);

//getter Methods
string getDefinition() ;
Definition* getNext();

private:
string definition;
Definition* next;
};
#endif

*************** *************** *************** *************** *************** *************** *************** ***
//and the cpp file (Definition.cpp )
#include <iostream>
#include <string>
#include "Definition .h"
using namespace std;

Definition::Def inition()
{
definition.clea r();
next = NULL;
}

Definition::~De finition()
{
}

void Definition::set Definition(stri ng d)
{
definition = d;
}

void Definition::set Next(Definition * n)
{
next = n;
}

string Definition::get Definition()
{
return definition; //*****line 29******
}

Definition* Definition::get Definition()

Definition* Definition::get Next()

{
return next; //*****line 34****
}

thanks for pointing out the mistake.
the program compiles without any errors now. :D

[=?UTF-8?B?RXJpayBXaWtzdHLDtm0=?=]

On 2007-10-13 09:23, djm wrote:

hello everyone, im doing a c++ coursework which consists linked lists
and use of classes. but im getting some compilation errors. can some
please help me out.

//this is the header file Definition.h
#ifndef DEFINTION_H
#define DEFINITON_H

#include <string>
using namespace std;

Never use "using namespace std;" in a header-file, it will come back and
bite you with hard to diagnose errors later since ny file that includes
this header will then be influenced by the using directive.

class Definition
{
public:
Definition(); //constructor(int ialisation)
~Definition(); //destructor

//setter methods
void setDefinition(s tring);
void setNext(Definit ion*);

//getter Methods
string getDefinition() ;
Definition* getNext();

private:
string definition;
Definition* next;
};
#endif

*************** *************** *************** *************** *************** *************** *************** ***
//and the cpp file (Definition.cpp )
#include <iostream>
#include <string>
#include "Definition .h"
using namespace std;

Definition::Def inition()
{
definition.clea r();

You do not have to call clear, the string will be empty on creation.

next = NULL;
}

Definition::~De finition()
{

I do not know exactly how your liked list is supposed to work, but you
might want to have "delete next;" here to prevent any memory leaks.

}

void Definition::set Definition(stri ng d)
{
definition = d;
}
void Definition::set Next(Definition * n)
{
next = n;

What happens if next already points to some object? You might want to
"delete next;" before the assignment to prevent memory leaks.

}

string Definition::get Definition()
{
return definition; //*****line 29******
}

Definition* Definition::get Definition()

Definition* Definition::get Next()

{
return next; //*****line 34****
}

--
Erik Wikström

[Duane Hebert]

"djm" <dj*******@gmai l.comwrote in message
news:11******** **************@ i13g2000prf.goo glegroups.com.. .

hello everyone, im doing a c++ coursework which consists linked lists
and use of classes. but im getting some compilation errors. can some
please help me out.

//this is the header file Definition.h
#ifndef DEFINTION_H
#define DEFINITON_H

#include <string>
using namespace std;

When you put this in a header file
everyone using your header is now using
namespace std. Sort of defeats the
purpose. You should lose points for that <g>