Whitespace separating lines using extraction operator on file

[Kevin Grigorenko]

Okay, i've got a file open, call it infile. I've got a simple while(!eof),
but say the first line of my file is "<?xml version="1.0">" , then it takes
two iterations to get the string. first 'line' is "<?xml", then 'line' is
"version="1.0"" , what's happening that I need to change the behavior of so
that I can get lines delimitted by the newlines in the file?

std::string line;
std::ifstream infile("whateve r.txt", std::ios_base:: in);
while(!infile.e of())
{
infile >> line;
std::cout << line << std::endl;
line = "";
}
infile.close();

Thanks for your time,
Kevin Grigorenko

[Buster]

"Kevin Grigorenko" <kz****@psu.edu > wrote

Okay, i've got a file open, call it infile. I've got a simple while(!eof),
but say the first line of my file is "<?xml version="1.0">" , then it takes
two iterations to get the string. first 'line' is "<?xml", then 'line' is
"version="1.0"" , what's happening that I need to change the behavior of so
that I can get lines delimitted by the newlines in the file?

This is covered in the FAQ. Good luck.

Regards,
Buster

[Kevin Grigorenko]

"Buster" <no***@nowhere. com> wrote in message
news:bk******** **@news6.svr.po l.co.uk...

"Kevin Grigorenko" <kz****@psu.edu > wrote

Okay, i've got a file open, call it infile. I've got a simple while(!eof), but say the first line of my file is "<?xml version="1.0">" , then it takes two iterations to get the string. first 'line' is "<?xml", then 'line' is "version="1.0"" , what's happening that I need to change the behavior of so that I can get lines delimitted by the newlines in the file?

This is covered in the FAQ. Good luck.

Regards,
Buster

It's fine to point out laziness, but you could have at minimum just given me
some section to look at. Every question on this forum has been answered
somewhere on the internet at some point in time, but searching is painful
and tedious, that's why people ask the same questions over and over again in
newsgroups - it saves time. I don't have the time I once had when I was a
teenager, so I try to elicit the help of the nice people in forums. So
please in the future do not just tell people "That is covered somewhere.
Good luck." That is a pretty ridiculous and obvious answer.

I will look at the FAQ as per your suggestion and hope that someone else
with a little bit more sympathy will reply in that timeframe and point me to
a more discrete direction.

Kevin Grigorenko

[Buster]

"Kevin Grigorenko" <kz****@psu.edu > wrote

It's fine to point out laziness I didn't say that.
but you could have at minimum just given me
some section to look at. OK.
http://www.parashift.com/c++-faq-lit...t.html#faq-5.5
Every question on this forum has been answered
somewhere on the internet at some point in time, but searching is painful
and tedious. So I should do it for you?
that's why people ask the same questions over and over again in
newsgroups - it saves time. Their time.
I don't have the time I once had when I was a
teenager, so I try to elicit the help of the nice people in forums. So
please in the future do not just tell people "That is covered somewhere.
Good luck." That is a pretty ridiculous and obvious answer. Obvious, yes. Ridiculous, no.
I will look at the FAQ as per your suggestion and hope that someone else
with a little bit more sympathy will reply in that timeframe and point me to
a more discrete direction.

And just maybe, the next person I help won't be gratuitously rude to me, again.
I don't hold out much hope though.

Again, good luck.
Buster.

[Rob Williscroft]

Kevin Grigorenko wrote in news:bk******** **@f04n12.cac.p su.edu:

Okay, i've got a file open, call it infile. I've got a simple
while(!eof), but say the first line of my file is "<?xml
version="1.0">" , then it takes two iterations to get the string.
first 'line' is "<?xml", then 'line' is "version="1.0"" , what's
happening that I need to change the behavior of so that I can get
lines delimitted by the newlines in the file?

std::string line;
std::ifstream infile("whateve r.txt", std::ios_base:: in);
Don't use eof(), it only reports true when a get operation actually
encounters the EOF.
while(!infile.e of())
{
This read's space delimited token's try std::getline.
infile >> line; std::cout << line << std::endl;
line = "";
}
infile.close();

while ( std::getline( infile, line ) )
{
std::cout << line << std::endl;
}

This loop will terminate on any stream error.

HTH

Rob.
--
http://www.victim-prime.dsl.pipex.com/

[Kevin Goodsell]

Kevin Grigorenko wrote:

It's fine to point out laziness, but you could have at minimum just given me
some section to look at.
There is a section specifically about I/O. You could start there.

Here's something in particular you should look at:

http://www.parashift.com/c++-faq-lit....html#faq-15.5
Every question on this forum has been answered
somewhere on the internet at some point in time, but searching is painful
and tedious, that's why people ask the same questions over and over again in
newsgroups - it saves time.
No, it wastes time. You can often get an answer more quickly from the
FAQ than from the group. Besides that, what about the time of the
hundreds of people reading the group? The FAQ is there to save everyone
time.
I don't have the time I once had when I was a
teenager, so I try to elicit the help of the nice people in forums. So
please in the future do not just tell people "That is covered somewhere.
Good luck." That is a pretty ridiculous and obvious answer.
Please in the future read the FAQ before posting. That's basic
Netiquette. (Honestly, I don't expect people to read the whole thing...
it's quite long. But you should at least try to locate your answer there
first.)

I will look at the FAQ as per your suggestion and hope that someone else
with a little bit more sympathy will reply in that timeframe and point me to
a more discrete direction.

I can't actually find the exact entry right now. What you want is

std::getline(in file, line);

But you should rewrite your loop like this (as the FAQ entry I linked
above indicates):

while (std::getline(i nfile, line))
{
// ...
}

-Kevin
--
My email address is valid, but changes periodically.
To contact me please use the address from a recent posting.

[Kevin Grigorenko]

"Buster" <no***@nowhere. com> wrote in message
news:bk******** **@newsg3.svr.p ol.co.uk...

"Kevin Grigorenko" <kz****@psu.edu > wrote

It's fine to point out laziness I didn't say that.

but you could have at minimum just given me
some section to look at.

OK.
http://www.parashift.com/c++-faq-lit...t.html#faq-5.5

And because Marshall Cline has written so, it must be true. "It's the old
give-them-a-fish vs. teach-them-to-fish problem." - My question is neither
extremely obvious/trivial, i.e. "What is a class?", nor is it something that
anyone could possibly say is something that needs in-depth study ..... it
just needs an answer to keep my project rolling - What's so hard about just
giving the answer sometimes? If you knew it was in the FAQ, then you
probably know that answer just as much.

Every question on this forum has been answered
somewhere on the internet at some point in time, but searching is painful and tedious. So I should do it for you?

that's why people ask the same questions over and over again in
newsgroups - it saves time.

Their time.

I don't have the time I once had when I was a
teenager, so I try to elicit the help of the nice people in forums. So
please in the future do not just tell people "That is covered somewhere.
Good luck." That is a pretty ridiculous and obvious answer.

Obvious, yes. Ridiculous, no.

I will look at the FAQ as per your suggestion and hope that someone else
with a little bit more sympathy will reply in that timeframe and point me to a more discrete direction.

And just maybe, the next person I help won't be gratuitously rude to me,

again. I don't hold out much hope though.
Who in this case did you actually "help?" By you saying go the FAQ you
actually think you've helped me?

Again, good luck.
Buster.

It is also quite interesting that whenever someone like myself makes these
kinds of comments, people like yourself always reply as you have above, even
though the reason they might have given a response as the first one that you
gave is to "improve the signal-to-noise ratio." This sure looks like a lot
of noise to me?!

If you had just replied with the answer in a concise fassion, this thread
would have been long out of anyone's mind.

Ridiculous... yes.

Kevin Grigorenko

[Buster Copley]

Kevin Grigorenko wrote:

It is also quite interesting that whenever someone like myself makes these
kinds of comments, people like yourself always reply as you have above, even
though the reason they might have given a response as the first one that you
gave is to "improve the signal-to-noise ratio." This sure looks like a lot
of noise to me?!

That's really interesting. Do go on.

[Jon Bell]

In article <bk**********@f 04n12.cac.psu.e du>,
Kevin Grigorenko <kz****@psu.edu > wrote:

Okay, i've got a file open, call it infile. I've got a simple while(!eof),
but say the first line of my file is "<?xml version="1.0">" , then it takes
two iterations to get the string. first 'line' is "<?xml", then 'line' is
"version="1.0" ", what's happening that I need to change the behavior of so
that I can get lines delimitted by the newlines in the file?

std::string line;
std::ifstrea m infile("whateve r.txt", std::ios_base:: in);
while(!infile. eof())
{
infile >> line;
Change the line above to

std::getline (infile, line);
std::cout << line << std::endl;
line = "";
}
infile.close() ;

Also, testing eof() directly in a while loop is almost never correct.
It becomes true only after you have tried and failed to read past the end
of file. In your loop, after you've read the last line, eof() will still
be false, so you go around the loop one more time and try to read again.
This makes eof() true, finally, but it also "reads" an extra garbage line.

It's better to test the input expression directly as the loop condition.
In a boolean context, it evaluates as true if the input succeeded, and
false if it failed:

while (std::getline (infile, line))
{
std::cout << line << std::endl;
}

There's no need to clear the line after you output it, because getline()
will clear the existing contents anyway.

--
Jon Bell <jt*******@pres by.edu> Presbyterian College
Dept. of Physics and Computer Science Clinton, South Carolina USA

[Kevin Grigorenko]

"Rob Williscroft" <rt*@freenet.RE MOVE.co.uk> wrote in message
news:Xn******** *************** **********@195. 129.110.130...

Kevin Grigorenko wrote in news:bk******** **@f04n12.cac.p su.edu:

Okay, i've got a file open, call it infile. I've got a simple
while(!eof), but say the first line of my file is "<?xml
version="1.0">" , then it takes two iterations to get the string.
first 'line' is "<?xml", then 'line' is "version="1.0"" , what's
happening that I need to change the behavior of so that I can get
lines delimitted by the newlines in the file?

std::string line;
std::ifstream infile("whateve r.txt", std::ios_base:: in);

Don't use eof(), it only reports true when a get operation actually
encounters the EOF.

while(!infile.e of())
{

This read's space delimited token's try std::getline.

infile >> line;

std::cout << line << std::endl;
line = "";
}
infile.close();

while ( std::getline( infile, line ) )
{
std::cout << line << std::endl;
}

This loop will terminate on any stream error.

HTH

Rob.
--
http://www.victim-prime.dsl.pipex.com/

Thanks. Following the loop, how would I know if there was an error or if
the loop exitted simply because of completion? Would checking infile.eof()
tell me whether it got to the end or not, and if infile.eof() is false, can
I assume there was some kind of stream error?

Thanks,
Kevin Grigorenko