K&R2, section1.6, exercise 1-13

[arnuld]

this programme runs without any error but it does not do what i want
it to do:

------------- PROGRAMME --------------
/* K&R2, section 1.6 Arrays; Exercise 1-13.

STATEMENT:
Write a program to print a histogram of the lengths of words in its
input.
It is easy to draw the histogram with the bars horizontal; a vertical
orientation is more challenging.
Method:

1.) we will store lenth of each wordn an array.
2.) for keeping simplicity, array size is 1000, i.e.
it can hold only 1000 words.
3.) after EOF is encountered then the "a Hostogram of starts ( * )
"will be
printed on the screen.

4.) each line of histogram will contain number of "stars" == length
of that word.

*/

#include <stdio.h>

#define IN 1
#define OUT 0
#define MAXWORDS 1000

int main()
{
int c;
int i = 0;
int aindex = 0;
int j = 0; /* "i,j,count" are general index counters */

int nc = 0; /* length of word or number of characters in a word */

int lwords[MAXWORDS + 1];

int nw = 0; /* number of words */

/* length of each word is stored in this array
and will be printed in the end */

int state = IN;

while( ((c = getchar()) != EOF) && (nw <= MAXWORDS) )
{
++nc;

if(c == ' ' || c == '\t' || c == '\n')
{
state = OUT;
--nc;
}

else if(state == OUT)
{
lwords[aindex++] = nc;
++nw;
state = IN;
}

}

printf("---------- printing HISTOGRAM -----------\n");

for(i = 0; i < aindex; ++i)
{
for(j = 0; j < lwords[i]; ++j)
putchar('*');

putchar('\n');
}

return 0;
}
------------- OUTPUT ---------------
[arch@voodo kr2]$ gcc -std=c99 -pedantic -Wall -Wextra ex_1-13.c
[arch@voodo kr2]$ ./a.out
like
---------- printing HISTOGRAM -----------
[arch@voodo kr2]$

[user923005]

I don't recall if you are supposed to have access to ispunct() and
isspace() by that point in the book (K&R2 1.6) or not. Functions
isn't until 1.7 but we have been using some of the library functions
right from the get-go. But for a word counter, they (the is*()
functions and strtok()) seem like natural tools. Also, the evil and
cantankerous strtok() can be used.

A simple way to start might be to use the previous incarnation of the
word-count program on page 20.

[arnuld]

On Mar 21, 11:42 am, "user923005 " <dcor...@connx. comwrote:

I don't recall if you are supposed to have access to ispunct() and
isspace() by that point in the book (K&R2 1.6) or not. Functions
isn't until 1.7 but we have been using some of the library functions
right from the get-go. But for a word counter, they (the is*()
functions and strtok()) seem like natural tools. Also, the evil and
cantankerous strtok() can be used.

you are using some really STRANGE words like "strtok".

A simple way to start might be to use the previous incarnation of the
word-count program on page 20.

my code *is* the modified-reincarnation of that programme. without
this modification, it does not work

[Gawain]

Change the code like this, maybe you can get you want.

if(c == ' ' || c == '\t' || c == '\n')
{
state = OUT;
--nc;
}
if(state == OUT)
{
lwords[aindex++] = nc;
++nw;
state = IN;
nc = 0;
}

[arnuld]

On Mar 21, 1:27 pm, "Gawain" <xia...@gmail.c omwrote:

Change the code like this, maybe you can get you want.

if(c == ' ' || c == '\t' || c == '\n')
{
state = OUT;
--nc;
}

if(state == OUT)
{
lwords[aindex++] = nc;
++nw;
state = IN;
nc = 0;
}

actually i did that just 2 second before i saw your post :-)

but it does not work :-(. i will try more after Lunch.

see you after Lunch....

[p_cricket_guy]

On Mar 21, 1:30 pm, "arnuld" <geek.arn...@gm ail.comwrote:

On Mar 21, 1:27 pm, "Gawain" <xia...@gmail.c omwrote:

Change the code like this, maybe you can get you want.

if(c == ' ' || c == '\t' || c == '\n')
{
state = OUT;
--nc;
}

if(state == OUT)
{
lwords[aindex++] = nc;
++nw;
state = IN;
nc = 0;
}

actually i did that just 2 second before i saw your post :-)

but it does not work :-(. i will try more after Lunch.

see you after Lunch....

That should work .. Gawain has suggested two changes:
1. "else if" changed to "if"
2. assign "nc = 0" under the above condition.

Did you try with both these changes ?

PS: My apologies if this post does not appear properly.
Right now, my google interface is not displaying the
cursor as I type :-(

[arnuld]

On Mar 21, 2:24 pm, p_cricket_...@y ahoo.co.in wrote:

That should work .. Gawain has suggested two changes:

1. "else if" changed to "if"

SORRY, i overlooked "if". i thought it was same as my code "else if".

2. assign "nc = 0" under the above condition.

i did that with "else if" and it did not work.

Did you try with both these changes ?

with this code changed to "if" and "nc = 0". it works :-) except of a
problem. here is the output:

[arch@voodo kr2]$ ./a.out
like---------- printing HISTOGRAM -----------
[arch@voodo kr2]$ ./a.out
like
---------- printing HISTOGRAM -----------
****
[arch@voodo kr2]$ ./a.out
like this about a
---------- printing HISTOGRAM -----------
****
****

*****
*
[arch@voodo kr2]$
it produces extra "newlines" for "tabs" entered.

how can i make it consistent ?

PS: My apologies if this post does not appear properly.
Right now, my google interface is not displaying the
cursor as I type :-(

i thought i was the only one who is facing this weired problem. i got
company now :-)

[arnuld]

i checked the solution at this page:

http://clc-wiki.net/wiki/K%26R2_solu..._1:Exercise_13

it is way-way complicated for me to understand.

any help ?

[Richard Heathfield]

arnuld said:

i checked the solution at this page:

http://clc-wiki.net/wiki/K%26R2_solu..._1:Exercise_13

it is way-way complicated for me to understand.

any help ?

Which part don't you understand?

--
Richard Heathfield
"Usenet is a strange place" - dmr 29/7/1999
http://www.cpax.org.uk
email: rjh at the above domain, - www.

[arnuld]

On Mar 21, 6:16 pm, Richard Heathfield <[e-mail].i nvalidwrote:

Which part don't you understand?

nearly, 90% of the solution. it is weired, something like a "syntax-
mess". i will ask in parts:

1.) what exactly these variables are doing:

long lengtharr[MAXWORDLEN + 1]; /* i know this is an array */
int firstletter = 1;
long thisval = 0;
long maxval = 0;
int thisidx = 0;
int done = 0;

2.) what is this code doing:

if(wordlen 0) /* i know what this line is doing */
{
thisval = ++lengtharr[wordlen - 1];
if(thisval maxval)
{
maxval = thisval;