C ++ Shuffling a deck of 52 cards, and handing 5 cards to 2 players

[JayP]

I'm trying to shuffle a deck of card in C ++, with out having the same card twice. And I'm supposed to give each player 5 cards. And if they want, they can replace 3 cards. Right now I can assign 5 cards to each player, but some of the cards repeat themselces (ex. I have 3 Ace of spades, or 2 king of clubs, etc). Can anyone help me fix this problem. Here is what I have so far.

#include <iostream> 
#include <ctime> 
#include <cstdlib>
#include <cmath>
 
 
using namespace std;
using std::cout;
using std::strncpy;
 
//int random;
 
int main() 
{ 
   srand((unsigned)time(0));
 
    string  heart[] =  {"A\3","2\3","3\3","4\3","5\3","6\3","7\3","8\3","9\3","10\3","J\3","Q\3","K\3"};
    string diamond[] = {"A\4","2\4","3\4","4\4","5\4","6\4","7\4","8\4","9\4","10\4","J\4","Q\4","K\4"};
    string  club[] =   {"A\5","2\5","3\5","4\5","5\6","6\5","7\5","8\5","9\5","10\5","J\5","Q\5","K\5"};
    string spade[] =   {"A\6","2\6","3\6","4\6","5\6","6\6","7\6","8\6","9\6","10\6","J\6","Q\6","K\6"};
 
 
    string general[52] ; //= new string[52];
    int k=0;
 
        for(int j = 0; j <= 12; j++)
        {
              general [k++] = heart[rand()% 12];
              general [k++] = diamond[rand()% 12];
              general [k++] = club[rand()% 12];
              general [k++] = spade[rand()% 12];
        }
 
 
  int id1, id2;  
  string temp;
  for (int i = 0; i < 100; i++ )
  {
      id1 = rand()%52;
      id2 = rand()%52;
      if(id1!=id2)
      {
      temp = general[id1];
      general[id1] = general[id2];
      general[id2] = temp;
      }
 
 }
 for(int i=0; i<52; i++)
 {
 
cout<< general[i]<<"  ";
}
cout << endl;
 
 
int currentId = 1;
string player1 [5];
string player2 [5];
int currentindex =0;
for (int p = 0; p < 5; p++)
    {
 
         player1 [p] = general [currentindex]; // picks the 0th,2nd,4th,6th,8th elements
 
         player2 [p] = general [currentId]; // picks the 1st,3rd,5th,7th,9th elements 
         currentindex = currentindex + 2;
         currentId = currentId +2;
    }
 
    for (int z = 0;z < 5;z++)
    {
    cout << player1[z] <<endl;
}
cout <<"-------------------------------"<<endl;    
 
for (int t = 0; t< 5; t++)
cout <<player2[t]<<endl;
 
 
 
system("pause");
 
 return 0;
}

[DeMan]

There are many approaches to this problem.....

One would be to "empty" an arrays value once it has been chosen, and set a loop around the random number generator which only exits when it finds an non-empty spot. This can, however be a little tedious and expensive.

ANother idea, might be to have a list where you keep all of the cards in some order (point to the array entry you want from the element in the list). As you choose a random card, remove it from the list, and alter your random number generator to choose a random number over the size of the reamining list eg:

if I have 10 elements in a list
Then rand % 10 and remove the element.

I now have nine elements in the list so rand % 9

etc.

[Ganon11]

If you can use classes, I would recommend making a Card class to hold the suit and value, and a Deck class to hold 52 cards. You can write functions in the Deck class to select a card from the top of the deck and remove that card from the current list of cards - this will guarantee that you on't get a repeat of a card.

[Savage]

I'm trying to shuffle a deck of card in C ++, with out having the same card twice. And I'm supposed to give each player 5 cards. And if they want, they can replace 3 cards. Right now I can assign 5 cards to each player, but some of the cards repeat themselces (ex. I have 3 Ace of spades, or 2 king of clubs, etc). Can anyone help me fix this problem. Here is what I have so far.

#include <iostream> 
#include <ctime> 
#include <cstdlib>
#include <cmath>
 
 
using namespace std;
using std::cout;
using std::strncpy;
 
//int random;
 
int main() 
{ 
   srand((unsigned)time(0));
 
    string  heart[] =  {"A\3","2\3","3\3","4\3","5\3","6\3","7\3","8\3","9\3","10\3","J\3","Q\3","K\3"};
    string diamond[] = {"A\4","2\4","3\4","4\4","5\4","6\4","7\4","8\4","9\4","10\4","J\4","Q\4","K\4"};
    string  club[] =   {"A\5","2\5","3\5","4\5","5\6","6\5","7\5","8\5","9\5","10\5","J\5","Q\5","K\5"};
    string spade[] =   {"A\6","2\6","3\6","4\6","5\6","6\6","7\6","8\6","9\6","10\6","J\6","Q\6","K\6"};
 
 
    string general[52] ; //= new string[52];
    int k=0;
 
        for(int j = 0; j <= 12; j++)
        {
              general [k++] = heart[rand()% 12];
              general [k++] = diamond[rand()% 12];
              general [k++] = club[rand()% 12];
              general [k++] = spade[rand()% 12];
        }
 
 
  int id1, id2;  
  string temp;
  for (int i = 0; i < 100; i++ )
  {
      id1 = rand()%52;
      id2 = rand()%52;
      if(id1!=id2)
      {
      temp = general[id1];
      general[id1] = general[id2];
      general[id2] = temp;
      }
 
 }
 for(int i=0; i<52; i++)
 {
 
cout<< general[i]<<"  ";
}
cout << endl;
 
 
int currentId = 1;
string player1 [5];
string player2 [5];
int currentindex =0;
for (int p = 0; p < 5; p++)
    {
 
         player1 [p] = general [currentindex]; // picks the 0th,2nd,4th,6th,8th elements
 
         player2 [p] = general [currentId]; // picks the 1st,3rd,5th,7th,9th elements 
         currentindex = currentindex + 2;
         currentId = currentId +2;
    }
 
    for (int z = 0;z < 5;z++)
    {
    cout << player1[z] <<endl;
}
cout <<"-------------------------------"<<endl;    
 
for (int t = 0; t< 5; t++)
cout <<player2[t]<<endl;
 
 
 
system("pause");
 
 return 0;
}

You need to implement a do while loop in your for loop for generarting cards.the loop shoul serch your's arrays and reapet it self if the same card is generated

It should be like:

int card_type[12];
do{
            k=0;
            for(int j = 0; j <= 12; j++)
            {
                  card_type[j] = rand()%12;
                  general [k++] = heart[card_type[j]];
                  general [k++] = diamond[card_type[j]];
                  general [k++] = club[card_type[j]];
                  general [k++] = spade[card_type[j]];
             }  
 
     }while( card_type[0]==card_type[1] ............);

Savage