warning: passing arg 1 of `fopen' makes pointer from integer without a cast

[mrmattborja]

Hello,

Here is a program I'm playing around with for fun in the process of learning C. The objective is to create a function

filesize()

and call it from within the

main()

section to retrieve the size in bytes of a file that I give it.

#include <stdio.h>
 
long filesize(f)
{
        FILE *fp;
        if((fp = fopen(f, "r")) == NULL)
        {
                printf("unable to open %s\n", f);
                exit(1);
        }
        fseek(fp, 0, SEEK_END);
        long filesize = ftell(fp);
        rewind(fp);
        fclose(fp);
        return(filesize);
}
 
int main(int argc, char *argv[])
{
        if(argc < 2)
        {
                printf("usage: %s <logfile>\n", argv[0]);
                exit(1);
        }
        long fsize = filesize(argv[1]);
 
        FILE *fp;
        if((fp = fopen(argv[1], "r")) == NULL)
        {
                printf("unable to open %s\n", argv[1]);
                exit(1);
        }
        printf("filesize of %s: %d bytes\n", argv[1], fsize);
 
        fclose(fp);
        return 0;
}
 

Everything compiles just fine except for one annoying little warning I keep getting in reference to the file handle I'm trying to open in the

filesize()

function. When I go to compile the program, it gives me this error:

log.c: In function `filesize':
log.c:6: warning: passing arg 1 of `fopen' makes pointer from integer without a cast

I'm wondering if it's possible to eliminate that warning by making whatever change is necessary. The two lines that I'm aiming to make possible by declaring this particular function are as follows:

long fsize = filesize(argv[1]);
printf("filesize of %s: %d bytes\n", argv[1], fsize);
 

Any help would be appreciated! The program will still compile and run just fine, but it'd be nice to compile and not have to see that warning.

By the way, I'm only interested in programming in C at this time.

[mrmattborja]

Ah, nevermind, I found it.

#include <stdio.h>
 
long filesize(char f[])
{
...
 

Should've seen it before :-P

[Ganon11]

Good to see you got it on your own. :)

[mrmattborja]

Here's my new function...head er include even!

/* filesize.h - returns size in bytes of filename */
long filesize(char f[])
{
        FILE *fp;
        if((fp = fopen(f, "r")) == NULL)
        {
                fprintf(stderr, "failed to open %s\n", f);
                exit(1);
        }
        fseek(fp, 0, SEEK_END);
        long filesize = ftell(fp);
        fclose(fp);
        return(filesize);
}