easy pointers to functions problem

[Michael]

Hi,

I am trying to get an idea of how function pointers work.
I have the following:

#include <stdio.h>

void do_stuff(int*,i nt,void*);
void getInt(int*);
void showInt(int*);

int main(){

int num_array[10];

do_stuff(num_ar ray, 10, getInt);
do_stuff(num_ar ray, 10, showInt);

return(0);
}

void do_stuff(int *a, int size, void (*process)(int *)){
int i;
for(i = 0; i < size; i++){
process(&a[i]);
}
}

void getInt(int *ptr){
if((scanf("%d", ptr)) != 1){
printf("error") ;

}
}

void showInt(int *ptr){
printf("%d", *ptr);
}

but I get errors "conficting types for do_stuff" and also warnings "ISO C
forbids passing of arg3 of do_stuff between pointer and void *"

I'm getting nowhere fast here. Can someone help me out with what I have
wrong?

Thanks

Michael

[lovecreatesbeauty]

Michael wrote:

#include <stdio.h>

void do_stuff(int*,i nt,void*);

void do_stuff(int *a, int size, void (*process)(int *));

<snip>

void do_stuff(int *a, int size, void (*process)(int *)){
int i;

<snip>

[Flash Gordon]

Michael wrote:

Hi,

I am trying to get an idea of how function pointers work.
I have the following:

#include <stdio.h>

void do_stuff(int*,i nt,void*);

Here the last parameter of do_stuff is void*. void* is *not* compatible
with function pointers, only object pointers (i.e. pointers to data).
I.e. you cannot pass a function pointer as a void* parameter.

void getInt(int*);
void showInt(int*);

int main(){

If you are not using the parameters, it is better to be explicit.

int main(void) {

int num_array[10];

do_stuff(num_ar ray, 10, getInt);
do_stuff(num_ar ray, 10, showInt);

Why the magic number 10? I would use a #define for the array size, then
there is only one place to change it.

return(0);
}

void do_stuff(int *a, int size, void (*process)(int *)){

This is different to your prototype of do_stuff above, just as the
compiler told you! It is this that is correct, so change your earlier
prototype to match.

int i;
for(i = 0; i < size; i++){
process(&a[i]);
}
}

void getInt(int *ptr){
if((scanf("%d", ptr)) != 1){
printf("error") ;

You might want a /n at the end of that printf. Or use puts.

}
}

void showInt(int *ptr){
printf("%d", *ptr);
}

but I get errors "conficting types for do_stuff"

The above error is obvious. Your prototype and definition don't match.
It's a bit like you telling someone you will give them an orange and
then giving them a cricket bat, of course they will tell you that they
are different!

and also warnings "ISO C
forbids passing of arg3 of do_stuff between pointer and void *"

This is less obvious. void* is only a generic pointer to object (i.e.
data), it cannot point to functions. Imagine a system with 32bit data
pointers and 64bit function pointers. 64 does not do in to 32!
--
Flash Gordon, living in interesting times.
Web site - http://home.flash-gordon.me.uk/
comp.lang.c posting guidelines and intro:
http://clc-wiki.net/wiki/Intro_to_clc

[lovecreatesbeauty]

Flash Gordon wrote:

Michael wrote:

printf("error") ;

You might want a /n at the end of that printf. Or use puts.

Do you point to a '\n'.

[Flash Gordon]

lovecreatesbeau ty wrote:

Flash Gordon wrote:

>Michael wrote:

>> printf("error") ;

You might want a /n at the end of that printf. Or use puts.

Do you point to a '\n'.

Indeed. Thank's for the correction.
--
Flash Gordon, living in interesting times.
Web site - http://home.flash-gordon.me.uk/
comp.lang.c posting guidelines and intro:
http://clc-wiki.net/wiki/Intro_to_clc

[Michael]

"Flash Gordon" <sp**@flash-gordon.me.ukwro te in message
news:t2******** ****@news.flash-gordon.me.uk...

Michael wrote:

>Hi,

I am trying to get an idea of how function pointers work.
I have the following:

#include <stdio.h>

void do_stuff(int*,i nt,void*);

Here the last parameter of do_stuff is void*. void* is *not* compatible
with function pointers, only object pointers (i.e. pointers to data). I.e.
you cannot pass a function pointer as a void* parameter.

I thought this was where my problem was, but when I tried to declare it many
other ways
I always ended up with a syntax error.

Could you tell me how I should declare it please? In the book I am working
from none of the
function prototypes are declared, they are all just declared implicitly.....

>

>void getInt(int*);
void showInt(int*);

int main(){

If you are not using the parameters, it is better to be explicit.

int main(void) {

> int num_array[10];

do_stuff(num_ar ray, 10, getInt);
do_stuff(num_ar ray, 10, showInt);

Why the magic number 10? I would use a #define for the array size, then
there is only one place to change it.

I was aware that I had a 'magic' number here, but as I was only writing this
to try and figure out
where everything else was wrong, I didn't bother with the #define. My
appologies.

>

> return(0);
}

void do_stuff(int *a, int size, void (*process)(int *)){

This is different to your prototype of do_stuff above, just as the
compiler told you! It is this that is correct, so change your earlier
prototype to match.

> int i;
for(i = 0; i < size; i++){
process(&a[i]);
}
}

void getInt(int *ptr){
if((scanf("%d", ptr)) != 1){
printf("error") ;

You might want a /n at the end of that printf. Or use puts.

again, I don't really care about the output, I just want to get the function
pointer stuff working, but fair comment.

Thanks for the help, I really apppreciate it.

> }
}

void showInt(int *ptr){
printf("%d", *ptr);
}

but I get errors "conficting types for do_stuff"

The above error is obvious. Your prototype and definition don't match.
It's a bit like you telling someone you will give them an orange and then
giving them a cricket bat, of course they will tell you that they are
different!

and also warnings "ISO C
forbids passing of arg3 of do_stuff between pointer and void *"

This is less obvious. void* is only a generic pointer to object (i.e.
data), it cannot point to functions. Imagine a system with 32bit data
pointers and 64bit function pointers. 64 does not do in to 32!
--
Flash Gordon, living in interesting times.
Web site - http://home.flash-gordon.me.uk/
comp.lang.c posting guidelines and intro:
http://clc-wiki.net/wiki/Intro_to_clc

[Flash Gordon]

Michael wrote:

"Flash Gordon" <sp**@flash-gordon.me.ukwro te in message
news:t2******** ****@news.flash-gordon.me.uk...

>Michael wrote:

>>Hi,

I am trying to get an idea of how function pointers work.
I have the following:

#include <stdio.h>

void do_stuff(int*,i nt,void*);

Here the last parameter of do_stuff is void*. void* is *not* compatible
with function pointers, only object pointers (i.e. pointers to data). I.e.
you cannot pass a function pointer as a void* parameter.

I thought this was where my problem was, but when I tried to declare it many
other ways
I always ended up with a syntax error.

Could you tell me how I should declare it please? In the book I am working
from none of the
function prototypes are declared, they are all just declared implicitly.....

Further down you defined the function as
void do_stuff(int *a, int size, void (*process)(int *)){
/* stuff */
}

Therefore, a prototype for it would be
void do_stuff(int *a, int size, void (*process)(int *));
I.e. the only difference is it ends with a semi-colon instead of being
followed by the body of the function.

It is good that you have decided to not rely on implicit declarations,
since they do not always work properly.

<snip>

again, I don't really care about the output, I just want to get the function
pointer stuff working, but fair comment.

Thanks for the help, I really apppreciate it.

No problem. I point out more than your current problem (as do others)
because this gives you more opportunity to learn.
--
Flash Gordon, living in interesting times.
Web site - http://home.flash-gordon.me.uk/
comp.lang.c posting guidelines and intro:
http://clc-wiki.net/wiki/Intro_to_clc

[Default User]

Michael wrote:

Hi,

I am trying to get an idea of how function pointers work.
I have the following:

but I get errors "conficting types for do_stuff" and also warnings
"ISO C forbids passing of arg3 of do_stuff between pointer and void *"

I'm getting nowhere fast here. Can someone help me out with what I
have wrong?

This is one of those cases where typedefs can be useful:

<http://c-faq.com/decl/pfitypedef.html >


Brian

[lovecreatesbeauty]

Default User wrote:

This is one of those cases where typedefs can be useful:

<http://c-faq.com/decl/pfitypedef.html >

I think typedef is unuseful totally.

[Michael Wojcik]

In article <11************ *********@m79g2 000cwm.googlegr oups.com>, "lovecreatesbea uty" <lo************ ***@gmail.comwr ites:

>
Default User wrote:

This is one of those cases where typedefs can be useful:

<http://c-faq.com/decl/pfitypedef.html >

I think typedef is unuseful totally.

There is at least situation where it is the only solution: for
using certain types with the va_arg macro. va_arg requires that
if used with type T, as in va_arg(ap, T), that T* be a pointer
to an object of type T.

This doesn't work with function pointers. Given a function
pointer of type "T (*)(P)", a pointer-to-function-pointer for that
type is "T (**)(P)". "T (*)(P)*" is syntactically invalid.

So if you have a variadic function that takes arguments with
function-pointer types, you MUST use typedef in order to retrieve
those arguments. typedef works because if you create a typedef
TD for a function pointer type, then TD* is a pointer-to-function-
pointer.

Now you could wrap those function pointers in structs and pass
them that way, but that's inconvenient for the caller, and may not
be the interface you want.

--
Michael Wojcik mi************@ microfocus.com

I am a realistic background detail. -- Bruce Schneier (on his mention in
_The Da Vinci Code_)