memcpy()

[ishmael4]

hello!

i've go two structures:

--cut here--
const unsigned int max_pkg_data=50 00;

typedef struct pkg_ {
short int info;
short int size;
char data[max_pkg_data];
} pkg;

typedef struct binary_ {
char* buffer;
int size;
} binary;
--cut here--

and i cant understand, why isnt this function working:

--cut here--
void SendBinary(bina ry& sent)
{
unsigned int n=0;
for (n=0;n<sent.siz e/max_pkg_data;++ n)
{
pkg nPkg;
memcpy((void*)n Pkg.data,(void* )sent.buffer[n*max_pkg_data],max_pkg_data);
nPkg.info=0;
nPkg.size=max_p kg_data;
// tu wpisujesz swoj kod do obs³ugi binary
Form1->CC1->Socket->SendBuf((void* )&nPkg,sizeof(p kg));
}
pkg nPkg;
memcpy((void*)n Pkg.data,(void* )sent.buffer[n*max_pkg_data],max_pkg_data);
nPkg.info=0;
nPkg.size=sent. size-((n)*max_pkg_da ta);
Form1->CC1->Socket->SendBuf((void* )&nPkg,sizeof(p kg));

return;
}
--cut here--

Especcialy:
memcpy((void*)n Pkg.data,(void* )sent.buffer[n*max_pkg_data],max_pkg_data);

Gives me an Acces Violation Message? Why is it so? Anyone could help me?
--
ishmael4

[David Resnick]

ishmael4 wrote:

hello!

i've go two structures:

--cut here--
const unsigned int max_pkg_data=50 00;

typedef struct pkg_ {
short int info;
short int size;
char data[max_pkg_data];
} pkg;

typedef struct binary_ {
char* buffer;
int size;
} binary;
--cut here--

and i cant understand, why isnt this function working:

--cut here--
void SendBinary(bina ry& sent)
{
unsigned int n=0;
for (n=0;n<sent.siz e/max_pkg_data;++ n)
{
pkg nPkg;
memcpy((void*)n Pkg.data,(void* )sent.buffer[n*max_pkg_data],max_pkg_data);
nPkg.info=0;
nPkg.size=max_p kg_data;
// tu wpisujesz swoj kod do obs³ugi binary
Form1->CC1->Socket->SendBuf((void* )&nPkg,sizeof(p kg));
}
pkg nPkg;
memcpy((void*)n Pkg.data,(void* )sent.buffer[n*max_pkg_data],max_pkg_data);
nPkg.info=0;
nPkg.size=sent. size-((n)*max_pkg_da ta);
Form1->CC1->Socket->SendBuf((void* )&nPkg,sizeof(p kg));

return;
}
--cut here--

Especcialy:
memcpy((void*)n Pkg.data,(void* )sent.buffer[n*max_pkg_data],max_pkg_data);

Gives me an Acces Violation Message? Why is it so? Anyone could help me?
--
ishmael4

What makes you think that your buffer is an exactl multiple of
max_pkg_data in size? For example, suppose that buffer is 4 bytes.
You will copy those 4 bytes, but also the next 4996 bytes, which you
ought not be reading.

-David

[Eric Sosman]

ishmael4 wrote On 09/22/05 12:47,:

hello!

i've go two structures:

--cut here--
const unsigned int max_pkg_data=50 00;

typedef struct pkg_ {
short int info;
short int size;
char data[max_pkg_data];
[...]

comp.lang.c++ is down the hall to your left, just
past the vending machines.

--
Er*********@sun .com

[ishmael4]

Uzytkownik "Eric Sosman" <er*********@su n.com> napisal w wiadomosci
news:dg******** **@news1brm.Cen tral.Sun.COM...

ishmael4 wrote On 09/22/05 12:47,:

hello!

i've go two structures:

--cut here--
const unsigned int max_pkg_data=50 00;

typedef struct pkg_ {
short int info;
short int size;
char data[max_pkg_data];
[...]

comp.lang.c++ is down the hall to your left, just
past the vending machines.

--
Er*********@sun .com

why do you think its c++?

ishmael4

[ishmael4]

Uzytkownik "David Resnick" <ln********@gma il.com> napisal w wiadomosci
news:11******** **************@ g47g2000cwa.goo glegroups.com.. .
ishmael4 wrote:

hello!

i've go two structures:

--cut here--
const unsigned int max_pkg_data=50 00;

typedef struct pkg_ {
short int info;
short int size;
char data[max_pkg_data];
} pkg;

typedef struct binary_ {
char* buffer;
int size;
} binary;
--cut here--

and i cant understand, why isnt this function working:

--cut here--
void SendBinary(bina ry& sent)
{
unsigned int n=0;
for (n=0;n<sent.siz e/max_pkg_data;++ n)
{
pkg nPkg;

memcpy((void*)n Pkg.data,(void* )sent.buffer[n*max_pkg_data],max_pkg_data);
nPkg.info=0;
nPkg.size=max_p kg_data;
// tu wpisujesz swoj kod do obs³ugi binary
Form1->CC1->Socket->SendBuf((void* )&nPkg,sizeof(p kg));
}
pkg nPkg;
memcpy((void*)n Pkg.data,(void* )sent.buffer[n*max_pkg_data],max_pkg_data);
nPkg.info=0;
nPkg.size=sent. size-((n)*max_pkg_da ta);
Form1->CC1->Socket->SendBuf((void* )&nPkg,sizeof(p kg));

return;
}
--cut here--

Especcialy:

memcpy((void*)n Pkg.data,(void* )sent.buffer[n*max_pkg_data],max_pkg_data);

Gives me an Acces Violation Message? Why is it so? Anyone could help me?
--
ishmael4

What makes you think that your buffer is an exactl multiple of
max_pkg_data in size? For example, suppose that buffer is 4 bytes.
You will copy those 4 bytes, but also the next 4996 bytes, which you
ought not be reading.

-David

for (n=0;n<sent.siz e/max_pkg_data;++ n)
guarantees me that its larger than 5000?

ishamel4

[David Resnick]

ishmael4 wrote:

Uzytkownik "David Resnick" <ln********@gma il.com> napisal w wiadomosci
news:11******** **************@ g47g2000cwa.goo glegroups.com.. .
ishmael4 wrote:

hello!

i've go two structures:

--cut here--
const unsigned int max_pkg_data=50 00;

typedef struct pkg_ {
short int info;
short int size;
char data[max_pkg_data];
} pkg;

typedef struct binary_ {
char* buffer;
int size;
} binary;
--cut here--

and i cant understand, why isnt this function working:

--cut here--
void SendBinary(bina ry& sent)
{
unsigned int n=0;
for (n=0;n<sent.siz e/max_pkg_data;++ n)
{
pkg nPkg;

memcpy((void*)n Pkg.data,(void* )sent.buffer[n*max_pkg_data],max_pkg_data);
nPkg.info=0;
nPkg.size=max_p kg_data;
// tu wpisujesz swoj kod do obs³ugi binary
Form1->CC1->Socket->SendBuf((void* )&nPkg,sizeof(p kg));
}
pkg nPkg;
memcpy((void*)n Pkg.data,(void* )sent.buffer[n*max_pkg_data],max_pkg_data);
nPkg.info=0;
nPkg.size=sent. size-((n)*max_pkg_da ta);
Form1->CC1->Socket->SendBuf((void* )&nPkg,sizeof(p kg));

return;
}
--cut here--

Especcialy:

memcpy((void*)n Pkg.data,(void* )sent.buffer[n*max_pkg_data],max_pkg_data);

Gives me an Acces Violation Message? Why is it so? Anyone could help me?
--
ishmael4

What makes you think that your buffer is an exactl multiple of
max_pkg_data in size? For example, suppose that buffer is 4 bytes.
You will copy those 4 bytes, but also the next 4996 bytes, which you
ought not be reading.

-David

for (n=0;n<sent.siz e/max_pkg_data;++ n)
guarantees me that its larger than 5000?

ishamel4

The one after the loop sends the "remainder" . That one is the problem
I think. You only want to copy the actual number of bytes (which is
less
than 5000). By copying the full 5000, you are reading where you may
not
go.

-David

[Martin Ambuhl]

ishmael4 wrote what appears to be C++ (so obfuscated from the first):

hello!

i've go two structures: [...]
Since you have posted to comp.lang.c, I suppose you have a C question.
I have provided an attempt at rewriting you code into C. Could you
check that it actually conforms to your intent, modifying it so it does,
and ask your question in that context? If you meant to actually ask
about code in the byzantine language C++, that abomination has its own
newsgroup <news:comp.lang .c++>

[attempted rewrite]
#include <string.h>

#if 0
/* mha: The line */
const unsigned int max_pkg_data = 5000;
/* mha: does not create a constant. Since the typedef pkg outside
of a function requires a compile-time constant for the size of
'data', this has been replaced. */
#endif
#define MAX_PKG_DATA 5000

typedef struct
{
short int info;
short int size;
char data[MAX_PKG_DATA];
} pkg;

typedef struct
{
char *buffer;
int size;
} binary;

void SendBinary(bina ry /* mha: C++-ism '&' replaced, uses of
'sent' fixed, pointless casts
removed */ * sent)
{
unsigned int n = 0;
for (n = 0; n < (unsigned) sent->size / MAX_PKG_DATA; ++n) {
pkg nPkg;
/* mha: the following had a char (buff[n * MAX_PKG_DATA]) as the
source for the copy. Changed */
memcpy(nPkg.dat a, sent->buffer + (n * MAX_PKG_DATA),
MAX_PKG_DATA);
nPkg.info = 0;
nPkg.size = MAX_PKG_DATA;
#if 0
/* mha: no information about 'Form1' was supplied. Line
suppressed */
Form1->CC1->Socket->SendBuf(&nPk g, sizeof(pkg));
#endif
}
pkg nPkg;
/* mha: the following had a char (buff[n * MAX_PKG_DATA]) as the
source for the copy. Changed */
memcpy(nPkg.dat a, sent->buffer + (n * MAX_PKG_DATA), MAX_PKG_DATA);
nPkg.info = 0;
nPkg.size = sent->size - (n * MAX_PKG_DATA);
#if 0
/* mha: no information about 'Form1' was supplied. Line suppressed */
Form1->CC1->Socket->SendBuf(&nPk g, sizeof(pkg));
#endif

}

int main(void)
{
binary f;
SendBinary(&f);
return 0;
}
[OP's post continued]
--cut here--
const unsigned int max_pkg_data=50 00;

typedef struct pkg_ {
short int info;
short int size;
char data[max_pkg_data];
} pkg;

typedef struct binary_ {
char* buffer;
int size;
} binary;
--cut here--

and i cant understand, why isnt this function working:

--cut here--
void SendBinary(bina ry& sent)
{
unsigned int n=0;
for (n=0;n<sent.siz e/max_pkg_data;++ n)
{
pkg nPkg;
memcpy((void*)n Pkg.data,(void* )sent.buffer[n*max_pkg_data],max_pkg_data);
nPkg.info=0;
nPkg.size=max_p kg_data;
// tu wpisujesz swoj kod do obs³ugi binary
Form1->CC1->Socket->SendBuf((void* )&nPkg,sizeof(p kg));
}
pkg nPkg;
memcpy((void*)n Pkg.data,(void* )sent.buffer[n*max_pkg_data],max_pkg_data);
nPkg.info=0;
nPkg.size=sent. size-((n)*max_pkg_da ta);
Form1->CC1->Socket->SendBuf((void* )&nPkg,sizeof(p kg));

return;
}
--cut here--

Especcialy:
memcpy((void*)n Pkg.data,(void* )sent.buffer[n*max_pkg_data],max_pkg_data);

Gives me an Acces Violation Message? Why is it so? Anyone could help me?

[Eric Sosman]

ishmael4 wrote On 09/22/05 13:05,:

Uzytkownik "Eric Sosman" <er*********@su n.com> napisal w wiadomosci
news:dg******** **@news1brm.Cen tral.Sun.COM...

ishmael4 wrote On 09/22/05 12:47,:

hello!

i've go two structures:

--cut here--
const unsigned int max_pkg_data=50 00;

typedef struct pkg_ {
short int info;
short int size;
char data[max_pkg_data];
[...]

comp.lang.c++ is down the hall to your left, just
past the vending machines.

why do you think its c++?

It isn't C, and it certainly looks like some of the
bits of C++ I've seen. You're right, though: it might
not actually be C++, but rather a snippet of code in
Ada or Babbage or ... or Yoda or Zuniga. I apologize
for jumping to a conclusion: non-C-ness does not imply
C++-ness.

The non-C-ness, however, is evident. A C compiler
object to the line just before my elision, because in
C a `const' variable does not qualify as a constant
expression. A C compiler would also object to this
subsequent line

void SendBinary(bina ry& sent)

.... and I admit it's this second offense that caught my
eye first, causing me to re-examine the earlier lines
more closely, which is when I spotted the first problem.

Whatever your code is, it's not C.

--
Er*********@sun .com

[Old Wolf]

Eric Sosman wrote:

ishmael4 wrote:

"Eric Sosman":

comp.lang.c++ is down the hall to your left, just
past the vending machines.

why do you think its c++?

It isn't C, and it certainly looks like some of the
bits of C++ I've seen.

Your instincts were correct. I'm not sure why the OP
might pretend it was not C++ ...

FWIW I think the OP's problem stems from the line:

memcpy((void*)n Pkg.data,(void* )sent.buffer[n*max_pkg_data],
max_pkg_data);

because sent.buffer[X] is a char, and he's casting a char to a
pointer. He probably meant: (void *)&sent.buffer[n*max_pkg_data].

A good reason to avoid stupid casting.

BTW, I haven't bothered to check if the memcpy is actually doing
something valid and non-overlapping.

[ishmael4]

Uzytkownik "Eric Sosman" <er*********@su n.com> napisal w wiadomosci
news:dg******** **@news1brm.Cen tral.Sun.COM...

ishmael4 wrote On 09/22/05 13:05,:

Uzytkownik "Eric Sosman" <er*********@su n.com> napisal w wiadomosci
news:dg******** **@news1brm.Cen tral.Sun.COM...

ishmael4 wrote On 09/22/05 12:47,:

hello!

i've go two structures:

--cut here--
const unsigned int max_pkg_data=50 00;

typedef struct pkg_ {
short int info;
short int size;
char data[max_pkg_data];
[...]

comp.lang.c++ is down the hall to your left, just
past the vending machines.
why do you think its c++?

It isn't C, and it certainly looks like some of the
bits of C++ I've seen. You're right, though: it might
not actually be C++, but rather a snippet of code in
Ada or Babbage or ... or Yoda or Zuniga. I apologize
for jumping to a conclusion: non-C-ness does not imply
C++-ness.

The non-C-ness, however, is evident. A C compiler
object to the line just before my elision, because in
C a `const' variable does not qualify as a constant
expression. A C compiler would also object to this
subsequent line

void SendBinary(bina ry& sent)

... and I admit it's this second offense that caught my
eye first, causing me to re-examine the earlier lines
more closely, which is when I spotted the first problem.

Whatever your code is, it's not C.

U needn't have used so many words. "> void SendBinary(bina ry& sent)" as an
example is enough. Well I admit using C++, but this certain line:
"memcpy((void*) nPkg.data,(void *)sent.buffer[n*max_pkg_data],max_pkg_data); "
is in pure C, isnt it? This is the major problem. So what do I do? Shall i
start a new topic?
--
Er*********@sun .com

--
ishmael4