Where the code trouble is?

[mikelinyoho]

Regards:

Where the code trouble is?
#include <windows.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>

int main(){

char *name;
char *title;
printf( "Enter your name:");
scanf( "%s", name );
title = strcat(name,"th e Great");
printf( "Hello, %s\n", title );
return(0);
}

--------------------------------------------

thank you
may goodness be with you all

[manoj1978]

mikelinyoho wrote:

Regards:

Where the code trouble is?
#include <windows.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>

int main(){

char *name;
char *title;
printf( "Enter your name:");
scanf( "%s", name ); Name is a pointer with no memory associated.Scan f dont allocate
memory.
Change char * name to an array.Use fgets instead of scanf to avoid
overflow issues. title = strcat(name,"th e Great");
printf( "Hello, %s\n", title );
return(0);
}

--------------------------------------------

thank you
may goodness be with you all

[Alexander Fleck]

Do you get compiler errors or what?
Can you be more specific?

Alex.

[Suman]

mikelinyoho wrote:

Regards:

Where the code trouble is?
#include <windows.h>
non standard header
#include <stdio.h>
#include <stdlib.h>
Do you really need this?
#include <string.h>

#define MAXMUNCH ... /* some size big enough for you */
int main(){
int main(void){

is a tad bit better.
char *name;
char *title;
printf( "Enter your name:");
scanf( "%s", name );
Not allocated enough (any) memory -- so you're
dead hereon.

Do name = malloc( sizeof *name * MAXMUNCH ); title = strcat(name,"th e Great");
... and to add insult to injury.
printf( "Hello, %s\n", title );
return(0);
}

[Martin Ambuhl]

mikelinyoho wrote:

Regards:

Where the code trouble is?

The same as in the last 4000 posts with pointers-to-nowhere from
clueless people who refuse to check the FAQ or follow the newsgroup
before posting.

[CBFalconer]

mikelinyoho wrote:

Where the code trouble is?

#include <windows.h>
No such standard header, eliminate it.
#include <stdio.h>
#include <stdlib.h>
#include <string.h>

int main(){

char *name;
char *title;
printf( "Enter your name:");
scanf( "%s", name );
title = strcat(name,"th e Great");
printf( "Hello, %s\n", title );
return(0);
}

Don't use scanf for interactive input. Do fflush of the prompt.
Do read the action of strcat. Do assign memory space to fill. eg:

#include <stdio.h>
#include <string.h>
#define BUFSIZE 80
#define CAPTION " the Great"

int main(void) {
char name[BUFSIZE + 1 + strlen(CAPTION)];
char *p;

printf("Enter your name:);
fflush(stdout);
fgets(name, BUFSIZE, stdin);
if (p = strchr(name, '\n') *p = '\0';
strcat(name, CAPTION");
printf("Hello, %s\n", name);
return(0);
} /* not tested */

Note the test for a final \n in the input and stripping of it.

--
"If you want to post a followup via groups.google.c om, don't use
the broken "Reply" link at the bottom of the article. Click on
"show options" at the top of the article, then click on the
"Reply" at the bottom of the article headers." - Keith Thompson

[Bart C]

"mikelinyoh o" <mi*********@gm ail.com> wrote in message
news:11******** *************@z 14g2000cwz.goog legroups.com...

Regards:

Where the code trouble is?
.... char *name;
char *title;
printf( "Enter your name:");
scanf( "%s", name );
The compiler might give a warning that 'name' is not initialised.

I would have expected scanf() to give an error when 'name' was (as I
assumed) null.

It fact on my test compiler 'name' has some arbitrary value (the program
worked), and not zero.

So ideally, there should be (1) a warning (2) 'name' is best set to null
when not initialised, to avoid undefined action, and (3) scanf() should at
very least not assign to a null pointer!
title = strcat(name,"th e Great");

A space might help

Bartthe Great

[Anton Petrusevich]

CBFalconer wrote:

#define BUFSIZE 80
#define CAPTION " the Great"

int main(void) {
char name[BUFSIZE + 1 + strlen(CAPTION)];

Excuse my ignorance, but does it really work? Well, I tried it with gcc and
I see that it really works, but since when?
--
Anton Petrusevich

[Keith Thompson]

Anton Petrusevich <ca***@att-ltd.biz> writes:

CBFalconer wrote:

#define BUFSIZE 80
#define CAPTION " the Great"

int main(void) {
char name[BUFSIZE + 1 + strlen(CAPTION)];

Excuse my ignorance, but does it really work? Well, I tried it with gcc and
I see that it really works, but since when?

Variable length arrays (VLAs) are a new feature in C99, not supported
in C90. gcc has supported them (or something very similar) as an
extension for some time. It won't work with a strict C90 compiler.

<OT>
I'm a little surprised to see that gcc doesn't complain about it, even
with "-ansi -pedantic -Wall -W".
</OT>

--
Keith Thompson (The_Other_Keit h) ks***@mib.org <http://www.ghoti.net/~kst>
San Diego Supercomputer Center <*> <http://users.sdsc.edu/~kst>
We must do something. This is something. Therefore, we must do this.

[CBFalconer]

Anton Petrusevich wrote:

CBFalconer wrote:

#define BUFSIZE 80
#define CAPTION " the Great"

int main(void) {
char name[BUFSIZE + 1 + strlen(CAPTION)];

Excuse my ignorance, but does it really work? Well, I tried it with gcc and
I see that it really works, but since when?

That should really have been sizeof(CAPTION) to be portable to
C90. Then it doesn't need the +1 either.

--
Chuck F (cb********@yah oo.com) (cb********@wor ldnet.att.net)
Available for consulting/temporary embedded and systems.
<http://cbfalconer.home .att.net> USE worldnet address!