Giving the histogram a shot...

[ext_u]

Ok I thought I would try to take the program one thing at a time. (If
you remember my last post I am trying to make a histogram with data on
the size of each word)
Anways first .. I obviously need to determine what a word actually is.
I wrote this program on my own without looking at the book or any
other resource once.

#include <stdio.h>
main()
{
int c;
int nword, nother;

nword = nother = 0;

while ((c = getchar()) != EOF)
{
if (c == ' ' ¦¦ '\t' ¦¦ '\n')
++nother;
else
++nword;
}
printf("Words = %d\nOther = %d", nword, nother);
}

I am basically just trying to tell the computer anything that is not a
blank space, a tab , or a newline is a word...
BUT everytime I run the program it adds to only the nother variable.
I can't figure out why, no matter what I type. I thought I had
written this program well and I even sketched it out on paper
beforehand , hehe.

I know you guys will probably find a horribly noobish mistake , but
please remember I started learning C all of like 48 hours ago.

[Mike Wahler]

ext_u <ex***********@ hotmail.com> wrote in message
news:32******** *************** ***@posting.goo gle.com...

Ok I thought I would try to take the program one thing at a time. (If
you remember my last post I am trying to make a histogram with data on
the size of each word)
Anways first .. I obviously need to determine what a word actually is.
I wrote this program on my own without looking at the book or any
other resource once.

#include <stdio.h>
main()
int main()
{
int c;
Encouragement:

Very good. Many novices make the mistake of
defining a 'char' for getchar() to store data
in. It must be 'int' as you have it, so it
can store EOF which is not guaranteed to fit
in a char.

int nword, nother;

nword = nother = 0;
Informative:

Rather than defining and then assigning after the fact,
you can give your variable initial values at definition time:

int nword = 0;
int nother = 0;

I recommend defining only one variable per line.
The reasons for this will become evident as you progress
(essentially makes the code easier to read and maintain,
and prevents possibly 'silly' mistakes, especially when
you start to work with pointers).


while ((c = getchar()) != EOF)
{
if (c == ' ' ¦¦ '\t' ¦¦ '\n')
++nother;
else
++nword;
}
printf("Words = %d\nOther = %d", nword, nother);
}

I am basically just trying to tell the computer anything that is not a
blank space, a tab , or a newline is a word...
More encouragement:

Well, I'm sure you realize that's not the ultimate goal,
but I'm glad to see you simplify things so you can get
*something* working.
BUT everytime I run the program it adds to only the nother variable.
I can't figure out why, no matter what I type. I thought I had
written this program well and I even sketched it out on paper
beforehand , hehe.
That is a very good idea, although in this case, it doesn't
help. :-( Your problem is a misunderstandin g of operator
syntax.

I know you guys will probably find a horribly noobish mistake , but
please remember I started learning C all of like 48 hours ago.

Yes, you did make a (very common) novice mistake. Don't feel bad,
many others have done this. The problem is with your statement:

if (c == ' ' ¦¦ '\t' ¦¦ '\n')
++nother;

The comparison operator (==) takes exactly two operands.
You supplied 'c' as the 'left-hand' operand, and the
expression, ( ' ' || '\t' || '\n' ) as the 'right-hand'
operand. The 'logical or' operator (||) returns true
if either of its operands yields a nonzero (true) value.
None of ' ', '\t', or '\n' have a value of zero, so 'or-ing'
any or all of them together will always yield nonzero (true).

To express 'if c is equal to any of ' ', '\t', or '\n', you
need to express three distinct comparisons, 'or-d' together.
Write:

if (c == ' ' || c == '\t' || c == '\n')
++nother;
else
++nword;

You made a very good try. Great work.

-Mike

[Mike Wahler]

Mike Wahler <mk******@mkwah ler.net> wrote in message
news:ds******** *******@newsrea d4.news.pas.ear thlink.net...

After looking at Kevin's reply, and seeing how mine
appears, it seems you might be using the wrong characters
to express logical 'or'. On a U.S. PC keyboard, it's the
shifted 'backslash' key. If you have some other keyboard,
I don't know which it is. Better check that out.

[snip]

Yes, you did make a (very common) novice mistake. Don't feel bad,
many others have done this. The problem is with your statement:

if (c == ' ' ¦¦ '\t' ¦¦ '\n')
++nother;
I copy/pasted the above from your post.

The comparison operator (==) takes exactly two operands.
You supplied 'c' as the 'left-hand' operand, and the
expression, ( ' ' || '\t' || '\n' ) as the 'right-hand'
operand. The 'logical or' operator (||) returns true
if either of its operands yields a nonzero (true) value.
None of ' ', '\t', or '\n' have a value of zero, so 'or-ing'
any or all of them together will always yield nonzero (true).

To express 'if c is equal to any of ' ', '\t', or '\n', you
need to express three distinct comparisons, 'or-d' together.
Write:

if (c == ' ' || c == '\t' || c == '\n')
++nother;
else
++nword;

Note how the 'or' operator appears different here.

-Mike

[CBFalconer]

ext_u wrote:

Ok I thought I would try to take the program one thing at a time. (If
you remember my last post I am trying to make a histogram with data on
the size of each word)
Don't keep starting new threads about the same thing. By posting
a reply in the original thread, and snipping what isn't germane,
you don't have to remind people about it. And it also makes it
easier for them to look back, if needed.
Anways first .. I obviously need to determine what a word actually is.
I wrote this program on my own without looking at the book or any
other resource once.
Good.

#include <stdio.h>
main()
get in the habit of writing "int main(void)" or
"int main(int argc; char *argv)"
{
int c;
int nword, nother;

nword = nother = 0;

while ((c = getchar()) != EOF)
{
if (c == ' ' ¦¦ '\t' ¦¦ '\n')
This should be the logical or of three logical statements. As it
is it won't do what you want. Try:

if ((c == ' ') || (c == '\t') || (c == '\n'))

think about it, and you will see the difference. Some may say the
parentheses are redundant, but it makes the statement perfectly
clear.

BTW, better to use an indentation of 3 or 4 spaces, 8 is too
much. So don't use tabs (if you are using them).
++nother;
else
++nword;
}
printf("Words = %d\nOther = %d", nword, nother);
}

I am basically just trying to tell the computer anything that is not a
blank space, a tab , or a newline is a word...
You are saying that every char is a word, unless it is ...
BUT everytime I run the program it adds to only the nother variable.
I can't figure out why, no matter what I type. I thought I had
written this program well and I even sketched it out on paper
beforehand , hehe.

I know you guys will probably find a horribly noobish mistake , but
please remember I started learning C all of like 48 hours ago.

You are doing fine.

--
Chuck F (cb********@yah oo.com) (cb********@wor ldnet.att.net)
Available for consulting/temporary embedded and systems.
<http://cbfalconer.home .att.net> USE worldnet address!

[Morris Dovey]

ext_u wrote:

I know you guys will probably find a horribly noobish mistake , but
please remember I started learning C all of like 48 hours ago.

<snip>

We're interested in four things:

[1] Determining if a character is part of a word
[2] Finding the first character of each word.
[3] Finding the first character after a word
[4] Counting the characters in a word

I took a try at the problem; and wrote main first; and just
assumed that I could write a word_char() function - so all I
needed to worry about were [2], [3], and [4]. I added EOF to your
list of getchar() input values that could not appear in a word
and then added the word_char() function to satisfy [1].

#include <stdio.h>

int word_char(int c)
{ return (c != ' ') && (c != '\t') && (c != '\n') && (c != EOF);
}

int main(void)
{ int c, chars=0, count[64], i, in_word=0;

for (i=0; i<64; i++) count[i] = 0;

do
{ c = getchar();
if (!in_word && word_char(c))
{ in_word = 1;
chars = 1;
}
else if (in_word)
{ if (word_char(c)) ++chars;
else
{ ++count[chars];
in_word = 0;
}
}
} while (c != EOF);

for (i=1; i<64; i++)
{ if (count[i])
printf("There were %d words with %d letters\n",
count[i], i);
}
return 0;
}

The program makes the assumption that there won't be any words
with more than 64 characters, and may behave /very/ badly if a
longer word is encountered; but I wanted to write a simple "quick
and dirty" example. I made the assumption that you've already
encountered the do {} while () loop construction.

HTH
--
Morris Dovey
West Des Moines, Iowa USA
C links at http://www.iedu.com/c

[Kevin Easton]

Mike Wahler <mk******@mkwah ler.net> wrote:
[...]

Yes, you did make a (very common) novice mistake. Don't feel bad,
many others have done this. The problem is with your statement:

if (c == ' ' ?? '\t' ?? '\n')
++nother;

The comparison operator (==) takes exactly two operands.
You supplied 'c' as the 'left-hand' operand, and the
expression, ( ' ' || '\t' || '\n' ) as the 'right-hand'
operand.
At risk of over-complicating the thread, == has higher precedence than
|| (for the OP, the table on page 53 of K&R2 is worth bookmarking...) ,
so the operands of the == operator in this case are c and ' '. In fact,
you rely on this precedence later in your message:

[...] Write:

if (c == ' ' || c == '\t' || c == '\n')

- Kevin.

[CBFalconer]

CBFalconer wrote:

ext_u wrote:

.... snip ...
#include <stdio.h>
main()

get in the habit of writing "int main(void)" or
"int main(int argc; char *argv)"

Make that last "char **argv". Someone e-mailed me but didn't
bother to put the correction up here. And no, the compiler won't
diagnose it.

--
Chuck F (cb********@yah oo.com) (cb********@wor ldnet.att.net)
Available for consulting/temporary embedded and systems.
<http://cbfalconer.home .att.net> USE worldnet address!

[Randy Howard]

In article <3F************ ***@yahoo.com>, cb********@yaho o.com says...

CBFalconer wrote:

ext_u wrote:

... snip ...
#include <stdio.h>
main()

get in the habit of writing "int main(void)" or
"int main(int argc; char *argv)"

Make that last "char **argv". Someone e-mailed me but didn't
bother to put the correction up here. And no, the compiler won't
diagnose it.

You sure you want that semicolon up there instead of a comma? :-)

[Chris Dollin]

ext_u wrote:

Ok I thought I would try to take the program one thing at a time. (If
you remember my last post I am trying to make a histogram with data on
the size of each word) if (c == ' ' ¦¦ '\t' ¦¦ '\n')

This doesn't mean what you thought it meant. It means

if c == ' '
or '\t' != 0
or '\n' != 0

and, since neither the tab character nor the newline character are
equal to 0, the condition is always true. You want

if (c == ' ' || c == '\t' || c == '\n') ...
or
#include <ctype.h>

if (isspace( c )) ...

if you're prepared to accept form feed, carraige return, and vertical
tab as separators as well.

--
Chris "electric hedgehog" Dollin
C FAQs at: http://www.faqs.org/faqs/by-newsgrou...mp.lang.c.html
C welcome: http://www.angelfire.com/ms3/bchambl...me_to_clc.html

[CBFalconer]

Randy Howard wrote:

cb********@yaho o.com says...

CBFalconer wrote:

ext_u wrote:
>

... snip ...

>
> #include <stdio.h>
> main()

get in the habit of writing "int main(void)" or
"int main(int argc; char *argv)"

Make that last "char **argv". Someone e-mailed me but didn't
bother to put the correction up here. And no, the compiler won't
diagnose it.

You sure you want that semicolon up there instead of a comma? :-)

Woops. Yes, that one would get diagnosed. :-)

I found something from ext_u on my spam trap. If he has trouble
with DJGPP the place to go is comp.os.msdos.d jgpp.

--
Chuck F (cb********@yah oo.com) (cb********@wor ldnet.att.net)
Available for consulting/temporary embedded and systems.
<http://cbfalconer.home .att.net> USE worldnet address!