weird error

[Joe Laughlin]

(file and class names changed to protect the innocent)

g++ -Wall -c file.cpp: In member function `std::string
Some_Class::get _member(const std::string&) const':
file.cpp:46: passing `const std::map<std::s tring,
std::string, std::less<std:: string>, std::allocator< std::pair<const
std::string, std::string> > >' as `this' argument of `_Tp& std::map<_Key,
_Tp, _Compare, _Alloc>::operat or[](const _Key&) [with _Key = std::string,
_Tp = std::string, _Compare = std::less<std:: string>, _Alloc =
std::allocator< std::pair<const std::string, std::string> >]' discards
qualifiers

I can't make heads or tails of this error. I'm guessing it has something to
do with calling a non-const function on some const object. Any ideas?

The function SomeClass::get_ member is:

std::string SomeClass::get_ member(const std::string &name) const
{
return _member[name];
}

where _member is a std::map<std::s tring, std::string>.

[Victor Bazarov]

"Joe Laughlin" <Jo************ ***@boeing.com> wrote...

(file and class names changed to protect the innocent)

g++ -Wall -c file.cpp: In member function `std::string
Some_Class::get _member(const std::string&) const':
file.cpp:46: passing `const std::map<std::s tring,
std::string, std::less<std:: string>, std::allocator< std::pair<const
std::string, std::string> > >' as `this' argument of `_Tp&
std::map<_Key,
_Tp, _Compare, _Alloc>::operat or[](const _Key&) [with _Key =
std::string,
_Tp = std::string, _Compare = std::less<std:: string>, _Alloc =
std::allocator< std::pair<const std::string, std::string> >]' discards
qualifiers

I can't make heads or tails of this error. I'm guessing it has something
to
do with calling a non-const function on some const object. Any ideas?

The function SomeClass::get_ member is:

std::string SomeClass::get_ member(const std::string &name) const
{
return _member[name];
}

where _member is a std::map<std::s tring, std::string>.

You declared this member function ('get_member') "const". That means that
the object (and all its data member except 'mutable' ones) are not going to
change. Indexing operator for 'map' template is a _non-const_ function.
I.e. it cannot be called for a const map. It has to be non-const because
it may insert a new object if it's not there yet.

You need to either make peace with the fact that it may insert another
object into your _member (and declare '_member' "mutable") or use some other
way. It seems that your function _assumes_ that there is an element with
the
key 'name' in the map. What if there isn't?

Victor

[Brian Riis]

Joe Laughlin wrote:

(file and class names changed to protect the innocent)

g++ -Wall -c file.cpp: In member function `std::string
Some_Class::get _member(const std::string&) const':
file.cpp:46: passing `const std::map<std::s tring,
std::string, std::less<std:: string>, std::allocator< std::pair<const
std::string, std::string> > >' as `this' argument of `_Tp& std::map<_Key,
_Tp, _Compare, _Alloc>::operat or[](const _Key&) [with _Key = std::string,
_Tp = std::string, _Compare = std::less<std:: string>, _Alloc =
std::allocator< std::pair<const std::string, std::string> >]' discards
qualifiers

I can't make heads or tails of this error. I'm guessing it has something to
do with calling a non-const function on some const object. Any ideas?

The function SomeClass::get_ member is:

std::string SomeClass::get_ member(const std::string &name) const
{
return _member[name];
Your function is declared const, but you cannot guarantee that the
subscript operator of the map doesn't change the value at 'name'. In
other words: In a const member function you can only use other const
functions (in regard to your own members). In the above, if 'name' does
not exist in _member, *it will be created*. You are not allowed to do
that in a const function.
}

try this:

std::string SomeClass::get_ member(std::str ing const & name) const
{
_member.const_i terator it;
it = _member.find(na me);
if(it != _member.end())
_return it->second;
else
<...> // Whatever you want to do, if 'name' isn't there...
}

Takes up a bit more space, but it works. On most compilers I should
think it is as efficient too.

--
/Brian Riis

[Joe Laughlin]

Brian Riis wrote:

Joe Laughlin wrote:

(file and class names changed to protect the innocent)

g++ -Wall -c file.cpp: In member function `std::string
Some_Class::get _member(const std::string&) const':
file.cpp:46: passing `const std::map<std::s tring,
std::string, std::less<std:: string>,
std::allocator< std::pair<const std::string,
std::string> > >' as `this' argument of `_Tp&
std::map<_Key, _Tp, _Compare,
_Alloc>::operat or[](const _Key&) [with _Key =
std::string, _Tp = std::string, _Compare =
std::less<std:: string>, _Alloc =
std::allocator< std::pair<const std::string, std::string>

>]' discards qualifiers

I can't make heads or tails of this error. I'm guessing
it has something to do with calling a non-const function
on some const object. Any ideas?

The function SomeClass::get_ member is:

std::string SomeClass::get_ member(const std::string
&name) const {
return _member[name];

Your function is declared const, but you cannot guarantee
that the subscript operator of the map doesn't change the
value at 'name'. In other words: In a const member
function you can only use other const functions (in
regard to your own members). In the above, if 'name' does
not exist in _member, *it will be created*. You are not
allowed to do that in a const function.

}

try this:

std::string SomeClass::get_ member(std::str ing const &
name) const {
_member.const_i terator it;
it = _member.find(na me);
if(it != _member.end())
_return it->second;
else
<...> // Whatever you want to do, if 'name' isn't
there... }

Takes up a bit more space, but it works. On most
compilers I should think it is as efficient too.

Thanks you guys.

Is:
_member.const_i terator it;
legal? The compiler didn't like that line, but it did like:
std::map<std::s tring, std::string>::c onst_iterator it;

Joe

[John Harrison]

>>

try this:

std::string SomeClass::get_ member(std::str ing const &
name) const {
_member.const_i terator it;
it = _member.find(na me);
if(it != _member.end())
_return it->second;
else
<...> // Whatever you want to do, if 'name' isn't
there... }

Takes up a bit more space, but it works. On most
compilers I should think it is as efficient too.
Thanks you guys.

Is:
_member.const_i terator it;
legal?

No
The compiler didn't like that line, but it did like:
std::map<std::s tring, std::string>::c onst_iterator it;

I'm sure that's what Brian meant to say.

john

[Joe Laughlin]

Joe Laughlin wrote:

(file and class names changed to protect the innocent)

g++ -Wall -c file.cpp: In member function `std::string
Some_Class::get _member(const std::string&) const':
file.cpp:46: passing `const std::map<std::s tring,
std::string, std::less<std:: string>,
std::allocator< std::pair<const std::string,
std::string> > >' as `this' argument of `_Tp&
std::map<_Key, _Tp, _Compare,
_Alloc>::operat or[](const _Key&) [with _Key =
std::string, _Tp = std::string, _Compare =
std::less<std:: string>, _Alloc =
std::allocator< std::pair<const std::string, std::string>

]' discards qualifiers

I can't make heads or tails of this error. I'm guessing
it has something to do with calling a non-const function
on some const object. Any ideas?

The function SomeClass::get_ member is:

std::string SomeClass::get_ member(const std::string
&name) const {
return _member[name];
}

where _member is a std::map<std::s tring, std::string>.

Here's another one, probably related to my lack of understanding about the
STL. (These error messages sure aren't very clear!)
Error is:
could not convert `
(&iter)->std::_List_ite rator<_Tp, _Ref, _Ptr>::operator *() const [with
_Tp =
SomeClass, _Ref = const SomeClass&, _Ptr = const
SomeClass*]()' to `SomeClass&'

SomeClass is a std::list of a user-defined class.

The error gets raised on the return statement of this function:
SomeClass& AnotherClass::g et_element(cons t string& tag) const
{
std::list<SomeC lass>::const_it erator iter = _elements.begin ();

// This isn't very well written, and I'm sure there's better
// ways of doing it. Feel free to give me ideas on how to improve it.
while (iter != _elements.end() )
{
if (iter->get_member("ta g") == tag)
return *iter; // error rasied here
++iter;
}
// throw exception cuz not found
}

[Victor Bazarov]

Joe Laughlin wrote:

Joe Laughlin wrote:

(file and class names changed to protect the innocent)

g++ -Wall -c file.cpp: In member function `std::string
Some_Class::get _member(const std::string&) const':
file.cpp:46 : passing `const std::map<std::s tring,
std::string, std::less<std:: string>,
std::allocator< std::pair<const std::string,
std::string> > >' as `this' argument of `_Tp&
std::map<_Key, _Tp, _Compare,
_Alloc>::operat or[](const _Key&) [with _Key =
std::string, _Tp = std::string, _Compare =
std::less<std ::string>, _Alloc =
std::allocato r<std::pair<con st std::string, std::string>

]' discards qualifiers

I can't make heads or tails of this error. I'm guessing
it has something to do with calling a non-const function
on some const object. Any ideas?

The function SomeClass::get_ member is:

std::string SomeClass::get_ member(const std::string
&name) const {
return _member[name];
}

where _member is a std::map<std::s tring, std::string>.

Here's another one, probably related to my lack of understanding about the
STL. (These error messages sure aren't very clear!)
Error is:
could not convert `
(&iter)->std::_List_ite rator<_Tp, _Ref, _Ptr>::operator *() const [with
_Tp =
SomeClass, _Ref = const SomeClass&, _Ptr = const
SomeClass*]()' to `SomeClass&'

SomeClass is a std::list of a user-defined class.

The error gets raised on the return statement of this function:
SomeClass& AnotherClass::g et_element(cons t string& tag) const
{
std::list<SomeC lass>::const_it erator iter = _elements.begin ();

// This isn't very well written, and I'm sure there's better
// ways of doing it. Feel free to give me ideas on how to improve it.
while (iter != _elements.end() )
{
if (iter->get_member("ta g") == tag)
return *iter; // error rasied here
++iter;
}
// throw exception cuz not found
}

Your 'const' is all screwed up again. The return value of this function
is 'SomeClass&', a reference to non-const SomeClass object. The 'iter'
is declared as 'const_iterator ', whose operator* (dereference operator)
yields a 'SomeClass const&', a reference to a const SomeClass object.
Of course it cannot convert a const ref to a non-const ref.

Victor

[Joe Laughlin]

Victor Bazarov wrote:

Joe Laughlin wrote:

Joe Laughlin wrote:

(file and class names changed to protect the innocent)

g++ -Wall -c file.cpp: In member function `std::string
Some_Class::get _member(const std::string&) const':
file.cpp:46: passing `const std::map<std::s tring,
std::string, std::less<std:: string>,
std::allocator< std::pair<const std::string,
std::string> > >' as `this' argument of `_Tp&
std::map<_Key, _Tp, _Compare,
_Alloc>::operat or[](const _Key&) [with _Key =
std::string, _Tp = std::string, _Compare =
std::less<std:: string>, _Alloc =
std::allocator< std::pair<const std::string, std::string>

]' discards qualifiers

I can't make heads or tails of this error. I'm guessing
it has something to do with calling a non-const function
on some const object. Any ideas?

The function SomeClass::get_ member is:

std::string SomeClass::get_ member(const std::string
&name) const {
return _member[name];
}

where _member is a std::map<std::s tring, std::string>.

Here's another one, probably related to my lack of
understanding about the STL. (These error messages sure
aren't very clear!)
Error is:
could not convert `
(&iter)->std::_List_ite rator<_Tp, _Ref,
_Ptr>::operator *() const [with _Tp =
SomeClass, _Ref = const SomeClass&, _Ptr = const
SomeClass*]()' to `SomeClass&'

SomeClass is a std::list of a user-defined class.

The error gets raised on the return statement of this
function: SomeClass& AnotherClass::g et_element(cons t
string& tag) const {
std::list<SomeC lass>::const_it erator iter =
_elements.begin ();

// This isn't very well written, and I'm sure
there's better // ways of doing it. Feel free to
give me ideas on how to improve it. while (iter !=
_elements.end() ) {
if (iter->get_member("ta g") == tag)
return *iter; // error rasied here
++iter;
}
// throw exception cuz not found
}

Your 'const' is all screwed up again. The return value
of this function is 'SomeClass&', a reference to
non-const SomeClass object. The 'iter' is declared as
'const_iterator ', whose operator* (dereference operator)
yields a 'SomeClass const&', a reference to a const
SomeClass object. Of course it cannot convert a const ref
to a non-const ref.

Victor

Ah, I understand. So what's the correct thing to do here? (Can I return a
const reference?)

[Victor Bazarov]

Joe Laughlin wrote:

Victor Bazarov wrote:

Joe Laughlin wrote:

Joe Laughlin wrote:
(file and class names changed to protect the innocent)

g++ -Wall -c file.cpp: In member function `std::string
Some_Class::get _member(const std::string&) const':
file.cpp:46 : passing `const std::map<std::s tring,
std::string, std::less<std:: string>,
std::allocator< std::pair<const std::string,
std::string> > >' as `this' argument of `_Tp&
std::map<_Key, _Tp, _Compare,
_Alloc>::operat or[](const _Key&) [with _Key =
std::string, _Tp = std::string, _Compare =
std::less<s td::string>, _Alloc =
std::alloca tor<std::pair<c onst std::string, std::string>

>]' discards qualifiers

I can't make heads or tails of this error. I'm guessing
it has something to do with calling a non-const function
on some const object. Any ideas?

The function SomeClass::get_ member is:

std::stri ng SomeClass::get_ member(const std::string
&name) const {
return _member[name];
}

where _member is a std::map<std::s tring, std::string>.
Here's another one, probably related to my lack of
understandin g about the STL. (These error messages sure
aren't very clear!)
Error is:
could not convert `
(&iter)->std::_List_ite rator<_Tp, _Ref,
_Ptr>::opera tor*() const [with _Tp =
SomeClass, _Ref = const SomeClass&, _Ptr = const
SomeClass*]()' to `SomeClass&'

SomeClass is a std::list of a user-defined class.

The error gets raised on the return statement of this
function: SomeClass& AnotherClass::g et_element(cons t
string& tag) const {
std::list<SomeC lass>::const_it erator iter =
_elements.be gin();

// This isn't very well written, and I'm sure
there's better // ways of doing it. Feel free to
give me ideas on how to improve it. while (iter !=
_elements.end() ) {
if (iter->get_member("ta g") == tag)
return *iter; // error rasied here
++iter;
}
// throw exception cuz not found
}

Your 'const' is all screwed up again. The return value
of this function is 'SomeClass&', a reference to
non-const SomeClass object. The 'iter' is declared as
'const_iterat or', whose operator* (dereference operator)
yields a 'SomeClass const&', a reference to a const
SomeClass object. Of course it cannot convert a const ref
to a non-const ref.

Victor

Ah, I understand. So what's the correct thing to do here? (Can I return a
const reference?)

You can of course. I don't know if your algorithm allows you to, though.
Why did you need a non-const ref before?

V

[Mike Wahler]

"Joe Laughlin" <Jo************ ***@boeing.com> wrote in message
news:I6******** @news.boeing.co m...

Victor Bazarov wrote:

Your 'const' is all screwed up again. The return value
of this function is 'SomeClass&', a reference to
non-const SomeClass object. The 'iter' is declared as
'const_iterator ', whose operator* (dereference operator)
yields a 'SomeClass const&', a reference to a const
SomeClass object. Of course it cannot convert a const ref
to a non-const ref.

Victor
Ah, I understand. So what's the correct thing to do here?

return a const reference.
(Can I return a
const reference?)

:-)

-Mike