Stupid Question #119

[Randy Yates]

OK, why doesn't this work:
string EraseCommas(str ing &numericStri ng)
{
UINT16_T commaPosition;

commaPosition = numericString.f ind(",");
while (commaPosition != string::npos);
{
numericString.e rase(commaPosit ion);
commaPosition = numericString.f ind(",", commaPosition);
}

return numericString;
}
istringstream(E raseCommas(desc ription.substr( begIndex, endIndex - begIndex + 1))) >> population;
compiles with

make -f import.mak TARGET=pc
g++ -c -DTARGET_PC -Wall -g -I /. -I /mingw/include/ -I /devstudio/vc/include -o ./pc/import.o -Wno-deprecated import.cpp
import.cpp: In member function `virtual bool COUNTY::parseOb ject(BOOK&)':
import.cpp:213: parse error before `>>' token
make: *** [pc/import.o] Error 1

Compilation exited abnormally with code 2 at Sun Oct 17 21:23:41

--
% Randy Yates % "And all that I can do
%% Fuquay-Varina, NC % is say I'm sorry,
%%% 919-577-9882 % that's the way it goes..."
%%%% <ya***@ieee.org > % Getting To The Point', *Balance of Power*, ELO
http://home.earthlink.net/~yatescr

[Malte Starostik]

Randy Yates schrieb:

OK, why doesn't this work:
string EraseCommas(str ing &numericStri ng) this way it can take a temporary, like description.sub str(...) below:
string EraseCommas(con st string &numericStri ng) { see above, and replace all occurances of numericString with result below:
string result = numericString; UINT16_T commaPosition; UINT16_T (some user-defined 16-bit unsigned type?) might very well not
be large enough for string::npos... :
string::size_ty pe commaPosition;

commaPosition = numericString.f ind(",");
while (commaPosition != string::npos); ^ oops, empty endless loop :-) {
numericString.e rase(commaPosit ion); erase one char, not everything from the comma till the end:
numericString.e rase(commaPosit ion, 1); commaPosition = numericString.f ind(",", commaPosition);
}

return numericString;
}
istringstream(E raseCommas(desc ription.substr( begIndex, endIndex - begIndex + 1))) >> population;
compiles with

make -f import.mak TARGET=pc
g++ -c -DTARGET_PC -Wall -g -I /. -I /mingw/include/ -I /devstudio/vc/include -o ./pc/import.o -Wno-deprecated import.cpp
import.cpp: In member function `virtual bool COUNTY::parseOb ject(BOOK&)':
import.cpp:213: parse error before `>>' token

Yep :-(
This line:
istringstream(E raseCommas(desc ription.substr( begIndex, endIndex -
begIndex + 1))) >> population;
is parsed as a function declaration followed by >> population
unfortunately. This one works:
istringstream is(EraseCommas( description.sub str(begIndex, endIndex -
begIndex + 1)));
is >> population;

Regards,
Malte

[Randy Yates]

Malte Starostik <ma************ *@t-online.de> writes:

Randy Yates schrieb:

OK, why doesn't this work:
string EraseCommas(str ing &numericStri ng)

this way it can take a temporary, like description.sub str(...) below:
string EraseCommas(con st string &numericStri ng)

{

see above, and replace all occurances of numericString with result below:
string result = numericString;

But, at the risk of being overly anal, that's not what I want to accomplish.
I'd like EraseCommas(num ericString) to operate either as a stand-along function
that operates on numericString,
string numericString;
EraseCommas(num ericString);

or as a string

string line;
string numericString;
line = EraseCommas(num ericString);

But thanks much for the help, Malte.

--Randy

UINT16_T commaPosition;

UINT16_T (some user-defined 16-bit unsigned type?) might very well not
be large enough for string::npos... :
string::size_ty pe commaPosition;

commaPosition = numericString.f ind(",");
while (commaPosition != string::npos);

^ oops, empty endless loop :-)

{
numericString.e rase(commaPosit ion);

erase one char, not everything from the comma till the end:
numericString.e rase(commaPosit ion, 1);

commaPosition = numericString.f ind(",", commaPosition);
}
return numericString;
} istringstream(E raseCommas(desc ription.substr( begIndex,
endIndex - begIndex + 1))) >> population;
compiles with make -f import.mak TARGET=pc g++ -c -DTARGET_PC -Wall
-g -I /. -I /mingw/include/ -I /devstudio/vc/include -o
./pc/import.o -Wno-deprecated import.cpp import.cpp: In member
function `virtual bool COUNTY::parseOb ject(BOOK&)':
import.cpp:213: parse error before `>>' token

Yep :-(
This line:
istringstream(E raseCommas(desc ription.substr( begIndex, endIndex -
begIndex + 1))) >> population;
is parsed as a function declaration followed by >> population
unfortunately. This one works:
istringstream is(EraseCommas( description.sub str(begIndex, endIndex -
begIndex + 1)));
is >> population;

Regards,
Malte

--
% Randy Yates % "Though you ride on the wheels of tomorrow,
%% Fuquay-Varina, NC % you still wander the fields of your
%%% 919-577-9882 % sorrow."
%%%% <ya***@ieee.org > % '21st Century Man', *Time*, ELO
http://home.earthlink.net/~yatescr

[E. Robert Tisdale]

Randy Yates wrote:

OK, why doesn't this work:

[snip]

It occured to me that someone else may have had this problem before
and solved it.

I used Google

http://www.google.com/

to search for

+"C++" +"embedded commas" +"number"

and I found lots of stuff including

http://www.roguewave.com/support/doc...rwdecimal.html

[Randy Yates]

"E. Robert Tisdale" <E.************ **@jpl.nasa.gov > writes:

Randy Yates wrote:

OK, why doesn't this work:

[snip]

It occured to me that someone else may have had this problem before
and solved it.

I used Google

http://www.google.com/

to search for

+"C++" +"embedded commas" +"number"

and I found lots of stuff including

http://www.roguewave.com/support/doc...rwdecimal.html

Yeah, I found a lot of "stuff" too. Just like Walmart...
--
% Randy Yates % "Bird, on the wing,
%% Fuquay-Varina, NC % goes floating by
%%% 919-577-9882 % but there's a teardrop in his eye..."
%%%% <ya***@ieee.org > % 'One Summer Dream', *Face The Music*, ELO
http://home.earthlink.net/~yatescr

[Rolf Magnus]

Randy Yates wrote:

Malte Starostik <ma************ *@t-online.de> writes:

Randy Yates schrieb:

OK, why doesn't this work:
string EraseCommas(str ing &numericStri ng)

this way it can take a temporary, like description.sub str(...) below:
string EraseCommas(con st string &numericStri ng)

{

see above, and replace all occurances of numericString with result below:
string result = numericString;

But, at the risk of being overly anal, that's not what I want to
accomplish. I'd like EraseCommas(num ericString) to operate either as a
stand-along function that operates on numericString,
string numericString;
EraseCommas(num ericString);

or as a string

string line;
string numericString;
line = EraseCommas(num ericString);

It will always operate on numericString. This second example will first
modify numericString, then copy it into line. In fact, your function will
always copy numericString. The first example just ignores that copy.

[Old Wolf]

Malte Starostik wrote:

OK, why doesn't this work:

string EraseCommas(str ing &numericStri ng)

g++ -c -DTARGET_PC -Wall -g -I /. -I /mingw/include/ -I /devstudio/vc/include -o ./pc/import.o -Wno-deprecated import.cpp
import.cpp: In member function `virtual bool COUNTY::parseOb ject(BOOK&)':
import.cpp:213: parse error before `>>' token

istringstream(E raseCommas(desc ription.substr( begIndex, endIndex -
begIndex + 1))) >> population;
is parsed as a function declaration followed by >> population
unfortunately.

How is that a function declaration? What's its name and parameter types?
It compiles just fine for me (see code below).

Maybe the OP had an error elsewhere (the error message talks
about a function COUNTY::parseOb ject(BOOK&) but the posted code
did not include such a function, perhaps he has an extra bracket
on the previous line or something.

#include <string>
#include <sstream>

using std::istringstr eam;
using std::string;

string EraseCommas(str ing &numericString) ;

int main()
{
string description;
int begIndex, endIndex, population;

istringstream(E raseCommas(desc ription.substr( begIndex, endIndex -
begIndex + 1))) >> population;
}

[Rolf Magnus]

Old Wolf wrote:

Malte Starostik wrote:

> OK, why doesn't this work:
>
> string EraseCommas(str ing &numericStri ng)
>
> g++ -c -DTARGET_PC -Wall -g -I /. -I /mingw/include/ -I
> /devstudio/vc/include -o ./pc/import.o -Wno-deprecated import.cpp
> import.cpp: In member function `virtual bool
> COUNTY::parseOb ject(BOOK&)': import.cpp:213: parse error before `>>'
> token
istringstream(E raseCommas(desc ription.substr( begIndex, endIndex -
begIndex + 1))) >> population;
is parsed as a function declaration followed by >> population
unfortunately.

How is that a function declaration? What's its name and parameter types?

Actually, I think it's not a function declaration, but instead the
definition of an object of type istringstream with name EraseCommas, i.e.
the same as:

istringstream EraseCommas(des cription.substr (begIndex, endIndex -
begIndex + 1)) >> population;

And you cannot define a named object and directly use operator>> on it.
After splitting it up, it compiles here, too:

istringstream(E raseCommas(desc ription.substr( begIndex, endIndex -
begIndex + 1)));

EraseCommas >> population;
It compiles just fine for me (see code below).
Really?
Maybe the OP had an error elsewhere (the error message talks
about a function COUNTY::parseOb ject(BOOK&) but the posted code
did not include such a function, perhaps he has an extra bracket
on the previous line or something.
I rather think that the erroneous line actually is part of that function in
the OP's original code.

#include <string>
#include <sstream>

using std::istringstr eam;
using std::string;

string EraseCommas(str ing &numericString) ;

int main()
{
string description;
int begIndex, endIndex, population;

istringstream(E raseCommas(desc ription.substr( begIndex, endIndex -
begIndex + 1))) >> population;
}

That code produces the same error message as the OP's code here.