StreamWriter, need to appendtext and not overwrite af file

[Mads Westen]

Hi,

I'm parsing some XML files, and converting them to CSV.
I got x number of XML files in a directory, these files do I need to be
converted and written to the same CSV file.
My problem is that my csv file only contains the data from the last XML file
parsed...

I got the following code for creating of my StreamWriter:
public OrderFileCreato r(string fileName)
{
this.fileName = fileName;
if(File.Exists( this.fileName))
{
fl = File.OpenWrite( this.fileName);
fs = new StreamWriter(fl , Encoding.GetEnc oding( 850 ));
}
if(!File.Exists (this.fileName) )
{
fl = File.Create(thi s.fileName);
fs = new StreamWriter(fl , Encoding.GetEnc oding( 850 ));
}
}
Best regards
Mads

[Mads Westen]

Hi, Vadym,

I finally googled my way to another solution.
I used the following:
if(File.Exists( this.fileName))
{
fl = new FileStream(this .fileName, FileMode.Append );
fs = new StreamWriter(fl , Encoding.GetEnc oding( 850 ));
}
if(!File.Exists (this.fileName) )
{
fl = File.Create(thi s.fileName);
fs = new StreamWriter(fl , Encoding.GetEnc oding( 850 ));
}
That worked fine.

I'm sure your solution would have worked to.
In my case, I don't care what end of the file i write to. But if that was a
issue, then your solution would come in handy.

Thaks!

Best regards
Mads

"Vadym Stetsyak" <va*****@ukr.ne t> skrev i en meddelelse
news:ug******** ******@TK2MSFTN GP11.phx.gbl...

Hello, Mads!

MW> I'm parsing some XML files, and converting them to CSV.
MW> I got x number of XML files in a directory, these files do I need to
be
MW> converted and written to the same CSV file.
MW> My problem is that my csv file only contains the data from the last
XML
MW> file parsed...

MW> I got the following code for creating of my StreamWriter:
MW> public OrderFileCreato r(string fileName)
MW> {
MW> this.fileName = fileName;
MW> if(File.Exists( this.fileName))
MW> {
MW> fl = File.OpenWrite( this.fileName);
MW> fs = new StreamWriter(fl , Encoding.GetEnc oding( 850 ));
MW> }
MW> if(!File.Exists (this.fileName) )
MW> {
MW> fl = File.Create(thi s.fileName);
MW> fs = new StreamWriter(fl , Encoding.GetEnc oding( 850 ));
MW> }
MW> }

The problems is the you start writing from the beginning of the file. You
need to "rewind" stream to the end.
You can do this with FileStream. fl.Position = fl.Length; or with
fl.Seek(...)

--
Regards, Vadym Stetsyak
www: http://vadmyst.blogspot.com

[Helge Jensen]

Mads Westen wrote:

if(File.Exists( this.fileName))
{
fl = new FileStream(this .fileName, FileMode.Append );
fs = new StreamWriter(fl , Encoding.GetEnc oding( 850 ));
}
if(!File.Exists (this.fileName) )
{
fl = File.Create(thi s.fileName);
fs = new StreamWriter(fl , Encoding.GetEnc oding( 850 ));
}

What's wrong with simply:

Stream s = File.Open(fileN ame, FileMode.Append );
StreamWriter sw = new StreamWriter(s, enc);

BTW, you should probably be "using" s and sw, or have some other method
of ensuring that they get closed.

--
Helge Jensen
mailto:he****** ****@slog.dk
sip:he********* *@slog.dk
-=> Sebastian cover-music: http://ungdomshus.nu <=-

[Vadym Stetsyak]

HJ> What's wrong with simply:

HJ> Stream s = File.Open(fileN ame, FileMode.Append );
HJ> StreamWriter sw = new StreamWriter(s, enc);

If you plan only to write to thele this is okay, because
File.Open(fileN ame, FileMode.Append ) - opens file with FileAccess.Writ e.

--
Regards, Vadym Stetsyak
www: http://vadmyst.blogspot.com

[Helge Jensen]

Vadym Stetsyak wrote:

HJ> What's wrong with simply:

HJ> Stream s = File.Open(fileN ame, FileMode.Append );
HJ> StreamWriter sw = new StreamWriter(s, enc);

If you plan only to write to thele this is okay, because
File.Open(fileN ame, FileMode.Append ) - opens file with FileAccess.Writ e.

I think you can assume that only writes are to be done, since the
original example did new FileStream(name , FileMode.Append ) -- which i
would believe is equivalent.

I just found it odd to check that the file exists first. It complicates
the code and introduces a race condition, probably not a bad one, but
still...

--
Helge Jensen
mailto:he****** ****@slog.dk
sip:he********* *@slog.dk
-=> Sebastian cover-music: http://ungdomshus.nu <=-