Filestream Error...

[Tim]

Hi,

I have a list of products in with images stored in a SQL Server 2000 DB. I
need to be able to retrieve the images when a product is chose. I use the
code below to get the image from the DB and assign it to the picture box.

It works fine the first time but subsequent times it gives me an error
saying that the file is in use by another process. What process? If I go to
the folder and try to delete the file in windows I get the same error. Can
anyone help me here? What am I doing wrong? I am closing the filestream so
what is still open?

Thanks

Tim

try

{

//Look Up the Image

SqlCommand cmdSelect=new SqlCommand("SEL ECT logo_image FROM
t_store_informa tion WHERE store_id =1" , DBConnection.DB Conn.Connection );

DBConnection.DB Conn.Connection .Open();

byte[] barrImg=(byte[])cmdSelect.Exec uteScalar();

DBConnection.DB Conn.Connection .Close();

string strfn=Convert.T oString(DateTim e.Now.ToFileTim e());

FileStream fs = new FileStream(@"C: \Program Files\MM\Temp\t humb.jpg",
FileMode.OpenOr Create, FileAccess.Writ e);

fs.Write(barrIm g,0,barrImg.Len gth);

fs.Close();

strfn = "";

this.pboxThumb. Image = Image.FromFile( @"C:\Program
Files\MM\Temp\t humb.jpg");

}

catch(Exception ex)

{

#if DEBUG

MessageBox.Show ("Image Error!\r\n\r\n" + ex.Message);

#endif

}

finally

{


DBConnection.DB Conn.Connection .Close();

}

[Jan]

Hi Tim,

If I were you I wouldn't use a FileStream but a MemoryStream. That way
you avoid all those stick file issues and it will work a goof deal
faster for you.

For the record what might be happeneing is that the FromFile functions
implementation may not be releasnig the unmanaged FileHandle fast
enough but i can't be sure.

If you want to see what process is holding the file handle try using
Process Explorer from www.sysinternals.com.

Good Luck,
Jan

[Tim]

Thanks Jan,

I don't suppose you have an example of MemoryStream do you? Also I thought
that pictureboxes had to have a file that actually existed on the hard
drive.

Tim
"Jan" <ja***********@ gmail.com> wrote in message
news:11******** **************@ g14g2000cwa.goo glegroups.com.. .

Hi Tim,

If I were you I wouldn't use a FileStream but a MemoryStream. That way
you avoid all those stick file issues and it will work a goof deal
faster for you.

For the record what might be happeneing is that the FromFile functions
implementation may not be releasnig the unmanaged FileHandle fast
enough but i can't be sure.

If you want to see what process is holding the file handle try using
Process Explorer from www.sysinternals.com.

Good Luck,
Jan

[Jan Bannister]

Hi Tim,

Here's an example:

using (System.IO.Memo ryStream mem = new
System.IO.Memor yStream(bytes,f alse))
{
System.Drawing. Bitmap bitmap = new Bitmap(mem,fals e);
pictureBox1.Ima ge = Bitmap;
}

And no PictureBoxes don't need a file. They just and Image (which is
the superclass of Bitmap).

Hope that helps,
Jan

[Jon Skeet [C# MVP]]

Tim <ti*@home.com > wrote:

I have a list of products in with images stored in a SQL Server 2000 DB. I
need to be able to retrieve the images when a product is chose. I use the
code below to get the image from the DB and assign it to the picture box.

It works fine the first time but subsequent times it gives me an error
saying that the file is in use by another process. What process? If I go to
the folder and try to delete the file in windows I get the same error. Can
anyone help me here? What am I doing wrong? I am closing the filestream so
what is still open?

It doesn't really mean another process - it's a misleading error
message.

Although you're closing the FileStream, you're then using
Image.FromFile, which opens another FileStream and keeps it open until
the image is disposed.

Using a MemoryStream as Jan suggested should solve the problem, but you
shouldn't use a using block - the image "owns" the stream you pass into
it, and expects you to leave it open. From the Bitmap constructor docs:

<quote>
Remarks
You must keep the stream open for the lifetime of the Bitmap object.
</quote>

You should, however, definitely use a using statement for your database
connection :)

--
Jon Skeet - <sk***@pobox.co m>
http://www.pobox.com/~skeet
If replying to the group, please do not mail me too

[Tim]

Thanks for your reply Jon, I really appreciated it. What do you mean by "You
should, however, definitely use a using statement for your database
connection"?

Thanks

Tim

"Jon Skeet [C# MVP]" <sk***@pobox.co m> wrote in message
news:MP******** *************** @msnews.microso ft.com...

Tim <ti*@home.com > wrote:

I have a list of products in with images stored in a SQL Server 2000 DB.
I
need to be able to retrieve the images when a product is chose. I use the
code below to get the image from the DB and assign it to the picture box.

It works fine the first time but subsequent times it gives me an error
saying that the file is in use by another process. What process? If I go
to
the folder and try to delete the file in windows I get the same error.
Can
anyone help me here? What am I doing wrong? I am closing the filestream
so
what is still open?

It doesn't really mean another process - it's a misleading error
message.

Although you're closing the FileStream, you're then using
Image.FromFile, which opens another FileStream and keeps it open until
the image is disposed.

Using a MemoryStream as Jan suggested should solve the problem, but you
shouldn't use a using block - the image "owns" the stream you pass into
it, and expects you to leave it open. From the Bitmap constructor docs:

<quote>
Remarks
You must keep the stream open for the lifetime of the Bitmap object.
</quote>

You should, however, definitely use a using statement for your database
connection :)

--
Jon Skeet - <sk***@pobox.co m>
http://www.pobox.com/~skeet
If replying to the group, please do not mail me too

[Tim]

Wow, Jan thank you. I have been struggling with this problem for a while and
this works like a charm.

Tim
"Jan Bannister" <ja***********@ gmail.com> wrote in message
news:11******** **************@ o13g2000cwo.goo glegroups.com.. .

Hi Tim,

Here's an example:

using (System.IO.Memo ryStream mem = new
System.IO.Memor yStream(bytes,f alse))
{
System.Drawing. Bitmap bitmap = new Bitmap(mem,fals e);
pictureBox1.Ima ge = Bitmap;
}

And no PictureBoxes don't need a file. They just and Image (which is
the superclass of Bitmap).

Hope that helps,
Jan

[Jon Skeet [C# MVP]]

Tim <ti*@home.com > wrote:

Thanks for your reply Jon, I really appreciated it. What do you mean by "You
should, however, definitely use a using statement for your database
connection"?

You're currently manually calling Close on your database connection,
which means that if an exception is thrown, you're failing to close it.
(You were doing the same with the FileStream too.)

You should use a using statement (like the one Jan used for the
MemoryStream) which is the equivalent of try/finally, with Dispose
being called in the finally block.

--
Jon Skeet - <sk***@pobox.co m>
http://www.pobox.com/~skeet
If replying to the group, please do not mail me too

[Tim]

Thanks Jon, I have adjusted my code accordingly.
"Jon Skeet [C# MVP]" <sk***@pobox.co m> wrote in message
news:MP******** *************** *@msnews.micros oft.com...

Tim <ti*@home.com > wrote:

Thanks for your reply Jon, I really appreciated it. What do you mean by
"You
should, however, definitely use a using statement for your database
connection"?

You're currently manually calling Close on your database connection,
which means that if an exception is thrown, you're failing to close it.
(You were doing the same with the FileStream too.)

You should use a using statement (like the one Jan used for the
MemoryStream) which is the equivalent of try/finally, with Dispose
being called in the finally block.

--
Jon Skeet - <sk***@pobox.co m>
http://www.pobox.com/~skeet
If replying to the group, please do not mail me too

[Jan Bannister]

Cool,

Glad to help,
Jan