By using this site, you agree to our updated Privacy Policy and our Terms of Use. Manage your Cookies Settings.
459,292 Members | 1,615 Online
Bytes IT Community
+ Ask a Question
Need help? Post your question and get tips & solutions from a community of 459,292 IT Pros & Developers. It's quick & easy.

request.querystring("something")(item)

P: n/a
Hi,

I have form GET method, example:

index.asp?Type=1&Type=3&Type=4&....
So,
I have something like this at the receiver side to retrieve multiple
Type value and insert into tables.

Set QINSERT = Server.CreateObject("ADODB.Recordset")
For Each item In Request.QueryString("Type")
SQL= " INSERT INTO tblType (TypeID, UserID) VALUES ('" &
Request.QueryString("Type")(item) & Session("ID") & "')"
Set QINSERT = conn.execute(SQL)
Next
But within the FOR statement, it ended up Internet 500 Error. What
did I do wrong ? Is Request.QueryString("Type")(item) correct ?

Session("ID") is OK. TypeID, UserID are correct too.

Please help to tell me what is wrong.

Regards,
magix

Dec 26 '07 #1
Share this Question
Share on Google+
5 Replies


P: n/a
On Dec 26, 11:04*am, "mag...@gmail.com" <mag...@gmail.comwrote:
Hi,

I have form GET method, example:

index.asp?Type=1&Type=3&Type=4&....

So,
I have something like this at the receiver side to retrieve multiple
Type value and insert into tables.

* *Set *QINSERT *= Server.CreateObject("ADODB.Recordset")
* *For Each item In Request.QueryString("Type")
* * * * * * * * * * * * * * * * * * * * * * * * * * * * SQL= " INSERT INTO tblType (TypeID, UserID) VALUES ('" &
Request.QueryString("Type")(item) & Session("ID") & "')"
* * * * Set QINSERT = conn.execute(SQL)
* *Next

* *But within the FOR statement, it ended up Internet 500 Error. What
did I do wrong ? Is Request.QueryString("Type")(item) correct ?

Session("ID") is OK. TypeID, UserID are correct too.

Please help to tell me what is wrong.

Regards,
magix

Issue resolved and closed.
Dec 26 '07 #2

P: n/a
ma****@gmail.com wrote on 26 dec 2007 in
ma****@gmail.com wrote on 26 dec 2007 in
>For Each item In Request.QueryString("Type")

Issue resolved and closed.
1 Since you are not the owner of usenet,
you cannot close an issue,
even if you opened it.

2 If you resolved your programming mistake,
it would be considerate to tell others,
that have already spent time thinking about it,
how and what.

====

Doing what you did with Request.QueryString,
if done on the open web,
is very dangerous for SQL injection.

Always validate all incoming data first,
or ask Bob for that other way,
which name always escapes me,
as I never use it.

--
Evertjan.
The Netherlands.
(Please change the x'es to dots in my emailaddress)
Dec 26 '07 #3

P: n/a

"Evertjan." <ex**************@interxnl.netwrote in message
news:Xn********************@194.109.133.242...
ma****@gmail.com wrote on 26 dec 2007 in
>ma****@gmail.com wrote on 26 dec 2007 in
>>For Each item In Request.QueryString("Type")

Issue resolved and closed.

1 Since you are not the owner of usenet,
you cannot close an issue,
even if you opened it.

2 If you resolved your programming mistake,
it would be considerate to tell others,
that have already spent time thinking about it,
how and what.

====

Doing what you did with Request.QueryString,
if done on the open web,
is very dangerous for SQL injection.

Always validate all incoming data first,
or ask Bob for that other way,
which name always escapes me,
as I never use it.
It's called parameters. And it isn't an alternative. It's as well as.
It's useful for preventing other potential problems - not just Sql
Injection.

--
Mike Brind
Dec 29 '07 #4

P: n/a
Mike Brind wrote on 29 dec 2007 in
microsoft.public.inetserver.asp.general:
>
"Evertjan." <ex**************@interxnl.netwrote in message
news:Xn********************@194.109.133.242...
>ma****@gmail.com wrote on 26 dec 2007 in
>>ma****@gmail.com wrote on 26 dec 2007 in
For Each item In Request.QueryString("Type")

Issue resolved and closed.

1 Since you are not the owner of usenet,
you cannot close an issue,
even if you opened it.

2 If you resolved your programming mistake,
it would be considerate to tell others,
that have already spent time thinking about it,
how and what.

====

Doing what you did with Request.QueryString,
if done on the open web,
is very dangerous for SQL injection.

Always validate all incoming data first,
or ask Bob for that other way,
which name always escapes me,
as I never use it.

It's called parameters.
Ah yes, I was thinking about parainches or orthoyards,
but I am glad it turns out to be metric after all.
And it isn't an alternative. It's as well as.
That is what alternative means, though I did not use that word.
It's useful for preventing other potential problems - not just Sql
Injection.
Please elaborate for us.

--
Evertjan.
The Netherlands.
(Please change the x'es to dots in my emailaddress)
Dec 29 '07 #5

P: n/a

"Evertjan." <ex**************@interxnl.netwrote in message
news:Xn********************@194.109.133.242...
Mike Brind wrote on 29 dec 2007 in
microsoft.public.inetserver.asp.general:
>>
"Evertjan." <ex**************@interxnl.netwrote in message
news:Xn********************@194.109.133.242...
>>ma****@gmail.com wrote on 26 dec 2007 in
ma****@gmail.com wrote on 26 dec 2007 in
For Each item In Request.QueryString("Type")

Issue resolved and closed.

1 Since you are not the owner of usenet,
you cannot close an issue,
even if you opened it.

2 If you resolved your programming mistake,
it would be considerate to tell others,
that have already spent time thinking about it,
how and what.

====

Doing what you did with Request.QueryString,
if done on the open web,
is very dangerous for SQL injection.

Always validate all incoming data first,
or ask Bob for that other way,
which name always escapes me,
as I never use it.

It's called parameters.

Ah yes, I was thinking about parainches or orthoyards,
but I am glad it turns out to be metric after all.
>And it isn't an alternative. It's as well as.

That is what alternative means, though I did not use that word.
>It's useful for preventing other potential problems - not just Sql
Injection.

Please elaborate for us.
The main additional benefit is that you don't need to delimit values in
concatenated SQL strings, which removes the source of a number of errors
posted here, such as datatype mismatches and syntax errors. With
parameters, you would still perform server-side validation of values (for
range, datatype etc), but you are right - you don't need to specifically
validate against Sql injection attempts.

--
Mike Brind
Dec 31 '07 #6

This discussion thread is closed

Replies have been disabled for this discussion.