ASP Validation

[blyxx86]

Can I have someone take a look at this code and let me know if you see any problems with it... In terms of efficiency, error control, etc... :) Thank you! This is my first completely self created Function.

<%
    Function WebTracking(sTracking) 
    Dim shipArray(2)
        shipArray(0)="<a href=""http://www.fedex.com/Tracking?tracknumbers="
        shipArray(1)="<a href=""http://www.calover.com/trackres.asp?tracking_number="
        shipArray(2)="<a href=""http://wwwapps.ups.com/WebTracking/processInputRequest?AgreeToTermsAndConditions=yes&tracknum="
 
        If IsNull(sTracking) Then
            LenTracking = 0
        Else
            LenTracking=Len(sTracking)
        End If
 
        Select Case LenTracking
            Case 12 'Fedex length
                WebTracking = shipArray(0) & sTracking & """>" & sTracking & "</a>"
            Case 15 'California Overnight / FedEx Ground Length
                If UCase(Left(sTracking,1)) = "C" Then 'California Overnight
                    WebTracking = shipArray(1) & sTracking & """>" & sTracking & "</a>"
                Else 'FedEx Ground
                    WebTracking = shipArray(0) & sTracking & """>" & sTracking & "</a>"
                End If
            Case 18 'UPS Length
                WebTracking = shipArray(2) & sTracking & """>" & sTracking & "</a>"
            Case 20 'Fedex Ground
                WebTracking = shipArray(0) & sTracking & """>" & sTracking & "</a>"
            Case Else
                WebTracking = sTracking
        End Select
    End Function 
%>
 

I stored the values in an array to hopefully speed up processing. I haven't seen any slowed down pages from this new script... Again, my very first Function, let me know! :) I'll be adding some comments in the code as well later on.

[Nicodemas]

Looks fine to me... you could try wrapping all concatenations with parenthesis. You might get a millisecond or two out of it :D

[blyxx86]

What do you mean wrapping in Parenthesis? I've not heard of this before...

sWebTracking = (sWebTracking & "something " & sSomethingElse)
 

???

[Nicodemas]

Yeah, pretty much exactly what you have there.

I've heard it makes things speedier, given ASP VBScript's concatenation efficiency (of which I have no benchmarks to show you or tell you about.) It's just one of those lores you hear thrown about. But, maybe you'll be the one to debunk it :D

[blyxx86]

I'd love to debunk it.. Perhaps you know of some code to capture information in milliseconds? I believe the "Now()" returns only seconds... Better yet, I'll just provide the code I found at: http://classicasp.aspfaq.com/general...-asp-code.html

<% 
    ' get timer before task begins: 
 
    starttime = Timer() 
 
    ' do some task, e.g.: 
 
    Do While z < 350000 
        z = z + 1 
    Loop 
 
    ' get timer after task completes: 
    endtime = Timer() 
 
    ' display results: 
    Response.Write "The task completed in " & endtime-starttime & " s" 
    Response.Write " (" & (endtime-starttime)*1000 & " milliseconds)." 
%>
 

[Nicodemas]

Eh, this won't give you the exact measure of milliseconds, because all your doing is multiplying by 1000. Multiplying by 1000 only provides the exact data, but represented by a different unit of measurement.

1 second will always = 1000 milliseconds
20 seconds will always = 20,000 milliseconds.

I say this because I believe that, when a time measurement is called, VBScript supplies only the nearest whole second, i.e. you'll never get 21.2 second measurements.