473,625 Members | 3,085 Online
Bytes | Software Development & Data Engineering Community
+ Post

Home Posts Topics Members FAQ

DoCmd.RunSQL() not reading variable from combo box

Help! I don't know why this isn't working:

Private Sub Combo9_Change()

Dim UsersCourseSele ction As String
UsersCourseSele ction = Me("Combo9").Va lue
Combo13.Visible = True

'the following SQL thing is all on one line in the actual code.

DoCmd.RunSQL ("INSERT INTO TEMP(courseCode , studentID) SELECT
studentsInCours es.courseCode, studentsInCours es.studentID FROM
studentsInCours es WHERE (courseCode=Me! Combo9.Value);" )

End Sub

The combo box correctly reads the data into the variable, but for some
reason the SQL line doesn't read the value. I also tried the following:

Private Sub Combo9_Change()

Dim UsersCourseSele ction As String
UsersCourseSele ction = Me("Combo9").Va lue
Combo13.Visible = True

'the following SQL thing is all on one line in the actual code.

DoCmd.RunSQL ("INSERT INTO TEMP(courseCode , studentID) SELECT
studentsInCours es.courseCode, studentsInCours es.studentID FROM
studentsInCours es WHERE (courseCode=Use rsCourseSelecti on);")

End Sub

HERE'S WHAT HAPPENED: When the query runs it prompts for the value, then
inserts the proper data according to the courseCode that I enter.

Is there a better way to get the variable information in there?
Nov 13 '05 #1
7 4283
You are reading in the variable correctly with the first part of the code.
however in your RunSQL command you have everything within the quotation
marks "" therefore it is taken literally (a string) and does not use the
value stored in the UsersCourseSele ction variable.

Have another variable strSQL (as string)
build this variable as (I've broken this down to really show things, you
could do it all in one hit if you like. The following would be three lines
of code)

strSQL = ("INSERT INTO TEMP(courseCode , studentID) SELECT
studentsInCours es.courseCode, studentsInCours es.studentID FROM
studentsInCours es WHERE (courseCode= "
strSql = strSql & UsersCourseSele ction
strSql = strSql & " )"

note how the literal strings are encased in quotes and the variables are
not.
you can then easily test eaxctly what data is being fed to the RunSql
command with a
debug.print strSql

then simply
DoCmd.RunSQL strSql
hth
Mal.
"Richard Hollenbeck" <ri************ ****@verizon.ne t> wrote in message
news:ap******** ***********@nwr ddc03.gnilink.n et...
Help! I don't know why this isn't working:

Private Sub Combo9_Change()

Dim UsersCourseSele ction As String
UsersCourseSele ction = Me("Combo9").Va lue
Combo13.Visible = True

'the following SQL thing is all on one line in the actual code.

DoCmd.RunSQL ("INSERT INTO TEMP(courseCode , studentID) SELECT
studentsInCours es.courseCode, studentsInCours es.studentID FROM
studentsInCours es WHERE (courseCode=Me! Combo9.Value);" )

End Sub

The combo box correctly reads the data into the variable, but for some
reason the SQL line doesn't read the value. I also tried the following:

Private Sub Combo9_Change()

Dim UsersCourseSele ction As String
UsersCourseSele ction = Me("Combo9").Va lue
Combo13.Visible = True

'the following SQL thing is all on one line in the actual code.

DoCmd.RunSQL ("INSERT INTO TEMP(courseCode , studentID) SELECT
studentsInCours es.courseCode, studentsInCours es.studentID FROM
studentsInCours es WHERE (courseCode=Use rsCourseSelecti on);")

End Sub

HERE'S WHAT HAPPENED: When the query runs it prompts for the value, then
inserts the proper data according to the courseCode that I enter.

Is there a better way to get the variable information in there?

Nov 13 '05 #2
It is because you have included the "reference" to the value inside a quoted
string. Try this, instead, which will pick up the value from the Combo and
concatenate it into the string.

DoCmd.RunSQL ("INSERT INTO TEMP(courseCode , studentID) SELECT
studentsInCours es.courseCode, studentsInCours es.studentID FROM
studentsInCours es WHERE (courseCode=" & Me!Combo9 & ");")

I removed ".Value" -- that's the default property, so you don't need to code
it specifically.

Larry Linson
Microsoft Access MVP

"Richard Hollenbeck" <ri************ ****@verizon.ne t> wrote in message
news:ap******** ***********@nwr ddc03.gnilink.n et...
Help! I don't know why this isn't working:

Private Sub Combo9_Change()

Dim UsersCourseSele ction As String
UsersCourseSele ction = Me("Combo9").Va lue
Combo13.Visible = True

'the following SQL thing is all on one line in the actual code.

DoCmd.RunSQL ("INSERT INTO TEMP(courseCode , studentID) SELECT
studentsInCours es.courseCode, studentsInCours es.studentID FROM
studentsInCours es WHERE (courseCode=Me! Combo9.Value);" )

End Sub

The combo box correctly reads the data into the variable, but for some
reason the SQL line doesn't read the value. I also tried the following:

Private Sub Combo9_Change()

Dim UsersCourseSele ction As String
UsersCourseSele ction = Me("Combo9").Va lue
Combo13.Visible = True

'the following SQL thing is all on one line in the actual code.

DoCmd.RunSQL ("INSERT INTO TEMP(courseCode , studentID) SELECT
studentsInCours es.courseCode, studentsInCours es.studentID FROM
studentsInCours es WHERE (courseCode=Use rsCourseSelecti on);")

End Sub

HERE'S WHAT HAPPENED: When the query runs it prompts for the value, then
inserts the proper data according to the courseCode that I enter.

Is there a better way to get the variable information in there?

Nov 13 '05 #3
I tried both of your answers (practically the same.) Thanks. It still
doesn't work. Here's what I did and then I'll tell you what happened:

Private Sub cmboSelectCours e_Change()
Dim strSql As String
Dim courseChoice As String

courseChoice = Me("cmboselectc ourse")

strSql = "INSERT INTO TEMP(studentID, courseCode) SELECT
studentsInCours es.studentID, studentsInCours es.courseCode FROM
studentsInCours es WHERE(studentsI nCourses.course Code="
strSql = strSql & courseChoice
strSql = strSql & ");"

DoCmd.RunSQL strSql

End Sub

I got a run time error 3464 Data Type Mismatch in Expressions. I thought it
might be the fact that Course Code is a string with only numbers and VBA may
be interpreting it as a number. So I tried
str(courseChoic e) but that didn't do the trick either.

I'll look up the error code. Thanks. Oh, I did get it out to an append
action but it found zero records, yet I know there are almost fifty records.
"Mal Reeve" <lo*****@earthl ink.net> wrote in message
news:2z******** ********@newsre ad3.news.atl.ea rthlink.net...
You are reading in the variable correctly with the first part of the code. however in your RunSQL command you have everything within the quotation
marks "" therefore it is taken literally (a string) and does not use the
value stored in the UsersCourseSele ction variable.

Have another variable strSQL (as string)
build this variable as (I've broken this down to really show things, you
could do it all in one hit if you like. The following would be three lines
of code)

strSQL = ("INSERT INTO TEMP(courseCode , studentID) SELECT
studentsInCours es.courseCode, studentsInCours es.studentID FROM
studentsInCours es WHERE (courseCode= "
strSql = strSql & UsersCourseSele ction
strSql = strSql & " )"

note how the literal strings are encased in quotes and the variables are
not.
you can then easily test eaxctly what data is being fed to the RunSql
command with a
debug.print strSql

then simply
DoCmd.RunSQL strSql
hth
Mal.

Nov 13 '05 #4
RunSQL (which can be run from a macro) doesn't know which
form 'Me' is. If you want to refer to a control in RunSQL,
you need to use Forms!myform!my ctl.

Or you can use Me!myctl in VBA to get a value, like you
have done, and then use that value in RunSQL or Execute:

.... (courseCode = " & UsersCourseSele ction & ") ...

(david)

With RunSQL, you can either refer to a fixed value, like '3',
or to a VBA function, or to a control on a form. On any form.
"Richard Hollenbeck" <ri************ ****@verizon.ne t> wrote in message
news:ap******** ***********@nwr ddc03.gnilink.n et...
Help! I don't know why this isn't working:

Private Sub Combo9_Change()

Dim UsersCourseSele ction As String
UsersCourseSele ction = Me("Combo9").Va lue
Combo13.Visible = True

'the following SQL thing is all on one line in the actual code.

DoCmd.RunSQL ("INSERT INTO TEMP(courseCode , studentID) SELECT
studentsInCours es.courseCode, studentsInCours es.studentID FROM
studentsInCours es WHERE (courseCode=Me! Combo9.Value);" )

End Sub

The combo box correctly reads the data into the variable, but for some
reason the SQL line doesn't read the value. I also tried the following:

Private Sub Combo9_Change()

Dim UsersCourseSele ction As String
UsersCourseSele ction = Me("Combo9").Va lue
Combo13.Visible = True

'the following SQL thing is all on one line in the actual code.

DoCmd.RunSQL ("INSERT INTO TEMP(courseCode , studentID) SELECT
studentsInCours es.courseCode, studentsInCours es.studentID FROM
studentsInCours es WHERE (courseCode=Use rsCourseSelecti on);")

End Sub

HERE'S WHAT HAPPENED: When the query runs it prompts for the value, then
inserts the proper data according to the courseCode that I enter.

Is there a better way to get the variable information in there?

Nov 13 '05 #5
On Thu, 22 Jul 2004 04:41:40 GMT, Richard Hollenbeck wrote:
I tried both of your answers (practically the same.) Thanks. It still
doesn't work. Here's what I did and then I'll tell you what happened:

Private Sub cmboSelectCours e_Change()
Dim strSql As String
Dim courseChoice As String

courseChoice = Me("cmboselectc ourse")

strSql = "INSERT INTO TEMP(studentID, courseCode) SELECT
studentsInCours es.studentID, studentsInCours es.courseCode FROM
studentsInCours es WHERE(studentsI nCourses.course Code="
strSql = strSql & courseChoice
strSql = strSql & ");"

DoCmd.RunSQL strSql

End Sub

I got a run time error 3464 Data Type Mismatch in Expressions. I thought it
might be the fact that Course Code is a string with only numbers and VBA may
be interpreting it as a number. So I tried
str(courseChoic e) but that didn't do the trick either.

I'll look up the error code. Thanks. Oh, I did get it out to an append
action but it found zero records, yet I know there are almost fifty records.

"Mal Reeve" <lo*****@earthl ink.net> wrote in message
news:2z******** ********@newsre ad3.news.atl.ea rthlink.net...
You are reading in the variable correctly with the first part of the code.
however in your RunSQL command you have everything within the quotation
marks "" therefore it is taken literally (a string) and does not use the
value stored in the UsersCourseSele ction variable.

Have another variable strSQL (as string)
build this variable as (I've broken this down to really show things, you
could do it all in one hit if you like. The following would be three lines
of code)

strSQL = ("INSERT INTO TEMP(courseCode , studentID) SELECT
studentsInCours es.courseCode, studentsInCours es.studentID FROM
studentsInCours es WHERE (courseCode= "
strSql = strSql & UsersCourseSele ction
strSql = strSql & " )"

note how the literal strings are encased in quotes and the variables are
not.
you can then easily test eaxctly what data is being fed to the RunSql
command with a
debug.print strSql

then simply
DoCmd.RunSQL strSql
hth
Mal.


Here is your answer: I thought it might be the fact that Course Code is a string with only numbers and VBA may
be interpreting it as a number.


When you write the where clause for a variable that is a Number
DATATYPE, you write it outside the quotes, as indicated above.
.... Where CourseCode = " & UsersCourseSele ction & ");"
The resulting SQL clause, with data, will look like this ...
..... Where (CourseCode =12345);"

However, if the variable is a string datatype (even if it's just
numbers in the string), you must write the clause a bit differently:

WHERE (courseCode= '" & UsersCourseSele ction & "');"

With spaces added for clarity it looks like this:
WHERE (courseCode= ' " & UsersCourseSele ction & " ' );"

The resulting SQL clause, with data, will look like this ...
..... Where (CourseCode ='12345');"
note the CourseCode value is within single quotes.

The entire SQL should look like this:

strSql = "INSERT INTO TEMP(studentID, courseCode) SELECT
studentsInCours es.studentID, studentsInCours es.courseCode FROM
studentsInCours es WHERE(studentsI nCourses.course Code='"
strSql = strSql & courseChoice & "');"

See Access help files on
Where clause + restrict data to a subset of records + Text Datatype

I hope this helps.
--
Fred
Please only reply to this newsgroup.
I do not reply to personal email.
Nov 13 '05 #6
Thank you everybody! I got it. It's very tricky. Single, double quotes,
whether to put parentheses or semicolons, etc. But I got it. Thanks.

"Richard Hollenbeck" <ri************ ****@verizon.ne t> wrote in message
news:ap******** ***********@nwr ddc03.gnilink.n et...
Help! I don't know why this isn't working:

Private Sub Combo9_Change()

Dim UsersCourseSele ction As String
UsersCourseSele ction = Me("Combo9").Va lue
Combo13.Visible = True

'the following SQL thing is all on one line in the actual code.

DoCmd.RunSQL ("INSERT INTO TEMP(courseCode , studentID) SELECT
studentsInCours es.courseCode, studentsInCours es.studentID FROM
studentsInCours es WHERE (courseCode=Me! Combo9.Value);" )

End Sub

The combo box correctly reads the data into the variable, but for some
reason the SQL line doesn't read the value. I also tried the following:

Private Sub Combo9_Change()

Dim UsersCourseSele ction As String
UsersCourseSele ction = Me("Combo9").Va lue
Combo13.Visible = True

'the following SQL thing is all on one line in the actual code.

DoCmd.RunSQL ("INSERT INTO TEMP(courseCode , studentID) SELECT
studentsInCours es.courseCode, studentsInCours es.studentID FROM
studentsInCours es WHERE (courseCode=Use rsCourseSelecti on);")

End Sub

HERE'S WHAT HAPPENED: When the query runs it prompts for the value, then
inserts the proper data according to the courseCode that I enter.

Is there a better way to get the variable information in there?

Nov 13 '05 #7
"Richard Hollenbeck" <ri************ ****@verizon.ne t> wrote in message news:<yB******* ***********@nwr ddc01.gnilink.n et>...
Thank you everybody! I got it. It's very tricky. Single, double quotes,
whether to put parentheses or semicolons, etc. But I got it. Thanks.

"Richard Hollenbeck" <ri************ ****@verizon.ne t> wrote in message
news:ap******** ***********@nwr ddc03.gnilink.n et...
Help! I don't know why this isn't working:

Private Sub Combo9_Change()

Dim UsersCourseSele ction As String
UsersCourseSele ction = Me("Combo9").Va lue
Combo13.Visible = True

'the following SQL thing is all on one line in the actual code.

DoCmd.RunSQL ("INSERT INTO TEMP(courseCode , studentID) SELECT
studentsInCours es.courseCode, studentsInCours es.studentID FROM
studentsInCours es WHERE (courseCode=Me! Combo9.Value);" )

End Sub

Richard,

I always create an SQL string so I can see the actual values that
were pulled from controls, et cetera. Try this.

strSQL = "INSERT INTO TEMP(courseCode , studentID) SELECT
studentsInCours es.courseCode, studentsInCours es.studentID FROM
studentsInCours es WHERE (courseCode=Me! Combo9.Value);"

DoCmd.RunSQL strSQL

Then that combo box value can be examined in the debugger and the
problem will probably be obvious to you.

Hank Reed
Nov 13 '05 #8

This thread has been closed and replies have been disabled. Please start a new discussion.

Similar topics

0
8237
by: Jim | last post by:
I am using Access 97 on a PC running Windows NT 4.0 SP6a. I have some code (shown below) intended to add a set of records to one table (tblGradeProps) when a new record is created in another (tblGrades) The oddity is that when the procedure Detail_Click is called from the procedure cmbMktSect_Exit, the RunSQL statement doesn't add the required records but it does so when invoked by the Detail_Click event!
4
10186
by: Rotsj | last post by:
Hi, i try to execute an update query from within a form, but i get the message: run time error '3144'. Syntax error on the update statement when i try something like this: DoCmd.RunSQL "UPDATE tblKlant " & _ "SET tblKlant.Bedrag = tblKlant.Bedrag + 10.96" & _ " WHERE tblKlant. = forms!!"
0
1929
by: Andy | last post by:
Hello, I am running an sql statement that INSERTS INTO a table. If I run the query using docmd.runSQL, it works fine - new records are added to the table and duplicate records are disregared ( I use DoCmd.SetWarnings False so the users don't see the warning about duplicate records). If I run the same query using this: rs.Open qryPolePosition1, CurrentProject.Connection, adOpenKeyset,
3
3454
by: Pathfinder | last post by:
Hi All I am trying to run the below but I receive the following error "runsql action requires an argument consisting of an SQL statment" Dim MySQL$ MySQL$ = "Select * from mytablename" DoCmd.RunSQL MySQL$ Any reason for that
8
11220
by: RC | last post by:
In my Access 2002 form, I have a combo box and on the AfterUpdate event I use DoCmd.RunSQL ("UPDATE .... to update records in a table. When it starts to run I get a message "You are about to update 3 row(s)." Is there a way to prevent the message from popping up?
6
68663
by: David | last post by:
I am trying to insert an employee number into the EmpNbr field in my main table from a form where I add a new employee to my employee table. I was hoping this command would work, but it isn't. DoCmd.RunSQL "INSERT INTO VALUES ()", 0 This is the only field I want to populate in the main table from this form. there are three other fields in the main table that I want to leave unpopulated.
2
5702
by: ben | last post by:
I have the following code in a VBA module: DoCmd.RunSql "Update tData Set sd = Log(Strike/Price) where symbol = '" & symbol & "'" This statement worked fine, and was using the built in math Log function. In a separate module, I added the following function:
3
2571
by: jl2886 | last post by:
Hello. I have two questions: Private Sub Form_Load() Dim assID As Long assID = DMax("CLng(Right(,3))", "Master_Log") Me.LSI_Case_Number = Month(Date) & Format(Year(Date), "yy") & "-" & Format(assID + 1, "000") End Sub It reads an indentifier cursor error. In my table LSI_Case_Number is a text variable
1
3072
by: natural | last post by:
Good Afternoon I have an option grou[ and on the after update i would like to provide the user with a msgbox, and then action placed my docmd.setwarnings false everywhere, but i still get my "record has been deleted". Is i possilbe to please assist in where i am going wrong Private Sub RecOffLet_AfterUpdate() On Error GoTo Err_Handler
0
8259
marktang
by: marktang | last post by:
ONU (Optical Network Unit) is one of the key components for providing high-speed Internet services. Its primary function is to act as an endpoint device located at the user's premises. However, people are often confused as to whether an ONU can Work As a Router. In this blog post, we’ll explore What is ONU, What Is Router, ONU & Router’s main usage, and What is the difference between ONU and Router. Let’s take a closer look ! Part I. Meaning of...
0
8192
by: Hystou | last post by:
Most computers default to English, but sometimes we require a different language, especially when relocating. Forgot to request a specific language before your computer shipped? No problem! You can effortlessly switch the default language on Windows 10 without reinstalling. I'll walk you through it. First, let's disable language synchronization. With a Microsoft account, language settings sync across devices. To prevent any complications,...
0
8696
Oralloy
by: Oralloy | last post by:
Hello folks, I am unable to find appropriate documentation on the type promotion of bit-fields when using the generalised comparison operator "<=>". The problem is that using the GNU compilers, it seems that the internal comparison operator "<=>" tries to promote arguments from unsigned to signed. This is as boiled down as I can make it. Here is my compilation command: g++-12 -std=c++20 -Wnarrowing bit_field.cpp Here is the code in...
0
8637
jinu1996
by: jinu1996 | last post by:
In today's digital age, having a compelling online presence is paramount for businesses aiming to thrive in a competitive landscape. At the heart of this digital strategy lies an intricately woven tapestry of website design and digital marketing. It's not merely about having a website; it's about crafting an immersive digital experience that captivates audiences and drives business growth. The Art of Business Website Design Your website is...
1
8358
by: Hystou | last post by:
Overview: Windows 11 and 10 have less user interface control over operating system update behaviour than previous versions of Windows. In Windows 11 and 10, there is no way to turn off the Windows Update option using the Control Panel or Settings app; it automatically checks for updates and installs any it finds, whether you like it or not. For most users, this new feature is actually very convenient. If you want to control the update process,...
0
7188
agi2029
by: agi2029 | last post by:
Let's talk about the concept of autonomous AI software engineers and no-code agents. These AIs are designed to manage the entire lifecycle of a software development project—planning, coding, testing, and deployment—without human intervention. Imagine an AI that can take a project description, break it down, write the code, debug it, and then launch it, all on its own.... Now, this would greatly impact the work of software developers. The idea...
1
6119
isladogs
by: isladogs | last post by:
The next Access Europe User Group meeting will be on Wednesday 1 May 2024 starting at 18:00 UK time (6PM UTC+1) and finishing by 19:30 (7.30PM). In this session, we are pleased to welcome a new presenter, Adolph Dupré who will be discussing some powerful techniques for using class modules. He will explain when you may want to use classes instead of User Defined Types (UDT). For example, to manage the data in unbound forms. Adolph will...
0
4195
by: adsilva | last post by:
A Windows Forms form does not have the event Unload, like VB6. What one acts like?
1
2621
by: 6302768590 | last post by:
Hai team i want code for transfer the data from one system to another through IP address by using C# our system has to for every 5mins then we have to update the data what the data is updated we have to send another system

By using Bytes.com and it's services, you agree to our Privacy Policy and Terms of Use.

To disable or enable advertisements and analytics tracking please visit the manage ads & tracking page.